Re: Concerns about "mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support"

2015-04-02 Thread James Bottomley
On Thu, 2015-04-02 at 16:39 +1100, Benjamin Herrenschmidt wrote: > On Thu, 2015-02-19 at 21:45 -0800, James Bottomley wrote: > > > Ben, this is legal by design. It was specifically designed for the > > aic79xx SCSI card, but can be used for a variety of other reasons. The > > aic79xx hardware

Re: Concerns about mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2015-04-02 Thread James Bottomley
On Thu, 2015-04-02 at 16:39 +1100, Benjamin Herrenschmidt wrote: On Thu, 2015-02-19 at 21:45 -0800, James Bottomley wrote: Ben, this is legal by design. It was specifically designed for the aic79xx SCSI card, but can be used for a variety of other reasons. The aic79xx hardware problem

Re: Concerns about "mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support"

2015-04-01 Thread Benjamin Herrenschmidt
On Thu, 2015-02-19 at 21:45 -0800, James Bottomley wrote: > Ben, this is legal by design. It was specifically designed for the > aic79xx SCSI card, but can be used for a variety of other reasons. The > aic79xx hardware problem was that the DMA engine could address the whole > of memory (it had

Re: Concerns about mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2015-04-01 Thread Benjamin Herrenschmidt
On Thu, 2015-02-19 at 21:45 -0800, James Bottomley wrote: Ben, this is legal by design. It was specifically designed for the aic79xx SCSI card, but can be used for a variety of other reasons. The aic79xx hardware problem was that the DMA engine could address the whole of memory (it had two

Re: Concerns about "mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support"

2015-02-19 Thread Benjamin Herrenschmidt
On Thu, 2015-02-19 at 21:45 -0800, James Bottomley wrote: > Ben, this is legal by design. It was specifically designed for the > aic79xx SCSI card, but can be used for a variety of other reasons. The > aic79xx hardware problem was that the DMA engine could address the whole > of memory (it had

Re: Concerns about "mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support"

2015-02-19 Thread Benjamin Herrenschmidt
On Fri, 2015-02-20 at 16:22 +1100, Benjamin Herrenschmidt wrote: > Looking a bit more closely, you basically do > > - set_dma_mask(64-bit) > - set_consistent_dma_mask(32-bit) > > Now, I don't know how x86 will react to the conflicting masks, but on > ppc64, I'm pretty sure the second one will

Re: Concerns about "mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support"

2015-02-19 Thread James Bottomley
On Fri, 2015-02-20 at 16:22 +1100, Benjamin Herrenschmidt wrote: > On Fri, 2015-02-20 at 16:06 +1100, Benjamin Herrenschmidt wrote: > > > Note that even on powerpc platforms where it would work because we > > maintain both 32-bit and 64-bit bypass windows in the device address > > space

Re: Concerns about "mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support"

2015-02-19 Thread Benjamin Herrenschmidt
On Fri, 2015-02-20 at 16:06 +1100, Benjamin Herrenschmidt wrote: > Note that even on powerpc platforms where it would work because we > maintain both 32-bit and 64-bit bypass windows in the device address > space simultaneously, you will leak iommu entries unless you also switch > back to 32-bit

Re: Concerns about "mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support"

2015-02-19 Thread Benjamin Herrenschmidt
On Fri, 2015-02-20 at 16:01 +1100, Benjamin Herrenschmidt wrote: > Hi Sreekanth ! > > While looking at some (unrelated) issue where mtp2sas seems to be using > 32-bit DMA instead of 64-bit DMA on some POWER platforms, I noticed this > patch which was merged as

Concerns about "mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support"

2015-02-19 Thread Benjamin Herrenschmidt
Hi Sreekanth ! While looking at some (unrelated) issue where mtp2sas seems to be using 32-bit DMA instead of 64-bit DMA on some POWER platforms, I noticed this patch which was merged as 5fb1bf8aaa832e1e9ca3198de7bbecb8eff7db9c. Can you confirm my understanding that you are: - Setting the DMA

Re: Concerns about mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2015-02-19 Thread Benjamin Herrenschmidt
On Fri, 2015-02-20 at 16:01 +1100, Benjamin Herrenschmidt wrote: Hi Sreekanth ! While looking at some (unrelated) issue where mtp2sas seems to be using 32-bit DMA instead of 64-bit DMA on some POWER platforms, I noticed this patch which was merged as 5fb1bf8aaa832e1e9ca3198de7bbecb8eff7db9c.

Re: Concerns about mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2015-02-19 Thread Benjamin Herrenschmidt
On Fri, 2015-02-20 at 16:22 +1100, Benjamin Herrenschmidt wrote: Looking a bit more closely, you basically do - set_dma_mask(64-bit) - set_consistent_dma_mask(32-bit) Now, I don't know how x86 will react to the conflicting masks, but on ppc64, I'm pretty sure the second one will barf.

Re: Concerns about mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2015-02-19 Thread Benjamin Herrenschmidt
On Thu, 2015-02-19 at 21:45 -0800, James Bottomley wrote: Ben, this is legal by design. It was specifically designed for the aic79xx SCSI card, but can be used for a variety of other reasons. The aic79xx hardware problem was that the DMA engine could address the whole of memory (it had two

Concerns about mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2015-02-19 Thread Benjamin Herrenschmidt
Hi Sreekanth ! While looking at some (unrelated) issue where mtp2sas seems to be using 32-bit DMA instead of 64-bit DMA on some POWER platforms, I noticed this patch which was merged as 5fb1bf8aaa832e1e9ca3198de7bbecb8eff7db9c. Can you confirm my understanding that you are: - Setting the DMA

Re: Concerns about mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2015-02-19 Thread Benjamin Herrenschmidt
On Fri, 2015-02-20 at 16:06 +1100, Benjamin Herrenschmidt wrote: Note that even on powerpc platforms where it would work because we maintain both 32-bit and 64-bit bypass windows in the device address space simultaneously, you will leak iommu entries unless you also switch back to 32-bit when

Re: Concerns about mpt2sas: Added Reply Descriptor Post Queue (RDPQ) Array support

2015-02-19 Thread James Bottomley
On Fri, 2015-02-20 at 16:22 +1100, Benjamin Herrenschmidt wrote: On Fri, 2015-02-20 at 16:06 +1100, Benjamin Herrenschmidt wrote: Note that even on powerpc platforms where it would work because we maintain both 32-bit and 64-bit bypass windows in the device address space simultaneously,