Re: Correct use of __init and __devinit

2007-12-26 Thread Haavard Skinnemoen
On Mon, 24 Dec 2007 14:01:43 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > So of the principle of least suprise it is best to use __devinit > for the probe function as most other drivers do. And if > the driver model happens to call your probe function after > init time then we will not oops. I

Re: Correct use of __init and __devinit

2007-12-24 Thread Sam Ravnborg
On Sun, Dec 23, 2007 at 04:56:14PM +, Adrian McMenamin wrote: > Could someone here help settle this argument? > > I have written a driver (for the CD Rom on the Sega Dreamcast). I have > marked various initialisation functions - including probe() and the > functions that it, and only it, calls

Correct use of __init and __devinit

2007-12-23 Thread Adrian McMenamin
Could someone here help settle this argument? I have written a driver (for the CD Rom on the Sega Dreamcast). I have marked various initialisation functions - including probe() and the functions that it, and only it, calls, as __init. Other developers tell me I should mark them as __devinit. How