Re: Crypto Update for 4.1

2015-04-23 Thread Bobby Powers
On Thu, Apr 23, 2015 at 4:10 PM, Ard Biesheuvel wrote: > > Hello Bobby, > > Would you be able to check whether the following patch fixes the crash? > > diff --git a/arch/x86/crypto/sha512-avx2-asm.S > b/arch/x86/crypto/sha512-avx2-asm.S > index a4771dcd1fcf..1f20b35d8573 100644 > ---

Re: Crypto Update for 4.1

2015-04-23 Thread Ard Biesheuvel
On 23 April 2015 at 21:27, Bobby Powers wrote: > Hello, > > Linus Torvalds wrote: >> Ok, this patch seems to fix it for me, so I undid my revert that I >> hadn't pushed out yet, and pushed out this instead. > > Commit e68410ebf62676dfb93aafff7c55b76644f37072 in Linus's tree from > this crpyto

Re: Crypto Update for 4.1

2015-04-23 Thread Ard Biesheuvel
On 23 April 2015 at 21:27, Bobby Powers bobbypow...@gmail.com wrote: Hello, Linus Torvalds torva...@linux-foundation.org wrote: Ok, this patch seems to fix it for me, so I undid my revert that I hadn't pushed out yet, and pushed out this instead. Commit

Re: Crypto Update for 4.1

2015-04-23 Thread Bobby Powers
On Thu, Apr 23, 2015 at 4:10 PM, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Hello Bobby, Would you be able to check whether the following patch fixes the crash? diff --git a/arch/x86/crypto/sha512-avx2-asm.S b/arch/x86/crypto/sha512-avx2-asm.S index a4771dcd1fcf..1f20b35d8573 100644

Re: Crypto Update for 4.1

2015-04-15 Thread Linus Torvalds
On Wed, Apr 15, 2015 at 8:07 PM, Herbert Xu wrote: > > Thanks! It actually appears to be a very simple bug that I somehow > missed during reviewing. Ok, this patch seems to fix it for me, so I undid my revert that I hadn't pushed out yet, and pushed out this instead. Thanks, Linus

Re: Crypto Update for 4.1

2015-04-15 Thread Herbert Xu
On Wed, Apr 15, 2015 at 07:49:01PM -0700, Linus Torvalds wrote: > On Wed, Apr 15, 2015 at 7:42 PM, Herbert Xu > wrote: > > > > Is CONFIG_CRYPTO_MANAGER_DISABLE_TESTS set or unset in you .config? > > # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set > > I'll send you the full .config in private

Re: Crypto Update for 4.1

2015-04-15 Thread Linus Torvalds
On Wed, Apr 15, 2015 at 7:42 PM, Herbert Xu wrote: > > Is CONFIG_CRYPTO_MANAGER_DISABLE_TESTS set or unset in you .config? # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set I'll send you the full .config in private (no need to spam the mailing list) in case you have any other questions about my

Re: Crypto Update for 4.1

2015-04-15 Thread Herbert Xu
On Wed, Apr 15, 2015 at 07:38:29PM -0700, Linus Torvalds wrote: > > > Ok, bisect completed: > > > > [torvalds@vaio linux]$ git bisect bad > > 9c521a200bc3c12bd724e48a75c57d5358f672be is the first bad commit > > commit 9c521a200bc3c12bd724e48a75c57d5358f672be > > Author: Stephan

Re: Crypto Update for 4.1

2015-04-15 Thread Linus Torvalds
u >> wrote: >>> >>> Here is the crypto update for 4.1: >> >> Just a heads-up: this breaks iwlwifi for me after suspend. > > Ok, bisect completed: > > [torvalds@vaio linux]$ git bisect bad > 9c521a200bc3c12bd724e48a75c57d5358f672be is the first b

Re: Crypto Update for 4.1

2015-04-15 Thread Linus Torvalds
On Wed, Apr 15, 2015 at 6:58 PM, Linus Torvalds wrote: > On Tue, Apr 14, 2015 at 8:39 PM, Herbert Xu > wrote: >> >> Here is the crypto update for 4.1: > > Just a heads-up: this breaks iwlwifi for me after suspend. Ok, bisect completed: [torvalds@vai

Re: Crypto Update for 4.1

2015-04-15 Thread Linus Torvalds
On Tue, Apr 14, 2015 at 8:39 PM, Herbert Xu wrote: > > Here is the crypto update for 4.1: Just a heads-up: this breaks iwlwifi for me after suspend. I'm bisecting right now. But because this laptop is what I expect to travel with tomorrow, I will ruthlessly revert anything I find, bec

Re: Crypto Update for 4.1

2015-04-15 Thread Linus Torvalds
On Wed, Apr 15, 2015 at 7:42 PM, Herbert Xu herb...@gondor.apana.org.au wrote: Is CONFIG_CRYPTO_MANAGER_DISABLE_TESTS set or unset in you .config? # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set I'll send you the full .config in private (no need to spam the mailing list) in case you have any

Re: Crypto Update for 4.1

2015-04-15 Thread Linus Torvalds
On Tue, Apr 14, 2015 at 8:39 PM, Herbert Xu herb...@gondor.apana.org.au wrote: Here is the crypto update for 4.1: Just a heads-up: this breaks iwlwifi for me after suspend. I'm bisecting right now. But because this laptop is what I expect to travel with tomorrow, I will ruthlessly revert

Re: Crypto Update for 4.1

2015-04-15 Thread Linus Torvalds
On Wed, Apr 15, 2015 at 6:58 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Tue, Apr 14, 2015 at 8:39 PM, Herbert Xu herb...@gondor.apana.org.au wrote: Here is the crypto update for 4.1: Just a heads-up: this breaks iwlwifi for me after suspend. Ok, bisect completed

Re: Crypto Update for 4.1

2015-04-15 Thread Linus Torvalds
14, 2015 at 8:39 PM, Herbert Xu herb...@gondor.apana.org.au wrote: Here is the crypto update for 4.1: Just a heads-up: this breaks iwlwifi for me after suspend. Ok, bisect completed: [torvalds@vaio linux]$ git bisect bad 9c521a200bc3c12bd724e48a75c57d5358f672be is the first bad

Re: Crypto Update for 4.1

2015-04-15 Thread Herbert Xu
On Wed, Apr 15, 2015 at 07:49:01PM -0700, Linus Torvalds wrote: On Wed, Apr 15, 2015 at 7:42 PM, Herbert Xu herb...@gondor.apana.org.au wrote: Is CONFIG_CRYPTO_MANAGER_DISABLE_TESTS set or unset in you .config? # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set I'll send you the full

Re: Crypto Update for 4.1

2015-04-15 Thread Linus Torvalds
On Wed, Apr 15, 2015 at 8:07 PM, Herbert Xu herb...@gondor.apana.org.au wrote: Thanks! It actually appears to be a very simple bug that I somehow missed during reviewing. Ok, this patch seems to fix it for me, so I undid my revert that I hadn't pushed out yet, and pushed out this instead.

Re: Crypto Update for 4.1

2015-04-15 Thread Herbert Xu
On Wed, Apr 15, 2015 at 07:38:29PM -0700, Linus Torvalds wrote: Ok, bisect completed: [torvalds@vaio linux]$ git bisect bad 9c521a200bc3c12bd724e48a75c57d5358f672be is the first bad commit commit 9c521a200bc3c12bd724e48a75c57d5358f672be Author: Stephan Mueller

Crypto Update for 4.1

2015-04-14 Thread Herbert Xu
Hi Linus: Here is the crypto update for 4.1: * Added user-space interface for AEAD. * Added user-space interface for RNG (i.e., pseudo RNG). * Prevent internal helper algos from being exposed to user-space. * Merged common code from assembly/C SHA implementations . * Added ARMv8 SHA1/256

Crypto Update for 4.1

2015-04-14 Thread Herbert Xu
Hi Linus: Here is the crypto update for 4.1: * Added user-space interface for AEAD. * Added user-space interface for RNG (i.e., pseudo RNG). * Prevent internal helper algos from being exposed to user-space. * Merged common code from assembly/C SHA implementations . * Added ARMv8 SHA1/256