Re: DMA allocations from CMA and fatal_signal_pending check

2014-11-03 Thread Florian Fainelli
On 11/03/2014 08:45 AM, Michal Nazarewicz wrote: > On Fri, Oct 31 2014, Florian Fainelli wrote: >> I agree that the CMA allocation should not be allowed to succeed, but >> the dma_alloc_coherent() allocation should succeed. If we look at the >> sysport driver, there are kmalloc() calls to

Re: DMA allocations from CMA and fatal_signal_pending check

2014-11-03 Thread Michal Nazarewicz
On Fri, Oct 31 2014, Florian Fainelli wrote: > I agree that the CMA allocation should not be allowed to succeed, but > the dma_alloc_coherent() allocation should succeed. If we look at the > sysport driver, there are kmalloc() calls to initialize private > structures, those will succeed (except

Re: DMA allocations from CMA and fatal_signal_pending check

2014-11-03 Thread Michal Nazarewicz
On Fri, Oct 31 2014, Florian Fainelli wrote: I agree that the CMA allocation should not be allowed to succeed, but the dma_alloc_coherent() allocation should succeed. If we look at the sysport driver, there are kmalloc() calls to initialize private structures, those will succeed (except under

Re: DMA allocations from CMA and fatal_signal_pending check

2014-11-03 Thread Florian Fainelli
On 11/03/2014 08:45 AM, Michal Nazarewicz wrote: On Fri, Oct 31 2014, Florian Fainelli wrote: I agree that the CMA allocation should not be allowed to succeed, but the dma_alloc_coherent() allocation should succeed. If we look at the sysport driver, there are kmalloc() calls to initialize

Re: DMA allocations from CMA and fatal_signal_pending check

2014-10-31 Thread Maxime Bizon
On Fri, 2014-10-31 at 17:28 +0900, Joonsoo Kim wrote: > I guess that it is okay that bcm_sysport_open() return -EINTR? actually, since CMA alloc is hidden behind dma_alloc_coherent(), all you get back is NULL and then return ENOMEM. -- Maxime -- To unsubscribe from this list: send the line

Re: DMA allocations from CMA and fatal_signal_pending check

2014-10-31 Thread Florian Fainelli
Hi Joonsoo, On 10/31/2014 01:28 AM, Joonsoo Kim wrote: > On Tue, Oct 28, 2014 at 12:08:46PM -0700, Florian Fainelli wrote: >> Hello, >> >> While debugging why some dma_alloc_coherent() allocations where >> returning NULL on our brcmstb platform, specifically with >>

Re: DMA allocations from CMA and fatal_signal_pending check

2014-10-31 Thread Joonsoo Kim
On Tue, Oct 28, 2014 at 12:08:46PM -0700, Florian Fainelli wrote: > Hello, > > While debugging why some dma_alloc_coherent() allocations where > returning NULL on our brcmstb platform, specifically with > drivers/net/ethernet/broadcom/bcmcsysport.c, I came across the > fatal_signal_pending()

Re: DMA allocations from CMA and fatal_signal_pending check

2014-10-31 Thread Joonsoo Kim
On Tue, Oct 28, 2014 at 12:08:46PM -0700, Florian Fainelli wrote: Hello, While debugging why some dma_alloc_coherent() allocations where returning NULL on our brcmstb platform, specifically with drivers/net/ethernet/broadcom/bcmcsysport.c, I came across the fatal_signal_pending() check in

Re: DMA allocations from CMA and fatal_signal_pending check

2014-10-31 Thread Florian Fainelli
Hi Joonsoo, On 10/31/2014 01:28 AM, Joonsoo Kim wrote: On Tue, Oct 28, 2014 at 12:08:46PM -0700, Florian Fainelli wrote: Hello, While debugging why some dma_alloc_coherent() allocations where returning NULL on our brcmstb platform, specifically with

Re: DMA allocations from CMA and fatal_signal_pending check

2014-10-31 Thread Maxime Bizon
On Fri, 2014-10-31 at 17:28 +0900, Joonsoo Kim wrote: I guess that it is okay that bcm_sysport_open() return -EINTR? actually, since CMA alloc is hidden behind dma_alloc_coherent(), all you get back is NULL and then return ENOMEM. -- Maxime -- To unsubscribe from this list: send the line

DMA allocations from CMA and fatal_signal_pending check

2014-10-28 Thread Florian Fainelli
Hello, While debugging why some dma_alloc_coherent() allocations where returning NULL on our brcmstb platform, specifically with drivers/net/ethernet/broadcom/bcmcsysport.c, I came across the fatal_signal_pending() check in mm/page_alloc.c which is there. This driver calls dma_alloc_coherent(,

DMA allocations from CMA and fatal_signal_pending check

2014-10-28 Thread Florian Fainelli
Hello, While debugging why some dma_alloc_coherent() allocations where returning NULL on our brcmstb platform, specifically with drivers/net/ethernet/broadcom/bcmcsysport.c, I came across the fatal_signal_pending() check in mm/page_alloc.c which is there. This driver calls dma_alloc_coherent(,