[PATCH 5.4 082/453] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-12-28 Thread Greg Kroah-Hartman
roblems! To be explicit, the patch ("soc: qcom: geni: More properly switch to DMA mode") is a prerequisite for this one. Fixes: 02b9aec59243 ("i2c: i2c-qcom-geni: Fix DMA transfer race") Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd Reviewed-by: Akash Asthana Tested

[PATCH 5.10 015/717] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-12-28 Thread Greg Kroah-Hartman
roblems! To be explicit, the patch ("soc: qcom: geni: More properly switch to DMA mode") is a prerequisite for this one. Fixes: 02b9aec59243 ("i2c: i2c-qcom-geni: Fix DMA transfer race") Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd Reviewed-by: Akash Asthana Tested

Re: [PATCH v2 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-11-03 Thread Wolfram Sang
> Sounds good, please find the series applied on top of v5.10-rc1 at: > > https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git > tags/20201013212531.428538-1-diand...@chromium.org Thanks, pulled. signature.asc Description: PGP signature

Re: [PATCH v2 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-10-26 Thread Bjorn Andersson
On Mon 26 Oct 10:13 CDT 2020, Wolfram Sang wrote: > > > Wolfram, would you like to pick this patch or would you prefer that it > > goes together with the other two through the soc tree? > > Actually, I prefer the soc tree because of the functional dependency. I > am not aware of any pending qcom

Re: [PATCH v2 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-10-26 Thread Wolfram Sang
> Wolfram, would you like to pick this patch or would you prefer that it > goes together with the other two through the soc tree? Actually, I prefer the soc tree because of the functional dependency. I am not aware of any pending qcom-geni patches, yet I think an immutable branch for me to pull i

Re: [PATCH v2 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-10-26 Thread Bjorn Andersson
y) zero problems! > > To be explicit, the patch ("soc: qcom: geni: More properly switch > to DMA mode") is a prerequisite for this one. > > Fixes: 02b9aec59243 ("i2c: i2c-qcom-geni: Fix DMA transfer race") > Signed-off-by: Douglas Anderson > Reviewed-by:

[PATCH v2 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-10-14 Thread Douglas Anderson
") is a prerequisite for this one. Fixes: 02b9aec59243 ("i2c: i2c-qcom-geni: Fix DMA transfer race") Signed-off-by: Douglas Anderson Reviewed-by: Stephen Boyd Reviewed-by: Akash Asthana Tested-by: Dmitry Baryshkov --- (no changes since v1) drivers/i2c/busses/i2c-qcom-geni.c | 6 +

Re: [PATCH 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-10-12 Thread Akash Asthana
oc: qcom: geni: More properly switch to DMA mode") is a prerequisite for this one. Fixes: 02b9aec59243 ("i2c: i2c-qcom-geni: Fix DMA transfer race") Signed-off-by: Douglas Anderson Reviewed-by: Akash Asthana -- The Qualcomm Innovation Center, Inc. is a member of the Code

Re: [PATCH 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-10-09 Thread Stephen Boyd
lems! > > To be explicit, the patch ("soc: qcom: geni: More properly switch > to DMA mode") is a prerequisite for this one. > > Fixes: 02b9aec59243 ("i2c: i2c-qcom-geni: Fix DMA transfer race") > Signed-off-by: Douglas Anderson > --- Reviewed-by: Stephen Boyd

[PATCH 2/3] Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"

2020-10-08 Thread Douglas Anderson
") is a prerequisite for this one. Fixes: 02b9aec59243 ("i2c: i2c-qcom-geni: Fix DMA transfer race") Signed-off-by: Douglas Anderson --- drivers/i2c/busses/i2c-qcom-geni.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b

[PATCH v2 08/11] spi: dw-dma: Detach DMA transfer into a dedicated method

2020-09-20 Thread Serge Semin
In order to add an alternative method of DMA-based SPI transfer first we need to detach the currently available one from the common code. Here we move the normal DMA-based SPI transfer execution functionality into a dedicated method. It will be utilized if either the DMA engine supports an unlimite

[PATCH v2 09/11] spi: dw-dma: Move DMAC register cleanup to DMA transfer method

2020-09-20 Thread Serge Semin
DW APB SSI DMA driver doesn't use the native SPI core wait API since commit bdbdf0f06337 ("spi: dw: Locally wait for the DMA transfers completion"). Due to that the driver can now clear the DMAC register in a single place synchronously with the DMA transactions completion or failure. After that all

Re: [PATCH 13/18] spi: stm32h7: fix handling of dma transfer completed

2020-08-05 Thread Mark Brown
On Wed, Aug 05, 2020 at 09:02:08AM +0200, Alain Volmat wrote: > From: Amelie Delaunay > > The rx dma is completed "after" the last data is received > from spi. Thus, to avoid loss of rx data, it's mandatory to > wait for the dma callback before tearing down the rx dma in > stm32_spi_disable(). A

[PATCH 13/18] spi: stm32h7: fix handling of dma transfer completed

2020-08-05 Thread Alain Volmat
tx: dma channel for TX transfer * @dma_rx: dma channel for RX transfer + * @dma_completion: completion to wait for end of DMA transfer * @phys_addr: SPI registers physical base address * @xfer_completion: completion to wait for end of transfer * @xfer_status: current transfer status @@ -304,6 +

[PATCH 6/8] spi: dw-dma: Move DMAC register cleanup to DMA transfer method

2020-07-31 Thread Serge Semin
DW APB SSI DMA driver doesn't use the native SPI core wait API since commit bdbdf0f06337 ("spi: dw: Locally wait for the DMA transfers completion"). Due to that the driver can now clear the DMAC register in a single place synchronously with the DMA transactions completion or failure. After that all

[PATCH 5/8] spi: dw-dma: Detach DMA transfer into a dedicated method

2020-07-31 Thread Serge Semin
In order to add an alternative method of DMA-based SPI transfer first we need to detach the currently available one from the common code. Here we move the normal DMA-based SPI transfer execution functionality into a dedicated method. It will be utilized if either the DMA engine supports an unlimite

[PATCH 5.4 065/138] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-27 Thread Greg Kroah-Hartman
From: Douglas Anderson [ Upstream commit 02b9aec59243c6240fc42884acc958602146ddf6 ] When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the DMA pa

[PATCH 5.7 092/179] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-27 Thread Greg Kroah-Hartman
From: Douglas Anderson [ Upstream commit 02b9aec59243c6240fc42884acc958602146ddf6 ] When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the DMA pa

Re: [PATCH v2] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-27 Thread Akash Asthana
On 7/26/2020 6:17 PM, Wolfram Sang wrote: On Thu, Jul 23, 2020 at 09:56:34PM +0200, Wolfram Sang wrote: On Wed, Jul 22, 2020 at 03:00:21PM -0700, Douglas Anderson wrote: When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one

Re: [PATCH v2] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-26 Thread Wolfram Sang
On Thu, Jul 23, 2020 at 09:56:34PM +0200, Wolfram Sang wrote: > On Wed, Jul 22, 2020 at 03:00:21PM -0700, Douglas Anderson wrote: > > When I have KASAN enabled on my kernel and I start stressing the > > touchscreen my system tends to hang. The touchscreen is one of the > > only things that does a

Re: [PATCH v2] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-23 Thread Wolfram Sang
On Wed, Jul 22, 2020 at 03:00:21PM -0700, Douglas Anderson wrote: > When I have KASAN enabled on my kernel and I start stressing the > touchscreen my system tends to hang. The touchscreen is one of the > only things that does a lot of big i2c transfers and ends up hitting > the DMA paths in the ge

Re: [PATCH v2] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-22 Thread Mukesh, Savaliya
On 7/23/2020 6:20 AM, Stephen Boyd wrote: Quoting Douglas Anderson (2020-07-22 15:00:21) When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the

Re: [PATCH v2] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-22 Thread Stephen Boyd
Quoting Douglas Anderson (2020-07-22 15:00:21) > When I have KASAN enabled on my kernel and I start stressing the > touchscreen my system tends to hang. The touchscreen is one of the > only things that does a lot of big i2c transfers and ends up hitting > the DMA paths in the geni i2c driver. It

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-22 Thread Doug Anderson
he mode (DMA vs. FIFO) and only > do writel() for DMA mode. If you're not convinced by my arguments > about dma_map_single(), would you be good with just doing the > non-relaxed version if we're in DMA mode? OK, so I did some quick benchmarking and I couldn't find any perf

[PATCH v2] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-22 Thread Douglas Anderson
When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the DMA paths in the geni i2c driver. It appears that KASAN adds enough delay in my system to ti

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Doug Anderson
Hi, On Tue, Jul 21, 2020 at 11:55 AM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-07-21 09:18:35) > > On Tue, Jul 21, 2020 at 12:08 AM Stephen Boyd wrote: > > > > > > Quoting Stephen Boyd (2020-07-20 22:59:14) > > > > > > > > I worry that we also need a dmb() here to make sure the dma buf

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Stephen Boyd
Quoting Doug Anderson (2020-07-21 09:18:35) > On Tue, Jul 21, 2020 at 12:08 AM Stephen Boyd wrote: > > > > Quoting Stephen Boyd (2020-07-20 22:59:14) > > > > > > I worry that we also need a dmb() here to make sure the dma buffer is > > > properly mapped before this write to the device is attempted

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Doug Anderson
Hi, On Tue, Jul 21, 2020 at 12:08 AM Stephen Boyd wrote: > > Quoting Stephen Boyd (2020-07-20 22:59:14) > > > > I worry that we also need a dmb() here to make sure the dma buffer is > > properly mapped before this write to the device is attempted. But it may > > only matter to be before the I2C_R

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Mukesh, Savaliya
On 7/21/2020 12:37 PM, Stephen Boyd wrote: Quoting Stephen Boyd (2020-07-20 22:59:14) I worry that we also need a dmb() here to make sure the dma buffer is properly mapped before this write to the device is attempted. But it may only matter to be before the I2C_READ. I'm suggesting this patc

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Akash Asthana
On 7/21/2020 5:54 AM, Douglas Anderson wrote: When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the DMA paths in the geni i2c driver. It appea

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Stephen Boyd
Quoting Stephen Boyd (2020-07-20 22:59:14) > > I worry that we also need a dmb() here to make sure the dma buffer is > properly mapped before this write to the device is attempted. But it may > only matter to be before the I2C_READ. > I'm suggesting this patch instead where we make geni_se_setup

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-20 Thread Stephen Boyd
Quoting Douglas Anderson (2020-07-20 17:24:53) > When I have KASAN enabled on my kernel and I start stressing the > touchscreen my system tends to hang. The touchscreen is one of the > only things that does a lot of big i2c transfers and ends up hitting > the DMA paths in the geni i2c driver. It

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-20 Thread Sai Prakash Ranjan
On 2020-07-21 05:54, Douglas Anderson wrote: When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the DMA paths in the geni i2c driver. It appears

[PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-20 Thread Douglas Anderson
When I have KASAN enabled on my kernel and I start stressing the touchscreen my system tends to hang. The touchscreen is one of the only things that does a lot of big i2c transfers and ends up hitting the DMA paths in the geni i2c driver. It appears that KASAN adds enough delay in my system to ti

[PATCH v1 0/13] Patches to improve dma transfer efficiency for Rockchip SoCs.

2020-06-08 Thread Sugar Zhang
Sugar Zhang (13): dmaengine: pl330: Remove the burst limit for quirk 'NO-FLUSHP' dmaengine: pl330: Add quirk 'arm,pl330-periph-burst' dt-bindings: dma: pl330: Document the quirk 'arm,pl330-periph-burst' ARM: dts: rk3036: Add 'arm,pl330-periph-burst' for dmac ARM: dts: rk322x: Add 'arm

Re: [PATCH] PCI: endpoint: functions/pci-epf-test: Support slave DMA transfer

2020-05-11 Thread Alan Mikhak
t; > + sconf.dst_addr = dma_dst; > > + sconf.src_addr = dma_src; > > + dmaengine_slave_config(chan, &sconf); > > + > > + buf = (dir == DMA_MEM_TO_DEV) ? dma_dst : dma_src; > > + tx = dmaengine_prep_

Re: [PATCH] PCI: endpoint: functions/pci-epf-test: Support slave DMA transfer

2020-05-07 Thread Rob Herring
On Fri, May 01, 2020 at 05:29:12PM -0700, Alan Mikhak wrote: > From: Alan Mikhak > > Modify pci_epf_test_data_transfer() to also support slave DMA transfers. > Adds a direction parameter so caller can specify one of the supported DMA > transfer directions: DMA_MEM_TO_MEM, DMA_

[PATCH] PCI: endpoint: functions/pci-epf-test: Support slave DMA transfer

2020-05-01 Thread Alan Mikhak
From: Alan Mikhak Modify pci_epf_test_data_transfer() to also support slave DMA transfers. Adds a direction parameter so caller can specify one of the supported DMA transfer directions: DMA_MEM_TO_MEM, DMA_MEM_TO_DEV, and DMA_DEV_TO_MEM. For DMA_MEM_TO_MEM, the function calls

[PATCH 4.19 149/280] spi: pxa2xx: Setup maximum supported DMA transfer length

2019-03-22 Thread Greg Kroah-Hartman
o SPI core provided DMA helpers, it missed to setup maximum supported DMA transfer length for the controller and thus users mistakenly try to send more data than supported with the following warning: ili9341 spi-PRP0001:01: DMA disabled for transfer length 153600 greater than 65536 Setup maximum

[PATCH 5.0 066/238] spi: pxa2xx: Setup maximum supported DMA transfer length

2019-03-22 Thread Greg Kroah-Hartman
o SPI core provided DMA helpers, it missed to setup maximum supported DMA transfer length for the controller and thus users mistakenly try to send more data than supported with the following warning: ili9341 spi-PRP0001:01: DMA disabled for transfer length 153600 greater than 65536 Setup maximum

[PATCH 4.14 087/183] spi: pxa2xx: Setup maximum supported DMA transfer length

2019-03-22 Thread Greg Kroah-Hartman
o SPI core provided DMA helpers, it missed to setup maximum supported DMA transfer length for the controller and thus users mistakenly try to send more data than supported with the following warning: ili9341 spi-PRP0001:01: DMA disabled for transfer length 153600 greater than 65536 Setup maximum

[PATCH 4.9 054/118] spi: pxa2xx: Setup maximum supported DMA transfer length

2019-03-22 Thread Greg Kroah-Hartman
o SPI core provided DMA helpers, it missed to setup maximum supported DMA transfer length for the controller and thus users mistakenly try to send more data than supported with the following warning: ili9341 spi-PRP0001:01: DMA disabled for transfer length 153600 greater than 65536 Setup maximum

[PATCH v2 10/14] spi: stm32: add start dma transfer function

2018-12-24 Thread cezary . gapinski
From: Cezary Gapinski Add transfer_one_dma_start function to be more generic for other stm32 SPI family drivers. Signed-off-by: Cezary Gapinski --- drivers/spi/spi-stm32.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-stm32.c b

Applied "spi: spi-fsl-dspi: Fill actual_length when doing DMA transfer" to the spi tree

2018-07-17 Thread Mark Brown
The patch spi: spi-fsl-dspi: Fill actual_length when doing DMA transfer has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

[PATCH v2] spi: spi-fsl-dspi: Fill actual_length when doing DMA transfer

2018-07-16 Thread Andrey Smirnov
Upper layer users of SPI device drivers may rely on 'actual_length', so it is important that information is correctly reported. One such example is spi_mem_exec_op() function that will fail if 'actual_length' of the data transferred is not what was requested. Add necessary code to populate 'actual_

Re: [PATCH] spi: spi-fsl-dspi: Fill actual_length when doing DMA transfer

2018-07-16 Thread Andrey Smirnov
On Mon, Jul 16, 2018 at 4:26 AM Mark Brown wrote: > > On Sun, Jul 15, 2018 at 11:25:08PM -0700, Andrey Smirnov wrote: > > Users of SPI device drivers may rely on 'actual_length', so it is > > important that information is correctly reported. One example would be > > spi_mem_exec_op() which will fa

Re: [PATCH] spi: spi-fsl-dspi: Fill actual_length when doing DMA transfer

2018-07-16 Thread Mark Brown
On Sun, Jul 15, 2018 at 11:25:08PM -0700, Andrey Smirnov wrote: > Users of SPI device drivers may rely on 'actual_length', so it is > important that information is correctly reported. One example would be > spi_mem_exec_op() which will fail if 'actual_length' doesn't match > requested transfer leng

[PATCH] spi: spi-fsl-dspi: Fill actual_length when doing DMA transfer

2018-07-15 Thread Andrey Smirnov
Users of SPI device drivers may rely on 'actual_length', so it is important that information is correctly reported. One example would be spi_mem_exec_op() which will fail if 'actual_length' doesn't match requested transfer length. To fix the problem, add necessary code to populate 'actual_length'.

Re: [PATCH v2 1/5] dmaengine: sprd: Define the DMA transfer step type

2018-04-26 Thread Vinod Koul
On Thu, Apr 19, 2018 at 10:00:46AM +0800, Baolin Wang wrote: > From: Eric Long > > Define the DMA transfer step type to make code more readable. Applied this one, thanks -- ~Vinod

[PATCH v2 1/5] dmaengine: sprd: Define the DMA transfer step type

2018-04-18 Thread Baolin Wang
From: Eric Long Define the DMA transfer step type to make code more readable. Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- Changes since v1: - Convert enum structure to macros definition for DMA step type. --- drivers/dma/sprd-dma.c | 19 +-- 1 file changed, 13

Re: [PATCH 1/5] dmaengine: sprd: Define the DMA transfer step type

2018-04-11 Thread Baolin Wang
Hi Vinod, On 11 April 2018 at 17:24, Vinod Koul wrote: > On Tue, Apr 10, 2018 at 03:46:03PM +0800, Baolin Wang wrote: >> From: Eric Long >> >> Define the DMA transfer step type to make code more readable. >> >> Signed-off-by: Eric Long >> Signed-off-by: B

Re: [PATCH 1/5] dmaengine: sprd: Define the DMA transfer step type

2018-04-11 Thread Vinod Koul
On Tue, Apr 10, 2018 at 03:46:03PM +0800, Baolin Wang wrote: > From: Eric Long > > Define the DMA transfer step type to make code more readable. > > Signed-off-by: Eric Long > Signed-off-by: Baolin Wang > --- > drivers/dma/sprd-dma.c | 28 ++

[PATCH 1/5] dmaengine: sprd: Define the DMA transfer step type

2018-04-10 Thread Baolin Wang
From: Eric Long Define the DMA transfer step type to make code more readable. Signed-off-by: Eric Long Signed-off-by: Baolin Wang --- drivers/dma/sprd-dma.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/dma/sprd-dma.c b/drivers

Re: [PATCH v2] spi: rspi: use correct enum for DMA transfer direction

2018-03-21 Thread Geert Uytterhoeven
Hi Stefan, On Mon, Mar 19, 2018 at 11:16 PM, Stefan Agner wrote: > Use enum dma_transfer_direction as required by dmaengine_prep_slave_sg > instead of enum dma_data_direction. This won't change behavior in > practice as the enum values are equivalent. Thanks for catching! BTW, spi-sh-msiof has

Applied "spi: rspi: use correct enum for DMA transfer direction" to the spi tree

2018-03-19 Thread Mark Brown
The patch spi: rspi: use correct enum for DMA transfer direction has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and

[PATCH v2] spi: rspi: use correct enum for DMA transfer direction

2018-03-19 Thread Stefan Agner
Use enum dma_transfer_direction as required by dmaengine_prep_slave_sg instead of enum dma_data_direction. This won't change behavior in practice as the enum values are equivalent. This fixes two warnings when building with clang: drivers/spi/spi-rspi.c:538:26: warning: implicit conversion from

Re: [PATCH] spi: rspi: use correct enum for DMA transfer direction

2018-03-19 Thread Stefan Agner
On 19.03.2018 22:42, Stefan Agner wrote: > Use enum dma_transfer_direction as required by dmaengine_prep_slave_sg > instead of enum dma_data_direction. > > This fixes two warnings when building with clang: > drivers/spi/spi-rspi.c:538:26: warning: implicit conversion from enumeration > typ

[PATCH] spi: rspi: use correct enum for DMA transfer direction

2018-03-19 Thread Stefan Agner
Use enum dma_transfer_direction as required by dmaengine_prep_slave_sg instead of enum dma_data_direction. This fixes two warnings when building with clang: drivers/spi/spi-rspi.c:538:26: warning: implicit conversion from enumeration type 'enum dma_data_direction' to different enumeration

[PATCH 4.4 12/49] spi: sh-msiof: Fix DMA transfer size check

2017-12-07 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Hiromitsu Yamasaki [ Upstream commit 36735783fdb599c94b9c86824583df367c65900b ] DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Fixes: b0d0ce8b6b91 ("spi: sh-msi

[PATCH 4.14 26/75] spi: sh-msiof: Fix DMA transfer size check

2017-12-07 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Hiromitsu Yamasaki [ Upstream commit 36735783fdb599c94b9c86824583df367c65900b ] DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Fixes: b0d0ce8b6b91 ("spi: sh-ms

[PATCH 4.9 019/109] spi: sh-msiof: Fix DMA transfer size check

2017-12-07 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Hiromitsu Yamasaki [ Upstream commit 36735783fdb599c94b9c86824583df367c65900b ] DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Fixes: b0d0ce8b6b91 ("spi: sh-msi

[PATCH 3.18 04/26] spi: sh-msiof: Fix DMA transfer size check

2017-12-07 Thread Greg Kroah-Hartman
3.18-stable review patch. If anyone has any objections, please let me know. -- From: Hiromitsu Yamasaki [ Upstream commit 36735783fdb599c94b9c86824583df367c65900b ] DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Fixes: b0d0ce8b6b91 ("spi: sh-ms

[PATCH AUTOSEL for 4.14 12/51] spi: sh-msiof: Fix DMA transfer size check

2017-11-22 Thread alexander . levin
From: Hiromitsu Yamasaki [ Upstream commit 36735783fdb599c94b9c86824583df367c65900b ] DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Fixes: b0d0ce8b6b91 ("spi: sh-msiof: Add DMA support") Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Simon Horman Acked-by: Ge

[PATCH AUTOSEL for 4.9 08/24] spi: sh-msiof: Fix DMA transfer size check

2017-11-22 Thread alexander . levin
From: Hiromitsu Yamasaki [ Upstream commit 36735783fdb599c94b9c86824583df367c65900b ] DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Fixes: b0d0ce8b6b91 ("spi: sh-msiof: Add DMA support") Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Simon Horman Acked-by: Ge

[PATCH AUTOSEL for 3.18 3/8] spi: sh-msiof: Fix DMA transfer size check

2017-11-22 Thread alexander . levin
From: Hiromitsu Yamasaki [ Upstream commit 36735783fdb599c94b9c86824583df367c65900b ] DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Fixes: b0d0ce8b6b91 ("spi: sh-msiof: Add DMA support") Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Simon Horman Acked-by: Ge

[PATCH AUTOSEL for 4.4 05/16] spi: sh-msiof: Fix DMA transfer size check

2017-11-22 Thread alexander . levin
From: Hiromitsu Yamasaki [ Upstream commit 36735783fdb599c94b9c86824583df367c65900b ] DMA supports 32-bit words only, even if BITLEN1 of SITMDR2 register is 16bit. Fixes: b0d0ce8b6b91 ("spi: sh-msiof: Add DMA support") Signed-off-by: Hiromitsu Yamasaki Signed-off-by: Simon Horman Acked-by: Ge

Re: [PATCH v6] mfd:rtsx: do retry when DMA transfer error

2017-05-23 Thread Lee Jones
On Tue, 23 May 2017, steven_f...@realsil.com.cn wrote: > From: Steven Feng > > The request should be resent when DMA transfer error occurred. > For rts5227, the clock rate needs to be reduced when error occurred. > > Signed-off-by: Steven Feng > --- > drivers/m

[PATCH v6] mfd:rtsx: do retry when DMA transfer error

2017-05-23 Thread steven_feng
From: Steven Feng The request should be resent when DMA transfer error occurred. For rts5227, the clock rate needs to be reduced when error occurred. Signed-off-by: Steven Feng --- drivers/mfd/rtsx_pcr.c | 17 +++-- include/linux/mfd/rtsx_pci.h | 5 + 2 files changed

Re: [PATCH v5] mfd:rtsx: do retry when DMA transfer error

2017-05-23 Thread Lee Jones
On Tue, 23 May 2017, steven_f...@realsil.com.cn wrote: > From: Steven Feng > > The request should be resent when DMA transfer error occurred. > For rts5227, the clock rate needs to be reduced when error occurred. > > Signed-off-by: Steven Feng > --- > drivers/m

[PATCH v5] mfd:rtsx: do retry when DMA transfer error

2017-05-22 Thread steven_feng
From: Steven Feng The request should be resent when DMA transfer error occurred. For rts5227, the clock rate needs to be reduced when error occurred. Signed-off-by: Steven Feng --- drivers/mfd/rtsx_pcr.c | 17 +++-- include/linux/mfd/rtsx_pci.h | 5 + 2 files changed

Re: [PATCH v4] mfd:rtsx: do retry when DMA transfer error

2017-05-22 Thread Lee Jones
On Wed, 26 Apr 2017, steven_f...@realsil.com.cn wrote: > From: Steven Feng > > The request should be resent when DMA transfer error occurred. > For rts5227, the clock rate needs to be reduced when error occurred. > > Signed-off-by: Steven Feng > --- > drivers/m

Re: [PATCH v4] mfd:rtsx: do retry when DMA transfer error

2017-04-26 Thread Lee Jones
e:181-6899-0403 Ext:57594 > > On 2017年04月26日 10:47, 冯伟linux wrote: > > From: Steven Feng > > > > The request should be resent when DMA transfer error occurred. > > For rts5227, the clock rate needs to be reduced when error occurred. > > > > Signed-off-b

Re: [PATCH v4] mfd:rtsx: do retry when DMA transfer error

2017-04-25 Thread 冯伟linux
Hi lee.jones: I have just now resented the patch V4, please review it. steven feng Realsil Microelectronics CO. LTD. Mobile:181-6899-0403 Ext:57594 On 2017年04月26日 10:47, 冯伟linux wrote: > From: Steven Feng > > The request should be resent when DMA transfer error occurred. >

[PATCH v4] mfd:rtsx: do retry when DMA transfer error

2017-04-25 Thread steven_feng
From: Steven Feng The request should be resent when DMA transfer error occurred. For rts5227, the clock rate needs to be reduced when error occurred. Signed-off-by: Steven Feng --- drivers/mfd/rtsx_pcr.c | 18 -- include/linux/mfd/rtsx_pci.h | 5 + 2 files changed

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-25 Thread Lee Jones
On Tue, 25 Apr 2017, 冯伟linux wrote: > Hi Lee Jones: > I send this email mainly for the fllowing two things; > 1.Is there anything unclear about the patch "mfd:rtsx: do retry when > dma transfer error" > 2.Whether the pach I submitted in email "[PATCH v4]

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-25 Thread 冯伟linux
Hi Lee Jones: I send this email mainly for the fllowing two things; 1.Is there anything unclear about the patch "mfd:rtsx: do retry when dma transfer error" 2.Whether the pach I submitted in email "[PATCH v4] mfd:rtsx: do retry when DMA transfer error" wil

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-10 Thread 冯伟linux
> This errno need to be -EILSEQ. > You need to explain why. > When DMA transfer error with -EILSEQ, the request will retry some times, but when with errno -EINVAL, the request will be aborted directly. At the same time the DMA transfer error truely beacuse of the Illegal byte sequence, s

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-10 Thread Lee Jones
DR104_MAX_DTR && > >>> + pcr->dma_error_count && > >>> + PCI_PID(pcr) == RTS5227_DEVICE_ID) > >>> + card_clock = (UHS_SDR104_MAX_DTR - > >>> + pcr->dma_error_count * 2000); > > ... but won&

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-10 Thread 冯伟linux
card_clock = (UHS_SDR104_MAX_DTR - >>> + pcr->dma_error_count * 2000); > ... but won't this only reduce the clock frequency just once? > > There is no point bracketing the whole statement. > > But you do need to bracket one (the second) section of it

[PATCH v4] mfd:rtsx: do retry when DMA transfer error

2017-04-10 Thread steven_feng
From: Steven Feng The request should be resent when DMA transfer error occurred. For rts5227, the clock rate needs to be reduced when error occurred. Signed-off-by: Steven Feng --- drivers/mfd/rtsx_pcr.c | 18 -- include/linux/mfd/rtsx_pci.h | 5 + 2 files changed

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-07 Thread Lee Jones
ven feng > Realsil Microelectronics CO. LTD. > Mobile:181-6899-0403 Ext:57594 > > On 2017年01月05日 17:01, 冯伟linux wrote: > > From: steven_feng Should be "Steven Feng" > > the request should be reissued when dma transfer error. > > for rts5227, the clock freq ne

Re: [PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-04-07 Thread 冯伟linux
: > From: steven_feng > > the request should be reissued when dma transfer error. > for rts5227, the clock freq need to step reduce when error occurred. > > Signed-off-by: steven_feng > --- > drivers/mfd/rtsx_pcr.c | 17 +++-- > include/linux/mfd/rtsx_

[PATCH 4.9 49/63] dmaengine: imx-sdma - correct the dma transfer residue calculation

2017-03-13 Thread Greg Kroah-Hartman
callback used to inform that dma transfer is complete. However this is not the case for all subsystems that use dma. Some subsystems use a timer to check the dma status periodically. Therefore the calculation was updated and residue is calculated accordingly by a) update the residue calculation taking in

[PATCH RESEND 1/3] serial: 8250_omap: pause DMA only if DMA transfer in progress

2017-01-20 Thread Vignesh R
It is possible that DMA transfer is already complete but, completion handler is yet to be called, when dmaengine_pause() is called in case of error condition(like break/rx timeout). This leads to dmaengine_pause() API to return EINVAL (as descriptor is already NULL) causing rx_dma_broken flag to

[PATCH 1/3] serial: 8250: omap: pause DMA only if DMA transfer in progress

2017-01-13 Thread Vignesh R
It is possible that DMA transfer is already complete but, completion handler is yet to be called, when dmaengine_pause() is called in case of error condition(like break/rx timeout). This leads to dmaengine_pause() API to return EINVAL (as descriptor is already NULL) causing rx_dma_broken flag to

Re: [PATCH v2] mfd:rtsx: do retry when dma transfer error

2017-01-05 Thread 冯伟linux
ecific? > > In which case, why isn't it in the SD card driver? > >> steven feng >> Realsil Microelectronics CO. LTD. >> Mobile:181-6899-0403 Ext:57594 >> >> 在 2017年01月04日 20:12, Lee Jones 写道: >>> On Wed, 04 Jan 2017, steven_f...@realsil.com.cn w

Re: [PATCH v2] mfd:rtsx: do retry when dma transfer error

2017-01-05 Thread Lee Jones
gt; 在 2017年01月04日 20:12, Lee Jones 写道: > > On Wed, 04 Jan 2017, steven_f...@realsil.com.cn wrote: > > > >> From: steven_feng > >> > >> the request should be reissued when dma transfer error. > >> for rts5227, the clock freq need to step reduce when e

Re: [PATCH v2] mfd:rtsx: do retry when dma transfer error

2017-01-05 Thread 冯伟linux
y as much as possible. steven feng Realsil Microelectronics CO. LTD. Mobile:181-6899-0403 Ext:57594 在 2017年01月04日 20:12, Lee Jones 写道: > On Wed, 04 Jan 2017, steven_f...@realsil.com.cn wrote: > >> From: steven_feng >> >> the request should be reissued when dma transfer

[PATCH v3] mfd:rtsx: do retry when dma transfer error

2017-01-05 Thread steven_feng
From: steven_feng the request should be reissued when dma transfer error. for rts5227, the clock freq need to step reduce when error occurred. Signed-off-by: steven_feng --- drivers/mfd/rtsx_pcr.c | 17 +++-- include/linux/mfd/rtsx_pci.h | 5 + 2 files changed, 20

Re: [PATCH v2] mfd:rtsx: do retry when dma transfer error

2017-01-04 Thread Lee Jones
On Wed, 04 Jan 2017, steven_f...@realsil.com.cn wrote: > From: steven_feng > > the request should be reissued when dma transfer error. > for rts5227, the clock freq need to step reduce when error occurred. > > Signed-off-by: steven_feng > --- > drivers/m

[PATCH v2] mfd:rtsx: do retry when dma transfer error

2017-01-04 Thread steven_feng
From: steven_feng the request should be reissued when dma transfer error. for rts5227, the clock freq need to step reduce when error occurred. Signed-off-by: steven_feng --- drivers/mfd/rtsx_pcr.c | 16 ++-- include/linux/mfd/rtsx_pci.h | 4 2 files changed, 18

Re: [PATCH] mfd:rtsx: do retry when dma transfer error

2017-01-04 Thread 冯伟linux
> This seems strange. What is the reason for using this error? > >> +if (pcr->dma_error_count < 8) > Why 8? dma_error_count record the number of dma transfer error, card clock decreased by 20MHz *dma_error_count, when setting card clock again. while dma_error_

Re: [PATCH] mfd:rtsx: do retry when dma transfer error

2017-01-03 Thread Lee Jones
On Fri, 09 Dec 2016, steven_f...@realsil.com.cn wrote: > From: steven_feng > > the request should be reissued when dma transfer error. > for rts5227, the clock freq need to step reduce when error occurred. > > Signed-off-by: steven_feng > --- > drivers/m

Re: Tearing down DMA transfer setup after DMA client has finished

2016-12-15 Thread Mark Brown
On Fri, Dec 09, 2016 at 07:23:17PM +0100, Mason wrote: > On 09/12/2016 18:56, Vinod Koul wrote: > > Right, but in that case the fallback would be PIO mode, and if that is > > not availble (IIRC some f your devices don't) then reject the usage with > > EAGAIN. > Maybe I'm missing something, but I

Re: Tearing down DMA transfer setup after DMA client has finished

2016-12-11 Thread Vinod Koul
On Fri, Dec 09, 2016 at 07:23:17PM +0100, Mason wrote: > [ Dropping Mans to preserve his peace-of-mind ] > > On 09/12/2016 18:56, Vinod Koul wrote: > > On Fri, Dec 09, 2016 at 06:34:15PM +0100, Mason wrote: > >> On 09/12/2016 18:17, Vinod Koul wrote: > >> > >>> On Fri, Dec 09, 2016 at 11:25:57AM +

Re: Tearing down DMA transfer setup after DMA client has finished

2016-12-09 Thread Mason
[ Dropping Mans to preserve his peace-of-mind ] On 09/12/2016 18:56, Vinod Koul wrote: > On Fri, Dec 09, 2016 at 06:34:15PM +0100, Mason wrote: >> On 09/12/2016 18:17, Vinod Koul wrote: >> >>> On Fri, Dec 09, 2016 at 11:25:57AM +0100, Sebastian Frias wrote: What concrete solution do you

Re: Tearing down DMA transfer setup after DMA client has finished

2016-12-09 Thread Vinod Koul
On Fri, Dec 09, 2016 at 11:26:06PM +0530, Vinod Koul wrote: > On Fri, Dec 09, 2016 at 06:34:15PM +0100, Mason wrote: > > On 09/12/2016 18:17, Vinod Koul wrote: > > > > > On Fri, Dec 09, 2016 at 11:25:57AM +0100, Sebastian Frias wrote: > > >> > > >> What concrete solution do you propose? > > > > >

Re: Tearing down DMA transfer setup after DMA client has finished

2016-12-09 Thread Vinod Koul
On Fri, Dec 09, 2016 at 06:34:15PM +0100, Mason wrote: > On 09/12/2016 18:17, Vinod Koul wrote: > > > On Fri, Dec 09, 2016 at 11:25:57AM +0100, Sebastian Frias wrote: > >> > >> What concrete solution do you propose? > > > > I have already proposed two solutions. > > > > A) Request a channel only

Re: Tearing down DMA transfer setup after DMA client has finished

2016-12-09 Thread Vinod Koul
On Fri, Dec 09, 2016 at 05:28:01PM +, Måns Rullgård wrote: > Vinod Koul writes: > > > On Fri, Dec 09, 2016 at 11:25:57AM +0100, Sebastian Frias wrote: > >> > >> What concrete solution do you propose? > > > > I have already proposed two solutions. > > > > A) Request a channel only when you ne

Re: Tearing down DMA transfer setup after DMA client has finished

2016-12-09 Thread Mason
On 09/12/2016 18:17, Vinod Koul wrote: > On Fri, Dec 09, 2016 at 11:25:57AM +0100, Sebastian Frias wrote: >> >> What concrete solution do you propose? > > I have already proposed two solutions. > > A) Request a channel only when you need it. Obviously we can't do virtual > channels with this (th

  1   2   3   >