From: Hans de Goede
commit aee6f25e9c911323aa89a200e1bb160c1613ed3d upstream.
After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down
displays gracefully on reboot"), the DSI panel on a Cherry Trail based
Predia Basic tablet would no longer properly light up after reb
).
This leads to allocating no DDB for the Y plane since .min_ddb_alloc
also gets zeroed. And that of course leads to underruns when scanning
out planar formats.
Cc: sta...@vger.kernel.org
Cc: Stanislav Lisovskiy
Fixes: dbf71381d733 ("drm/i915: Nuke
intel_atomic_crtc_state_for_each_plane_state()
i915_pm_resume elsewhere.)
>
This patch can be separated from the series, thanks.
> BR,
> Jani.
>
> >
> > Signed-off-by: Hsin-Yi Wang
> > Reported-by: kernel test robot
> > ---
> > drivers/gpu/drm/i915/selftests/i915_gem.c | 10 +-
> > 1 file
> ---
> drivers/gpu/drm/i915/selftests/i915_gem.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c
> b/drivers/gpu/drm/i915/selftests/i915_gem.c
> index dc394fb7ccfa..525afda9d31f 100644
> --- a
ess_one_work+0x26d/0x6d0
worker_thread+0x53/0x330
kthread+0x1b0/0x1d0
? process_one_work+0x6d0/0x6d0
? __kthread_parkme+0xc0/0xc0
ret_from_fork+0x22/0x30
Fixes: 9d5612ca165a ("drm/i915/gt: Defer enabling the breadcrumb interrupt to
after submission")
Signed-off-by: Jun Miao
---
d
of kstrdup().
Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security
mitigations")
Signed-off-by: Jisheng Zhang
---
Since v2:
- Use strscpy() per Ville's suggestion.
Since v1:
- Ensure "str" is properly terminated. Thanks Ville for pointing thi
Vetter
Cc: Rodrigo Vivi
Cc: Zhenyu Wang
Cc: Zhi Wang
---
drivers/gpu/drm/i915/gvt/gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
index 897c007ea96a..937b6083b2dc 100644
--- a/drivers/gpu/drm/i915/gvt/gtt.c
at that time, so kstrdup()
> returns NULL. Fix this issue by using stack var instead of kstrdup().
>
> Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security
> mitigations")
> Signed-off-by: Jisheng Zhang
> ---
> Since v1:
> - Ensure "
pm_resume and pm_suspend might be conflict with the ones defined in
include/linux/suspend.h. Rename pm_resume{suspend} to
i915_pm_resume{suspend} since they are only used here.
Signed-off-by: Hsin-Yi Wang
Reported-by: kernel test robot
---
drivers/gpu/drm/i915/selftests/i915_gem.c | 10
On 2021.04.13 14:18:48 +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/gpu/drm/i915/gvt/gtt.c:590:20: warning: unused function
> 'ppgtt_set_guest_root_entry' [-Wunused-function].
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
>
g kernel: `off' invalid for parameter
> > `i915.mitigations'
> >
> > The reason is slab subsystem isn't ready at that time, so kstrdup()
> > returns NULL. Fix this issue by using stack var instead of kstrdup().
> >
> > Fixes: 984cadea032b ("drm/i915: Allow the sys
med the new strategy doesn't introduce
regression on XPS 9380.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3384
References: https://gitlab.freedesktop.org/drm/intel/-/issues/272
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/i915/display/intel_dp.c | 10 +-
1 file changed
' invalid for parameter
> > `i915.mitigations'
> >
> > The reason is slab subsystem isn't ready at that time, so kstrdup()
> > returns NULL. Fix this issue by using stack var instead of kstrdup().
> >
> > Fixes: 984cadea032b ("drm/i915: Allow the sysadm
of kstrdup().
Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security
mitigations")
Signed-off-by: Jisheng Zhang
---
Since v1:
- Ensure "str" is properly terminated. Thanks Ville for pointing this out.
drivers/gpu/drm/i915/i915_mitigations.c | 8 +++-
1 fi
at that time, so kstrdup()
> returns NULL. Fix this issue by using stack var instead of kstrdup().
>
> Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security
> mitigations")
> Signed-off-by: Jisheng Zhang
> ---
> drivers/gpu/drm/i915/i915_mitigat
of kstrdup().
Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security
mitigations")
Signed-off-by: Jisheng Zhang
---
drivers/gpu/drm/i915/i915_mitigations.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_mitigations.c
b/
Fix the following clang warning:
drivers/gpu/drm/i915/gvt/gtt.c:590:20: warning: unused function
'ppgtt_set_guest_root_entry' [-Wunused-function].
Reported-by: Abaci Robot
Signed-off-by: Jiapeng Chong
---
drivers/gpu/drm/i915/gvt/gtt.c | 6 --
1 file changed, 6 deletions(-)
diff --git
man
---
drivers/gpu/drm/i915/display/intel_acpi.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
--- a/drivers/gpu/drm/i915/display/intel_acpi.c
+++ b/drivers/gpu/drm/i915/display/intel_acpi.c
@@ -84,13 +84,31 @@ static void intel_dsm_platform_mux_i
man
---
drivers/gpu/drm/i915/display/intel_acpi.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
--- a/drivers/gpu/drm/i915/display/intel_acpi.c
+++ b/drivers/gpu/drm/i915/display/intel_acpi.c
@@ -84,13 +84,31 @@ static void intel_dsm_platform_mux_i
man
---
drivers/gpu/drm/i915/display/intel_acpi.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
--- a/drivers/gpu/drm/i915/display/intel_acpi.c
+++ b/drivers/gpu/drm/i915/display/intel_acpi.c
@@ -83,13 +83,31 @@ static void intel_dsm_platform_mux_i
we send out the report, we also tested fe7d52bccab6, the issue
> > > > still
> > > > exists on it.
> > > > attached one kmsg-fe7d52bccab6.xz FYI.
> > > >
> > > > we also tested on latest v5.12-rc3, also exists.
> > > &g
Fix the following coccicheck warning:
drivers/gpu/drm/i915/display/intel_psr.c:1530:29-31: WARNING
!A || A && B is equivalent to !A || B
Signed-off-by: Qiheng Lin
---
drivers/gpu/drm/i915/display/intel_psr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers
On Thu, 08 Apr 2021 18:56:06 +0200,
Ville Syrjälä wrote:
>
> On Thu, Apr 08, 2021 at 06:34:06PM +0200, Takashi Iwai wrote:
> > On Thu, 08 Apr 2021 09:51:18 +0200,
> > Takashi Iwai wrote:
> > >
> > > On Wed, 07 Apr 2021 23:28:48 +0200,
> > > Ville Syrjälä wrote:
> > > >
> > > > Oh, could you ask
On Thu, Apr 08, 2021 at 06:34:06PM +0200, Takashi Iwai wrote:
> On Thu, 08 Apr 2021 09:51:18 +0200,
> Takashi Iwai wrote:
> >
> > On Wed, 07 Apr 2021 23:28:48 +0200,
> > Ville Syrjälä wrote:
> > >
> > > Oh, could you ask the bug reporter to attach an acpidump to the
> > > bug? Might be good to
On Thu, 08 Apr 2021 09:51:18 +0200,
Takashi Iwai wrote:
>
> On Wed, 07 Apr 2021 23:28:48 +0200,
> Ville Syrjälä wrote:
> >
> > Oh, could you ask the bug reporter to attach an acpidump to the
> > bug? Might be good to have that stuff on record somewhere if/when
> > someone wants to actually
gt; > v1->v2: Check the info contents before dereferencing, too
> > > >
> > > > BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074
> > > > Cc:
> > > > Signed-off-by: Takashi Iwai
> > > > ---
> > > > drivers/
ly.
> > >
> > > Add the checks of the contents in the returned values and skip the
> > > values for invalid cases.
> > >
> > > v1->v2: Check the info contents before dereferencing, too
> > >
> > > BugLink: http://bugzilla.opensuse.org
ues for invalid cases.
> >
> > v1->v2: Check the info contents before dereferencing, too
> >
> > BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074
> > Cc:
> > Signed-off-by: Takashi Iwai
> > ---
> > drivers/gpu/drm/i915/display/intel_acp
; BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074
> Cc:
> Signed-off-by: Takashi Iwai
> ---
> drivers/gpu/drm/i915/display/intel_acpi.c | 22 --
> 1 file changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_a
t; > There is no need to carry on entire kernel.h.
> > >
> > > Signed-off-by: Andy Shevchenko
> >
> > That's hardly drm/i915 specific!
>
> It was originated from i915!
>
> > Reviewed-by: Jani Nikula
>
> Thanks!
>
> > But who's going to pi
On Wed, Apr 07, 2021 at 03:46:37PM +0300, Jani Nikula wrote:
> On Wed, 07 Apr 2021, Andy Shevchenko
> wrote:
> > The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> > There is no need to carry on entire kernel.h.
> >
> > Signed-off-by: Andy Shev
On Wed, 07 Apr 2021, Andy Shevchenko wrote:
> The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> There is no need to carry on entire kernel.h.
>
> Signed-off-by: Andy Shevchenko
That's hardly drm/i915 specific!
Reviewed-by: Jani Nikula
But who's going t
The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
There is no need to carry on entire kernel.h.
Signed-off-by: Andy Shevchenko
---
include/linux/ascii85.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h
fixed. Will resend once I figure out what's
>> > going on
>>
>> Well, I think there are actually multiple issues on multiple
>> machines. This fixes the issue on ThinkPad X1 Titanium Gen1 [1].
>>
>> I suspect reverting 98e497e203a5 ("drm/i915/dp
On Sun, 04 Apr 2021, Carlis wrote:
> From: Xuezhi Zhang
>
> Fix the following coccicheck warning:
> drivers/gpu/drm/i915//i915_sysfs.c:266:8-16:
> WARNING: use scnprintf or sprintf
> drivers/gpu/drm/i915//i915_sysfs.c:285:8-16:
> WARNING: use scnprintf or sprintf
&
From: Xuezhi Zhang
Fix the following coccicheck warning:
drivers/gpu/drm/i915//i915_sysfs.c:266:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:285:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:276:8-16:
WARNING: use scnprintf or sprintf
, as reported recently.
Add the checks of the contents in the returned values and skip the
values for invalid cases.
v1->v2: Check the info contents before dereferencing, too
BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074
Cc:
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/disp
; Signed-off-by: Takashi Iwai
Scratch this one. I sent an older version mistakenly.
Will resubmit the right one.
Takashi
> ---
> drivers/gpu/drm/i915/display/intel_acpi.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel
, as reported recently.
Add the checks of the contents in the returned values and skip the
values for invalid cases.
BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074
Cc:
Signed-off-by: Takashi Iwai
---
drivers/gpu/drm/i915/display/intel_acpi.c | 12
1 file changed, 12 insertions
Vetter
Cc: Rodrigo Vivi
Cc: Zhenyu Wang
Cc: Zhi Wang
---
drivers/gpu/drm/i915/gvt/gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
index 897c007ea96a..937b6083b2dc 100644
--- a/drivers/gpu/drm/i915/gvt/gtt.c
.
Fix this by setting err to zero before the while loop starts.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.lock.")
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 +-
1 fi
Hi,
Static analysis with Coverity on Linux-next has detected a potential
issue with the following commit:
commit 480ae79537b28f30ef6e07b7de69a9ae2599daa7
Author: Maarten Lankhorst
Date: Tue Mar 23 16:50:49 2021 +0100
drm/i915/selftests: Prepare gtt tests for obj->mm.lock remo
Hi Nick,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: d19cc4bfbff1ae72c3505a00fb8ce0d3fa519e6c
commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable
-Wframe-address
date: 11 months ago
config
Hi,
On 3/22/21 5:02 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> gcc-11 warns that intel_dp_check_mst_status() has a local array of
> fourteen bytes and passes the last four bytes into a function that
> expects a six-byte array:
>
> drivers/gpu/drm/i915/display/in
: Chris Wilson
Cc: # v4.12+
Fixes: 181df2d458f3 ("drm/i915: Take rpm wakelock for releasing the fence on
unbind")
Reviewed-by: Chris Wilson
Signed-off-by: Imre Deak
Link:
https://patchwork.freedesktop.org/patch/msgid/20210322204223.919936-1-imre.d...@intel.com
(cherry picked f
From: Jani Nikula
commit b61fde1beb6b1847f1743e75f4d9839acebad76a upstream.
Use the correct DSS CTL registers for ICL DSI transcoders.
As a side effect, this also brings back the sanity check for trying to
use pipe DSC registers on pipe A on ICL.
Fixes: 8a029c113b17 ("drm/i915/dp: Modify
: Chris Wilson
Cc: # v4.12+
Fixes: 181df2d458f3 ("drm/i915: Take rpm wakelock for releasing the fence on
unbind")
Reviewed-by: Chris Wilson
Signed-off-by: Imre Deak
Link:
https://patchwork.freedesktop.org/patch/msgid/20210322204223.919936-1-imre.d...@intel.com
(cherry picked f
struct drm_i915_private, struct intel_crtc_state and
struct intel_crtc is declared twice.
Remove the duplicate.
Reviewed-by: José Roberto de Souza
Signed-off-by: Wan Jiabing
---
Changelog:
v2:
- Modify subject line.
- Delete trailing whitespace in commit log.
---
drivers/gpu/drm/i915/display
:00
Committer: Thomas Gleixner
CommitterDate: Thu, 25 Mar 2021 18:21:03 +01:00
drm/i915: Use tasklet_unlock_spin_wait() in __tasklet_disable_sync_once()
The i915 driver has its own tasklet interface which was overseen in the
tasklet rework. __tasklet_disable_sync_once() is a wrapper around
On 3/25/21 3:53 AM, Arnd Bergmann wrote:
On Thu, Mar 25, 2021 at 9:05 AM Jani Nikula wrote:
Clearly something is wrong here, but I can't quite figure out what.
Changing the array size to 16 bytes avoids the warning, but is
probably the wrong solution here.
Ugh. drm_dp_channel_eq_ok() does
On Thu, Mar 25, 2021 at 9:05 AM Jani Nikula wrote:
> > Clearly something is wrong here, but I can't quite figure out what.
> > Changing the array size to 16 bytes avoids the warning, but is
> > probably the wrong solution here.
>
> Ugh. drm_dp_channel_eq_ok() does not actually require more than
>
On Mon, 22 Mar 2021, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> gcc-11 warns that intel_dp_check_mst_status() has a local array of
> fourteen bytes and passes the last four bytes into a function that
> expects a six-byte array:
>
> drivers/gpu/drm/i915/display/in
inlined from ‘ilk_setup_wm_latency’ at
> > drivers/gpu/drm/i915/intel_pm.c:3108:3:
> > drivers/gpu/drm/i915/intel_pm.c:3057:9: error: ‘intel_print_wm_latency’
> > reading 16 bytes from a region of size 10 [-Werror=stringop-overread]
> > 3057 | intel_prin
> >
> > > tree:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c
> > > commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable
> > > -Wframe-addre
On Mon, 22 Mar 2021, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> gcc-11 warns about what appears to be an out-of-range array access:
>
> In function ‘snb_wm_latency_quirk’,
> inlined from ‘ilk_setup_wm_latency’ at
> drivers/gpu/drm/i915/intel_pm.c:3108:3:
&
torvalds/linux.git
> > master
> > head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c
> > commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable
> > -Wframe-address
>
> This in unrelated to my change.
>
> + Changbin, Zhenyu (authors of 3aff3512802) and Zhi
0e260cdfc9f0b8c
> commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable
> -Wframe-address
This in unrelated to my change.
+ Changbin, Zhenyu (authors of 3aff3512802) and Zhi (author of
054f4eba2a298) in case there's any interest in fixing this up.
Otherwise I don't think these tiny helpful functions w
02:53:11PM -0500, Lyude Paul wrote:
> > > Am I right in assuming this is likely a very delayed test result from
> > > before:
> > >
> > > fe7d52bccab6 ("drm/i915/dp: Don't use DPCD backlights that need PWM
> > > enable/disable")
> > >
> >
going on
>
> Well, I think there are actually multiple issues on multiple
> machines. This fixes the issue on ThinkPad X1 Titanium Gen1 [1].
>
> I suspect reverting 98e497e203a5 ("drm/i915/dpcd_bl: uncheck PWM_PIN_CAP
> when detect eDP backlight capabilities") would too.
the issue on ThinkPad X1 Titanium Gen1 [1].
I suspect reverting 98e497e203a5 ("drm/i915/dpcd_bl: uncheck PWM_PIN_CAP
when detect eDP backlight capabilities") would too. But then that would
break *other* machines that claim support for *both* eDP PWM pin and
DPCD backlight control
tasklet_unlock_spin_wait() instead which can be invoked from
non-preemptible contexts.
Fixes: da044747401fc ("tasklets: Replace spin wait in tasklet_unlock_wait()")
Reported-by: kernel test robot
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/gpu/drm/i915/i915_gem.h | 2 +-
1 file
On 10:53 Tue 23 Mar 2021, Jani Nikula wrote:
On Tue, 23 Mar 2021, Bhaskar Chowdhury wrote:
s/nothign/nothing/
Signed-off-by: Bhaskar Chowdhury
You've sent the same patch before? I've already pushed it.
Apologies and thanks.
BR,
Jani.
---
drivers/gpu/drm/i915/display/intel_dpll_mgr.c
On Tue, 23 Mar 2021, Bhaskar Chowdhury wrote:
> s/nothign/nothing/
>
> Signed-off-by: Bhaskar Chowdhury
You've sent the same patch before? I've already pushed it.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
s/nothign/nothing/
Signed-off-by: Bhaskar Chowdhury
---
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index f6ad257a260e
From: Arnd Bergmann
gcc-11 warns that intel_dp_check_mst_status() has a local array of
fourteen bytes and passes the last four bytes into a function that
expects a six-byte array:
drivers/gpu/drm/i915/display/intel_dp.c: In function
‘intel_dp_check_mst_status’:
drivers/gpu/drm/i915/display
From: Arnd Bergmann
gcc-11 warns about what appears to be an out-of-range array access:
In function ‘snb_wm_latency_quirk’,
inlined from ‘ilk_setup_wm_latency’ at
drivers/gpu/drm/i915/intel_pm.c:3108:3:
drivers/gpu/drm/i915/intel_pm.c:3057:9: error: ‘intel_print_wm_latency’ reading
16
On Tue, Mar 16, 2021 at 08:10:36AM -0700, Yu-cheng Yu wrote:
> After the introduction of _PAGE_COW, a modified page's PTE can have either
> _PAGE_DIRTY or _PAGE_COW. Change _PAGE_DIRTY to _PAGE_DIRTY_BITS.
>
> Signed-off-by: Yu-cheng Yu
> Reviewed-by: Kees Cook
> Cc: David Airlie
> Cc: Joonas
Hi Nick,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c
commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable
-Wframe-address
date: 11 months ago
config
92010a97098c4c9fd777408cc98064d26b32695b)
Signed-off-by: Colin Xu
Cc: # 5.4.y
Signed-off-by: Greg Kroah-Hartman
---
drivers/gpu/drm/i915/gvt/handlers.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt
://patchwork.freedesktop.org/patch/msgid/20201012045231.226748-1-colin...@intel.com
(cherry picked from commit 8fe105679765700378eb328495fcfe1566cdbbd0)
Signed-off-by: Colin Xu
Cc: # 5.4.y
Signed-off-by: Greg Kroah-Hartman
---
drivers/gpu/drm/i915/gvt/handlers.c | 32
, the guest driver won't detect a valid HPD pulse thus no full
display detection will be executed to read the updated EDID.
With this patch, the vfio_edid is enabled again on BXT/APL, which is
previously disabled.
Fixes: 642403e3599e ("drm/i915/gvt: Temporarily disable vfio_edid for BXT/APL")
might evaluate actual display hotplug for BDW to make this function
work as expected, anyway this is always required to be fixed first.
Reported-by: Alejandro Sior
Cc: Alejandro Sior
Fixes: 0178f4ce3c3b ("drm/i915/gvt: Enable vfio edid for all GVT supported
platform")
Reviewed-by:
-off-by: Colin Xu
Cc: # 5.4.y
Signed-off-by: Greg Kroah-Hartman
---
drivers/gpu/drm/i915/gvt/display.c | 173 +
drivers/gpu/drm/i915/gvt/mmio.c|5 +
2 files changed, 178 insertions(+)
--- a/drivers/gpu/drm/i915/gvt/display.c
+++ b/drivers/gpu/drm/i915
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
> s/nothign/nothing/
>
> Signed-off-by: Bhaskar Chowdhury
Thanks, pushed.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/driv
the reproduction
steps.
Regards,
Tomi
> From: Lyude Paul
>
> Subject: Re: [drm/i915/dp] 4a8d79901d:
> WARNING:at_drivers/gpu/drm/i915/display/intel_display_power.c:#assert_
> can_disable_lcpll[i915]
>
> Well this is surprising, because I had been pretty sure we had asked
> so
s/nothign/nothing/
Signed-off-by: Bhaskar Chowdhury
---
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index f6ad257a260e
On 3/18/21 3:19 AM, Bhaskar Chowdhury wrote:
>
> s/bariers/barriers/
>
> Signed-off-by: Bhaskar Chowdhury
Acked-by: Randy Dunlap
> ---
> drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gi
t; the VBT just to be safe. We might be able to try enabling this again by
> default in the future.
>
> Fixes: 2227816e647a ("drm/i915/dp: Allow forcing specific interfaces through
> enable_dpcd_backlight")
> Cc: Jani Nikula
> Cc: Rodrigo Vivi
> Bugzilla: https://gitlab.fr
ul wrote:
> > Am I right in assuming this is likely a very delayed test result from
> > before:
> >
> > fe7d52bccab6 ("drm/i915/dp: Don't use DPCD backlights that need PWM
> > enable/disable")
> >
> > Made it into the kernel? I see that ther
to be safe. We might be able to try enabling this again by
default in the future.
Fixes: 2227816e647a ("drm/i915/dp: Allow forcing specific interfaces through
enable_dpcd_backlight")
Cc: Jani Nikula
Cc: Rodrigo Vivi
Bugzilla: https://gitlab.freedesktop.org/drm/intel/-/issues/3169
Signed-off
s/bariers/barriers/
Signed-off-by: Bhaskar Chowdhury
---
drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c
b/drivers/gpu/drm/i915/gt/intel_timeline.c
index 037b0e3ccbed..25fc7f44fee0 100644
Wang
Cc: Zhi Wang
---
drivers/gpu/drm/i915/gvt/gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
index 897c007ea96a..937b6083b2dc 100644
--- a/drivers/gpu/drm/i915/gvt/gtt.c
+++ b/drivers/gpu/drm/i915/gvt
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 1e28eed17697bcf343c6743f0028cc3b5dd88bf0
commit: 03c62d886dd6d3dfebf59d385a37245fe667fe90 drm/i915: Make GEM errors
non-fatal by default
date: 8 weeks ago
config: x86_64-randconfig-m001-20210316 (attached
From: Greg Kroah-Hartman
From: Tvrtko Ursulin
commit a829f033e966d5e4aa27c3ef2b381f51734e4a7f upstream.
Commit 311a50e76a33 ("drm/i915: Add support for mandatory cmdparsing")
introduced mandatory command parsing but setup failures were not
translated into wedging the GPU which wa
From: Greg Kroah-Hartman
From: Tvrtko Ursulin
commit a829f033e966d5e4aa27c3ef2b381f51734e4a7f upstream.
Commit 311a50e76a33 ("drm/i915: Add support for mandatory cmdparsing")
introduced mandatory command parsing but setup failures were not
translated into wedging the GPU which wa
On 3/13/21 8:43 PM, Bhaskar Chowdhury wrote:
>
> s/bariers/barriers/
>
> Signed-off-by: Bhaskar Chowdhury
Acked-by: Randy Dunlap
> ---
> drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gi
s/bariers/barriers/
Signed-off-by: Bhaskar Chowdhury
---
drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c
b/drivers/gpu/drm/i915/gt/intel_timeline.c
index 8015964043eb..2b921c1796dc 100644
Hi Chris,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: 88fe49249c99de14e543c632a46248d85411ab9e
commit: 70a2b431c36483c0c06e589e11c59e438cd0ac06 drm/i915/gt: Rename lrc.c to
execlists_submission.c
date: 3
t; FYI, we noticed the following commit (built with gcc-9):
> > >
> > > commit: 7962893ecb853aa7c8925ce237ab6c4274cfc1c7 ("drm/i915: Disable
> > > runtime power management during shutdown")
> > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git
Hi Chris,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: a74e6a014c9d4d4161061f770c9b4f98372ac778
commit: 70a2b431c36483c0c06e589e11c59e438cd0ac06 drm/i915/gt: Rename lrc.c to
execlists_submission.c
date: 3
Wang
Cc: Zhi Wang
---
drivers/gpu/drm/i915/gvt/gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
index 897c007ea96a..937b6083b2dc 100644
--- a/drivers/gpu/drm/i915/gvt/gtt.c
+++ b/drivers/gpu/drm/i915/gvt
eb_copy_relocations() only do unsafe_put_user(), it only
requires write access to user.
Use user_write_access_begin() instead of user_access_begin().
Signed-off-by: Christophe Leroy
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
i_handle instead of void*
> > > v5: same as v4
> > > v4: Same as v3
> > > v3: fold the code into existing acpi_device_id_update() function
> > > v2: formed by splitting the original patch into ACPI lookup, and privacy
> > > screen property. Also move it into i915 n
On 2021/3/8 17:18, Chris Wilson wrote:
Quoting Jia-Ju Bai (2021-03-08 08:59:52)
When i915_random_order() returns NULL to order, no error return code of
igt_buddy_alloc_smoke() is assigned.
To fix this bug, err is assigned with -EINVAL in this case.
It would not be EINVAL since that is used
Quoting Jia-Ju Bai (2021-03-08 08:59:52)
> When i915_random_order() returns NULL to order, no error return code of
> igt_buddy_alloc_smoke() is assigned.
> To fix this bug, err is assigned with -EINVAL in this case.
It would not be EINVAL since that is used for a reference failure, but
in this
Quoting Jia-Ju Bai (2021-03-08 09:07:22)
> When kcalloc() returns NULL to tsk or thread, no error code of
> igt_threaded_blt() is returned.
> To fix this bug, -ENOMEM is returned as error code.
Because we decided to skip the test if it could not be run due to
insufficient memory, as opposed to
When kcalloc() returns NULL to tsk or thread, no error code of
igt_threaded_blt() is returned.
To fix this bug, -ENOMEM is returned as error code.
Fixes: 0e99f939f08f ("drm/i915/selftests/blt: add some kthreads into the mix")
Reported-by: TOTE Robot
Signed-off-by: Jia-Ju Bai
---
d
When i915_random_order() returns NULL to order, no error return code of
igt_buddy_alloc_smoke() is assigned.
To fix this bug, err is assigned with -EINVAL in this case.
Fixes: 1fe3818d17c9 ("drm/i915/selftests: try to rein in alloc_smoke")
Reported-by: TOTE Robot
Signed-off-by:
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a return statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva
---
drivers/gpu/drm/i915/gem
-by: Thomas Gleixner
Cc: Jani Nikula
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Cc: David Airlie
Cc: Daniel Vetter
Cc: Chris Wilson
Cc: intel-...@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
---
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c |7 +---
drivers/gpu/drm/i915/i915_gem.c
1 - 100 of 8900 matches
Mail list logo