[PATCH 5.11 078/122] drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when disabling the panel

2021-04-19 Thread Greg Kroah-Hartman
From: Hans de Goede commit aee6f25e9c911323aa89a200e1bb160c1613ed3d upstream. After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down displays gracefully on reboot"), the DSI panel on a Cherry Trail based Predia Basic tablet would no longer properly light up after reb

[PATCH 5.11 061/122] drm/i915: Dont zero out the Y planes watermarks

2021-04-19 Thread Greg Kroah-Hartman
). This leads to allocating no DDB for the Y plane since .min_ddb_alloc also gets zeroed. And that of course leads to underruns when scanning out planar formats. Cc: sta...@vger.kernel.org Cc: Stanislav Lisovskiy Fixes: dbf71381d733 ("drm/i915: Nuke intel_atomic_crtc_state_for_each_plane_state()

Re: [PATCH v19 6/6] drm/i915/selftests: Rename functions names

2021-04-16 Thread Hsin-Yi Wang
i915_pm_resume elsewhere.) > This patch can be separated from the series, thanks. > BR, > Jani. > > > > > Signed-off-by: Hsin-Yi Wang > > Reported-by: kernel test robot > > --- > > drivers/gpu/drm/i915/selftests/i915_gem.c | 10 +- > > 1 file

Re: [PATCH v19 6/6] drm/i915/selftests: Rename functions names

2021-04-16 Thread Jani Nikula
> --- > drivers/gpu/drm/i915/selftests/i915_gem.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c > b/drivers/gpu/drm/i915/selftests/i915_gem.c > index dc394fb7ccfa..525afda9d31f 100644 > --- a

[V3] drm/i915/gt: Fix a lockdep warning with interrupts enabled

2021-04-16 Thread Jun Miao
ess_one_work+0x26d/0x6d0 worker_thread+0x53/0x330 kthread+0x1b0/0x1d0 ? process_one_work+0x6d0/0x6d0 ? __kthread_parkme+0xc0/0xc0 ret_from_fork+0x22/0x30 Fixes: 9d5612ca165a ("drm/i915/gt: Defer enabling the breadcrumb interrupt to after submission") Signed-off-by: Jun Miao --- d

[PATCH v3] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-16 Thread Jisheng Zhang
of kstrdup(). Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security mitigations") Signed-off-by: Jisheng Zhang --- Since v2: - Use strscpy() per Ville's suggestion. Since v1: - Ensure "str" is properly terminated. Thanks Ville for pointing thi

[PATCH v25 10/30] drm/i915/gvt: Change _PAGE_DIRTY to _PAGE_DIRTY_BITS

2021-04-15 Thread Yu-cheng Yu
Vetter Cc: Rodrigo Vivi Cc: Zhenyu Wang Cc: Zhi Wang --- drivers/gpu/drm/i915/gvt/gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index 897c007ea96a..937b6083b2dc 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.c

Re: [PATCH v2] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-15 Thread Ville Syrjälä
at that time, so kstrdup() > returns NULL. Fix this issue by using stack var instead of kstrdup(). > > Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security > mitigations") > Signed-off-by: Jisheng Zhang > --- > Since v1: > - Ensure "

[PATCH v19 6/6] drm/i915/selftests: Rename functions names

2021-04-14 Thread Hsin-Yi Wang
pm_resume and pm_suspend might be conflict with the ones defined in include/linux/suspend.h. Rename pm_resume{suspend} to i915_pm_resume{suspend} since they are only used here. Signed-off-by: Hsin-Yi Wang Reported-by: kernel test robot --- drivers/gpu/drm/i915/selftests/i915_gem.c | 10

Re: [PATCH] drm/i915/gvt: remove useless function

2021-04-14 Thread Zhenyu Wang
On 2021.04.13 14:18:48 +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/gpu/drm/i915/gvt/gtt.c:590:20: warning: unused function > 'ppgtt_set_guest_root_entry' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong >

Re: [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-14 Thread Jisheng Zhang
g kernel: `off' invalid for parameter > > `i915.mitigations' > > > > The reason is slab subsystem isn't ready at that time, so kstrdup() > > returns NULL. Fix this issue by using stack var instead of kstrdup(). > > > > Fixes: 984cadea032b ("drm/i915: Allow the sys

[PATCH] drm/i915/dp: Use slow and wide link training for DPCP rev < 1.4

2021-04-14 Thread Kai-Heng Feng
med the new strategy doesn't introduce regression on XPS 9380. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3384 References: https://gitlab.freedesktop.org/drm/intel/-/issues/272 Signed-off-by: Kai-Heng Feng --- drivers/gpu/drm/i915/display/intel_dp.c | 10 +- 1 file changed

Re: [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-14 Thread Jisheng Zhang
' invalid for parameter > > `i915.mitigations' > > > > The reason is slab subsystem isn't ready at that time, so kstrdup() > > returns NULL. Fix this issue by using stack var instead of kstrdup(). > > > > Fixes: 984cadea032b ("drm/i915: Allow the sysadm

[PATCH v2] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-14 Thread Jisheng Zhang
of kstrdup(). Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security mitigations") Signed-off-by: Jisheng Zhang --- Since v1: - Ensure "str" is properly terminated. Thanks Ville for pointing this out. drivers/gpu/drm/i915/i915_mitigations.c | 8 +++- 1 fi

Re: [PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-13 Thread Ville Syrjälä
at that time, so kstrdup() > returns NULL. Fix this issue by using stack var instead of kstrdup(). > > Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security > mitigations") > Signed-off-by: Jisheng Zhang > --- > drivers/gpu/drm/i915/i915_mitigat

[PATCH] drm/i915: Fix "mitigations" parsing if i915 is builtin

2021-04-13 Thread Jisheng Zhang
of kstrdup(). Fixes: 984cadea032b ("drm/i915: Allow the sysadmin to override security mitigations") Signed-off-by: Jisheng Zhang --- drivers/gpu/drm/i915/i915_mitigations.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_mitigations.c b/

[PATCH] drm/i915/gvt: remove useless function

2021-04-13 Thread Jiapeng Chong
Fix the following clang warning: drivers/gpu/drm/i915/gvt/gtt.c:590:20: warning: unused function 'ppgtt_set_guest_root_entry' [-Wunused-function]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/i915/gvt/gtt.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[PATCH 5.11 019/210] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-12 Thread Greg Kroah-Hartman
man --- drivers/gpu/drm/i915/display/intel_acpi.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/i915/display/intel_acpi.c +++ b/drivers/gpu/drm/i915/display/intel_acpi.c @@ -84,13 +84,31 @@ static void intel_dsm_platform_mux_i

[PATCH 5.10 018/188] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-12 Thread Greg Kroah-Hartman
man --- drivers/gpu/drm/i915/display/intel_acpi.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/i915/display/intel_acpi.c +++ b/drivers/gpu/drm/i915/display/intel_acpi.c @@ -84,13 +84,31 @@ static void intel_dsm_platform_mux_i

[PATCH 5.4 012/111] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-12 Thread Greg Kroah-Hartman
man --- drivers/gpu/drm/i915/display/intel_acpi.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/i915/display/intel_acpi.c +++ b/drivers/gpu/drm/i915/display/intel_acpi.c @@ -83,13 +83,31 @@ static void intel_dsm_platform_mux_i

Re: [drm/i915/dp] 4a8d79901d: WARNING:at_drivers/gpu/drm/i915/display/intel_display_power.c:#assert_can_disable_lcpll[i915]

2021-04-09 Thread Lyude Paul
we send out the report, we also tested fe7d52bccab6, the issue > > > > still > > > > exists on it. > > > > attached one kmsg-fe7d52bccab6.xz FYI. > > > > > > > > we also tested on latest v5.12-rc3, also exists. > > > &g

[PATCH -next] drm/i915/display: remove redundant NULL check

2021-04-09 Thread Qiheng Lin
Fix the following coccicheck warning: drivers/gpu/drm/i915/display/intel_psr.c:1530:29-31: WARNING !A || A && B is equivalent to !A || B Signed-off-by: Qiheng Lin --- drivers/gpu/drm/i915/display/intel_psr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-08 Thread Takashi Iwai
On Thu, 08 Apr 2021 18:56:06 +0200, Ville Syrjälä wrote: > > On Thu, Apr 08, 2021 at 06:34:06PM +0200, Takashi Iwai wrote: > > On Thu, 08 Apr 2021 09:51:18 +0200, > > Takashi Iwai wrote: > > > > > > On Wed, 07 Apr 2021 23:28:48 +0200, > > > Ville Syrjälä wrote: > > > > > > > > Oh, could you ask

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-08 Thread Ville Syrjälä
On Thu, Apr 08, 2021 at 06:34:06PM +0200, Takashi Iwai wrote: > On Thu, 08 Apr 2021 09:51:18 +0200, > Takashi Iwai wrote: > > > > On Wed, 07 Apr 2021 23:28:48 +0200, > > Ville Syrjälä wrote: > > > > > > Oh, could you ask the bug reporter to attach an acpidump to the > > > bug? Might be good to

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-08 Thread Takashi Iwai
On Thu, 08 Apr 2021 09:51:18 +0200, Takashi Iwai wrote: > > On Wed, 07 Apr 2021 23:28:48 +0200, > Ville Syrjälä wrote: > > > > Oh, could you ask the bug reporter to attach an acpidump to the > > bug? Might be good to have that stuff on record somewhere if/when > > someone wants to actually

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-08 Thread Takashi Iwai
gt; > v1->v2: Check the info contents before dereferencing, too > > > > > > > > BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074 > > > > Cc: > > > > Signed-off-by: Takashi Iwai > > > > --- > > > > drivers/

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-07 Thread Ville Syrjälä
ly. > > > > > > Add the checks of the contents in the returned values and skip the > > > values for invalid cases. > > > > > > v1->v2: Check the info contents before dereferencing, too > > > > > > BugLink: http://bugzilla.opensuse.org

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-07 Thread Takashi Iwai
ues for invalid cases. > > > > v1->v2: Check the info contents before dereferencing, too > > > > BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074 > > Cc: > > Signed-off-by: Takashi Iwai > > --- > > drivers/gpu/drm/i915/display/intel_acp

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-07 Thread Ville Syrjälä
; BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074 > Cc: > Signed-off-by: Takashi Iwai > --- > drivers/gpu/drm/i915/display/intel_acpi.c | 22 -- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_a

Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h

2021-04-07 Thread Andy Shevchenko
t; > There is no need to carry on entire kernel.h. > > > > > > Signed-off-by: Andy Shevchenko > > > > That's hardly drm/i915 specific! > > It was originated from i915! > > > Reviewed-by: Jani Nikula > > Thanks! > > > But who's going to pi

Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h

2021-04-07 Thread Andy Shevchenko
On Wed, Apr 07, 2021 at 03:46:37PM +0300, Jani Nikula wrote: > On Wed, 07 Apr 2021, Andy Shevchenko > wrote: > > The ascii85.h is user of exactly two headers, i.e. math.h and types.h. > > There is no need to carry on entire kernel.h. > > > > Signed-off-by: Andy Shev

Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h

2021-04-07 Thread Jani Nikula
On Wed, 07 Apr 2021, Andy Shevchenko wrote: > The ascii85.h is user of exactly two headers, i.e. math.h and types.h. > There is no need to carry on entire kernel.h. > > Signed-off-by: Andy Shevchenko That's hardly drm/i915 specific! Reviewed-by: Jani Nikula But who's going t

[PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h

2021-04-07 Thread Andy Shevchenko
The ascii85.h is user of exactly two headers, i.e. math.h and types.h. There is no need to carry on entire kernel.h. Signed-off-by: Andy Shevchenko --- include/linux/ascii85.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h

Re: [Intel-gfx] [PATCH] drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT

2021-04-06 Thread Jani Nikula
fixed. Will resend once I figure out what's >> > going on >> >> Well, I think there are actually multiple issues on multiple >> machines. This fixes the issue on ThinkPad X1 Titanium Gen1 [1]. >> >> I suspect reverting 98e497e203a5 ("drm/i915/dp

Re: [PATCH] drm/i915/sysfs: convert snprintf to sysfs_emit

2021-04-06 Thread Jani Nikula
On Sun, 04 Apr 2021, Carlis wrote: > From: Xuezhi Zhang > > Fix the following coccicheck warning: > drivers/gpu/drm/i915//i915_sysfs.c:266:8-16: > WARNING: use scnprintf or sprintf > drivers/gpu/drm/i915//i915_sysfs.c:285:8-16: > WARNING: use scnprintf or sprintf &

[PATCH] drm/i915/sysfs: convert snprintf to sysfs_emit

2021-04-04 Thread Carlis
From: Xuezhi Zhang Fix the following coccicheck warning: drivers/gpu/drm/i915//i915_sysfs.c:266:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/i915//i915_sysfs.c:285:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/i915//i915_sysfs.c:276:8-16: WARNING: use scnprintf or sprintf

[PATCH v2] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-02 Thread Takashi Iwai
, as reported recently. Add the checks of the contents in the returned values and skip the values for invalid cases. v1->v2: Check the info contents before dereferencing, too BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/disp

Re: [PATCH] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-02 Thread Takashi Iwai
; Signed-off-by: Takashi Iwai Scratch this one. I sent an older version mistakenly. Will resubmit the right one. Takashi > --- > drivers/gpu/drm/i915/display/intel_acpi.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel

[PATCH] drm/i915: Fix invalid access to ACPI _DSM objects

2021-04-02 Thread Takashi Iwai
, as reported recently. Add the checks of the contents in the returned values and skip the values for invalid cases. BugLink: http://bugzilla.opensuse.org/show_bug.cgi?id=1184074 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/i915/display/intel_acpi.c | 12 1 file changed, 12 insertions

[PATCH v24 10/30] drm/i915/gvt: Change _PAGE_DIRTY to _PAGE_DIRTY_BITS

2021-04-01 Thread Yu-cheng Yu
Vetter Cc: Rodrigo Vivi Cc: Zhenyu Wang Cc: Zhi Wang --- drivers/gpu/drm/i915/gvt/gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index 897c007ea96a..937b6083b2dc 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.c

[PATCH][next] drm/i915: Fix an uninitialized variable issue

2021-04-01 Thread Colin King
. Fix this by setting err to zero before the while loop starts. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.lock.") Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 +- 1 fi

re: drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal

2021-04-01 Thread Colin Ian King
Hi, Static analysis with Coverity on Linux-next has detected a potential issue with the following commit: commit 480ae79537b28f30ef6e07b7de69a9ae2599daa7 Author: Maarten Lankhorst Date: Tue Mar 23 16:50:49 2021 +0100 drm/i915/selftests: Prepare gtt tests for obj->mm.lock remo

drivers/gpu/drm/i915/i915_sw_fence.c:47:20: error: unused function 'debug_fence_init_onstack'

2021-04-01 Thread kernel test robot
Hi Nick, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d19cc4bfbff1ae72c3505a00fb8ce0d3fa519e6c commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable -Wframe-address date: 11 months ago config

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-30 Thread Hans de Goede
Hi, On 3/22/21 5:02 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns that intel_dp_check_mst_status() has a local array of > fourteen bytes and passes the last four bytes into a function that > expects a six-byte array: > > drivers/gpu/drm/i915/display/in

[PATCH 5.11 102/254] drm/i915: Fix the GT fence revocation runtime PM logic

2021-03-29 Thread Greg Kroah-Hartman
: Chris Wilson Cc: # v4.12+ Fixes: 181df2d458f3 ("drm/i915: Take rpm wakelock for releasing the fence on unbind") Reviewed-by: Chris Wilson Signed-off-by: Imre Deak Link: https://patchwork.freedesktop.org/patch/msgid/20210322204223.919936-1-imre.d...@intel.com (cherry picked f

[PATCH 5.11 101/254] drm/i915/dsc: fix DSS CTL register usage for ICL DSI transcoders

2021-03-29 Thread Greg Kroah-Hartman
From: Jani Nikula commit b61fde1beb6b1847f1743e75f4d9839acebad76a upstream. Use the correct DSS CTL registers for ICL DSI transcoders. As a side effect, this also brings back the sanity check for trying to use pipe DSC registers on pipe A on ICL. Fixes: 8a029c113b17 ("drm/i915/dp: Modify

[PATCH 5.10 088/221] drm/i915: Fix the GT fence revocation runtime PM logic

2021-03-29 Thread Greg Kroah-Hartman
: Chris Wilson Cc: # v4.12+ Fixes: 181df2d458f3 ("drm/i915: Take rpm wakelock for releasing the fence on unbind") Reviewed-by: Chris Wilson Signed-off-by: Imre Deak Link: https://patchwork.freedesktop.org/patch/msgid/20210322204223.919936-1-imre.d...@intel.com (cherry picked f

[PATCH] [v2] drm/i915: Remove repeated declaration

2021-03-25 Thread Wan Jiabing
struct drm_i915_private, struct intel_crtc_state and struct intel_crtc is declared twice. Remove the duplicate. Reviewed-by: José Roberto de Souza Signed-off-by: Wan Jiabing --- Changelog: v2: - Modify subject line. - Delete trailing whitespace in commit log. --- drivers/gpu/drm/i915/display

[tip: irq/core] drm/i915: Use tasklet_unlock_spin_wait() in __tasklet_disable_sync_once()

2021-03-25 Thread tip-bot2 for Sebastian Andrzej Siewior
:00 Committer: Thomas Gleixner CommitterDate: Thu, 25 Mar 2021 18:21:03 +01:00 drm/i915: Use tasklet_unlock_spin_wait() in __tasklet_disable_sync_once() The i915 driver has its own tasklet interface which was overseen in the tasklet rework. __tasklet_disable_sync_once() is a wrapper around

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-25 Thread Martin Sebor
On 3/25/21 3:53 AM, Arnd Bergmann wrote: On Thu, Mar 25, 2021 at 9:05 AM Jani Nikula wrote: Clearly something is wrong here, but I can't quite figure out what. Changing the array size to 16 bytes avoids the warning, but is probably the wrong solution here. Ugh. drm_dp_channel_eq_ok() does

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-25 Thread Arnd Bergmann
On Thu, Mar 25, 2021 at 9:05 AM Jani Nikula wrote: > > Clearly something is wrong here, but I can't quite figure out what. > > Changing the array size to 16 bytes avoids the warning, but is > > probably the wrong solution here. > > Ugh. drm_dp_channel_eq_ok() does not actually require more than >

Re: [PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-25 Thread Jani Nikula
On Mon, 22 Mar 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns that intel_dp_check_mst_status() has a local array of > fourteen bytes and passes the last four bytes into a function that > expects a six-byte array: > > drivers/gpu/drm/i915/display/in

Re: [PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency

2021-03-24 Thread Ville Syrjälä
inlined from ‘ilk_setup_wm_latency’ at > > drivers/gpu/drm/i915/intel_pm.c:3108:3: > > drivers/gpu/drm/i915/intel_pm.c:3057:9: error: ‘intel_print_wm_latency’ > > reading 16 bytes from a region of size 10 [-Werror=stringop-overread] > > 3057 | intel_prin

Re: drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type'

2021-03-24 Thread Nick Desaulniers
> > > > > tree: > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > > head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c > > > commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable > > > -Wframe-addre

Re: [PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency

2021-03-24 Thread Jani Nikula
On Mon, 22 Mar 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns about what appears to be an out-of-range array access: > > In function ‘snb_wm_latency_quirk’, > inlined from ‘ilk_setup_wm_latency’ at > drivers/gpu/drm/i915/intel_pm.c:3108:3: &

Re: drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type'

2021-03-24 Thread Zhenyu Wang
torvalds/linux.git > > master > > head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c > > commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable > > -Wframe-address > > This in unrelated to my change. > > + Changbin, Zhenyu (authors of 3aff3512802) and Zhi

Re: drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type'

2021-03-23 Thread Nick Desaulniers
0e260cdfc9f0b8c > commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable > -Wframe-address This in unrelated to my change. + Changbin, Zhenyu (authors of 3aff3512802) and Zhi (author of 054f4eba2a298) in case there's any interest in fixing this up. Otherwise I don't think these tiny helpful functions w

Re: [drm/i915/dp] 4a8d79901d: WARNING:at_drivers/gpu/drm/i915/display/intel_display_power.c:#assert_can_disable_lcpll[i915]

2021-03-23 Thread Lyude Paul
02:53:11PM -0500, Lyude Paul wrote: > > > Am I right in assuming this is likely a very delayed test result from > > > before: > > > > > > fe7d52bccab6 ("drm/i915/dp: Don't use DPCD backlights that need PWM > > > enable/disable") > > > > >

Re: [PATCH] drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT

2021-03-23 Thread Lyude Paul
going on > > Well, I think there are actually multiple issues on multiple > machines. This fixes the issue on ThinkPad X1 Titanium Gen1 [1]. > > I suspect reverting 98e497e203a5 ("drm/i915/dpcd_bl: uncheck PWM_PIN_CAP > when detect eDP backlight capabilities") would too.

Re: [PATCH] drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT

2021-03-23 Thread Jani Nikula
the issue on ThinkPad X1 Titanium Gen1 [1]. I suspect reverting 98e497e203a5 ("drm/i915/dpcd_bl: uncheck PWM_PIN_CAP when detect eDP backlight capabilities") would too. But then that would break *other* machines that claim support for *both* eDP PWM pin and DPCD backlight control

[PATCH] drm/i915: Use tasklet_unlock_spin_wait() in __tasklet_disable_sync_once()

2021-03-23 Thread Sebastian Andrzej Siewior
tasklet_unlock_spin_wait() instead which can be invoked from non-preemptible contexts. Fixes: da044747401fc ("tasklets: Replace spin wait in tasklet_unlock_wait()") Reported-by: kernel test robot Signed-off-by: Sebastian Andrzej Siewior --- drivers/gpu/drm/i915/i915_gem.h | 2 +- 1 file

Re: [PATCH] drm/i915: A typo fix

2021-03-23 Thread Bhaskar Chowdhury
On 10:53 Tue 23 Mar 2021, Jani Nikula wrote: On Tue, 23 Mar 2021, Bhaskar Chowdhury wrote: s/nothign/nothing/ Signed-off-by: Bhaskar Chowdhury You've sent the same patch before? I've already pushed it. Apologies and thanks. BR, Jani. --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c

Re: [PATCH] drm/i915: A typo fix

2021-03-23 Thread Jani Nikula
On Tue, 23 Mar 2021, Bhaskar Chowdhury wrote: > s/nothign/nothing/ > > Signed-off-by: Bhaskar Chowdhury You've sent the same patch before? I've already pushed it. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

[PATCH] drm/i915: A typo fix

2021-03-22 Thread Bhaskar Chowdhury
s/nothign/nothing/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c index f6ad257a260e

[PATCH 11/11] [RFC] drm/i915/dp: fix array overflow warning

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns that intel_dp_check_mst_status() has a local array of fourteen bytes and passes the last four bytes into a function that expects a six-byte array: drivers/gpu/drm/i915/display/intel_dp.c: In function ‘intel_dp_check_mst_status’: drivers/gpu/drm/i915/display

[PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 warns about what appears to be an out-of-range array access: In function ‘snb_wm_latency_quirk’, inlined from ‘ilk_setup_wm_latency’ at drivers/gpu/drm/i915/intel_pm.c:3108:3: drivers/gpu/drm/i915/intel_pm.c:3057:9: error: ‘intel_print_wm_latency’ reading 16

Re: [PATCH v23 10/28] drm/i915/gvt: Change _PAGE_DIRTY to _PAGE_DIRTY_BITS

2021-03-22 Thread Kirill A. Shutemov
On Tue, Mar 16, 2021 at 08:10:36AM -0700, Yu-cheng Yu wrote: > After the introduction of _PAGE_COW, a modified page's PTE can have either > _PAGE_DIRTY or _PAGE_COW. Change _PAGE_DIRTY to _PAGE_DIRTY_BITS. > > Signed-off-by: Yu-cheng Yu > Reviewed-by: Kees Cook > Cc: David Airlie > Cc: Joonas

drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type'

2021-03-20 Thread kernel test robot
Hi Nick, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable -Wframe-address date: 11 months ago config

[PATCH 5.4 09/18] drm/i915/gvt: Fix mmio handler break on BXT/APL.

2021-03-19 Thread Greg Kroah-Hartman
92010a97098c4c9fd777408cc98064d26b32695b) Signed-off-by: Colin Xu Cc: # 5.4.y Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/gvt/handlers.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/i915/gvt/handlers.c +++ b/drivers/gpu/drm/i915/gvt

[PATCH 5.4 08/18] drm/i915/gvt: Set SNOOP for PAT3 on BXT/APL to workaround GPU BB hang

2021-03-19 Thread Greg Kroah-Hartman
://patchwork.freedesktop.org/patch/msgid/20201012045231.226748-1-colin...@intel.com (cherry picked from commit 8fe105679765700378eb328495fcfe1566cdbbd0) Signed-off-by: Colin Xu Cc: # 5.4.y Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/gvt/handlers.c | 32

[PATCH 5.4 12/18] drm/i915/gvt: Fix vfio_edid issue for BXT/APL

2021-03-19 Thread Greg Kroah-Hartman
, the guest driver won't detect a valid HPD pulse thus no full display detection will be executed to read the updated EDID. With this patch, the vfio_edid is enabled again on BXT/APL, which is previously disabled. Fixes: 642403e3599e ("drm/i915/gvt: Temporarily disable vfio_edid for BXT/APL")

[PATCH 5.4 11/18] drm/i915/gvt: Fix port number for BDW on EDID region setup

2021-03-19 Thread Greg Kroah-Hartman
might evaluate actual display hotplug for BDW to make this function work as expected, anyway this is always required to be fixed first. Reported-by: Alejandro Sior Cc: Alejandro Sior Fixes: 0178f4ce3c3b ("drm/i915/gvt: Enable vfio edid for all GVT supported platform") Reviewed-by:

[PATCH 5.4 10/18] drm/i915/gvt: Fix virtual display setup for BXT/APL

2021-03-19 Thread Greg Kroah-Hartman
-off-by: Colin Xu Cc: # 5.4.y Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/gvt/display.c | 173 + drivers/gpu/drm/i915/gvt/mmio.c|5 + 2 files changed, 178 insertions(+) --- a/drivers/gpu/drm/i915/gvt/display.c +++ b/drivers/gpu/drm/i915

Re: [PATCH] drm: i915: Fix a typo

2021-03-19 Thread Jani Nikula
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote: > s/nothign/nothing/ > > Signed-off-by: Bhaskar Chowdhury Thanks, pushed. BR, Jani. > --- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driv

RE: [drm/i915/dp] 4a8d79901d: WARNING:at_drivers/gpu/drm/i915/display/intel_display_power.c:#assert_can_disable_lcpll[i915]

2021-03-19 Thread Sarvela, Tomi P
the reproduction steps. Regards, Tomi > From: Lyude Paul > > Subject: Re: [drm/i915/dp] 4a8d79901d: > WARNING:at_drivers/gpu/drm/i915/display/intel_display_power.c:#assert_ > can_disable_lcpll[i915] > > Well this is surprising, because I had been pretty sure we had asked > so

[PATCH] drm: i915: Fix a typo

2021-03-18 Thread Bhaskar Chowdhury
s/nothign/nothing/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c index f6ad257a260e

Re: [PATCH] drm/i915/gt: A typo fix

2021-03-18 Thread Randy Dunlap
On 3/18/21 3:19 AM, Bhaskar Chowdhury wrote: > > s/bariers/barriers/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [PATCH] drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT

2021-03-18 Thread Lyude Paul
t; the VBT just to be safe. We might be able to try enabling this again by > default in the future. > > Fixes: 2227816e647a ("drm/i915/dp: Allow forcing specific interfaces through > enable_dpcd_backlight") > Cc: Jani Nikula > Cc: Rodrigo Vivi > Bugzilla: https://gitlab.fr

Re: [drm/i915/dp] 4a8d79901d: WARNING:at_drivers/gpu/drm/i915/display/intel_display_power.c:#assert_can_disable_lcpll[i915]

2021-03-18 Thread Lyude Paul
ul wrote: > > Am I right in assuming this is likely a very delayed test result from > > before: > > > > fe7d52bccab6 ("drm/i915/dp: Don't use DPCD backlights that need PWM > > enable/disable") > > > > Made it into the kernel? I see that ther

[PATCH] drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT

2021-03-18 Thread Lyude Paul
to be safe. We might be able to try enabling this again by default in the future. Fixes: 2227816e647a ("drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight") Cc: Jani Nikula Cc: Rodrigo Vivi Bugzilla: https://gitlab.freedesktop.org/drm/intel/-/issues/3169 Signed-off

[PATCH] drm/i915/gt: A typo fix

2021-03-18 Thread Bhaskar Chowdhury
s/bariers/barriers/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c index 037b0e3ccbed..25fc7f44fee0 100644

[PATCH v23 10/28] drm/i915/gvt: Change _PAGE_DIRTY to _PAGE_DIRTY_BITS

2021-03-16 Thread Yu-cheng Yu
Wang Cc: Zhi Wang --- drivers/gpu/drm/i915/gvt/gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index 897c007ea96a..937b6083b2dc 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.c +++ b/drivers/gpu/drm/i915/gvt

drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c:233 igt_fill_blt_thread() error: 'ce' dereferencing possible ERR_PTR()

2021-03-15 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1e28eed17697bcf343c6743f0028cc3b5dd88bf0 commit: 03c62d886dd6d3dfebf59d385a37245fe667fe90 drm/i915: Make GEM errors non-fatal by default date: 8 weeks ago config: x86_64-randconfig-m001-20210316 (attached

[PATCH 5.10 097/290] drm/i915: Wedge the GPU if command parser setup fails

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Tvrtko Ursulin commit a829f033e966d5e4aa27c3ef2b381f51734e4a7f upstream. Commit 311a50e76a33 ("drm/i915: Add support for mandatory cmdparsing") introduced mandatory command parsing but setup failures were not translated into wedging the GPU which wa

[PATCH 5.11 111/306] drm/i915: Wedge the GPU if command parser setup fails

2021-03-15 Thread gregkh
From: Greg Kroah-Hartman From: Tvrtko Ursulin commit a829f033e966d5e4aa27c3ef2b381f51734e4a7f upstream. Commit 311a50e76a33 ("drm/i915: Add support for mandatory cmdparsing") introduced mandatory command parsing but setup failures were not translated into wedging the GPU which wa

Re: [PATCH] gpu: drm: i915: gt: Rudimentary typo fix in the file intel_timeline.c

2021-03-13 Thread Randy Dunlap
On 3/13/21 8:43 PM, Bhaskar Chowdhury wrote: > > s/bariers/barriers/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

[PATCH] gpu: drm: i915: gt: Rudimentary typo fix in the file intel_timeline.c

2021-03-13 Thread Bhaskar Chowdhury
s/bariers/barriers/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/i915/gt/intel_timeline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_timeline.c b/drivers/gpu/drm/i915/gt/intel_timeline.c index 8015964043eb..2b921c1796dc 100644

drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: error: format string is not a string literal (potentially insecure)

2021-03-13 Thread kernel test robot
Hi Chris, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 88fe49249c99de14e543c632a46248d85411ab9e commit: 70a2b431c36483c0c06e589e11c59e438cd0ac06 drm/i915/gt: Rename lrc.c to execlists_submission.c date: 3

Re: [LKP] Re: [drm/i915] 7962893ecb: WARNING:at_drivers/gpu/drm/i915/intel_runtime_pm.c:#intel_runtime_pm_driver_release[i915]

2021-03-11 Thread Imre Deak
t; FYI, we noticed the following commit (built with gcc-9): > > > > > > commit: 7962893ecb853aa7c8925ce237ab6c4274cfc1c7 ("drm/i915: Disable > > > runtime power management during shutdown") > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git

drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: error: format string is not a string literal (potentially insecure)

2021-03-10 Thread kernel test robot
Hi Chris, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a74e6a014c9d4d4161061f770c9b4f98372ac778 commit: 70a2b431c36483c0c06e589e11c59e438cd0ac06 drm/i915/gt: Rename lrc.c to execlists_submission.c date: 3

[PATCH v22 10/28] drm/i915/gvt: Change _PAGE_DIRTY to _PAGE_DIRTY_BITS

2021-03-10 Thread Yu-cheng Yu
Wang Cc: Zhi Wang --- drivers/gpu/drm/i915/gvt/gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index 897c007ea96a..937b6083b2dc 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.c +++ b/drivers/gpu/drm/i915/gvt

[PATCH] drm/i915/gem: Use user_write_access_begin() instead of user_access_begin()

2021-03-10 Thread Christophe Leroy
eb_copy_relocations() only do unsafe_put_user(), it only requires write access to user. Use user_write_access_begin() instead of user_access_begin(). Signed-off-by: Christophe Leroy --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

Re: [Intel-gfx] [PATCH v9 5/5] drm/i915: Enable support for integrated privacy screen

2021-03-09 Thread Rajat Jain
i_handle instead of void* > > > v5: same as v4 > > > v4: Same as v3 > > > v3: fold the code into existing acpi_device_id_update() function > > > v2: formed by splitting the original patch into ACPI lookup, and privacy > > > screen property. Also move it into i915 n

Re: [PATCH] gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()

2021-03-08 Thread Jia-Ju Bai
On 2021/3/8 17:18, Chris Wilson wrote: Quoting Jia-Ju Bai (2021-03-08 08:59:52) When i915_random_order() returns NULL to order, no error return code of igt_buddy_alloc_smoke() is assigned. To fix this bug, err is assigned with -EINVAL in this case. It would not be EINVAL since that is used

Re: [PATCH] gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()

2021-03-08 Thread Chris Wilson
Quoting Jia-Ju Bai (2021-03-08 08:59:52) > When i915_random_order() returns NULL to order, no error return code of > igt_buddy_alloc_smoke() is assigned. > To fix this bug, err is assigned with -EINVAL in this case. It would not be EINVAL since that is used for a reference failure, but in this

Re: [PATCH] gpu: drm: i915: fix error return code of igt_threaded_blt()

2021-03-08 Thread Chris Wilson
Quoting Jia-Ju Bai (2021-03-08 09:07:22) > When kcalloc() returns NULL to tsk or thread, no error code of > igt_threaded_blt() is returned. > To fix this bug, -ENOMEM is returned as error code. Because we decided to skip the test if it could not be run due to insufficient memory, as opposed to

[PATCH] gpu: drm: i915: fix error return code of igt_threaded_blt()

2021-03-08 Thread Jia-Ju Bai
When kcalloc() returns NULL to tsk or thread, no error code of igt_threaded_blt() is returned. To fix this bug, -ENOMEM is returned as error code. Fixes: 0e99f939f08f ("drm/i915/selftests/blt: add some kthreads into the mix") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- d

[PATCH] gpu: drm: i915: fix error return code of igt_buddy_alloc_smoke()

2021-03-08 Thread Jia-Ju Bai
When i915_random_order() returns NULL to order, no error return code of igt_buddy_alloc_smoke() is assigned. To fix this bug, err is assigned with -EINVAL in this case. Fixes: 1fe3818d17c9 ("drm/i915/selftests: try to rein in alloc_smoke") Reported-by: TOTE Robot Signed-off-by:

[PATCH RESEND][next] drm/i915/gem: Fix fall-through warnings for Clang

2021-03-05 Thread Gustavo A. R. Silva
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a return statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/i915/gem

[patch 6/7] drm/i915: Replace io_mapping_map_atomic_wc()

2021-03-04 Thread Thomas Gleixner
-by: Thomas Gleixner Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: David Airlie Cc: Daniel Vetter Cc: Chris Wilson Cc: intel-...@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c |7 +--- drivers/gpu/drm/i915/i915_gem.c

  1   2   3   4   5   6   7   8   9   10   >