Re: Deadlock in serial driver 2.6.x

2005-02-04 Thread Paul Fulghum
Martin Kögler wrote: As a temporary workaround, dropping the lock should also work: This looks good to me, and seems much more reasonable that changing driver interfaces. Treat tty_flip_buffer_push(tty) as something that can call back into your driver (which *is* the case for low_latency), so don't

Re: Deadlock in serial driver 2.6.x

2005-02-04 Thread Martin Kögler
On Thu, Feb 03, 2005 at 10:21:12AM -0800, Andrew Morton wrote: > The "echo method" method sounds good. Do we think that's feasible for > 2.6.11, or would it be safer to disable low-latency mode for that driver? As a temporary workaround, dropping the lock should also work: --- linux-2.6.10/drive

Re: Deadlock in serial driver 2.6.x

2005-02-03 Thread Andrew Morton
Alan Cox <[EMAIL PROTECTED]> wrote: > > On Llu, 2005-01-31 at 08:48, Andrew Morton wrote: > > > The tty layer cannot fix this for now, and I don't intend to fix it. Fix > > > the serial driver: the fix is quite simple since you can keep a field in > > > the driver for now to detect recursive cal

Re: Deadlock in serial driver 2.6.x

2005-02-03 Thread Alan Cox
On Llu, 2005-01-31 at 08:48, Andrew Morton wrote: > > The tty layer cannot fix this for now, and I don't intend to fix it. Fix > > the serial driver: the fix is quite simple since you can keep a field in > > the driver for now to detect recursive calling into the echo case and > > don't relock.

Re: Deadlock in serial driver 2.6.x

2005-01-31 Thread Andrew Morton
Alan Cox <[EMAIL PROTECTED]> wrote: > > On Sul, 2005-01-30 at 16:48, Russell King wrote: > > Unsolvable as the tty layer currently stands. tty needs to not call back > > into serial drivers when they supply read characters from their interrupt > > functions. > > The tty layer cannot fix this

Re: Deadlock in serial driver 2.6.x

2005-01-31 Thread Alan Cox
On Sul, 2005-01-30 at 16:48, Russell King wrote: > Unsolvable as the tty layer currently stands. tty needs to not call back > into serial drivers when they supply read characters from their interrupt > functions. The tty layer cannot fix this for now, and I don't intend to fix it. Fix the serial

Re: Deadlock in serial driver 2.6.x

2005-01-30 Thread Russell King
On Sun, Jan 30, 2005 at 03:39:32PM +, Alan Cox wrote: > On Iau, 2005-01-27 at 07:13, Andrew Morton wrote: > > Martin Kögler <[EMAIL PROTECTED]> wrote: > > (For some reason the NMI watchdog isn't triggering here, and it's still > > taking interrupts). > > > Looks like low-latency mode is busted

Re: Deadlock in serial driver 2.6.x

2005-01-30 Thread Alan Cox
On Iau, 2005-01-27 at 07:13, Andrew Morton wrote: > Martin KÃgler <[EMAIL PROTECTED]> wrote: > (For some reason the NMI watchdog isn't triggering here, and it's still > taking interrupts). > Looks like low-latency mode is busted. low latency mode is fine, the drivers/serial layer is busted. It wo

Re: Deadlock in serial driver 2.6.x

2005-01-26 Thread Andrew Morton
Martin Kögler <[EMAIL PROTECTED]> wrote: > > I noticed with different kernel versions (a 2.6.5 FC2 Kernel, a 2.6.7 Knoppix > Kernel > and 2.6.10 FC2 and FC3 Kernels (which have no patches for the serial > driver)), that it > is possible for a normal user, which has rw access to /dev/ttySx, to

Deadlock in serial driver 2.6.x

2005-01-26 Thread Martin Kögler
I noticed with different kernel versions (a 2.6.5 FC2 Kernel, a 2.6.7 Knoppix Kernel and 2.6.10 FC2 and FC3 Kernels (which have no patches for the serial driver)), that it is possible for a normal user, which has rw access to /dev/ttySx, to hang a computer. To exploit it, there must be a device