Re: Does braille console work?

2017-03-19 Thread Samuel Thibault
Hello, Steven Rostedt, on ven. 17 mars 2017 09:02:08 -0400, wrote: > Samuel Thibault wrote: > > Petr Mladek, on ven. 17 mars 2017 10:35:44 +0100, wrote: > > > Anyway, the feature is not usable at the moment. Samuel, would > > > you be able to fix and test it, please? > > > > Sure, it's already

Re: Does braille console work?

2017-03-17 Thread Steven Rostedt
On Fri, 17 Mar 2017 10:40:51 +0100 Samuel Thibault wrote: > Petr Mladek, on ven. 17 mars 2017 10:35:44 +0100, wrote: > > Anyway, the feature is not usable at the moment. Samuel, would > > you be able to fix and test it, please? > > Sure, it's already on my TODO list, I will do when I get the t

Re: Does braille console work?

2017-03-17 Thread Aleksey Makarov
On 03/17/2017 03:53 AM, Samuel Thibault wrote: > Hello, > > Aleksey Makarov, on jeu. 16 mars 2017 17:02:53 +0300, wrote: >> There can be 3 outcomes from this function: >> 1) it returns NULL and does not set brl_options >> 2) it returns NULL and set the variable pointed by str to NULL >> 3) it re

Re: Does braille console work?

2017-03-17 Thread Samuel Thibault
Petr Mladek, on ven. 17 mars 2017 10:35:44 +0100, wrote: > Anyway, the feature is not usable at the moment. Samuel, would > you be able to fix and test it, please? Sure, it's already on my TODO list, I will do when I get the time. Samuel

Re: Does braille console work?

2017-03-17 Thread Petr Mladek
Hello, On Fri 2017-03-17 01:53:55, Samuel Thibault wrote: > Aleksey Makarov, on jeu. 16 mars 2017 17:02:53 +0300, wrote: > > > > So braille console registration should not work. What do I miss? > > Nothing, the code transformation was broken :/ > > So it looks like braille console has not been

Re: Does braille console work?

2017-03-17 Thread Samuel Thibault
Aleksey Makarov, on ven. 17 mars 2017 12:00:02 +0300, wrote: > I think removing it is a good idea Removing potential for accessibility is almost never a good idea. Getting that code in was difficult because it required introducing accessibility features in the rest of the core. Removing that code

Re: Does braille console work?

2017-03-16 Thread Samuel Thibault
Hello, Aleksey Makarov, on jeu. 16 mars 2017 17:02:53 +0300, wrote: > There can be 3 outcomes from this function: > 1) it returns NULL and does not set brl_options > 2) it returns NULL and set the variable pointed by str to NULL > 3) it returns non-NULL Uh, that's odd indeed, the intent was that

Does braille console work?

2017-03-16 Thread Aleksey Makarov
Hi, I am looking at the braille console code and don't understand how its initialization works. This is from kernel/printk/braille.c: char *_braille_console_setup(char **str, char **brl_options) { if (!strncmp(*str, "brl,", 4)) { *brl_options = ""; *str +=