Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Daniel Borkmann
On 07/23/2015 03:36 PM, Michael Kerrisk (man-pages) wrote: ... Ok, I guess we could revisit/clarify that at a later point in time. I'd add a TODO comment to the source or the like, as this also is related to the 2nd below use case (aggregation/accounting), where an array is typically used.

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Michael Kerrisk (man-pages)
Hi Daniel, On 07/23/2015 02:47 PM, Daniel Borkmann wrote: > On 07/23/2015 01:23 PM, Michael Kerrisk (man-pages) wrote: > ... >>> Btw, a user obviously can close() the map fds if he >>> wants to, but ultimatively they're freed when the program unloads. >> >> Okay. (Not sure if you meant that

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Daniel Borkmann
On 07/23/2015 01:23 PM, Michael Kerrisk (man-pages) wrote: ... Btw, a user obviously can close() the map fds if he wants to, but ultimatively they're freed when the program unloads. Okay. (Not sure if you meant that something should be added to the page.) I think not necessary. [...]

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Michael Kerrisk (man-pages)
Hi Daniel, On 07/23/2015 11:31 AM, Daniel Borkmann wrote: > Hi Michael, > > looks good already, a couple of comments inline, on top of Alexei's feedback: > > On 07/22/2015 10:10 PM, Michael Kerrisk (man-pages) wrote: > ... >> NAME >> bpf - perform a command on an extended eBPF map or

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Michael Kerrisk (man-pages)
On 07/23/2015 12:12 AM, Alexei Starovoitov wrote: > On 7/22/15 1:10 PM, Michael Kerrisk (man-pages) wrote: >> BPF maps are a generic data structure for storage of different >> data types. A user process can create multiple maps (with >> key/value-pairs being

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Daniel Borkmann
Hi Michael, looks good already, a couple of comments inline, on top of Alexei's feedback: On 07/22/2015 10:10 PM, Michael Kerrisk (man-pages) wrote: ... NAME bpf - perform a command on an extended eBPF map or program 'extended eBPF' should perhaps just say 'eBPF' or 'extended BPF'

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Daniel Borkmann
On 07/23/2015 01:23 PM, Michael Kerrisk (man-pages) wrote: ... Btw, a user obviously can close() the map fds if he wants to, but ultimatively they're freed when the program unloads. Okay. (Not sure if you meant that something should be added to the page.) I think not necessary. [...]

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Michael Kerrisk (man-pages)
Hi Daniel, On 07/23/2015 02:47 PM, Daniel Borkmann wrote: On 07/23/2015 01:23 PM, Michael Kerrisk (man-pages) wrote: ... Btw, a user obviously can close() the map fds if he wants to, but ultimatively they're freed when the program unloads. Okay. (Not sure if you meant that something should

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Michael Kerrisk (man-pages)
Hi Daniel, On 07/23/2015 11:31 AM, Daniel Borkmann wrote: Hi Michael, looks good already, a couple of comments inline, on top of Alexei's feedback: On 07/22/2015 10:10 PM, Michael Kerrisk (man-pages) wrote: ... NAME bpf - perform a command on an extended eBPF map or program

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Daniel Borkmann
On 07/23/2015 03:36 PM, Michael Kerrisk (man-pages) wrote: ... Ok, I guess we could revisit/clarify that at a later point in time. I'd add a TODO comment to the source or the like, as this also is related to the 2nd below use case (aggregation/accounting), where an array is typically used.

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Michael Kerrisk (man-pages)
On 07/23/2015 12:12 AM, Alexei Starovoitov wrote: On 7/22/15 1:10 PM, Michael Kerrisk (man-pages) wrote: BPF maps are a generic data structure for storage of different data types. A user process can create multiple maps (with key/value-pairs being opaque

Re: Draft 3 of bpf(2) man page for review

2015-07-23 Thread Daniel Borkmann
Hi Michael, looks good already, a couple of comments inline, on top of Alexei's feedback: On 07/22/2015 10:10 PM, Michael Kerrisk (man-pages) wrote: ... NAME bpf - perform a command on an extended eBPF map or program 'extended eBPF' should perhaps just say 'eBPF' or 'extended BPF'

Re: Draft 3 of bpf(2) man page for review

2015-07-22 Thread Alexei Starovoitov
On 7/22/15 1:10 PM, Michael Kerrisk (man-pages) wrote: BPF maps are a generic data structure for storage of different data types. A user process can create multiple maps (with key/value-pairs being opaque bytes of data) and access them via file

Re: Draft 3 of bpf(2) man page for review

2015-07-22 Thread Michael Kerrisk (man-pages)
On 07/22/2015 09:22 PM, Alexei Starovoitov wrote: > On 7/22/15 11:43 AM, Michael Kerrisk (man-pages) wrote: >> .TH BPF 2 2015-03-10 "Linux" "Linux Programmer's Manual" > > should the date be updated ? It'll get updated later, by scripts. >> BPF maps are a generic data structure for storage of

Re: Draft 3 of bpf(2) man page for review

2015-07-22 Thread Alexei Starovoitov
On 7/22/15 11:43 AM, Michael Kerrisk (man-pages) wrote: .TH BPF 2 2015-03-10 "Linux" "Linux Programmer's Manual" should the date be updated ? BPF maps are a generic data structure for storage of different data types. A user process can create multiple maps (with key/value-pairs being opaque

Draft 3 of bpf(2) man page for review

2015-07-22 Thread Michael Kerrisk (man-pages)
Hello Alexei, Daniel, et al. Please find below another draft of the bpf(2) man page. It has gone through some fairly substantial editing since the last draft. There still remain quite a number of FIXMEs. Alexei, I am mindful that you'd like to get a version of this page released soon. With that

Re: Draft 3 of bpf(2) man page for review

2015-07-22 Thread Alexei Starovoitov
On 7/22/15 11:43 AM, Michael Kerrisk (man-pages) wrote: .TH BPF 2 2015-03-10 Linux Linux Programmer's Manual should the date be updated ? BPF maps are a generic data structure for storage of different data types. A user process can create multiple maps (with key/value-pairs being opaque

Draft 3 of bpf(2) man page for review

2015-07-22 Thread Michael Kerrisk (man-pages)
Hello Alexei, Daniel, et al. Please find below another draft of the bpf(2) man page. It has gone through some fairly substantial editing since the last draft. There still remain quite a number of FIXMEs. Alexei, I am mindful that you'd like to get a version of this page released soon. With that

Re: Draft 3 of bpf(2) man page for review

2015-07-22 Thread Michael Kerrisk (man-pages)
On 07/22/2015 09:22 PM, Alexei Starovoitov wrote: On 7/22/15 11:43 AM, Michael Kerrisk (man-pages) wrote: .TH BPF 2 2015-03-10 Linux Linux Programmer's Manual should the date be updated ? It'll get updated later, by scripts. BPF maps are a generic data structure for storage of different

Re: Draft 3 of bpf(2) man page for review

2015-07-22 Thread Alexei Starovoitov
On 7/22/15 1:10 PM, Michael Kerrisk (man-pages) wrote: BPF maps are a generic data structure for storage of different data types. A user process can create multiple maps (with key/value-pairs being opaque bytes of data) and access them via file