RE: [PATCH 2/2] drivers: hv: Create a consistent pattern for checking Hyper-V hypercall status

2021-04-20 Thread Michael Kelley
mu.c | 8 > arch/x86/hyperv/nested.c| 8 > arch/x86/include/asm/mshyperv.h | 1 + > drivers/hv/hv.c | 2 +- > drivers/pci/controller/pci-hyperv.c | 2 +- > include/asm-generic/mshyperv.h | 25 +++

RE: ** POTENTIAL FRAUD ALERT - RED HAT ** [PATCH v2 1/1] Drivers: hv: vmbus: Increase wait time for VMbus unload

2021-04-20 Thread Michael Kelley
t through the BIOS/UEFI code. > > > > Fix this problem by increasing the timeout in vmbus_wait_for_unload() > > to 100 seconds. Also output periodic messages so that if anyone is > > watching the serial console, they won't think the VM is completely > > hung. >

Re: ** POTENTIAL FRAUD ALERT - RED HAT ** [PATCH v2 1/1] Drivers: hv: vmbus: Increase wait time for VMbus unload

2021-04-20 Thread Wei Liu
hrough the BIOS/UEFI code. > > > > Fix this problem by increasing the timeout in vmbus_wait_for_unload() > > to 100 seconds. Also output periodic messages so that if anyone is > > watching the serial console, they won't think the VM is completely > > hung. > >

Re: [PATCH v2] Drivers: hv: vmbus: Initialize unload_event statically

2021-04-20 Thread Wei Liu
_response() > > > > [1] > > https://lore.kernel.org/linux-hyperv/20210416143932.16512-1-parri.and...@gmail.com/ > > > > drivers/hv/channel_mgmt.c | 7 ++- > > drivers/hv/connection.c | 2 ++ > > 2 files changed, 8 insertions(+), 1 deletion(-) > > > > Reviewed-by: Michael Kelley Applied to hyperv-next. Thanks.

Re: ** POTENTIAL FRAUD ALERT - RED HAT ** [PATCH v2 1/1] Drivers: hv: vmbus: Increase wait time for VMbus unload

2021-04-20 Thread Vitaly Kuznetsov
o output periodic messages so that if anyone is > watching the serial console, they won't think the VM is completely > hung. > > Fixes: 911e1987efc8 ("Drivers: hv: vmbus: Add timeout to > vmbus_wait_for_unload") > Signed-off-by: Michael Kelley > --- >

RE: [PATCH v2] Drivers: hv: vmbus: Initialize unload_event statically

2021-04-19 Thread Michael Kelley
> Reported-by: Michael Kelley > Signed-off-by: Andrea Parri (Microsoft) > --- > Changes since v1[1]: > - add inline comment in vmbus_unload_response() > > [1] > https://lore.kernel.org/linux-hyperv/20210416143932.16512-1-parri.and...@gmail.com/ > > driver

[PATCH v2 1/1] Drivers: hv: vmbus: Increase wait time for VMbus unload

2021-04-19 Thread Michael Kelley
think the VM is completely hung. Fixes: 911e1987efc8 ("Drivers: hv: vmbus: Add timeout to vmbus_wait_for_unload") Signed-off-by: Michael Kelley --- Changed in v2: Fixed silly error in the argument to mdelay() --- drivers/hv/channel_mgmt.c | 30 +- 1 file ch

[PATCH v2] Drivers: hv: vmbus: Initialize unload_event statically

2021-04-19 Thread Andrea Parri (Microsoft)
]: - add inline comment in vmbus_unload_response() [1] https://lkml.kernel.org/r/20210416143932.16512-1-parri.and...@gmail.com drivers/hv/channel_mgmt.c | 7 ++- drivers/hv/connection.c | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/hv/channel_mgmt.c b/drivers

[PATCH 1/1] Drivers: hv: vmbus: Increase wait time for VMbus unload

2021-04-19 Thread Michael Kelley
think the VM is completely hung. Fixes: 911e1987efc8 ("Drivers: hv: vmbus: Add timeout to vmbus_wait_for_unload") Signed-off-by: Michael Kelley --- drivers/hv/channel_mgmt.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/drivers

Re: [PATCH] Drivers: hv: vmbus: Initialize unload_event statically

2021-04-18 Thread Andrea Parri
On Fri, Apr 16, 2021 at 03:25:03PM +, Michael Kelley wrote: > From: Andrea Parri (Microsoft) Sent: Friday, April > 16, 2021 7:40 AM > > > > If a malicious or compromised Hyper-V sends a spurious message of type > > CHANNELMSG_UNLOAD_RESPONSE, the function vmbus_unload_response() will > > cal

Re: [PATCH v3 0/3] Drivers: hv: vmbus: Introduce CHANNELMSG_MODIFYCHANNEL_RESPONSE

2021-04-18 Thread Wei Liu
[1] https://lkml.kernel.org/r/20210414150118.2843-1-parri.and...@gmail.com > [2] https://lkml.kernel.org/r/20201126191210.13115-1-parri.and...@gmail.com > > Andrea Parri (Microsoft) (3): > Drivers: hv: vmbus: Introduce and negotiate VMBus protocol vers

[PATCH 2/2] drivers: hv: Create a consistent pattern for checking Hyper-V hypercall status

2021-04-16 Thread Joseph Salisbury
+ drivers/hv/hv.c | 2 +- drivers/pci/controller/pci-hyperv.c | 2 +- include/asm-generic/mshyperv.h | 25 - 10 files changed, 54 insertions(+), 41 deletions(-) diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c index 284e73661a18

RE: [PATCH] Drivers: hv: vmbus: Initialize unload_event statically

2021-04-16 Thread Michael Kelley
ease leave a comment somewhere in the code itself that describes this scenario so that somebody in the future doesn't decide it's OK to "simplify" the initialization of unload_event. :-) Michael > > Reported-by: Michael Kelley > Signed-off-by: Andrea Parri (Microsoft

RE: [PATCH v3 3/3] Drivers: hv: vmbus: Check for pending channel interrupts before taking a CPU offline

2021-04-16 Thread Michael Kelley
From: Andrea Parri (Microsoft) Sent: Friday, April 16, 2021 7:35 AM > > Check that enough time has passed such that the modify channel message > has been processed before taking a CPU offline. > > Signed-off-by: Andrea Parri (Microsoft) > --- >

RE: [PATCH v3 1/3] Drivers: hv: vmbus: Introduce and negotiate VMBus protocol version 5.3

2021-04-16 Thread Michael Kelley
From: Andrea Parri (Microsoft) Sent: Friday, April 16, 2021 7:35 AM > > Hyper-V has added VMBus protocol version 5.3. Allow Linux guests to > negotiate the new version on version of Hyper-V that support it. > > Signed-off-by: Andrea Parri (Microsoft) > --- > driver

[PATCH] Drivers: hv: vmbus: Initialize unload_event statically

2021-04-16 Thread Andrea Parri (Microsoft)
If a malicious or compromised Hyper-V sends a spurious message of type CHANNELMSG_UNLOAD_RESPONSE, the function vmbus_unload_response() will call complete() on an uninitialized event, and cause an oops. Reported-by: Michael Kelley Signed-off-by: Andrea Parri (Microsoft) --- drivers/hv

[PATCH v3 3/3] Drivers: hv: vmbus: Check for pending channel interrupts before taking a CPU offline

2021-04-16 Thread Andrea Parri (Microsoft)
Check that enough time has passed such that the modify channel message has been processed before taking a CPU offline. Signed-off-by: Andrea Parri (Microsoft) --- drivers/hv/hv.c | 56 ++--- 1 file changed, 53 insertions(+), 3 deletions(-) diff --git

[PATCH v3 2/3] Drivers: hv: vmbus: Drivers: hv: vmbus: Introduce CHANNELMSG_MODIFYCHANNEL_RESPONSE

2021-04-16 Thread Andrea Parri (Microsoft)
Introduce the CHANNELMSG_MODIFYCHANNEL_RESPONSE message type, and code to receive and process such a message. Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley --- drivers/hv/channel.c | 99 --- drivers/hv/channel_mgmt.c | 42

[PATCH v3 1/3] Drivers: hv: vmbus: Introduce and negotiate VMBus protocol version 5.3

2021-04-16 Thread Andrea Parri (Microsoft)
Hyper-V has added VMBus protocol version 5.3. Allow Linux guests to negotiate the new version on version of Hyper-V that support it. Signed-off-by: Andrea Parri (Microsoft) --- drivers/hv/connection.c | 3 ++- include/linux/hyperv.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion

[PATCH v3 0/3] Drivers: hv: vmbus: Introduce CHANNELMSG_MODIFYCHANNEL_RESPONSE

2021-04-16 Thread Andrea Parri (Microsoft)
.com Andrea Parri (Microsoft) (3): Drivers: hv: vmbus: Introduce and negotiate VMBus protocol version 5.3 Drivers: hv: vmbus: Drivers: hv: vmbus: Introduce CHANNELMSG_MODIFYCHANNEL_RESPONSE Drivers: hv: vmbus: Check for pending channel interrupts before taking a CPU offline driver

Re: [PATCH] Drivers: hv: vmbus: Use after free in __vmbus_open()

2021-04-16 Thread Wei Liu
moving it from the > > list. This will result in a use after free. First remove it from the > > list, and then free it. > > > > Fixes: 6f3d791f3006 ("Drivers: hv: vmbus: Fix rescind handling issues") > > Signed-off-by: Dan Carpenter > > I had this 'queued' in my list, > > Reviewed-by: Andrea Parri Applied. Thanks.

Re: [PATCH v2 3/3] Drivers: hv: vmbus: Check for pending channel interrupts before taking a CPU offline

2021-04-15 Thread Andrea Parri
> > @@ -336,6 +372,19 @@ int hv_synic_cleanup(unsigned int cpu) > > if (channel_found && vmbus_connection.conn_state == CONNECTED) > > return -EBUSY; > > > > + if (vmbus_proto_version >= VERSION_WIN10_V4_1) { > > + /* > > +* channel_found == false means that

Re: [PATCH v2 1/3] Drivers: hv: vmbus: Introduce and negotiate VMBus protocol version 5.3

2021-04-15 Thread Andrea Parri
> > @@ -234,6 +234,7 @@ static inline u32 hv_get_avail_to_write_percent( > > * 5 . 0 (Newer Windows 10) > > * 5 . 1 (Windows 10 RS4) > > * 5 . 2 (Windows Server 2019, RS5) > > + * 5 . 3 (Windows Server 2021) // FIXME: use proper version number/name > > The official name is now public inf

RE: [PATCH v2 3/3] Drivers: hv: vmbus: Check for pending channel interrupts before taking a CPU offline

2021-04-14 Thread Michael Kelley
From: Andrea Parri (Microsoft) Sent: Wednesday, April 14, 2021 8:01 AM > > Check that enough time has passed such that the modify channel message > has been processed before taking a CPU offline. > > Signed-off-by: Andrea Parri (Microsoft) > --- >

RE: [PATCH v2 2/3] Drivers: hv: vmbus: Drivers: hv: vmbus: Introduce CHANNELMSG_MODIFYCHANNEL_RESPONSE

2021-04-14 Thread Michael Kelley
From: Andrea Parri (Microsoft) Sent: Wednesday, April 14, 2021 8:01 AM > > Introduce the CHANNELMSG_MODIFYCHANNEL_RESPONSE message type, and code > to receive and process such a message. > > Signed-off-by: Andrea Parri (Microsoft) > --- > drivers/h

RE: [PATCH v2 1/3] Drivers: hv: vmbus: Introduce and negotiate VMBus protocol version 5.3

2021-04-14 Thread Michael Kelley
From: Andrea Parri (Microsoft) Sent: Wednesday, April 14, 2021 8:01 AM > > Hyper-V has added VMBus protocol version 5.3. Allow Linux guests to > negotiate the new version on version of Hyper-V that support it. > > Signed-off-by: Andrea Parri (Microsoft) > --- > driver

Re: [PATCH] Drivers: hv: vmbus: remove unused function

2021-04-14 Thread Wei Liu
On Wed, Apr 14, 2021 at 02:48:17PM +, Michael Kelley wrote: > From: Jiapeng Chong Sent: Tuesday, April > 13, 2021 11:21 PM [...] > This function became unused as of commit 4226ff69a3df > ("vmbus: simplify hv_ringbuffer_read") on 7/17/2017. > > Reviewed-by: Michael Kelley Applied to hyperv

[PATCH v2 3/3] Drivers: hv: vmbus: Check for pending channel interrupts before taking a CPU offline

2021-04-14 Thread Andrea Parri (Microsoft)
Check that enough time has passed such that the modify channel message has been processed before taking a CPU offline. Signed-off-by: Andrea Parri (Microsoft) --- drivers/hv/hv.c | 49 + 1 file changed, 49 insertions(+) diff --git a/drivers/hv

[PATCH v2 2/3] Drivers: hv: vmbus: Drivers: hv: vmbus: Introduce CHANNELMSG_MODIFYCHANNEL_RESPONSE

2021-04-14 Thread Andrea Parri (Microsoft)
Introduce the CHANNELMSG_MODIFYCHANNEL_RESPONSE message type, and code to receive and process such a message. Signed-off-by: Andrea Parri (Microsoft) --- drivers/hv/channel.c | 99 --- drivers/hv/channel_mgmt.c | 42 + drivers/hv

[PATCH v2 0/3] Drivers: hv: vmbus: Introduce CHANNELMSG_MODIFYCHANNEL_RESPONSE

2021-04-14 Thread Andrea Parri (Microsoft)
ents - style changes [1] https://lkml.kernel.org/r/20201126191210.13115-1-parri.and...@gmail.com Andrea Parri (Microsoft) (3): Drivers: hv: vmbus: Introduce and negotiate VMBus protocol version 5.3 Drivers: hv: vmbus: Drivers: hv: vmbus: Introduce CHANNELMSG_MODIFYCHANNEL_RESPONSE Drivers

[PATCH v2 1/3] Drivers: hv: vmbus: Introduce and negotiate VMBus protocol version 5.3

2021-04-14 Thread Andrea Parri (Microsoft)
Hyper-V has added VMBus protocol version 5.3. Allow Linux guests to negotiate the new version on version of Hyper-V that support it. Signed-off-by: Andrea Parri (Microsoft) --- drivers/hv/connection.c | 3 ++- include/linux/hyperv.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion

RE: [PATCH] Drivers: hv: vmbus: remove unused function

2021-04-14 Thread Michael Kelley
From: Jiapeng Chong Sent: Tuesday, April 13, 2021 11:21 PM > > Fix the following clang warning: > > drivers/hv/ring_buffer.c:89:1: warning: unused function > 'hv_set_next_read_location' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by:

[PATCH] Drivers: hv: vmbus: remove unused function

2021-04-13 Thread Jiapeng Chong
Fix the following clang warning: drivers/hv/ring_buffer.c:89:1: warning: unused function 'hv_set_next_read_location' [-Wunused-function]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/hv/ring_buffer.c | 9 - 1 file changed, 9 deletions(-) diff --git a/

Re: [PATCH] Drivers: hv: vmbus: Use after free in __vmbus_open()

2021-04-13 Thread Andrea Parri
st remove it from the > list, and then free it. > > Fixes: 6f3d791f3006 ("Drivers: hv: vmbus: Fix rescind handling issues") > Signed-off-by: Dan Carpenter I had this 'queued' in my list, Reviewed-by: Andrea Parri Andrea > --- > From static analysis. Un

Re: [PATCH] Drivers: hv: vmbus: Use after free in __vmbus_open()

2021-04-13 Thread Wei Liu
st remove it from the > list, and then free it. > > Fixes: 6f3d791f3006 ("Drivers: hv: vmbus: Fix rescind handling issues") > Signed-off-by: Dan Carpenter > --- > From static analysis. Untested etc. There is almost certainly a good > reason to add it to the list before

Re: [PATCH] Drivers: hv: vmbus: remove unused including

2021-04-13 Thread Wei Liu
On Tue, Apr 13, 2021 at 05:49:18PM +0800, Yang Li wrote: > Fix the following versioncheck warning: > ./drivers/hv/hv.c: 16 linux/version.h not needed. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Thanks for the patch. This has also been reported by Huawei's ker

[PATCH] Drivers: hv: vmbus: Use after free in __vmbus_open()

2021-04-13 Thread Dan Carpenter
The "open_info" variable is added to the &vmbus_connection.chn_msg_list, but the error handling frees "open_info" without removing it from the list. This will result in a use after free. First remove it from the list, and then free it. Fixes: 6f3d791f3006 ("Dr

[PATCH] Drivers: hv: vmbus: remove unused including

2021-04-13 Thread Yang Li
Fix the following versioncheck warning: ./drivers/hv/hv.c: 16 linux/version.h not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/hv/hv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index f202ac7..2c3ae4d 100644 --- a/drivers/hv/hv.c

Re: [PATCH hyperv-next] Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer

2021-04-09 Thread Andrea Parri
On Fri, Apr 09, 2021 at 03:49:00PM +, Michael Kelley wrote: > From: Andrea Parri (Microsoft) Sent: Thursday, April > 8, 2021 9:15 AM > > > > Pointers to ring-buffer packets sent by Hyper-V are used within the > > guest VM. Hyper-V can send packets with erroneous values or modify > > packet f

RE: [PATCH hyperv-next] Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer

2021-04-09 Thread Michael Kelley
_MAX_XFER_PAGE_RANGES? It used to be a fixed 375, but now is NVSP_RSC_MAX, which is 562. If that's the only change, then Reviewed-by: Michael Kelley > > Signed-off-by: Andres Beltran > Co-developed-by: Andrea Parri (Microsoft) > Signed-off-by: Andrea Parri (Mic

[PATCH hyperv-next] Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer

2021-04-08 Thread Andrea Parri (Microsoft)
validating its length and offset fields in hv_pkt_iter_first(). In this way, the packet can no longer be modified by the host. Signed-off-by: Andres Beltran Co-developed-by: Andrea Parri (Microsoft) Signed-off-by: Andrea Parri (Microsoft) --- drivers/hv/channel.c | 9 ++-- drivers/hv

Re: [PATCH v2] drivers: hv: Fix EXPORT_SYMBOL and tab spaces issue

2021-03-22 Thread Wei Liu
On Wed, Mar 10, 2021 at 10:51:55AM +0530, Vasanth wrote: > 1.Fixed EXPORT_SYMBOL should be follow immediately function/variable. > 2.Fixed code tab spaces issue. > > Signed-off-by: Vasanth M Applied to hyperv-next.

[PATCH v2] drivers: hv: Fix EXPORT_SYMBOL and tab spaces issue

2021-03-09 Thread Vasanth
1.Fixed EXPORT_SYMBOL should be follow immediately function/variable. 2.Fixed code tab spaces issue. Signed-off-by: Vasanth M --- changes in v2: * Added commit message * Revised Subject drivers/hv/channel_mgmt.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a

[PATCH v9 7/7] Drivers: hv: Enable Hyper-V code to be built on ARM64

2021-03-08 Thread Michael Kelley
Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on ARM64, causing the Hyper-V specific code to be built. Signed-off-by: Michael Kelley Reviewed-by: Sunil Muthuswamy --- drivers/hv/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hv/Kconfig b

Re: [PATCH] drivers: hv: Fix no spaces issue

2021-03-08 Thread Wei Liu
On Fri, Mar 05, 2021 at 09:34:49PM +0530, Vasanth wrote: > Fixed code spaces issue. > > Signed-off-by: Vasanth M What do you mean by "Fixed no spaces issue" in the title? I can see you deleted an empty line and changed some tabs to spaces. Please be specific in the commit message. Wei.

[PATCH] drivers: hv: Fix no spaces issue

2021-03-05 Thread Vasanth
Fixed code spaces issue. Signed-off-by: Vasanth M --- drivers/hv/channel_mgmt.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index 1d44bb635bb8..84d6b3dde76f 100644 --- a/drivers/hv/channel_mgmt.c +++ b/drivers

RE: [PATCH v8 6/6] Drivers: hv: Enable Hyper-V code to be built on ARM64

2021-03-03 Thread Sunil Muthuswamy
> Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on > ARM64, causing the Hyper-V specific code to be built. > > Signed-off-by: Michael Kelley > --- > drivers/hv/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/driv

Re: [PATCH] Drivers: hv: vmbus: Drop error message when 'No request id available'

2021-03-03 Thread Wei Liu
either be > dropped (since we don't output a message when the ring buffer is full) > or be made conditional/debug-only. > > Suggested-by: Michael Kelley > Signed-off-by: Andrea Parri (Microsoft) > Fixes: e8b7db38449ac ("Drivers: hv: vmbus: Add vmbus_requestor data structure

[PATCH v3 03/10] Drivers: hv: Redo Hyper-V synthetic MSR get/set functions

2021-03-02 Thread Michael Kelley
Feng --- arch/x86/hyperv/hv_init.c | 2 +- arch/x86/include/asm/hyperv-tlfs.h | 102 +++-- arch/x86/include/asm/mshyperv.h| 39 -- drivers/clocksource/hyperv_timer.c | 26 +----- drivers/hv/hv.c| 37 ------ drive

[PATCH v3 04/10] Drivers: hv: vmbus: Move hyperv_report_panic_msg to arch neutral code

2021-03-02 Thread Michael Kelley
-by: Boqun Feng --- arch/x86/hyperv/hv_init.c | 27 --- drivers/hv/vmbus_drv.c | 24 +++- include/asm-generic/mshyperv.h | 1 - 3 files changed, 19 insertions(+), 33 deletions(-) diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv

[PATCH v3 01/10] Drivers: hv: vmbus: Move Hyper-V page allocator to arch neutral code

2021-03-02 Thread Michael Kelley
/hv_init.c | 22 -- arch/x86/include/asm/mshyperv.h | 5 - drivers/hv/hv.c | 36 include/asm-generic/mshyperv.h | 4 4 files changed, 40 insertions(+), 27 deletions(-) diff --git a/arch/x86/hyperv/hv_init.c b/arch

[PATCH v3 05/10] Drivers: hv: vmbus: Handle auto EOI quirk inline

2021-03-02 Thread Michael Kelley
h/x86/include/asm/mshyperv.h | 3 --- drivers/hv/hv.c | 12 +++- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h index 2590ce5..a6c608d 100644 --- a/arch/x86/include/asm/mshyperv.h +++ b/arch/x86/in

[PATCH v3 06/10] Drivers: hv: vmbus: Move handling of VMbus interrupts

2021-03-02 Thread Michael Kelley
6/x64, special case code is retained under arch/x86, but no VMbus interrupt handling code is needed under arch/arm64. No functional change. Signed-off-by: Michael Kelley Reviewed-by: Boqun Feng --- arch/x86/include/asm/mshyperv.h | 1 - arch/x86/kernel/cpu/mshyperv.c | 13 +++------ drivers/hv

Re: [PATCH v3] drivers: hv: Fix whitespace errors

2021-03-02 Thread Wei Liu
; ker...@vger.kernel.org; Vasanth > > Subject: [PATCH v3] drivers: hv: Fix whitespace errors > > > > Fixed checkpatch warning and errors on hv driver. > > > > Signed-off-by: Vasanth Vasanth, normally people put their full name in the SoB. Do you want to do that to

RE: ** POTENTIAL FRAUD ALERT - RED HAT ** [PATCH v2 01/10] Drivers: hv: vmbus: Move Hyper-V page allocator to arch neutral code

2021-03-02 Thread Michael Kelley
ion for ARM64 is not needed. > > > > No functional change. > > > > Signed-off-by: Michael Kelley > > Reviewed-by: Boqun Feng > > --- > > arch/x86/hyperv/hv_init.c | 22 ---------- > > arch/x86/

Re: ** POTENTIAL FRAUD ALERT - RED HAT ** [PATCH v2 01/10] Drivers: hv: vmbus: Move Hyper-V page allocator to arch neutral code

2021-03-02 Thread Vitaly Kuznetsov
Kelley > Reviewed-by: Boqun Feng > --- > arch/x86/hyperv/hv_init.c | 22 -- > arch/x86/include/asm/mshyperv.h | 5 - > drivers/hv/hv.c | 36 > include/asm-generic/mshyperv.h | 4 &

[PATCH] Drivers: hv: vmbus: Drop error message when 'No request id available'

2021-03-01 Thread Andrea Parri (Microsoft)
made conditional/debug-only. Suggested-by: Michael Kelley Signed-off-by: Andrea Parri (Microsoft) Fixes: e8b7db38449ac ("Drivers: hv: vmbus: Add vmbus_requestor data structure for VMBus hardening") --- drivers/hv/ring_buffer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hv/

[PATCH 5.10 218/663] Drivers: hv: vmbus: Avoid use-after-free in vmbus_onoffer_rescind()

2021-03-01 Thread Greg Kroah-Hartman
;Drivers: hv: vmbus: Fix rescind handling") Reported-by: Juan Vazquez Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-5-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/chann

[PATCH 5.11 260/775] Drivers: hv: vmbus: Avoid use-after-free in vmbus_onoffer_rescind()

2021-03-01 Thread Greg Kroah-Hartman
;Drivers: hv: vmbus: Fix rescind handling") Reported-by: Juan Vazquez Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-5-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/chann

[PATCH 5.4 113/340] Drivers: hv: vmbus: Avoid use-after-free in vmbus_onoffer_rescind()

2021-03-01 Thread Greg Kroah-Hartman
;Drivers: hv: vmbus: Fix rescind handling") Reported-by: Juan Vazquez Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-5-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/chann

[PATCH 4.19 099/247] Drivers: hv: vmbus: Avoid use-after-free in vmbus_onoffer_rescind()

2021-03-01 Thread Greg Kroah-Hartman
;Drivers: hv: vmbus: Fix rescind handling") Reported-by: Juan Vazquez Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-5-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/chann

[PATCH 4.14 059/176] Drivers: hv: vmbus: Avoid use-after-free in vmbus_onoffer_rescind()

2021-03-01 Thread Greg Kroah-Hartman
;Drivers: hv: vmbus: Fix rescind handling") Reported-by: Juan Vazquez Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-5-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/chann

[PATCH v2 06/10] Drivers: hv: vmbus: Move handling of VMbus interrupts

2021-02-28 Thread Michael Kelley
6/x64, special case code is retained under arch/x86, but no VMbus interrupt handling code is needed under arch/arm64. No functional change. Signed-off-by: Michael Kelley Reviewed-by: Boqun Feng --- arch/x86/include/asm/mshyperv.h | 1 - arch/x86/kernel/cpu/mshyperv.c | 13 +++------ drivers/hv

[PATCH v2 05/10] Drivers: hv: vmbus: Handle auto EOI quirk inline

2021-02-28 Thread Michael Kelley
h/x86/include/asm/mshyperv.h | 3 --- drivers/hv/hv.c | 12 +++- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h index 2590ce5..a6c608d 100644 --- a/arch/x86/include/asm/mshyperv.h +++ b/arch/x86/in

[PATCH v2 04/10] Drivers: hv: vmbus: Move hyperv_report_panic_msg to arch neutral code

2021-02-28 Thread Michael Kelley
-by: Boqun Feng --- arch/x86/hyperv/hv_init.c | 27 --- drivers/hv/vmbus_drv.c | 24 +++- include/asm-generic/mshyperv.h | 1 - 3 files changed, 19 insertions(+), 33 deletions(-) diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv

[PATCH v2 03/10] Drivers: hv: Redo Hyper-V synthetic MSR get/set functions

2021-02-28 Thread Michael Kelley
Feng --- arch/x86/hyperv/hv_init.c | 2 +- arch/x86/include/asm/hyperv-tlfs.h | 102 +++-- arch/x86/include/asm/mshyperv.h| 39 -- drivers/clocksource/hyperv_timer.c | 26 +----- drivers/hv/hv.c| 37 ------ drive

[PATCH v2 01/10] Drivers: hv: vmbus: Move Hyper-V page allocator to arch neutral code

2021-02-28 Thread Michael Kelley
/hv_init.c | 22 -- arch/x86/include/asm/mshyperv.h | 5 - drivers/hv/hv.c | 36 include/asm-generic/mshyperv.h | 4 4 files changed, 40 insertions(+), 27 deletions(-) diff --git a/arch/x86/hyperv/hv_init.c b/arch

Re: [PATCH AUTOSEL 5.11 50/67] Drivers: hv: vmbus: Initialize memory to be sent to the host

2021-02-26 Thread Sasha Levin
On Wed, Feb 24, 2021 at 02:30:52PM +0100, Andrea Parri wrote: On Wed, Feb 24, 2021 at 02:16:00PM +0100, Andrea Parri wrote: On Wed, Feb 24, 2021 at 07:50:08AM -0500, Sasha Levin wrote: > From: "Andrea Parri (Microsoft)" > > [ Upstream commit e99c4afbee07e9323e9191a20b24d74dbf815bdf ] > > __vmbu

Re: [PATCH AUTOSEL 5.11 50/67] Drivers: hv: vmbus: Initialize memory to be sent to the host

2021-02-24 Thread Andrea Parri
On Wed, Feb 24, 2021 at 02:16:00PM +0100, Andrea Parri wrote: > On Wed, Feb 24, 2021 at 07:50:08AM -0500, Sasha Levin wrote: > > From: "Andrea Parri (Microsoft)" > > > > [ Upstream commit e99c4afbee07e9323e9191a20b24d74dbf815bdf ] > > > > __vmbus_open() and vmbus_teardown_gpadl() do not iniziali

Re: [PATCH AUTOSEL 4.14 15/16] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2021-02-24 Thread Andrea Parri
; Signed-off-by: Wei Liu > Signed-off-by: Sasha Levin Same here. Andrea > --- > drivers/hv/channel_mgmt.c | 12 > include/linux/hyperv.h | 1 + > 2 files changed, 13 insertions(+) > > diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c >

Re: [PATCH AUTOSEL 5.10 40/56] Drivers: hv: vmbus: Initialize memory to be sent to the host

2021-02-24 Thread Andrea Parri
e information to the host. > > Reported-by: Juan Vazquez > Signed-off-by: Andrea Parri (Microsoft) > Reviewed-by: Michael Kelley > Link: https://lore.kernel.org/r/20201209070827.29335-2-parri.and...@gmail.com > Signed-off-by: Wei Liu > Signed-off-by: Sasha Levin Same here.

Re: [PATCH AUTOSEL 5.10 41/56] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2021-02-24 Thread Andrea Parri
; Signed-off-by: Wei Liu > Signed-off-by: Sasha Levin Same here. Andrea > --- > drivers/hv/channel_mgmt.c | 12 > include/linux/hyperv.h | 1 + > 2 files changed, 13 insertions(+) > > diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c >

Re: [PATCH AUTOSEL 5.4 30/40] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2021-02-24 Thread Andrea Parri
; Signed-off-by: Wei Liu > Signed-off-by: Sasha Levin Same here. Andrea > --- > drivers/hv/channel_mgmt.c | 12 > include/linux/hyperv.h | 1 + > 2 files changed, 13 insertions(+) > > diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c >

Re: [PATCH AUTOSEL 4.19 21/26] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2021-02-24 Thread Andrea Parri
; Signed-off-by: Wei Liu > Signed-off-by: Sasha Levin Same here. Andrea > --- > drivers/hv/channel_mgmt.c | 12 > include/linux/hyperv.h | 1 + > 2 files changed, 13 insertions(+) > > diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c >

Re: [PATCH AUTOSEL 5.11 51/67] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2021-02-24 Thread Andrea Parri
e properly treated as new functionality rather than as bug fixes. So I would propose that we *not* bring such patches back to stable branches. Thanks, Andrea > --- > drivers/hv/channel_mgmt.c | 12 > include/linux/hyperv.h | 1 + > 2 files changed, 13 insertion

Re: [PATCH AUTOSEL 5.11 50/67] Drivers: hv: vmbus: Initialize memory to be sent to the host

2021-02-24 Thread Andrea Parri
So I would propose that we *not* bring such patches back to stable branches. Thanks, Andrea > --- > drivers/hv/channel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c > index 6fb0c76bfbf81..0bd202de796

[PATCH AUTOSEL 4.14 15/16] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2021-02-24 Thread Sasha Levin
ez Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-6-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/channel_mgmt.c | 12 include/linux/hyperv.h| 1 + 2 files c

[PATCH AUTOSEL 4.19 21/26] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2021-02-24 Thread Sasha Levin
ez Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-6-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/channel_mgmt.c | 12 include/linux/hyperv.h| 1 + 2 files c

[PATCH AUTOSEL 5.4 30/40] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2021-02-24 Thread Sasha Levin
ez Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-6-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/channel_mgmt.c | 12 include/linux/hyperv.h| 1 + 2 files c

[PATCH AUTOSEL 5.10 41/56] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2021-02-24 Thread Sasha Levin
ez Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-6-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/channel_mgmt.c | 12 include/linux/hyperv.h| 1 + 2 files c

[PATCH AUTOSEL 5.10 40/56] Drivers: hv: vmbus: Initialize memory to be sent to the host

2021-02-24 Thread Sasha Levin
ael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-2-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index fbd

[PATCH AUTOSEL 5.11 50/67] Drivers: hv: vmbus: Initialize memory to be sent to the host

2021-02-24 Thread Sasha Levin
ael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-2-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index 6fb

[PATCH AUTOSEL 5.11 51/67] Drivers: hv: vmbus: Resolve race condition in vmbus_onoffer_rescind()

2021-02-24 Thread Sasha Levin
ez Signed-off-by: Andrea Parri (Microsoft) Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20201209070827.29335-6-parri.and...@gmail.com Signed-off-by: Wei Liu Signed-off-by: Sasha Levin --- drivers/hv/channel_mgmt.c | 12 include/linux/hyperv.h| 1 + 2 files c

Re: [PATCH 06/10] Drivers: hv: vmbus: Move handling of VMbus interrupts

2021-02-21 Thread Boqun Feng
y: Michael Kelley Reviewed-by: Boqun Feng Regards, Boqun > --- > arch/x86/include/asm/mshyperv.h | 1 - > arch/x86/kernel/cpu/mshyperv.c | 13 +++------ > drivers/hv/hv.c | 8 +- > drivers/hv/vmbus_drv.c | 63 > +++

Re: [PATCH 05/10] Drivers: hv: vmbus: Handle auto EOI quirk inline

2021-02-21 Thread Boqun Feng
No functional change. > > Signed-off-by: Michael Kelley Reviewed-by: Boqun Feng Regards, Boqun > --- > arch/x86/include/asm/mshyperv.h | 3 --- > drivers/hv/hv.c | 12 +++- > 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/arch/x

Re: [PATCH 04/10] Drivers: hv: vmbus: Move hyperv_report_panic_msg to arch neutral code

2021-02-21 Thread Boqun Feng
; under arch/arm64. > > No functional change. > > Signed-off-by: Michael Kelley Reviewed-by: Boqun Feng Regards, Boqun > --- > arch/x86/hyperv/hv_init.c | 27 ------- > drivers/hv/vmbus_drv.c | 24 +++- > includ

Re: [PATCH 03/10] Drivers: hv: Redo Hyper-V synthetic MSR get/set functions

2021-02-21 Thread Boqun Feng
-- > arch/x86/include/asm/mshyperv.h| 39 ++++-- > drivers/clocksource/hyperv_timer.c | 26 +++++- > drivers/hv/hv.c| 37 -- > drivers/hv/vmbus_drv.c | 2 +- > include/asm-generic/mshyperv.h |

Re: [PATCH 01/10] Drivers: hv: vmbus: Move Hyper-V page allocator to arch neutral code

2021-02-21 Thread Boqun Feng
nctional change. > > Signed-off-by: Michael Kelley Reviewed-by: Boqun Feng Regards, Boqun > --- > arch/x86/hyperv/hv_init.c | 22 -- > arch/x86/include/asm/mshyperv.h | 5 - > drivers/hv/hv.c | 36

RE: [PATCH v3] drivers: hv: Fix whitespace errors

2021-02-19 Thread Michael Kelley
From: Vasanth Sent: Friday, February 19, 2021 9:13 AM > To: KY Srinivasan > Cc: Haiyang Zhang ; Stephen Hemminger > ; wei@kernel.org; linux-hyp...@vger.kernel.org; > linux- > ker...@vger.kernel.org; Vasanth > Subject: [PATCH v3] drivers: hv: Fix whitespace errors >

[PATCH v3] drivers: hv: Fix whitespace errors

2021-02-19 Thread Vasanth
Fixed checkpatch warning and errors on hv driver. Signed-off-by: Vasanth --- changes in v2: * Added commit message * Revised Subject drivers/hv/channel.c| 2 +- drivers/hv/connection.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hv/channel.c b/drivers

RE: [PATCH] drivers: hv: channel: fixed a tab having spaces before hv: connection: fixed required space for "=" sign before.

2021-02-19 Thread Michael Kelley
ifying the "Subject" line. The Subject line should ideally be no more than about 70 characters, and just needs to summarize. So go with something like: [PATCH] drivers: hv: Fix whitespace errors Or: [PATCH] drivers: hv: Fix whitespace errors from checkpatch The "drivers: hv:"

[PATCH v8 6/6] Drivers: hv: Enable Hyper-V code to be built on ARM64

2021-02-18 Thread Michael Kelley
Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on ARM64, causing the Hyper-V specific code to be built. Signed-off-by: Michael Kelley --- drivers/hv/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig index 79e5356

[PATCH] drivers: hv: channel: fixed a tab having spaces before hv: connection: fixed required space for "=" sign before.

2021-02-18 Thread Vasanth
Fixed checkpatch warning: Tab space before having normal space. Fixed checkpatch error: Required space for "=" sign before. Signed-off-by: Vasanth --- drivers/hv/channel.c | 2 +- drivers/hv/connection.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH v6 03/16] Drivers: hv: vmbus: skip VMBus initialization if Linux is root

2021-02-03 Thread Wei Liu
There is no VMBus and the other infrastructures initialized in hv_acpi_init when Linux is running as the root partition. Signed-off-by: Wei Liu Reviewed-by: Pavel Tatashin Reviewed-by: Michael Kelley --- v3: Return 0 instead of -ENODEV. --- drivers/hv/vmbus_drv.c | 3 +++ 1 file changed, 3

Re: [PATCH v3 hyperv-next 0/4] Drivers: hv: vmbus: Restrict devices and configurations on 'isolated' guests

2021-02-01 Thread Wei Liu
On Mon, Feb 01, 2021 at 03:48:10PM +0100, Andrea Parri (Microsoft) wrote: > Andrea Parri (Microsoft) (4): > x86/hyperv: Load/save the Isolation Configuration leaf > Drivers: hv: vmbus: Restrict vmbus_devices on isolated guests > Drivers: hv: vmbus: Enforce 'VMBus version &g

RE: [PATCH v3 hyperv-next 3/4] Drivers: hv: vmbus: Enforce 'VMBus version >= 5.2' on isolated guests

2021-02-01 Thread Michael Kelley
tial VMs and > hence the exposure to bugs and vulnerabilities. > > Signed-off-by: Andrea Parri (Microsoft) > --- > drivers/hv/connection.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c > index 11170d9a2e1a

RE: [PATCH v3 hyperv-next 2/4] Drivers: hv: vmbus: Restrict vmbus_devices on isolated guests

2021-02-01 Thread Michael Kelley
f the > code that will be exercised by Confidential VMs and hence the exposure > to bugs and vulnerabilities. > > Signed-off-by: Andrea Parri (Microsoft) > --- > drivers/hv/channel_mgmt.c | 38 ++ > include/linux/hyperv.h| 1 +

[PATCH v3 hyperv-next 2/4] Drivers: hv: vmbus: Restrict vmbus_devices on isolated guests

2021-02-01 Thread Andrea Parri (Microsoft)
vulnerabilities. Signed-off-by: Andrea Parri (Microsoft) --- drivers/hv/channel_mgmt.c | 38 ++ include/linux/hyperv.h| 1 + 2 files changed, 39 insertions(+) diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index 68950a1e4b638..f0ed730e2e4e4

[PATCH v3 hyperv-next 3/4] Drivers: hv: vmbus: Enforce 'VMBus version >= 5.2' on isolated guests

2021-02-01 Thread Andrea Parri (Microsoft)
(Microsoft) --- drivers/hv/connection.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c index 11170d9a2e1a5..c83612cddb995 100644 --- a/drivers/hv/connection.c +++ b/drivers/hv/connection.c @@ -244,6 +244,13 @@ int vmbus_connect(void

[PATCH v3 hyperv-next 0/4] Drivers: hv: vmbus: Restrict devices and configurations on 'isolated' guests

2021-02-01 Thread Andrea Parri (Microsoft)
hyperv: Load/save the Isolation Configuration leaf Drivers: hv: vmbus: Restrict vmbus_devices on isolated guests Drivers: hv: vmbus: Enforce 'VMBus version >= 5.2' on isolated guests hv_netvsc: Restrict configurations on isolated guests arch/x86/hyperv/hv_init.c | 15 +

  1   2   3   4   5   6   7   8   9   10   >