Re: Duplicated module names

2016-01-29 Thread Lucas De Marchi
Hi! On Fri, Jan 29, 2016 at 3:54 AM, Rusty Russell wrote: > Lucas De Marchi writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_CRC32 and >> CONFIG_CRYPTO_CRC32 can be compiled as module, and they generate >> modules with the same

Re: Duplicated module names

2016-01-29 Thread Sudeep Holla
On Fri, Jan 29, 2016 at 5:54 AM, Rusty Russell wrote: > Lucas De Marchi writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_CRC32 and >> CONFIG_CRYPTO_CRC32 can be compiled as module, and they generate >> modules with the same name,

Re: Duplicated module names

2016-01-29 Thread Herbert Xu
Rusty Russell wrote: > > I think we could rename it to crypto_crc32, but I don't think it's the > only one. Marco, I think depmod should probably FAIL if two modules > have the same name, which would at least find such problems. This patch renames it to crc32_generic. ---8<--- Subject:

Re: Duplicated module names

2016-01-29 Thread Herbert Xu
Rusty Russell wrote: > > I think we could rename it to crypto_crc32, but I don't think it's the > only one. Marco, I think depmod should probably FAIL if two modules > have the same name, which would at least find such problems. This patch renames it to crc32_generic.

Re: Duplicated module names

2016-01-29 Thread Sudeep Holla
On Fri, Jan 29, 2016 at 5:54 AM, Rusty Russell wrote: > Lucas De Marchi writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_CRC32 and >> CONFIG_CRYPTO_CRC32 can be compiled as module,

Re: Duplicated module names

2016-01-29 Thread Lucas De Marchi
Hi! On Fri, Jan 29, 2016 at 3:54 AM, Rusty Russell wrote: > Lucas De Marchi writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_CRC32 and >> CONFIG_CRYPTO_CRC32 can be compiled as

Re: Duplicated module names

2016-01-28 Thread Tomi Valkeinen
On 29/01/16 07:54, Rusty Russell wrote: > Lucas De Marchi writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_CRC32 and >> CONFIG_CRYPTO_CRC32 can be compiled as module, and they generate >> modules with the same name, crc32. Could

Duplicated module names

2016-01-28 Thread Rusty Russell
Lucas De Marchi writes: > Hi! > > CC'ing Rusty and mailing lists Thanks. > Rusty and ohers: it looks like both CONFIG_CRC32 and > CONFIG_CRYPTO_CRC32 can be compiled as module, and they generate > modules with the same name, crc32. Could that be fixed? Gah. Looks like it's been that way

Re: Duplicated module names

2016-01-28 Thread Tomi Valkeinen
On 29/01/16 07:54, Rusty Russell wrote: > Lucas De Marchi writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_CRC32 and >> CONFIG_CRYPTO_CRC32 can be compiled as module, and they generate >> modules with the

Duplicated module names

2016-01-28 Thread Rusty Russell
Lucas De Marchi writes: > Hi! > > CC'ing Rusty and mailing lists Thanks. > Rusty and ohers: it looks like both CONFIG_CRC32 and > CONFIG_CRYPTO_CRC32 can be compiled as module, and they generate > modules with the same name, crc32. Could that be fixed? Gah. Looks