[PATCH] pci.h stubs (for EDD build error)

On Tue, 26 Jun 2007 21:45:05 -0500 Matt Domsch wrote: > On Tue, Jun 26, 2007 at 01:26:22PM -0700, Randy Dunlap wrote: > > Hi, > > > > CONFIG_EDD does not depend on PCI, but edd.c uses pci_* interface > > functions, resulting in: > > > > CC [M] drivers/firmware/edd.o > > drivers/firmware/edd.c

Re: pci.h stubs (was: EDD build error)

> > So the answer is "yes" we should then, and move from pci_get_bus_and_slot > > to pci_get_bus_domain_and_slot() [or just add an argument]. The point of > > the functions is to be easy to use, so it should be handled internally. > > My point was that code which doesn't currently keep the bus poi

Re: pci.h stubs (was: EDD build error)

On Wed, Jun 27, 2007 at 03:32:58PM +0100, Alan Cox wrote: > On Wed, 27 Jun 2007 08:03:05 -0600 > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > On Wed, Jun 27, 2007 at 02:55:00PM +0100, Alan Cox wrote: > > > On Wed, 27 Jun 2007 05:30:48 -0600 > > > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > >

Re: pci.h stubs (was: EDD build error)

On Wed, 27 Jun 2007 08:03:05 -0600 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Wed, Jun 27, 2007 at 02:55:00PM +0100, Alan Cox wrote: > > On Wed, 27 Jun 2007 05:30:48 -0600 > > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > > pci_get_bus_and_slot() shouldn't be used because it fails to work on >

Re: pci.h stubs (was: EDD build error)

On Wed, Jun 27, 2007 at 02:55:00PM +0100, Alan Cox wrote: > On Wed, 27 Jun 2007 05:30:48 -0600 > Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > pci_get_bus_and_slot() shouldn't be used because it fails to work on > > systems with multiple domains. pci_get_slot() avoids this problem (and > > is much

Re: pci.h stubs (was: EDD build error)

On Wed, 27 Jun 2007 05:30:48 -0600 Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Tue, Jun 26, 2007 at 09:45:05PM -0500, Matt Domsch wrote: > > On Tue, Jun 26, 2007 at 01:26:22PM -0700, Randy Dunlap wrote: > > > ERROR: "pci_get_bus_and_slot" [drivers/firmware/edd.ko] undefined! > > > > It should

Re: pci.h stubs (was: EDD build error)

On Tue, Jun 26, 2007 at 09:45:05PM -0500, Matt Domsch wrote: > On Tue, Jun 26, 2007 at 01:26:22PM -0700, Randy Dunlap wrote: > > ERROR: "pci_get_bus_and_slot" [drivers/firmware/edd.ko] undefined! > > It should be stubbed, in include/linux/pci.h where all the other PCI > functions are stubbed for t

Re: EDD build error

On Wed, 27 Jun 2007 00:44:02 +0200 Torsten Duwe wrote: > On Wednesday 27 June 2007, Randy Dunlap wrote: > > > > From original email: > > (This is in 2.6.22-rc4-mm2 FWIW.) > > Sorry. This one should be better. > I've moved the edd_info, to avoid the -Wunused. Yes, that one works fine. Thanks. -

Re: EDD build error

On Wednesday 27 June 2007, Randy Dunlap wrote: > > From original email: > (This is in 2.6.22-rc4-mm2 FWIW.) Sorry. This one should be better. I've moved the edd_info, to avoid the -Wunused. Torsten --- linux-2.6.22-rc4-mm2/drivers/firmware/edd.c.orig 2007-06-27 00:36:45.0 +0200 ++

Re: EDD build error

On Wed, 27 Jun 2007 00:16:44 +0200 Torsten Duwe wrote: > On Tuesday 26 June 2007, Randy Dunlap wrote: > > > ERROR: "pci_get_bus_and_slot" [drivers/firmware/edd.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > > > Should EDD depend on PCI or should some parts of edd.c be stubbed? > > I'd s

Re: EDD build error

On Tuesday 26 June 2007, Randy Dunlap wrote: > ERROR: "pci_get_bus_and_slot" [drivers/firmware/edd.ko] undefined! > make[1]: *** [__modpost] Error 1 > > Should EDD depend on PCI or should some parts of edd.c be stubbed? I'd suggest to simply stub it, as attached (untested, as my crap-Awarded BIOS

EDD build error

Hi, CONFIG_EDD does not depend on PCI, but edd.c uses pci_* interface functions, resulting in: CC [M] drivers/firmware/edd.o drivers/firmware/edd.c: In function 'edd_get_pci_dev': drivers/firmware/edd.c:672: warning: implicit declaration of function 'pci_get_bus_and_slot' drivers/firmware/edd