Re: First kernel patch (optimization)

On 29 September 2015 at 14:51, Austin S Hemmelgarn wrote: > On 2015-09-26 09:28, Eric Curtin wrote: >> >> Hi Dimitry, >> >>> Is it Debian-derivative by any chance? Their capslock setup is wonky >>> because CapsLock key does no actually set up as a CapsLock but another >>> modifier. Also is it in

Re: First kernel patch (optimization)

On 2015-09-26 09:28, Eric Curtin wrote: Hi Dimitry, Is it Debian-derivative by any chance? Their capslock setup is wonky because CapsLock key does no actually set up as a CapsLock but another modifier. Also is it in X or is it on text console? Because X handles led state on its own... I'm on

Re: First kernel patch (optimization)

On 2015-09-26 09:28, Eric Curtin wrote: Hi Dimitry, Is it Debian-derivative by any chance? Their capslock setup is wonky because CapsLock key does no actually set up as a CapsLock but another modifier. Also is it in X or is it on text console? Because X handles led state on its own... I'm on

Re: First kernel patch (optimization)

On 29 September 2015 at 14:51, Austin S Hemmelgarn wrote: > On 2015-09-26 09:28, Eric Curtin wrote: >> >> Hi Dimitry, >> >>> Is it Debian-derivative by any chance? Their capslock setup is wonky >>> because CapsLock key does no actually set up as a CapsLock but another >>>

Re: First kernel patch (optimization)

On Mon, Sep 28, 2015 at 03:54:20AM -0300, Thiago Farina wrote: > And many maintainers of open source projects that I know off, are not > very welcome to cleanup patches, especially when the project is > mature. They just call it churn and turn it down. Then those are not very mature developers as

Re: First kernel patch (optimization)

On Sat, Sep 19, 2015 at 2:18 AM, Greg KH wrote: > On Fri, Sep 18, 2015 at 10:26:24PM -0400, Theodore Ts'o wrote: >> On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: >> > So don't take cleanup patches for your code, that's fine, and I totally >> > understand why _you_ don't want to do

Re: First kernel patch (optimization)

On Mon, Sep 28, 2015 at 03:54:20AM -0300, Thiago Farina wrote: > And many maintainers of open source projects that I know off, are not > very welcome to cleanup patches, especially when the project is > mature. They just call it churn and turn it down. Then those are not very mature developers as

Re: First kernel patch (optimization)

On Sat, Sep 19, 2015 at 2:18 AM, Greg KH wrote: > On Fri, Sep 18, 2015 at 10:26:24PM -0400, Theodore Ts'o wrote: >> On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: >> > So don't take cleanup patches for your code, that's fine, and I totally >> > understand why

Re: First kernel patch (optimization)

Hi Dimitry, > Is it Debian-derivative by any chance? Their capslock setup is wonky > because CapsLock key does no actually set up as a CapsLock but another > modifier. Also is it in X or is it on text console? Because X handles > led state on its own... I'm on Fedora 22. Yeah, you're correct X

Re: First kernel patch (optimization)

Hi Dimitry, > Is it Debian-derivative by any chance? Their capslock setup is wonky > because CapsLock key does no actually set up as a CapsLock but another > modifier. Also is it in X or is it on text console? Because X handles > led state on its own... I'm on Fedora 22. Yeah, you're correct X

Re: First kernel patch (optimization)

Hi Erik, > > Yeah, I'm still reading this email thread and learned lots from it. > I'm working on something more meaningful, but it's not going to be > ground breaking of course, there is a led on my capslock key on a new > machine I won at work that does not switch off properly after it is >

Re: First kernel patch (optimization)

Hi Erik, > > Yeah, I'm still reading this email thread and learned lots from it. > I'm working on something more meaningful, but it's not going to be > ground breaking of course, there is a led on my capslock key on a new > machine I won at work that does not switch off properly after it is >

Re: First kernel patch (optimization)

Am 20.09.2015 um 12:41 schrieb Alexander Holler: Am 20.09.2015 um 04:21 schrieb Theodore Ts'o: As far as what you want to do next, you have a personal "proof of concept" patch that seems to work well enough for you. Great! I'm sure you can keep using it for your own purposes. If you can

Re: First kernel patch (optimization)

Am 20.09.2015 um 12:41 schrieb Alexander Holler: Am 20.09.2015 um 04:21 schrieb Theodore Ts'o: As far as what you want to do next, you have a personal "proof of concept" patch that seems to work well enough for you. Great! I'm sure you can keep using it for your own purposes. If you can

Re: First kernel patch (optimization)

On 22 September 2015 at 18:38, Linus Torvalds wrote: > On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: >> My first kernel patch, hope I did everything correctly! Instead of calling >> strlen on every iteration of the for loop, just call it once instead and >> store in a variable. > > Heh.

Re: First kernel patch (optimization)

On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: > My first kernel patch, hope I did everything correctly! Instead of calling > strlen on every iteration of the for loop, just call it once instead and > store in a variable. Heh. Ok, that resulted in a rather long email thread. Anyway, I'd

Re: First kernel patch (optimization)

On 22 September 2015 at 18:38, Linus Torvalds wrote: > On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: >> My first kernel patch, hope I did everything correctly! Instead of calling >> strlen on every iteration of the for loop, just

Re: First kernel patch (optimization)

On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: > My first kernel patch, hope I did everything correctly! Instead of calling > strlen on every iteration of the for loop, just call it once instead and > store in a variable. Heh. Ok, that resulted in a rather long

Re: First kernel patch (optimization)

Am 21.09.2015 um 17:47 schrieb Austin S Hemmelgarn: On 2015-09-20 06:41, Alexander Holler wrote: Am 20.09.2015 um 04:21 schrieb Theodore Ts'o: On Sat, Sep 19, 2015 at 07:47:22PM +0200, Alexander Holler wrote: Again, I don't think that encryption is an alternative. Besides that there is

Re: First kernel patch (optimization)

Am 21.09.2015 um 17:47 schrieb Austin S Hemmelgarn: The problem I see with this argument is: 1. There's a lot of code in the kernel that wouldn't be merged today in the state it's in, this creates a false sense of what quality is expected for new code (BTRFS in particular comes to mind here).

Re: First kernel patch (optimization)

On 2015-09-20 06:41, Alexander Holler wrote: Am 20.09.2015 um 04:21 schrieb Theodore Ts'o: On Sat, Sep 19, 2015 at 07:47:22PM +0200, Alexander Holler wrote: Perhaps not so surprisingly, over a decade later, it is not currently at the top of the priority list of any of the current file system

Re: First kernel patch (optimization)

On 2015-09-20 06:41, Alexander Holler wrote: Am 20.09.2015 um 04:21 schrieb Theodore Ts'o: On Sat, Sep 19, 2015 at 07:47:22PM +0200, Alexander Holler wrote: Perhaps not so surprisingly, over a decade later, it is not currently at the top of the priority list of any of the current file system

Re: First kernel patch (optimization)

Am 21.09.2015 um 17:47 schrieb Austin S Hemmelgarn: The problem I see with this argument is: 1. There's a lot of code in the kernel that wouldn't be merged today in the state it's in, this creates a false sense of what quality is expected for new code (BTRFS in particular comes to mind here).

Re: First kernel patch (optimization)

Am 21.09.2015 um 17:47 schrieb Austin S Hemmelgarn: On 2015-09-20 06:41, Alexander Holler wrote: Am 20.09.2015 um 04:21 schrieb Theodore Ts'o: On Sat, Sep 19, 2015 at 07:47:22PM +0200, Alexander Holler wrote: Again, I don't think that encryption is an alternative. Besides that there is

Re: First kernel patch (optimization)

Am 20.09.2015 um 04:21 schrieb Theodore Ts'o: On Sat, Sep 19, 2015 at 07:47:22PM +0200, Alexander Holler wrote: Perhaps not so surprisingly, over a decade later, it is not currently at the top of the priority list of any of the current file system or VFS developers, as far as I know. One of

Re: First kernel patch (optimization)

Am 20.09.2015 um 04:21 schrieb Theodore Ts'o: On Sat, Sep 19, 2015 at 07:47:22PM +0200, Alexander Holler wrote: Perhaps not so surprisingly, over a decade later, it is not currently at the top of the priority list of any of the current file system or VFS developers, as far as I know. One of

Re: First kernel patch (optimization)

On Sat, Sep 19, 2015 at 07:47:22PM +0200, Alexander Holler wrote: > No. I don't want to lower the standards. Maybe in regard to silly style > stuff, but not in regard to code quality (and I mean real bugs like races, > deadlocks or such, and not if a line has more than 80 characters). I would >

Re: First kernel patch (optimization)

Am 19.09.2015 um 16:22 schrieb Theodore Ts'o: On Sat, Sep 19, 2015 at 02:52:06PM +0200, Alexander Holler wrote: I've recently posted a proof of concept for wiping files, or in other words to really delete files, And it was a disaster because if someone posts imperfect pathhes on this list,

Re: First kernel patch (optimization)

On Sat, Sep 19, 2015 at 02:52:06PM +0200, Alexander Holler wrote: > > I've recently posted a proof of concept for wiping files, or in other words > to really delete files, And it was a disaster because if someone posts > imperfect pathhes on this list, people have fun trying to eat you (because >

Re: First kernel patch (optimization)

Am 19.09.2015 um 14:52 schrieb Alexander Holler: Am 19.09.2015 um 07:18 schrieb Greg KH: I have been saying for years that we have a lack of real projects / tasks / ideas for people who are skilled, yet have no idea what to do. I know of well over a hundred people I have email addresses of

Re: First kernel patch (optimization)

Am 19.09.2015 um 07:18 schrieb Greg KH: I have been saying for years that we have a lack of real projects / tasks / ideas for people who are skilled, yet have no idea what to do. I know of well over a hundred people I have email addresses of that have asked me for these types of things, and

Re: First kernel patch (optimization)

On Fri, Sep 18, 2015 at 10:18:27PM -0700, Greg KH wrote: > And again, don't knock the basic whitespace patch. It is non-trivial, > see the tutorials for proof of that. > > And please, NEVER chide someone for contributing whitespace patches, > it's a sure way to ensure that this person never

Re: First kernel patch (optimization)

On Sat, Sep 19, 2015 at 07:47:22PM +0200, Alexander Holler wrote: > No. I don't want to lower the standards. Maybe in regard to silly style > stuff, but not in regard to code quality (and I mean real bugs like races, > deadlocks or such, and not if a line has more than 80 characters). I would >

Re: First kernel patch (optimization)

On Fri, Sep 18, 2015 at 10:18:27PM -0700, Greg KH wrote: > And again, don't knock the basic whitespace patch. It is non-trivial, > see the tutorials for proof of that. > > And please, NEVER chide someone for contributing whitespace patches, > it's a sure way to ensure that this person never

Re: First kernel patch (optimization)

Am 19.09.2015 um 07:18 schrieb Greg KH: I have been saying for years that we have a lack of real projects / tasks / ideas for people who are skilled, yet have no idea what to do. I know of well over a hundred people I have email addresses of that have asked me for these types of things, and

Re: First kernel patch (optimization)

Am 19.09.2015 um 14:52 schrieb Alexander Holler: Am 19.09.2015 um 07:18 schrieb Greg KH: I have been saying for years that we have a lack of real projects / tasks / ideas for people who are skilled, yet have no idea what to do. I know of well over a hundred people I have email addresses of

Re: First kernel patch (optimization)

On Sat, Sep 19, 2015 at 02:52:06PM +0200, Alexander Holler wrote: > > I've recently posted a proof of concept for wiping files, or in other words > to really delete files, And it was a disaster because if someone posts > imperfect pathhes on this list, people have fun trying to eat you (because >

Re: First kernel patch (optimization)

Am 19.09.2015 um 16:22 schrieb Theodore Ts'o: On Sat, Sep 19, 2015 at 02:52:06PM +0200, Alexander Holler wrote: I've recently posted a proof of concept for wiping files, or in other words to really delete files, And it was a disaster because if someone posts imperfect pathhes on this list,

Re: First kernel patch (optimization)

On Fri, Sep 18, 2015 at 10:26:24PM -0400, Theodore Ts'o wrote: > On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: > > So don't take cleanup patches for your code, that's fine, and I totally > > understand why _you_ don't want to do that. But to blow off the effort > > as being somehow

Re: First kernel patch (optimization)

On Fri, Sep 18, 2015 at 10:26:24PM -0400, Theodore Ts'o wrote: > On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: > > Rather, what concerns me is that we aren't pushing people to go > *beyond* cleanup patches. We have lots of tutorials about how to > create perfectly formed patches; but

Re: First kernel patch (optimization)

On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: > So don't take cleanup patches for your code, that's fine, and I totally > understand why _you_ don't want to do that. But to blow off the effort > as being somehow trivial and not worthy of us, that's totally missing > the point, and

Re: First kernel patch (optimization)

On 2015-09-18 05:31, Raymond Jennings wrote: On 09/18/15 00:42, Greg KH wrote: On Thu, Sep 17, 2015 at 11:12:51PM -0400, Theodore Ts'o wrote: On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: That isn't true. It helps the submitter understand the workflow and expectations. What

Re: First kernel patch (optimization)

On 09/18/15 00:42, Greg KH wrote: On Thu, Sep 17, 2015 at 11:12:51PM -0400, Theodore Ts'o wrote: On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: That isn't true. It helps the submitter understand the workflow and expectations. What you meant to say is that it doesn't help you.

Re: First kernel patch (optimization)

On Thu, Sep 17, 2015 at 11:12:51PM -0400, Theodore Ts'o wrote: > On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: > > > > That isn't true. It helps the submitter understand the workflow and > > expectations. What you meant to say is that it doesn't help you. > > > The problem is

Re: First kernel patch (optimization)

On Thu, Sep 17, 2015 at 11:12:51PM -0400, Theodore Ts'o wrote: > On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: > > > > That isn't true. It helps the submitter understand the workflow and > > expectations. What you meant to say is that it doesn't help you. > > > The problem is

Re: First kernel patch (optimization)

On 2015-09-18 05:31, Raymond Jennings wrote: On 09/18/15 00:42, Greg KH wrote: On Thu, Sep 17, 2015 at 11:12:51PM -0400, Theodore Ts'o wrote: On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: That isn't true. It helps the submitter understand the workflow and expectations. What

Re: First kernel patch (optimization)

On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: > So don't take cleanup patches for your code, that's fine, and I totally > understand why _you_ don't want to do that. But to blow off the effort > as being somehow trivial and not worthy of us, that's totally missing > the point, and

Re: First kernel patch (optimization)

On Fri, Sep 18, 2015 at 10:26:24PM -0400, Theodore Ts'o wrote: > On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: > > Rather, what concerns me is that we aren't pushing people to go > *beyond* cleanup patches. We have lots of tutorials about how to > create perfectly formed patches; but

Re: First kernel patch (optimization)

On Fri, Sep 18, 2015 at 10:26:24PM -0400, Theodore Ts'o wrote: > On Fri, Sep 18, 2015 at 12:42:48AM -0700, Greg KH wrote: > > So don't take cleanup patches for your code, that's fine, and I totally > > understand why _you_ don't want to do that. But to blow off the effort > > as being somehow

Re: First kernel patch (optimization)

On 09/18/15 00:42, Greg KH wrote: On Thu, Sep 17, 2015 at 11:12:51PM -0400, Theodore Ts'o wrote: On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: That isn't true. It helps the submitter understand the workflow and expectations. What you meant to say is that it doesn't help you.

Re: First kernel patch (optimization)

On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: > > That isn't true. It helps the submitter understand the workflow and > expectations. What you meant to say is that it doesn't help you. The problem is that workflow isn't the hard part. It's the part that can be taught most

RE: First kernel patch (optimization)

From: Jaime Arrocha > Sent: 17 September 2015 02:50 .. > One interesting observation I found was that in O0 and O2, it does make > a call to strlen while in O1 it calculates > the length of the string using: > You want an 'xor %rcx,%rcx' here. > repnz scas%es:(%rdi),%al > not

RE: First kernel patch (optimization)

From: Jaime Arrocha > Sent: 17 September 2015 02:50 .. > One interesting observation I found was that in O0 and O2, it does make > a call to strlen while in O1 it calculates > the length of the string using: > You want an 'xor %rcx,%rcx' here. > repnz scas%es:(%rdi),%al > not

Re: First kernel patch (optimization)

On Wed, Sep 16, 2015 at 01:26:51PM -0400, Josh Boyer wrote: > > That isn't true. It helps the submitter understand the workflow and > expectations. What you meant to say is that it doesn't help you. The problem is that workflow isn't the hard part. It's the part that can be taught most

Re: First kernel patch (optimization)

On 09/16/2015 07:56 AM, David Laight wrote: From: Austin S Hemmelgarn Sent: 16 September 2015 12:46 On 2015-09-15 20:09, Steve Calfee wrote: On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c

Re: First kernel patch (optimization)

On Wed, Sep 16, 2015 at 09:21:58PM +0100, Eric Curtin wrote: > On 16 September 2015 at 21:02, Greg KH wrote: > > On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: > >> Hi Greg, > >> > >> As I said in the subject of the mail (which I have been since told I > >> shouldn't have done

Re: First kernel patch (optimization)

On 16 September 2015 at 21:02, Greg KH wrote: > On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: >> Hi Greg, >> >> As I said in the subject of the mail (which I have been since told I >> shouldn't have done this), I'm a noob to kernel code. I tried to pick >> off something super

Re: First kernel patch (optimization)

On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: > Hi Greg, > > As I said in the subject of the mail (which I have been since told I > shouldn't have done this), I'm a noob to kernel code. I tried to pick > off something super simple to just see what the process of getting a > patch

Re: First kernel patch (optimization)

Hi Eric, First of all, thanks for your attempt and I really hope you haven't been totally discouraged from future participation. Getting a patch into the kernel is hard, but I'm pretty disappointed with the responses you've gotten so far. On Wed, Sep 16, 2015 at 12:40 PM, Theodore Ts'o wrote:

Re: First kernel patch (optimization)

On 09/16/15 09:40, Theodore Ts'o wrote: On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: Hi Greg, As I said in the subject of the mail (which I have been since told I shouldn't have done this), I'm a noob to kernel code. I tried to pick off something super simple to just see what

Re: First kernel patch (optimization)

On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: > Hi Greg, > > As I said in the subject of the mail (which I have been since told I > shouldn't have done this), I'm a noob to kernel code. I tried to pick > off something super simple to just see what the process of getting a > patch

Re: First kernel patch (optimization)

Hi Greg, As I said in the subject of the mail (which I have been since told I shouldn't have done this), I'm a noob to kernel code. I tried to pick off something super simple to just see what the process of getting a patch in is. Youtube videos and documentation only get you so far. >From

Re: First kernel patch (optimization)

On Wed, Sep 16, 2015 at 07:45:53AM -0400, Austin S Hemmelgarn wrote: > On 2015-09-15 20:09, Steve Calfee wrote: > >On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: > >>Signed-off-by: Eric Curtin > >> > >>diff --git a/tools/usb/usbip/src/usbip_detach.c >

RE: First kernel patch (optimization)

From: Austin S Hemmelgarn > Sent: 16 September 2015 12:46 > On 2015-09-15 20:09, Steve Calfee wrote: > > On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin > > wrote: > >> Signed-off-by: Eric Curtin > >> > >> diff --git a/tools/usb/usbip/src/usbip_detach.c > >> b/tools/usb/usbip/src/usbip_detach.c

Re: First kernel patch (optimization)

On 2015-09-15 20:09, Steve Calfee wrote: On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index 05c6d15..9db9d21 100644 --- a/tools/usb/usbip/src/usbip_detach.c +++

Re: First kernel patch (optimization)

On 2015-09-15 20:09, Steve Calfee wrote: On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index 05c6d15..9db9d21 100644 ---

Re: First kernel patch (optimization)

On Wed, Sep 16, 2015 at 07:45:53AM -0400, Austin S Hemmelgarn wrote: > On 2015-09-15 20:09, Steve Calfee wrote: > >On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: > >>Signed-off-by: Eric Curtin > >> > >>diff --git

RE: First kernel patch (optimization)

From: Austin S Hemmelgarn > Sent: 16 September 2015 12:46 > On 2015-09-15 20:09, Steve Calfee wrote: > > On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin > > wrote: > >> Signed-off-by: Eric Curtin > >> > >> diff --git

Re: First kernel patch (optimization)

On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: > Hi Greg, > > As I said in the subject of the mail (which I have been since told I > shouldn't have done this), I'm a noob to kernel code. I tried to pick > off something super simple to just see what the process of getting a > patch

Re: First kernel patch (optimization)

Hi Greg, As I said in the subject of the mail (which I have been since told I shouldn't have done this), I'm a noob to kernel code. I tried to pick off something super simple to just see what the process of getting a patch in is. Youtube videos and documentation only get you so far. >From

Re: First kernel patch (optimization)

On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: > Hi Greg, > > As I said in the subject of the mail (which I have been since told I > shouldn't have done this), I'm a noob to kernel code. I tried to pick > off something super simple to just see what the process of getting a > patch

Re: First kernel patch (optimization)

On 16 September 2015 at 21:02, Greg KH wrote: > On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: >> Hi Greg, >> >> As I said in the subject of the mail (which I have been since told I >> shouldn't have done this), I'm a noob to kernel code. I tried to pick

Re: First kernel patch (optimization)

On Wed, Sep 16, 2015 at 09:21:58PM +0100, Eric Curtin wrote: > On 16 September 2015 at 21:02, Greg KH wrote: > > On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: > >> Hi Greg, > >> > >> As I said in the subject of the mail (which I have been since told I >

Re: First kernel patch (optimization)

On 09/16/2015 07:56 AM, David Laight wrote: From: Austin S Hemmelgarn Sent: 16 September 2015 12:46 On 2015-09-15 20:09, Steve Calfee wrote: On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: Signed-off-by: Eric Curtin diff --git

Re: First kernel patch (optimization)

On 09/16/15 09:40, Theodore Ts'o wrote: On Wed, Sep 16, 2015 at 05:03:39PM +0100, Eric Curtin wrote: Hi Greg, As I said in the subject of the mail (which I have been since told I shouldn't have done this), I'm a noob to kernel code. I tried to pick off something super simple to just see what

Re: First kernel patch (optimization)

Hi Eric, First of all, thanks for your attempt and I really hope you haven't been totally discouraged from future participation. Getting a patch into the kernel is hard, but I'm pretty disappointed with the responses you've gotten so far. On Wed, Sep 16, 2015 at 12:40 PM, Theodore Ts'o

Re: First kernel patch (optimization)

On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: > Signed-off-by: Eric Curtin > > diff --git a/tools/usb/usbip/src/usbip_detach.c > b/tools/usb/usbip/src/usbip_detach.c > index 05c6d15..9db9d21 100644 > --- a/tools/usb/usbip/src/usbip_detach.c > +++ b/tools/usb/usbip/src/usbip_detach.c > @@

Re: First kernel patch (optimization)

On 09/15/2015 12:52 PM, Eric Curtin wrote: My first kernel patch, hope I did everything correctly! Instead of calling strlen on every iteration of the for loop, just call it once instead and store in a variable. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c

Re: First kernel patch (optimization)

On Tue, Sep 15, 2015 at 08:53:28PM +0100, Eric Curtin wrote: > My first kernel patch, hope I did everything correctly! Instead of calling > strlen on every iteration of the for loop, just call it once instead and > store in a variable. this should be broken up at 72 characters. Also, your

First kernel patch (optimization)

My first kernel patch, hope I did everything correctly! Instead of calling strlen on every iteration of the for loop, just call it once instead and store in a variable. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index

First kernel patch (optimization)

My first kernel patch, hope I did everything correctly! Instead of calling strlen on every iteration of the for loop, just call it once instead and store in a variable. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index

Re: First kernel patch (optimization)

On Tue, Sep 15, 2015 at 12:53 PM, Eric Curtin wrote: > Signed-off-by: Eric Curtin > > diff --git a/tools/usb/usbip/src/usbip_detach.c > b/tools/usb/usbip/src/usbip_detach.c > index 05c6d15..9db9d21 100644 > --- a/tools/usb/usbip/src/usbip_detach.c

Re: First kernel patch (optimization)

On 09/15/2015 12:52 PM, Eric Curtin wrote: My first kernel patch, hope I did everything correctly! Instead of calling strlen on every iteration of the for loop, just call it once instead and store in a variable. Signed-off-by: Eric Curtin diff --git

First kernel patch (optimization)

My first kernel patch, hope I did everything correctly! Instead of calling strlen on every iteration of the for loop, just call it once instead and store in a variable. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c

First kernel patch (optimization)

My first kernel patch, hope I did everything correctly! Instead of calling strlen on every iteration of the for loop, just call it once instead and store in a variable. Signed-off-by: Eric Curtin diff --git a/tools/usb/usbip/src/usbip_detach.c

Re: First kernel patch (optimization)

On Tue, Sep 15, 2015 at 08:53:28PM +0100, Eric Curtin wrote: > My first kernel patch, hope I did everything correctly! Instead of calling > strlen on every iteration of the for loop, just call it once instead and > store in a variable. this should be broken up at 72 characters. Also, your