Re: Fix ccp_run_passthru_cmd dma variable assignments

2014-02-09 Thread Herbert Xu
On Fri, Jan 24, 2014 at 02:17:12PM -0600, Tom Lendacky wrote: > On 01/24/2014 12:39 PM, Dave Jones wrote: > > There are some suspicious looking lines of code in the new ccp driver, > > including > > one that assigns a variable to itself, and another that overwrites a > > previous assignment. > >

Re: Fix ccp_run_passthru_cmd dma variable assignments

2014-01-24 Thread Tom Lendacky
On 01/24/2014 12:39 PM, Dave Jones wrote: > There are some suspicious looking lines of code in the new ccp driver, > including > one that assigns a variable to itself, and another that overwrites a previous > assignment. > > This may have been a cut-and-paste error where 'src' was forgotten to b

Fix ccp_run_passthru_cmd dma variable assignments

2014-01-24 Thread Dave Jones
There are some suspicious looking lines of code in the new ccp driver, including one that assigns a variable to itself, and another that overwrites a previous assignment. This may have been a cut-and-paste error where 'src' was forgotten to be changed to 'dst'. I have no hardware to test this, s