Hi,
On Fri, 2005-01-21 at 21:48, Andreas Gruenbacher wrote:
> Well, we could split EXT3_STATE_NEW into a "GOOD_OLD_NEW" flag for the
> first 128 bytes and a "BIG_INODE_NEW" flag for the rest, and only
> initialize the rest in the xattr code when necessary. Not any better it
> I suppose.
Agreed.
On Fri, 2005-01-21 at 22:36, Stephen C. Tweedie wrote:
> Ugh. It feels horrible to have to do this, but we _do_ want to clear
> the raw inode, and we only want to do it once, and we have to do it on
> first access to the on-disk structures. I can't see an easy way round
> it that doesn't add more
Hi,
On Thu, 2005-01-20 at 18:22, Andreas Gruenbacher wrote:
> When a new inode is created, ext3_new_inode sets the EXT3_STATE_NEW
> flag, which tells ext3_do_update_inode to zero out the inode before
> filling in the inode's data. When a file is created in a directory with
> a default acl, the ne
On Thu, 20 Jan 2005 20:09:24 +0100, Andreas Gruenbacher said:
> On Thu, 2005-01-20 at 19:56, [EMAIL PROTECTED] wrote:
> > [...] I'm failing to see how adding *another* zero operation [...] is going
> > to help the
> > fact [...]
>
> It's an ancient kernel hackers trick: ;)
> > + EXT3_I
On Thu, 2005-01-20 at 19:56, [EMAIL PROTECTED] wrote:
> [...] I'm failing to see how adding *another* zero operation [...] is going
> to help the
> fact [...]
It's an ancient kernel hackers trick: ;)
> + EXT3_I(inode)->i_state &= ~EXT3_STATE_NEW;
Regards,
--
Andreas Gruenbacher <[E
On Jan 20, 2005 13:56 -0500, [EMAIL PROTECTED] wrote:
> On Thu, 20 Jan 2005 19:22:25 +0100, Andreas Gruenbacher said:
> > ===
> > --- linux-2.6.11-latest.orig/fs/ext3/xattr.c
> > +++ linux-2.6.11-latest/fs/ext3/xattr.c
> > @@ -954,6 +
On Thu, 20 Jan 2005 19:22:25 +0100, Andreas Gruenbacher said:
> When a new inode is created, ext3_new_inode sets the EXT3_STATE_NEW
> flag, which tells ext3_do_update_inode to zero out the inode before
> filling in the inode's data. When a file is created in a directory with
> a default acl, the n
Hello,
here is another nastiness.
When a new inode is created, ext3_new_inode sets the EXT3_STATE_NEW
flag, which tells ext3_do_update_inode to zero out the inode before
filling in the inode's data. When a file is created in a directory with
a default acl, the new inode inherits the directory's d
8 matches
Mail list logo
