Re: Fix lapic time counter read for periodic mode

2013-08-20 Thread Paolo Bonzini
gt; > time >>>> > > > of the hires timer. If this difference is negative, the hires timer >>>> > > > expired. For oneshot mode this is correctly translated into a zero >>>> > > > value >>>> > > > for the t

Re: Fix lapic time counter read for periodic mode

2013-08-20 Thread Paolo Bonzini
must use the negative difference unmodified. regards Christian Fix lapic time counter read for periodic mode. In periodic mode the hrtimer is rearmed once expired, see apic_timer_fn. So _get_remaining should return proper value even if the guest

Re: Fix lapic time counter read for periodic mode

2012-11-13 Thread Marcelo Tosatti
e this is correctly translated into a zero value > > > for the time counter. However, in periodic mode we must use the negative > > > difference unmodified. > > > > > > regards Christian > > > > > > Fix lapic time counter read for periodic

Re: Fix lapic time counter read for periodic mode

2012-11-13 Thread Marcelo Tosatti
time counter read for periodic mode. In periodic mode the hrtimer is rearmed once expired, see apic_timer_fn. So _get_remaining should return proper value even if the guest is not able to process timer interrupts. Can you describe your specific scenario in more detail? In my

Re: Fix lapic time counter read for periodic mode

2012-11-12 Thread Christian Ehrhardt
d expiration time > > of the hires timer. If this difference is negative, the hires timer > > expired. For oneshot mode this is correctly translated into a zero value > > for the time counter. However, in periodic mode we must use the negative > > difference unmodified. > >

Re: Fix lapic time counter read for periodic mode

2012-11-12 Thread Marcelo Tosatti
ive, the hires timer > expired. For oneshot mode this is correctly translated into a zero value > for the time counter. However, in periodic mode we must use the negative > difference unmodified. > > regards Christian > > Fix lapic time counter read for periodic mode. In

Re: Fix lapic time counter read for periodic mode

2012-11-12 Thread Marcelo Tosatti
translated into a zero value for the time counter. However, in periodic mode we must use the negative difference unmodified. regards Christian Fix lapic time counter read for periodic mode. In periodic mode the hrtimer is rearmed once expired, see apic_timer_fn. So _get_remaining

Re: Fix lapic time counter read for periodic mode

2012-11-12 Thread Christian Ehrhardt
. For oneshot mode this is correctly translated into a zero value for the time counter. However, in periodic mode we must use the negative difference unmodified. regards Christian Fix lapic time counter read for periodic mode. In periodic mode the hrtimer is rearmed once expired

Fix lapic time counter read for periodic mode

2012-11-11 Thread Christian Ehrhardt
use the negative difference unmodified. regards Christian Fix lapic time counter read for periodic mode. Signed-off-by: Christian Ehrhardt diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 43e9fad..eff902d 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c

Fix lapic time counter read for periodic mode

2012-11-11 Thread Christian Ehrhardt
use the negative difference unmodified. regards Christian Fix lapic time counter read for periodic mode. Signed-off-by: Christian Ehrhardt l...@c--e.de diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 43e9fad..eff902d 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm