On Tue, 8 Mar 2005 22:55:37 +0100
Pavel Machek <[EMAIL PROTECTED]> wrote:
> Any idea what to do there? I'd say that request_irq is very unlikely
> to fail given that it worked okay before suspend...
What you have is fine for now.
It is just a general issue that ->resume() has no way to cleanly
Hi!
> > @@ -1934,6 +1936,9 @@
> > if (!netif_running(dev))
> > return 0;
> >
> > + if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev))
> > + printk(KERN_ERR PFX "%s: request_irq failed\n", dev->name);
> > +
>
> This is a hard error and means that
On Tue, 8 Mar 2005 10:46:55 +0100
Pavel Machek <[EMAIL PROTECTED]> wrote:
> @@ -1934,6 +1936,9 @@
> if (!netif_running(dev))
> return 0;
>
> + if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev))
> + printk(KERN_ERR PFX "%s: request_irq
Hi!
This should fix problems people have with b44 during
suspend/resume. Please apply,
Pavel
--- clean/drivers/net/b44.c 2004-12-25 13:35:00.0 +0100
+++ linux/drivers/net/b44.c 2005-01-19 11:59:12.0 +0100
@@
Hi!
This should fix problems people have with b44 during
suspend/resume. Please apply,
Pavel
--- clean/drivers/net/b44.c 2004-12-25 13:35:00.0 +0100
+++ linux/drivers/net/b44.c 2005-01-19 11:59:12.0 +0100
@@
On Tue, 8 Mar 2005 10:46:55 +0100
Pavel Machek [EMAIL PROTECTED] wrote:
@@ -1934,6 +1936,9 @@
if (!netif_running(dev))
return 0;
+ if (request_irq(dev-irq, b44_interrupt, SA_SHIRQ, dev-name, dev))
+ printk(KERN_ERR PFX %s: request_irq failed\n,
Hi!
@@ -1934,6 +1936,9 @@
if (!netif_running(dev))
return 0;
+ if (request_irq(dev-irq, b44_interrupt, SA_SHIRQ, dev-name, dev))
+ printk(KERN_ERR PFX %s: request_irq failed\n, dev-name);
+
This is a hard error and means that bringup of the chip
On Tue, 8 Mar 2005 22:55:37 +0100
Pavel Machek [EMAIL PROTECTED] wrote:
Any idea what to do there? I'd say that request_irq is very unlikely
to fail given that it worked okay before suspend...
What you have is fine for now.
It is just a general issue that -resume() has no way to cleanly
fail.
8 matches
Mail list logo