Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-23 Thread SF Markus Elfring
>> I am trying to improve various open issues also in Linux source files. >> > That the fact that you see issues (in these particular cases) while > others do not I guess that the discussed "story" affects more challenges in communication and different opinions about where to invest software devel

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-23 Thread Emil Velikov
On 23 September 2016 at 09:50, SF Markus Elfring wrote: >> Markus, please contact the list in advance in future before posting a bunch >> of patches that don't fix any problems. > > I am trying to improve various open issues also in Linux source files. > That the fact that you see issues (in these

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-23 Thread SF Markus Elfring
> Markus, please contact the list in advance in future before posting a bunch > of patches that don't fix any problems. I am trying to improve various open issues also in Linux source files. Unfortunately, some of the proposed changes might not fit to your software development attention at the mo

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-23 Thread SF Markus Elfring
> I will refrain from merging any more style/checkpatch/"code cleanup" > patches from Markus until we start getting real, tested, bug fixes. Can such a kind of feedback be also interpreted in the way that you insist to keep some weaknesses which I tried to point in the Linux source code out for an

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-23 Thread SF Markus Elfring
>> Would you like to discuss the statistics for my failure (or success) rate >> a bit more so that involved issues can be clarified in a constructive way? > > It should be that you target 20 bug fixes for each new regression > that you add. How do you think about to clarify any concrete "regressi

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-23 Thread Dave Airlie
On 23 September 2016 at 17:25, Sean Paul wrote: > On Thu, Sep 22, 2016 at 1:24 PM, Dan Carpenter > wrote: >> On Thu, Sep 22, 2016 at 03:11:25PM +0200, SF Markus Elfring wrote: >>> > If you restricted yourself to fixing bugs only then you would maybe fix >>> > more >>> > bugs than you introduce

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-23 Thread Sean Paul
On Thu, Sep 22, 2016 at 1:24 PM, Dan Carpenter wrote: > On Thu, Sep 22, 2016 at 03:11:25PM +0200, SF Markus Elfring wrote: >> > If you restricted yourself to fixing bugs only then you would maybe fix >> > more >> > bugs than you introduce but as it you are making the kernel worse. >> >> Would you

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread Dan Carpenter
On Thu, Sep 22, 2016 at 03:11:25PM +0200, SF Markus Elfring wrote: > > If you restricted yourself to fixing bugs only then you would maybe fix more > > bugs than you introduce but as it you are making the kernel worse. > > Would you like to discuss the statistics for my failure (or success) rate >

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread Gerd Hoffmann
On Do, 2016-09-22 at 19:16 +0200, SF Markus Elfring wrote: > > For starters make sure the patches land actually on the list. > > How do you think about to take another look at this update suggestion > also by the usual archive interfaces? > > * https://patchwork.kernel.org/patch/9344521/ > > *

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread SF Markus Elfring
> For starters make sure the patches land actually on the list. How do you think about to take another look at this update suggestion also by the usual archive interfaces? * https://patchwork.kernel.org/patch/9344521/ * https://lkml.kernel.org/r/ > Only the cover letter arrived here. Would y

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread Gerd Hoffmann
On Do, 2016-09-22 at 15:11 +0200, SF Markus Elfring wrote: > > Guys, please stop accepting patches from Markus! > > I would appreciate a bit more explanation for this request. For starters make sure the patches land actually on the list. Only the cover letter arrived here. cheers, Gerd

Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread SF Markus Elfring
> Guys, please stop accepting patches from Markus! I would appreciate a bit more explanation for this request. > Markus, you always introduce bugs. I find the wording "always" exaggerated. It can also happen that I make another programming mistake occasionally. > I have asked you over and ov

Re: [PATCH 2/4] GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread Dan Carpenter
Guys, please stop accepting patches from Markus! Markus, you always introduce bugs. I have asked you over and over to stop sending "cleanup patches" because you are not careful. If you restricted yourself to fixing bugs only then you would maybe fix more bugs than you introduce but as it you are

[PATCH 2/4] GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-21 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 21 Sep 2016 22:33:54 +0200 Move the assignments for three data structure members to the end so that they will only be performed if the desired resource allocations succeeded by this function. Signed-off-by: Markus Elfring --- drivers/gpu/drm/qxl/qxl_kms.c | 9 ++