Re: HPA patches

2007-04-13 Thread Alan Cox
> Pondering about this, it's ATA_LBA according to the docs, specifying > that the address is an LBA. This is true for some commands, but not all. It gets used for other stuff too. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED

Re: HPA patches

2007-04-12 Thread Kyle McMartin
On Fri, Mar 23, 2007 at 01:03:15PM -0700, Randy Dunlap wrote: > > It's 0x40. Its a "command dependant bit" - no useful name. > > dependent. OK, thanks. > Hi, Pondering about this, it's ATA_LBA according to the docs, specifying that the address is an LBA. Cheers, Kyle - To unsubscribe

Re: HPA patches

2007-03-28 Thread Kyle McMartin
On Wed, Mar 28, 2007 at 10:54:31PM +0100, Alan Cox wrote: > > Hm. I tried adding it in the eh code after ata_set_mode() in > > ata_eh_recover(), which alters the problem slightly - hpa_sectors is > > still 0, so the taskfile call is still failing, but now the system just > > stops at around the

Re: HPA patches

2007-03-28 Thread Matthew Garrett
On Wed, Mar 28, 2007 at 10:54:31PM +0100, Alan Cox wrote: > I wonder if the firmware is dying when we ask the disk to go zero sized > rather than erroring politely. I'm not sure hth HPA sectors can come back > as zero but we can be fairly sure 0 means "no HPA" in this case I guess ? No, it seems

Re: HPA patches

2007-03-28 Thread Alan Cox
> Hm. I tried adding it in the eh code after ata_set_mode() in > ata_eh_recover(), which alters the problem slightly - hpa_sectors is > still 0, so the taskfile call is still failing, but now the system just > stops at around the time that anything attempts to access sda with no > errors other

Re: HPA patches

2007-03-28 Thread Matthew Garrett
On Wed, Mar 28, 2007 at 10:57:54AM +0100, Alan Cox wrote: > Ok thanks. This is interesting as the only thing new it is doing is > asking for the HPA size. Does I think explain the problem however: Can > you move the HPA setting call to after the mode has been set and see if > that makes the proble

Re: HPA patches

2007-03-28 Thread Alan Cox
On Wed, 28 Mar 2007 01:08:52 +0100 Matthew Garrett <[EMAIL PROTECTED]> wrote: > On Fri, Mar 23, 2007 at 07:13:21PM +, Alan Cox wrote: > > For reference this is what I am currently using with 2.6.21-rc4-mm1 and > > it is working for all my test cases so far: Its basically Kyle's patch > > with

Re: HPA patches

2007-03-27 Thread Matthew Garrett
On Wed, Mar 28, 2007 at 01:08:52AM +0100, Matthew Garrett wrote: > ata3.01: ata_hpa_resize 1: sectors = 234441648, hpa_sectors = 0 ^ Does this just indicate the lack of an hpa? If so, the /* if no hpa, both should be equal */ comment

Re: HPA patches

2007-03-27 Thread Matthew Garrett
On Fri, Mar 23, 2007 at 07:13:21PM +, Alan Cox wrote: > For reference this is what I am currently using with 2.6.21-rc4-mm1 and > it is working for all my test cases so far: Its basically Kyle's patch > with a libata switch to turn it on/off and some minor fixups from > the original patch as po

Re: HPA patches

2007-03-26 Thread Jeff Garzik
Matthew Garrett wrote: On Fri, Mar 23, 2007 at 07:13:21PM +, Alan Cox wrote: +static int ata_ignore_hpa = 0; +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644); +MODULE_PARM_DESC(ignore_hpa, "Ignore HPA (0=off 1=on)"); I'm not sure I like the language here. "Ignore HPA" appears to

Re: HPA patches

2007-03-26 Thread Kyle McMartin
On Fri, Mar 23, 2007 at 07:13:21PM +, Alan Cox wrote: > For reference this is what I am currently using with 2.6.21-rc4-mm1 and > it is working for all my test cases so far: Its basically Kyle's patch > with a libata switch to turn it on/off and some minor fixups from > the original patch as po

Re: HPA patches

2007-03-23 Thread Chuck Ebbert
Alan Cox wrote: What is 0x40? can it be #defined (or enum-ed) instead of a magic value? please? (more of same below) >>> It's 0x40. Its a "command dependant bit" - no useful name. >> dependent. OK, thanks. > > IDE is a bit like that. I'm amazed some of the command flags arent in > la

Re: HPA patches

2007-03-23 Thread Matthew Garrett
On Fri, Mar 23, 2007 at 07:13:21PM +, Alan Cox wrote: > +static int ata_ignore_hpa = 0; > +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644); > +MODULE_PARM_DESC(ignore_hpa, "Ignore HPA (0=off 1=on)"); I'm not sure I like the language here. "Ignore HPA" appears to mean "Explicitly dis

Re: HPA patches

2007-03-23 Thread Alan Cox
On Fri, 23 Mar 2007 12:22:32 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Alan Cox <[EMAIL PROTECTED]> > Date: Fri, 23 Mar 2007 20:08:19 + > > > u64 is always unsigned long long (and its debug anyway) > > It's plain "unsigned long" on sparc64 and some other 64-bit platforms.

Re: HPA patches

2007-03-23 Thread Alan Cox
> > > What is 0x40? can it be #defined (or enum-ed) instead of a magic > > > value? please? (more of same below) > > > > It's 0x40. Its a "command dependant bit" - no useful name. > > dependent. OK, thanks. IDE is a bit like that. I'm amazed some of the command flags arent in latin. > Alrea

Re: HPA patches

2007-03-23 Thread Randy Dunlap
On Fri, 23 Mar 2007 20:08:19 + Alan Cox wrote: > > > +static int ata_ignore_hpa = 0; > > > > Don't init to 0. Not needed, bloats binary files. > > It'll be one for the final release 8) > > > > +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644); > > > +MODULE_PARM_DESC(ignore_hpa, "

Re: HPA patches

2007-03-23 Thread David Miller
From: Alan Cox <[EMAIL PROTECTED]> Date: Fri, 23 Mar 2007 20:08:19 + > u64 is always unsigned long long (and its debug anyway) It's plain "unsigned long" on sparc64 and some other 64-bit platforms. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: HPA patches

2007-03-23 Thread Alan Cox
> > +static int ata_ignore_hpa = 0; > > Don't init to 0. Not needed, bloats binary files. It'll be one for the final release 8) > > +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644); > > +MODULE_PARM_DESC(ignore_hpa, "Ignore HPA (0=off 1=on)"); > > So 1 = on = ignore, right? Yes. >

Re: HPA patches

2007-03-23 Thread Randy Dunlap
On Fri, 23 Mar 2007 19:13:21 + Alan Cox wrote: > For reference this is what I am currently using with 2.6.21-rc4-mm1 and > it is working for all my test cases so far: Its basically Kyle's patch > with a libata switch to turn it on/off and some minor fixups from > the original patch as posted >

HPA patches

2007-03-23 Thread Alan Cox
For reference this is what I am currently using with 2.6.21-rc4-mm1 and it is working for all my test cases so far: Its basically Kyle's patch with a libata switch to turn it on/off and some minor fixups from the original patch as posted diff -u --new-file --recursive --exclude-from /usr/src/exclu