Re: Help with reviewing dosfstools patches

2019-06-14 Thread Pali Rohár
On Friday 14 June 2019 17:45:20 Enrico Weigelt, metux IT consult wrote: > On 14.06.19 16:20, Enrico Weigelt, metux IT consult wrote: > > > > Currently working through your branches. Smells like they really deserve > a rebase and signed-off lines. Every patch/pull request is mean to be based on

Re: Help with reviewing dosfstools patches

2019-06-14 Thread Pali Rohár
On Friday 14 June 2019 07:30:52 Christoph Hellwig wrote: > On Fri, Jun 14, 2019 at 04:25:34PM +0200, Pali Rohár wrote: > > > Does the project already have a maillist ? > > > > No, there is no mailing list. Basically whole development is on github > > via github pull requests where are also put rev

Re: Help with reviewing dosfstools patches

2019-06-14 Thread Enrico Weigelt, metux IT consult
On 14.06.19 17:45, Enrico Weigelt, metux IT consult wrote: > On 14.06.19 16:20, Enrico Weigelt, metux IT consult wrote: > > > > Currently working through your branches. Smells like they really deserve > a rebase and signed-off lines. rebased/applied your patches and got test failures: XFAIL: c

Re: Help with reviewing dosfstools patches

2019-06-14 Thread Enrico Weigelt, metux IT consult
On 14.06.19 16:20, Enrico Weigelt, metux IT consult wrote: Currently working through your branches. Smells like they really deserve a rebase and signed-off lines. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering i...@metux.net -- +49-151-27565287

Re: Help with reviewing dosfstools patches

2019-06-14 Thread Christoph Hellwig
On Fri, Jun 14, 2019 at 04:25:34PM +0200, Pali Rohár wrote: > > Does the project already have a maillist ? > > No, there is no mailing list. Basically whole development is on github > via github pull requests where are also put review comments and where is > also whole discussion, including bug re

Re: Help with reviewing dosfstools patches

2019-06-14 Thread Pali Rohár
On Friday 14 June 2019 16:20:08 Enrico Weigelt, metux IT consult wrote: > On 14.06.19 12:25, Pali Rohár wrote: > > Hello! > > > > Can somebody help with reviewing existing patches / pull requests for > > dosfstools project? https://github.com/dosfstools/dosfstools/pulls > > I'll have a look at it

Re: Help with reviewing dosfstools patches

2019-06-14 Thread Enrico Weigelt, metux IT consult
On 14.06.19 12:25, Pali Rohár wrote: > Hello! > > Can somebody help with reviewing existing patches / pull requests for > dosfstools project? https://github.com/dosfstools/dosfstools/pulls I'll have a look at it. Could you perhaps prepare a (rebased) patch queue ? Does the project already have a

Help with reviewing dosfstools patches

2019-06-14 Thread Pali Rohár
Hello! Can somebody help with reviewing existing patches / pull requests for dosfstools project? https://github.com/dosfstools/dosfstools/pulls Dosfstools contains linux userspace utilities for FAT file filesystems, including mkfs and fsck. They are de-facto standard tools available in any linux