[PATCH bpf v3] bpf: fix unpopulated name_len field in perf_event link info

2024-10-03 Thread tyrone-wu
lse { @@ -3609,7 +3613,7 @@ static int bpf_perf_link_fill_kprobe(const struct perf_event *event, uname = u64_to_user_ptr(info->perf_event.kprobe.func_name); ulen = info->perf_event.kprobe.name_len; - err = bpf_perf_link_fill_common(event, uname, ulen, &offset, &

Re: [PATCH bpf v2] bpf: fix unpopulated name_len field in perf_event link info

2024-10-03 Thread Jiri Olsa
On Wed, Oct 02, 2024 at 09:38:39PM +, tyrone-wu wrote: > Previously when retrieving `bpf_link_info.perf_event` for > kprobe/uprobe/tracepoint, the `name_len` field was not populated by the > kernel, leaving it to reflect the value initially set by the user. This > behavior was inconsistent with

[syzbot] [net?] [virt?] INFO: rcu detected stall in schedule_tail (6)

2024-10-03 Thread syzbot
-assets/35f22e8643ee/bzImage-9852d85e.xz IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+4d2bdddae2e386601...@syzkaller.appspotmail.com rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { 0-...D } 2665 jiffies s: 1653 root: 0x1/. rcu

[PATCH bpf v2] bpf: fix unpopulated name_len field in perf_event link info

2024-10-02 Thread tyrone-wu
return err; } else { @@ -3609,7 +3613,7 @@ static int bpf_perf_link_fill_kprobe(const struct perf_event *event, uname = u64_to_user_ptr(info->perf_event.kprobe.func_name); ulen = info->perf_event.kprobe.name_len; - err = bpf_perf_link_fill_common(even

Re: [PATCH bpf] bpf: fix unpopulated name_len field in perf_event link info

2024-10-02 Thread Jiri Olsa
if (err) > return err; > } else { > @@ -3609,7 +3611,7 @@ static int bpf_perf_link_fill_kprobe(const struct > perf_event *event, > > uname = u64_to_user_ptr(info->perf_event.kprobe.func_name); > ulen = info->perf_event.kp

[PATCH bpf] bpf: fix unpopulated name_len field in perf_event link info

2024-09-30 Thread tyrone-wu
pf_copy_to_user(uname, buf, ulen, len); + err = bpf_copy_to_user(uname, buf, *ulen, len); if (err) return err; } else { @@ -3609,7 +3611,7 @@ static int bpf_perf_link_fill_kprobe(const struct perf_event *event, uname =

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-09-26 Thread Sami Tolvanen
On Thu, Sep 26, 2024 at 5:22 AM Christophe Leroy wrote: > > > > Le 26/09/2024 à 01:38, Matthew Maurer a écrit : > > Adds a new format for MODVERSIONS which stores each field in a separate > > ELF section. This initially adds support for variable length names, but > > could later be used to add add

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-09-26 Thread Christophe Leroy
Le 26/09/2024 à 01:38, Matthew Maurer a écrit : Adds a new format for MODVERSIONS which stores each field in a separate ELF section. This initially adds support for variable length names, but could later be used to add additional fields to MODVERSIONS in a backwards compatible way if needed. A

Re: [PATCH v4 14/16] modules: Support extended MODVERSIONS info

2024-09-25 Thread Matthew Maurer
t to me. > > Nit: might be cleaner in a single if statement though: > > /* Skip one leading dot */ > if (last == '\0' && str_seq[in] == '.') > in++; > > > +void modversion_ext_start(const struct load_info *info, &

[PATCH v5 16/16] export_report: Use new version info format

2024-09-25 Thread Matthew Maurer
The new version info format has a superset of symbols in the old format. Since this is a tool for in-tree modules, we don't need to parse the old one with this tool any longer. Signed-off-by: Matthew Maurer --- scripts/export_report.pl | 22 ++ 1 file changed, 10 inser

[PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-09-25 Thread Matthew Maurer
f2be83902..59959c21b205 100644 --- a/kernel/module/internal.h +++ b/kernel/module/internal.h @@ -86,6 +86,8 @@ struct load_info { unsigned int vers; unsigned int info; unsigned int pcpu; + unsigned int vers_ext_crc; +

Re: [PATCH v4 14/16] modules: Support extended MODVERSIONS info

2024-09-25 Thread Sami Tolvanen
might be cleaner in a single if statement though: /* Skip one leading dot */ if (last == '\0' && str_seq[in] == '.') in++; > +void modversion_ext_start(const struct load_info *info, > + struct modversion_inf

[PATCH v4 14/16] modules: Support extended MODVERSIONS info

2024-09-24 Thread Matthew Maurer
b/kernel/module/internal.h index daef2be83902..59959c21b205 100644 --- a/kernel/module/internal.h +++ b/kernel/module/internal.h @@ -86,6 +86,8 @@ struct load_info { unsigned int vers; unsigned int info; unsigned int pcpu; + unsigned int

Re: [syzbot] [virt?] [netfilter?] INFO: rcu detected stall in ip_list_rcv (6)

2024-09-14 Thread syzbot
syzbot suspects this issue was fixed by commit: commit e634134180885574d1fe7aa162777ba41e7fcd5b Author: Vladimir Oltean Date: Mon May 27 15:39:54 2024 + net/sched: taprio: make q->picos_per_byte available to fill_sched_entry() bisection log: https://syzkaller.appspot.com/x/bisect.txt

Re: [PATCH v3 14/16] modules: Support extended MODVERSIONS info

2024-08-19 Thread Michael Ellerman
Matthew Maurer writes: > On Fri, Aug 16, 2024 at 4:04 PM Michael Ellerman wrote: >> Matthew Maurer writes: >> > Adds a new format for MODVERSIONS which stores each field in a separate >> > ELF section. This initially adds support for variable length names, but >> > could later be used to add add

Re: [PATCH v3 14/16] modules: Support extended MODVERSIONS info

2024-08-19 Thread Matthew Maurer
On Fri, Aug 16, 2024 at 4:04 PM Michael Ellerman wrote: > > Matthew Maurer writes: > > Adds a new format for MODVERSIONS which stores each field in a separate > > ELF section. This initially adds support for variable length names, but > > could later be used to add additional fields to MODVERSION

Re: [syzbot] [kvm?] [net?] [virt?] INFO: task hung in __vhost_worker_flush

2024-08-19 Thread Mike Christie
On 8/16/24 1:17 PM, Michael S. Tsirkin wrote: > On Fri, Aug 16, 2024 at 11:10:32AM -0700, Sean Christopherson wrote: >> On Fri, Aug 16, 2024, syzbot wrote: On Wed, May 29, 2024, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:9b62e02e6336

Re: [PATCH v3 14/16] modules: Support extended MODVERSIONS info

2024-08-16 Thread Michael Ellerman
Matthew Maurer writes: > Adds a new format for MODVERSIONS which stores each field in a separate > ELF section. This initially adds support for variable length names, but > could later be used to add additional fields to MODVERSIONS in a > backwards compatible way if needed. Any new fields will be

Re: [syzbot] [kvm?] [net?] [virt?] INFO: task hung in __vhost_worker_flush

2024-08-16 Thread Michael S. Tsirkin
On Fri, Aug 16, 2024 at 11:10:32AM -0700, Sean Christopherson wrote: > On Fri, Aug 16, 2024, syzbot wrote: > > > On Wed, May 29, 2024, syzbot wrote: > > >> Hello, > > >> > > >> syzbot found the following issue on: > > >> > > >> HEAD commit:9b62e02e6336 Merge tag > > >> 'mm-hotfixes-stable-20

Re: [syzbot] [kvm?] [net?] [virt?] INFO: task hung in __vhost_worker_flush

2024-08-16 Thread Sean Christopherson
On Fri, Aug 16, 2024, syzbot wrote: > > On Wed, May 29, 2024, syzbot wrote: > >> Hello, > >> > >> syzbot found the following issue on: > >> > >> HEAD commit:9b62e02e6336 Merge tag > >> 'mm-hotfixes-stable-2024-05-25-09-1.. > >> git tree: upstream > >> console output: https://syzkaller.

Re: [syzbot] [kvm?] [net?] [virt?] INFO: task hung in __vhost_worker_flush

2024-08-16 Thread syzbot
> On Wed, May 29, 2024, syzbot wrote: >> Hello, >> >> syzbot found the following issue on: >> >> HEAD commit:9b62e02e6336 Merge tag 'mm-hotfixes-stable-2024-05-25-09-1.. >> git tree: upstream >> console output: https://syzkaller.appspot.com/x/log.txt?x=16cb0eec98 >> kernel config:

Re: [syzbot] [kvm?] [net?] [virt?] INFO: task hung in __vhost_worker_flush

2024-08-16 Thread Sean Christopherson
On Wed, May 29, 2024, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:9b62e02e6336 Merge tag 'mm-hotfixes-stable-2024-05-25-09-1.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=16cb0eec98 > kernel config: https://sy

[PATCH v4 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-08-15 Thread Avadhut Naik
st *node, *tmp; - struct mce *mce; head = llist_del_all(&mce_event_llist); if (!head) @@ -83,8 +83,8 @@ void mce_gen_pool_process(struct work_struct *__unused) head = llist_reverse_order(head); llist_for_each_entry_safe(node, tmp, head, llnode) {

Re: [PATCH v3 14/16] modules: Support extended MODVERSIONS info

2024-08-15 Thread Sami Tolvanen
Hi Matt, On Tue, Aug 6, 2024 at 9:25 PM Matthew Maurer wrote: > [...] > +void modversion_ext_start(const struct load_info *info, > + struct modversion_info_ext *start) > +{ > + unsigned int crc_idx = info->index.vers_ext_crc; > + unsigne

[PATCH v3 14/16] modules: Support extended MODVERSIONS info

2024-08-06 Thread Matthew Maurer
b/kernel/module/internal.h index daef2be83902..59959c21b205 100644 --- a/kernel/module/internal.h +++ b/kernel/module/internal.h @@ -86,6 +86,8 @@ struct load_info { unsigned int vers; unsigned int info; unsigned int pcpu; + unsigned int

Re: [PATCH v3 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-08-03 Thread kernel test robot
Hi Avadhut, kernel test robot noticed the following build warnings: [auto build test WARNING on dee974604f7870167161cbe51e8f3b9c2858de34] url: https://github.com/intel-lab-lkp/linux/commits/Avadhut-Naik/x86-mce-Add-wrapper-for-struct-mce-to-export-vendor-specific-info/20240801-192550 base

[PATCH v3 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-07-30 Thread Avadhut Naik
t *node, *tmp; - struct mce *mce; head = llist_del_all(&mce_event_llist); if (!head) @@ -83,8 +83,8 @@ void mce_gen_pool_process(struct work_struct *__unused) head = llist_reverse_order(head); llist_for_each_entry_safe(node, tmp, head, llnode) { -

Re: [PATCH] pwm: Make info in traces about affected pwm more useful

2024-07-30 Thread Uwe Kleine-König
On Tue, Jul 30, 2024 at 10:39:10AM -0400, Steven Rostedt wrote: > On Tue, 30 Jul 2024 09:22:53 +0200 > Uwe Kleine-König wrote: > > > I think the patch is obvious enough to be ok even without the tracing > > maintainer's blessing. I applied it to > > https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH] pwm: Make info in traces about affected pwm more useful

2024-07-30 Thread Steven Rostedt
On Tue, 30 Jul 2024 09:22:53 +0200 Uwe Kleine-König wrote: > I think the patch is obvious enough to be ok even without the tracing > maintainer's blessing. I applied it to > https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git > pwm/for-next > . No problem. Thanks for the Cc. I do

Re: [PATCH] pwm: Make info in traces about affected pwm more useful

2024-07-30 Thread Uwe Kleine-König
Hello, On Fri, Jul 05, 2024 at 11:14:51PM +0200, Uwe Kleine-König wrote: > The hashed pointer isn't useful to identify the pwm device. Instead > store and emit chipid and hwpwm. > > Signed-off-by: Uwe Kleine-König > --- > include/trace/events/pwm.h | 10 ++ > 1 file changed, 6 insertion

[PATCH] pwm: Make info in traces about affected pwm more useful

2024-07-05 Thread Uwe Kleine-König
The hashed pointer isn't useful to identify the pwm device. Instead store and emit chipid and hwpwm. Signed-off-by: Uwe Kleine-König --- include/trace/events/pwm.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/include/trace/events/pwm.h b/include/trace/events/pwm

Re: [PATCH v3] module: Add log info for verifying module signature

2024-06-28 Thread Luis Chamberlain
rt 'bad_signature.ko': Key was rejected by service > (linux) > > There have different logging behavior the bad signature case only log > in user-space, add log info for fatal errors in module_sig_check(). > > Signed-off-by: Yusong Gao > --- > V3: Clarify the message ty

[PATCH v3] module: Add log info for verifying module signature

2024-06-28 Thread Yusong Gao
nly log in user-space, add log info for fatal errors in module_sig_check(). Signed-off-by: Yusong Gao --- V3: Clarify the message type and the error code meaning. V2: Change print level from notice to debug. --- kernel/module/signing.c | 27 +++ 1 file changed, 27 insertions(

Re: [PATCH v2 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-06-26 Thread Borislav Petkov
On Wed, Jun 26, 2024 at 05:11:29PM +, Luck, Tony wrote: > > Tony, any comments? You ok with this, would that fit any Intel-specific > > vendor > > fields too or do you need some additional Intel-specific changes? > > It looks easy enough to add any Intel specific bits to the union later. > >

RE: [PATCH v2 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-06-26 Thread Luck, Tony
> Tony, any comments? You ok with this, would that fit any Intel-specific vendor > fields too or do you need some additional Intel-specific changes? It looks easy enough to add any Intel specific bits to the union later. Is there anyway that the trace event could be "smarter" about what vendor s

Re: [PATCH v2 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-06-26 Thread Borislav Petkov
On Tue, Jun 25, 2024 at 02:56:21PM -0500, Avadhut Naik wrote: > Currently, exporting new additional machine check error information > involves adding new fields for the same at the end of the struct mce. > This additional information can then be consumed through mcelog or > tracepoint. > > However

[PATCH v2 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-06-25 Thread Avadhut Naik
void mce_gen_pool_process(struct work_struct *__unused) { + struct mce_hw_err *err; struct llist_node *head; struct mce_evt_llist *node, *tmp; - struct mce *mce; head = llist_del_all(&mce_event_llist); if (!head) @@ -83,8 +83,8 @@ void mce_gen_pool_

Re: [syzbot] [usb?] [input?] INFO: task hung in __input_unregister_device (5)

2024-06-04 Thread syzbot
syzbot has bisected this issue to: commit 6b0b708f12d18f9cccfb1c418bea59fcbff8798c Author: Takashi Sakamoto Date: Wed May 1 07:32:38 2024 + firewire: core: add tracepoint event for handling bus reset bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14969a1698 start com

[PATCH 1/4] x86/mce: Add wrapper for struct mce to export vendor specific info

2024-05-30 Thread Avadhut Naik
d mce_gen_pool_process(struct work_struct *__unused) head = llist_reverse_order(head); llist_for_each_entry_safe(node, tmp, head, llnode) { - mce = &node->mce; - blocking_notifier_call_chain(&x86_mce_decoder_chain, 0, mce); + err

[PATCH v3 4/4] virtio_balloon: introduce memory scan/reclaim info

2024-04-22 Thread zhenwei pi
Expose memory scan/reclaim information to the host side via virtio balloon device. Now we have a metric to analyze the memory performance: y: counter increases n: counter does not changes h: the rate of counter change is high l: the rate of counter change is low OOM: VIRTIO_BALLOON_S_OOM_KILL ST

[PATCH v2 4/4] virtio_balloon: introduce memory scan/reclaim info

2024-04-22 Thread zhenwei pi
Expose memory scan/reclaim information to the host side via virtio balloon device. Now we have a metric to analyze the memory performance: y: counter increases n: counter does not changes h: the rate of counter change is high l: the rate of counter change is low OOM: VIRTIO_BALLOON_S_OOM_KILL ST

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-19 Thread Jonathan Cameron
On Fri, 5 Apr 2024 00:07:06 + "Ho-Ren (Jack) Chuang" wrote: > The current implementation treats emulated memory devices, such as > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > (E820_TYPE_RAM). However, these emulated devices have different > characteristics t

Re: [PATCH 3/3] virtio_balloon: introduce memory scan/reclaim info

2024-04-18 Thread David Hildenbrand
On 18.04.24 08:26, zhenwei pi wrote: Expose memory scan/reclaim information to the host side via virtio balloon device. Now we have a metric to analyze the memory performance: y: counter increases n: counter does not changes h: the rate of counter change is high l: the rate of counter change is

[PATCH 3/3] virtio_balloon: introduce memory scan/reclaim info

2024-04-17 Thread zhenwei pi
Expose memory scan/reclaim information to the host side via virtio balloon device. Now we have a metric to analyze the memory performance: y: counter increases n: counter does not changes h: the rate of counter change is high l: the rate of counter change is low OOM: VIRTIO_BALLOON_S_OOM_KILL ST

Re: [External] Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-17 Thread Ho-Ren (Jack) Chuang
to > > > > > > handle cases where memtype is not initialized and where HMAT > > > > > > information is > > > > > > available. > > > > > > > > > > > > * Introduce `default_memory_types` for those memory

Re: [RFC 3/3] virtio_balloon: introduce memory scan/reclaim info

2024-04-15 Thread David Hildenbrand
On 15.04.24 10:41, zhenwei pi wrote: Expose memory scan/reclaim information to the host side via virtio balloon device. Now we have a metric to analyze the memory performance: y: counter increases n: counter does not changes h: the rate of counter change is high l: the rate of counter change is

[RFC 3/3] virtio_balloon: introduce memory scan/reclaim info

2024-04-15 Thread zhenwei pi
Expose memory scan/reclaim information to the host side via virtio balloon device. Now we have a metric to analyze the memory performance: y: counter increases n: counter does not changes h: the rate of counter change is high l: the rate of counter change is low OOM: VIRTIO_BALLOON_S_OOM_KILL ST

Re: [External] Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-10 Thread Jonathan Cameron
information is > > > > > available. > > > > > > > > > > * Introduce `default_memory_types` for those memory types that are not > > > > > initialized by device drivers. > > > > > Because late initialized memory and de

Re: [External] Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-09 Thread Ho-Ren (Jack) Chuang
ed, > >> > a default memory type is created for storing all memory types that are > >> > not initialized by device drivers and as a fallback. > >> > > >> > Signed-off-by: Ho-Ren (Jack) Chuang > >> > Signed-off-by: Hao Xiang > >&g

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-09 Thread Huang, Ying
a fallback. >> > >> > Signed-off-by: Ho-Ren (Jack) Chuang >> > Signed-off-by: Hao Xiang >> > Reviewed-by: "Huang, Ying" >> >> Hi - one remaining question. Why can't we delay init for all nodes >> to either drivers or your fallback

Re: [External] Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-09 Thread Ho-Ren (Jack) Chuang
y device drivers. > > > > Because late initialized memory and default DRAM memory need to be > > > > managed, > > > > a default memory type is created for storing all memory types that are > > > > not initialized by device drivers and as a fallback

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-09 Thread Jonathan Cameron
-by: "Huang, Ying" > > > > Hi - one remaining question. Why can't we delay init for all nodes > > to either drivers or your fallback late_initcall code. > > It would be nice to reduce possible code paths. > > I try not to change too mu

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-05 Thread Ho-Ren (Jack) Chuang
nodes > to either drivers or your fallback late_initcall code. > It would be nice to reduce possible code paths. I try not to change too much of the existing code structure in this patchset. To me, postponing/moving all memory tier registrations to late_initcall() is another possible action it

Re: [PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-05 Thread Jonathan Cameron
On Fri, 5 Apr 2024 00:07:06 + "Ho-Ren (Jack) Chuang" wrote: > The current implementation treats emulated memory devices, such as > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > (E820_TYPE_RAM). However, these emulated devices have different > characteristics t

[PATCH v11 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-04 Thread Ho-Ren (Jack) Chuang
@@ static struct demotion_nodes *node_demotion __read_mostly; static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); +/* The lock is used to protect `default_dram_perf*` info and nid. */ +static DEFINE_MUTEX(default_dram_perf_lock); static bool default_dram_perf_error; static struct access_

Re: [External] Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-04 Thread Ho-Ren (Jack) Chuang
Hi Jonathan, Thank you! I will fix them and send a V11 soon. On Thu, Apr 4, 2024 at 6:37 AM Jonathan Cameron wrote: > > > > > > > @@ -858,7 +910,8 @@ static int __init memory_tier_init(void) > > > >* For now we can have 4 faster memory tiers with smaller > > > > adistance > > > >

Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-04 Thread Jonathan Cameron
> > > @@ -858,7 +910,8 @@ static int __init memory_tier_init(void) > > >* For now we can have 4 faster memory tiers with smaller adistance > > >* than default DRAM tier. > > >*/ > > > - default_dram_type = alloc_memory_type(MEMTIER_ADISTANCE_DRAM); > > > + default_

Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-03 Thread Ho-Ren (Jack) Chuang
node_memory_type_map node_memory_types[MAX_NUMNODES]; > > struct memory_dev_type *default_dram_type; > > > > @@ -108,6 +113,8 @@ static struct demotion_nodes *node_demotion > > __read_mostly; > > > > static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); > > >

Re: [PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-03 Thread Jonathan Cameron
t_dram_type; > > @@ -108,6 +113,8 @@ static struct demotion_nodes *node_demotion __read_mostly; > > static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); > > +/* The lock is used to protect `default_dram_perf*` info and nid. */ > +static DEFINE_MUTEX(default_dram_perf_lock); &

[PATCH v10 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-04-01 Thread Ho-Ren (Jack) Chuang
is used to protect `default_dram_perf*` info and nid. */ +static DEFINE_MUTEX(default_dram_perf_lock); static bool default_dram_perf_error; static struct access_coordinate default_dram_perf; static int default_dram_perf_ref_nid = NUMA_NO_NODE; @@ -505,7 +512,8 @@ static inline void __init_node_m

[PATCH v9 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-28 Thread Ho-Ren (Jack) Chuang
@@ static struct demotion_nodes *node_demotion __read_mostly; static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); +/* The lock is used to protect `default_dram_perf*` info and nid. */ +static DEFINE_MUTEX(default_dram_perf_lock); static bool default_dram_perf_error; static struct access_

Re: [External] Re: [PATCH v8 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-28 Thread Ho-Ren (Jack) Chuang
> > > > static DEFINE_MUTEX(memory_tier_lock); > > static LIST_HEAD(memory_tiers); > > +/* > > + * The list is used to store all memory types that are not created > > + * by a device driver. > > + */ > > +static LIST_HEAD(default_memory_types); > >

Re: [PATCH v8 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-28 Thread Huang, Ying
emory_dev_type *default_dram_type; > > @@ -108,6 +113,8 @@ static struct demotion_nodes *node_demotion __read_mostly; > > static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); > > +/* The lock is used to protect `default_dram_perf*` info and nid. */ > +stati

[PATCH v8 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-28 Thread Ho-Ren (Jack) Chuang
@@ static struct demotion_nodes *node_demotion __read_mostly; static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); +/* The lock is used to protect `default_dram_perf*` info and nid. */ +static DEFINE_MUTEX(default_dram_perf_lock); static bool default_dram_perf_error; static struct access_

Re: [External] Re: [PATCH v6 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-28 Thread Ho-Ren (Jack) Chuang
On Wed, Mar 27, 2024 at 6:37 PM Huang, Ying wrote: > > "Ho-Ren (Jack) Chuang" writes: > > [snip] > > > @@ -655,6 +672,34 @@ void mt_put_memory_types(struct list_head > > *memory_types) > > } > > EXPORT_SYMBOL_GPL(mt_put_memory_types); > > > > +/* > > + * This is invoked via `late_initcall()` t

Re: [PATCH v6 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-27 Thread Huang, Ying
"Ho-Ren (Jack) Chuang" writes: [snip] > @@ -655,6 +672,34 @@ void mt_put_memory_types(struct list_head *memory_types) > } > EXPORT_SYMBOL_GPL(mt_put_memory_types); > > +/* > + * This is invoked via `late_initcall()` to initialize memory tiers for > + * CPU-less memory nodes after driver init

[PATCH v6 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-27 Thread Ho-Ren (Jack) Chuang
*node_demotion __read_mostly; static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); +/* The lock is used to protect `default_dram_perf*` info and nid. */ +static DEFINE_MUTEX(default_dram_perf_lock); static bool default_dram_perf_error; static struct access_coordinate default_dram_perf; static

Re: [External] Re: [PATCH v5 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-26 Thread Ho-Ren (Jack) Chuang
ic DEFINE_MUTEX(memory_tier_lock); > > static LIST_HEAD(memory_tiers); > > +/* > > + * The list is used to store all memory types that are not created > > + * by a device driver. > > + */ > > +static LIST_HEAD(default_memory_types); > > static struct node_m

Re: [PATCH v5 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-26 Thread Huang, Ying
LIST_HEAD(memory_tiers); > +/* > + * The list is used to store all memory types that are not created > + * by a device driver. > + */ > +static LIST_HEAD(default_memory_types); > static struct node_memory_type_map node_memory_types[MAX_NUMNODES]; > struct memory_dev_type *default_dram_type; &

[PATCH v5 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-26 Thread Ho-Ren (Jack) Chuang
; static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); +/* The lock is used to protect `default_dram_perf*` info and nid. */ +static DEFINE_MUTEX(default_dram_perf_lock); static bool default_dram_perf_error; static struct access_coordinate default_dram_perf; static int

Re: [External] Re: [PATCH v4 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-25 Thread Ho-Ren (Jack) Chuang
.c > >> > +++ b/mm/memory-tiers.c > >> > @@ -36,6 +36,11 @@ struct node_memory_type_map { > >> > > >> > static DEFINE_MUTEX(memory_tier_lock); > >> > static LIST_HEAD(memory_tiers); > >> > +/* > >> > + * The list i

Re: [External] Re: [PATCH v4 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-25 Thread Huang, Ying
tatic LIST_HEAD(memory_tiers); >> > +/* >> > + * The list is used to store all memory types that are not created >> > + * by a device driver. >> > + */ >> > +static LIST_HEAD(default_memory_types); >> > static struct node_memory_type_map node_memory_typ

Re: [External] Re: [PATCH v4 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-22 Thread Ho-Ren (Jack) Chuang
s[MAX_NUMNODES]; > > struct memory_dev_type *default_dram_type; > > > > @@ -108,6 +113,7 @@ static struct demotion_nodes *node_demotion > > __read_mostly; > > > > static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); > > > > +static DEFINE_MUTEX(default_

Re: [PATCH v4 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-22 Thread Huang, Ying
"Ho-Ren (Jack) Chuang" writes: > The current implementation treats emulated memory devices, such as > CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory > (E820_TYPE_RAM). However, these emulated devices have different > characteristics than traditional DRAM, making it im

[PATCH v4 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-22 Thread Ho-Ren (Jack) Chuang
The current implementation treats emulated memory devices, such as CXL1.1 type3 memory, as normal DRAM when they are emulated as normal memory (E820_TYPE_RAM). However, these emulated devices have different characteristics than traditional DRAM, making it important to distinguish them. Thus, we mod

Re: [External] Re: [PATCH v3 1/2] memory tier: dax/kmem: create CPUless memory tiers after obtaining HMAT info

2024-03-20 Thread Ho-Ren (Jack) Chuang
mtype = default_dram_type; > pr_info("Failed to allocate a memory type. Fall > back.\n"); > } > } > Sounds good! I will do. > > + __init_node_memory_type(node, mtype); > > > > memtype = node_memory_typ

Re: [PATCH v3 1/2] memory tier: dax/kmem: create CPUless memory tiers after obtaining HMAT info

2024-03-20 Thread Huang, Ying
es) > +{ > + bool found = false; > + struct memory_dev_type *mtype; > + > + list_for_each_entry(mtype, memory_types, list) { > + if (mtype->adistance == adist) { > + found = true; > + break; > +

[PATCH v3 1/2] memory tier: dax/kmem: create CPUless memory tiers after obtaining HMAT info

2024-03-19 Thread Ho-Ren (Jack) Chuang
mtype = alloc_memory_type(adist); + if (!IS_ERR(mtype)) + list_add(&mtype->list, memory_types); + } + + return mtype; +} +EXPORT_SYMBOL_GPL(mt_find_alloc_memory_type); + +/* + * This is invoked via late_initcall() to create + * CPUless m

Re: [External] Re: [PATCH v2 1/1] memory tier: acpi/hmat: create CPUless memory tiers after obtaining HMAT info

2024-03-18 Thread Ho-Ren (Jack) Chuang
mory_tier_init() and late_initcall(memory_tier_late_init);? > > And this is the reason why you mention to exclude > > "node_memory_types[nid].memtype != NULL" in memory_tier_late_init(). > > Is my understanding correct? > > Yes. > Thanks. > >> > static DEFINE_MUTEX(target_lock); > >> >

Re: [External] Re: [PATCH v2 1/1] memory tier: acpi/hmat: create CPUless memory tiers after obtaining HMAT info

2024-03-14 Thread Huang, Ying
tanding correct? Yes. >> > static DEFINE_MUTEX(target_lock); >> > >> > /* >> > @@ -149,6 +151,12 @@ int acpi_get_genport_coordinates(u32 uid, >> > } >> > EXPORT_SYMBOL_NS_GPL(acpi_get_genport_coordinates, CXL); >> > >> > +struct

Re: [External] Re: [PATCH v2 1/1] memory tier: acpi/hmat: create CPUless memory tiers after obtaining HMAT info

2024-03-13 Thread Ho-Ren (Jack) Chuang
gt; } > > EXPORT_SYMBOL_NS_GPL(acpi_get_genport_coordinates, CXL); > > > > +struct memory_dev_type *hmat_find_alloc_memory_type(int adist) > > +{ > > + return find_alloc_memory_type(adist, &hmat_memory_types); > > +} > > +EXPORT_SYMBOL_GPL(hmat_find_alloc_me

Re: [PATCH v2 1/1] memory tier: acpi/hmat: create CPUless memory tiers after obtaining HMAT info

2024-03-12 Thread Huang, Ying
static __init void alloc_memory_initiator(unsigned int cpu_pxm) > { > struct memory_initiator *initiator; > @@ -1038,6 +1046,9 @@ static __init int hmat_init(void) > if (!hmat_set_default_dram_perf()) > register_mt_adistance_algorithm(&hmat_adist_nb);

[PATCH v2 1/1] memory tier: acpi/hmat: create CPUless memory tiers after obtaining HMAT info

2024-03-11 Thread Ho-Ren (Jack) Chuang
ator; @@ -1038,6 +1046,9 @@ static __init int hmat_init(void) if (!hmat_set_default_dram_perf()) register_mt_adistance_algorithm(&hmat_adist_nb); + /* Post-create CPUless memory tiers after getting HMAT info */ + memory_tier_late_init(); + return 0;

Re: INFO: rcu detected stall in nsim_fib_event_work

2024-02-03 Thread Hillf Danton
On Sat, 03 Feb 2024 14:16:16 +0800 Ubisectech Sirius > Hello. > We are Ubisectech Sirius Team, the vulnerability lab of China ValiantSec. > Recently, our team has discovered a issue in Linux kernel > 6.8.0-rc2-g6764c317b6bb. > Attached to the email were a POC file of the issue. Could you test if

INFO: rcu detected stall in idle_cull_fn

2024-02-02 Thread Ubisectech Sirius
Hello. We are Ubisectech Sirius Team, the vulnerability lab of China ValiantSec. Recently, our team has discovered a issue in Linux kernel 6.8.0-rc1-gecb1b8288dc7. Attached to the email were a POC file of the issue. Stack dump: rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks: { 1

INFO: rcu detected stall in nsim_fib_event_work

2024-02-02 Thread Ubisectech Sirius
Hello. We are Ubisectech Sirius Team, the vulnerability lab of China ValiantSec. Recently, our team has discovered a issue in Linux kernel 6.8.0-rc2-g6764c317b6bb. Attached to the email were a POC file of the issue. Stack dump: rcu: INFO: rcu_preempt detected expedited stalls on CPUs/tasks

[syzbot] [modules?] INFO: task hung in _vm_unmap_aliases (3)

2024-01-09 Thread syzbot
-assets/ac6cb620d377/zImage-610a9b8f.xz IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+fe8f8efd070d727de...@syzkaller.appspotmail.com INFO: task kworker/0:1:9 blocked for more than 450 seconds. Not tainted 6.7.0-rc8-syzkaller #0 "echo 0 &g

[PATCH v2 5/5] export_report: Use new version info format

2023-11-17 Thread Matthew Maurer
The new version info format has a superset of symbols in the old format. Since this is a tool for in-tree modules, we don't need to parse the old one with this tool any longer. Signed-off-by: Matthew Maurer --- scripts/export_report.pl | 22 ++ 1 file changed, 10 inser

[PATCH] ring-buffer: Fix bytes info in per_cpu buffer stats

2023-09-21 Thread Zheng Yejian
The 'bytes' info in file 'per_cpu/cpu/stats' means the number of bytes in cpu buffer that have not been consumed. However, currently after consuming data by reading file 'trace_pipe', the 'bytes' info was not changed as expected. # cat per_cpu/cpu0/

Re: [syzbot] INFO: task hung in perf_event_free_task

2021-04-20 Thread syzbot
een close() and fork()") INFO: task syz-executor890:6628 blocked for more than 143 seconds. Not tainted 5.12.0-rc8-syzkaller #0 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. task:syz-executor890 state:D stack:25968 pid: 6628 ppid: 8391 flags:0x000

Re: Re: [syzbot] INFO: rcu detected stall in tx

2021-04-20 Thread Greg Kroah-Hartman
On Mon, Apr 19, 2021 at 08:56:19PM +, Guido Kiener wrote: > Hi all, > > The error is in usbtmc_interrupt(struct urb *urb) since five years. The > status code EPROTO is not handled correctly. > It's not a showstopper, but we should fix it and check the status code > according to usbtmc_read_b

Re: [syzbot] INFO: task hung in __io_uring_cancel

2021-04-19 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: KASAN: null-ptr-deref Write in io_uring_cancel_sqpoll == BUG: KASAN: null-ptr-deref in instrument_atomic_read_write include/linux/instrume

Re: [syzbot] INFO: task hung in __io_uring_cancel

2021-04-19 Thread Pavel Begunkov
://syzkaller.appspot.com/x/log.txt?x=15b86f9ad0 > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+47fc00967b06a3019...@syzkaller.appspotmail.com > Fixes: d9d05217cb69 ("io_uring: stop SQPOLL submit on creator's death"

RE: Re: [syzbot] INFO: rcu detected stall in tx

2021-04-19 Thread Guido Kiener
an do it. @Greg: Is it urgent? - Guido -Original Message- From: Dmitry Sent: Monday, April 19, 2021 9:27 AM Subject: Re: [syzbot] INFO: rcu detected stall in tx On Mon, Apr 19, 2021 at 9:19 AM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD co

[syzbot] INFO: task hung in __io_uring_cancel

2021-04-19 Thread syzbot
https://syzkaller.appspot.com/x/log.txt?x=15b86f9ad0 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+47fc00967b06a3019...@syzkaller.appspotmail.com Fixes: d9d05217cb69 ("io_uring: stop SQPOLL submit on creator's death") INFO: task iou-sqp-8700:8

Re: [PATCH] rtl8xxxu: Fix device info for RTL8192EU devices

2021-04-19 Thread Pascal Terjan
On Mon, 19 Apr 2021 at 12:53, Jes Sorensen wrote: > > On 3/23/21 3:36 PM, Pascal Terjan wrote: > > Based on 2001:3319 and 2357:0109 which I used to test the fix and > > 0bda:818b and 2357:0108 for which I found efuse dumps online. > > > > == 2357:0109 == > > === Before === > > Vendor: Realtek > >

[PATCH v2 2/2] delayacct: add a proc file to dump the delay info

2021-04-19 Thread brookxu
From: Chunguang Xu Many distributions do not install the getdelay tool by default, similar to task_io_accounting, adding a proc file to make access easier. v2: Fix some errors prompted by the kernel test robot. Signed-off-by: Chunguang Xu Reported-by: kernel test robot --- fs/proc/base.c

[PATCH 5.4 15/73] lockdep: Add a missing initialization hint to the "INFO: Trying to register non-static key" message

2021-04-19 Thread Greg Kroah-Hartman
bool assign_lock_key(struct lockdep_map *lock) /* Debug-check: all keys must be persistent! */ debug_locks_off(); pr_err("INFO: trying to register non-static key.\n"); - pr_err("the code is fine but needs lockde

[PATCH 5.10 016/103] lockdep: Add a missing initialization hint to the "INFO: Trying to register non-static key" message

2021-04-19 Thread Greg Kroah-Hartman
bool assign_lock_key(struct lockdep_map *lock) /* Debug-check: all keys must be persistent! */ debug_locks_off(); pr_err("INFO: trying to register non-static key.\n"); - pr_err("the code is fine but needs lockde

[PATCH 5.11 020/122] lockdep: Add a missing initialization hint to the "INFO: Trying to register non-static key" message

2021-04-19 Thread Greg Kroah-Hartman
bool assign_lock_key(struct lockdep_map *lock) /* Debug-check: all keys must be persistent! */ debug_locks_off(); pr_err("INFO: trying to register non-static key.\n"); - pr_err("the code is fine but needs lockde

  1   2   3   4   5   6   7   8   9   10   >