Re: ISDN-Gigaset: Fine-tuning for three function implementations

2016-09-28 Thread Paul Bolle
On Wed, 2016-09-28 at 18:50 +0200, SF Markus Elfring wrote: > Would you like to look once more into an improved patch series for this > software module a bit later? I'm afraid I'm not looking forward to receiving an update of this series, sorry. Thanks, Paul Bolle

Re: ISDN-Gigaset: Fine-tuning for three function implementations

2016-09-28 Thread SF Markus Elfring
> Two of the five patches introduced bugs. The rest of the series isn't > free of various nits either. Of course, I was in no mood to be lenient > when I looked at those three patches. > > I won't take any of these patches, sorry. Would you like to look once more into an improved patch series for

Re: [PATCH 0/5] ISDN-Gigaset: Fine-tuning for three function implementations

2016-09-28 Thread Paul Bolle
On Mon, 2016-09-26 at 17:37 +0200, SF Markus Elfring wrote: > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): >   Use kmalloc_array() in two functions >   Improve another size determination in gigaset_initcs() >   Delete an error message

Re: ISDN-Gigaset: Fine-tuning for three function implementations

2016-09-26 Thread SF Markus Elfring
>> Use kmalloc_array() in two functions >> Improve another size determination in gigaset_initcs() >> Delete an error message for a failed memory allocation >> Release memory in gigaset_initcs() after an allocation failure > > Which "static source code analysis" was used for that discovery?

Re: [PATCH 0/5] ISDN-Gigaset: Fine-tuning for three function implementations

2016-09-26 Thread Paul Bolle
On Mon, 2016-09-26 at 17:37 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 26 Sep 2016 17:27:17 +0200 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): >   Use kmalloc_array() in two functions >   Improve another

[PATCH 0/5] ISDN-Gigaset: Fine-tuning for three function implementations

2016-09-26 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 26 Sep 2016 17:27:17 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (5): Use kmalloc_array() in two functions Improve another size determination in gigaset_initcs() Delete an error message for a failed