Re: Implement devicetree support for AB8500 Btemp

2012-09-12 Thread Rajanikanth HV
On Tuesday 11 September 2012 04:52 PM, Arnd Bergmann wrote: > On Tuesday 11 September 2012, Rajanikanth HV wrote: +Supplied-to: + This shall be power supply class dependency where in the >> runtime battery + properties will be shared across fuel guage and charging >> algori

Re: Implement devicetree support for AB8500 Btemp

2012-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2012, Rajanikanth HV wrote: > On Tuesday 11 September 2012 04:52 PM, Arnd Bergmann wrote: > > On Tuesday 11 September 2012, Rajanikanth HV wrote: > Consider: USB charging: > __ >| | > --(Vbus)-->| USB Char

Re: Implement devicetree support for AB8500 Btemp

2012-09-13 Thread Rajanikanth HV
On Wednesday 12 September 2012 09:06 PM, Arnd Bergmann wrote: > On Wednesday 12 September 2012, Rajanikanth HV wrote: >> On Tuesday 11 September 2012 04:52 PM, Arnd Bergmann wrote: >>> On Tuesday 11 September 2012, Rajanikanth HV wrote: > >> Consider: USB charging: >> ___

Re: Implement devicetree support for AB8500 Btemp

2012-09-13 Thread Arnd Bergmann
On Thursday 13 September 2012, Rajanikanth HV wrote: > On Wednesday 12 September 2012 09:06 PM, Arnd Bergmann wrote:> > > > If this is true, I don't understand what makes the 'supplied-to' > > properties you list in the device tree binding board specific. Are > > they not always done the same way?

Re: Implement devicetree support for AB8500 Btemp

2012-09-13 Thread Anton Vorontsov
(Thanks for Cc'ing me.) On Thu, Sep 13, 2012 at 02:37:38PM +, Arnd Bergmann wrote: [...] > > > If this is true, I don't understand what makes the 'supplied-to' > > > properties you list in the device tree binding board specific. Are > > > they not always done the same way? If so, you could jus

Re: Implement devicetree support for AB8500 Btemp

2012-09-14 Thread Arnd Bergmann
On Friday 14 September 2012, Anton Vorontsov wrote: > Power supply subsystem's supplied_to describes not just how driver > should notify other devices, supplied_to is more generic stuff, in terms > that it describes power supply hierarchy. It's like a directed graph, > e.g.: > >supplied_to

Re: Implement devicetree support for AB8500 Btemp

2012-09-14 Thread Rajanikanth HV
On Friday 14 September 2012 01:39 PM, Arnd Bergmann wrote: > On Friday 14 September 2012, Anton Vorontsov wrote: >> Power supply subsystem's supplied_to describes not just how driver >> should notify other devices, supplied_to is more generic stuff, in terms >> that it describes power supply hiera

Re: Implement devicetree support for AB8500 Btemp

2012-09-14 Thread Rajanikanth HV
On Thursday 13 September 2012 08:07 PM, Arnd Bergmann wrote: > On Thursday 13 September 2012, Rajanikanth HV wrote: >> On Wednesday 12 September 2012 09:06 PM, Arnd Bergmann wrote:> > >>> If this is true, I don't understand what makes the 'supplied-to' >>> properties you list in the device tree

mfd: Implement devicetree support for AB8500 Btemp

2012-09-10 Thread Rajanikanth HV
This patch adds device tree support for battery temperature monitor driver Signed-off-by: Rajanikanth H.V --- .../bindings/power_supply/ab8500/btemp.txt | 52 ++ arch/arm/boot/dts/dbx5x0.dtsi |8 + drivers/mfd/ab8500-core.c |1 +

Re: mfd: Implement devicetree support for AB8500 Btemp

2012-09-10 Thread Linus Walleij
On Mon, Sep 10, 2012 at 7:01 AM, Arnd Bergmann wrote: > On Monday 10 September 2012, Rajanikanth HV wrote: >> + thermister-internal-to-battery = <1>; >> + li_ion_9100_battery = <0>; > > Boolean properties should be empty when enabled and not present when > disabled. In

Re: mfd: Implement devicetree support for AB8500 Btemp

2012-09-11 Thread Arnd Bergmann
On Tuesday 11 September 2012, Rajanikanth HV wrote: > >> +Supplied-to: > >> + This shall be power supply class dependency where in the > runtime battery > >> + properties will be shared across fuel guage and charging > algorithm driver. > > > > I probably don't understand enough of this, bu

Re: mfd: Implement devicetree support for AB8500 Btemp

2012-09-10 Thread Arnd Bergmann
On Monday 10 September 2012, Rajanikanth HV wrote: > + > +supplied-to: > + This is a logical binding w.r.t power supply event change > + across energy-management-module drivers where in the > + runtime battery properties are shared along with uevent > + notification. > +

Re: mfd: Implement devicetree support for AB8500 Btemp

2012-09-15 Thread Francesco Lavra
On 09/10/2012 01:21 PM, Rajanikanth HV wrote: ... > -static int __devinit ab8500_btemp_probe(struct platform_device *pdev) > +static int __devinit > +btemp_of_probe(struct device *dev, > + struct device_node *np, > + struct abx500_bm_plat_data *bm_pdata) > { > - int irq

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-10 Thread Arnd Bergmann
On Tuesday 10 July 2012, Rajanikanth H.V wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/power_supply/ab8500/btemp.txt > @@ -0,0 +1,54 @@ > +AB8500 Battery Termperature Monitor Driver > + > +AB8500 is a mixed signal multimedia and power management > +device comprising: power and e

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-10 Thread Lee Jones
Some of my comments are picky, but if it's going into Mainline, it should at least look professional. You didn't CC the ST-Ericsson internal mailing list. Address is stericsson_nomadik_li...@list.st.com I'll do it for now, but please do so on your next submission. On 10/07/12 15:23, Rajanikan

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Rajanikanth HV
ect: Re: [PATCH] mfd: Implement devicetree support for AB8500 > Btemp > Message-ID: <4ffc563d.2080...@linaro.org> > Content-Type: text/plain; charset=UTF-8; format=flowed > > Some of my comments are picky, but if it's going into Mainline, it > should at least look profe

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Rajanikanth HV
> Date: Tue, 10 Jul 2012 14:12:01 + > From: Arnd Bergmann > To: linux-arm-ker...@lists.infradead.org > Cc: linaro-...@lists.linaro.org, linux-kernel@vger.kernel.org, > "Rajanikanth H.V" , patc...@linaro.org > Subject: Re: [PATCH] mfd: Implement d

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Lee Jones
@@ -964,11 +966,13 @@ static int __devinit ab8500_btemp_probe(struct platform_device *pdev) { int irq, i, ret = 0; u8 val; - struct abx500_bm_plat_data *plat_data = pdev->dev.platform_data; I already told you about this. your previous comment was: "No, it's meant to work w