Re: Infinite retries reading the partition table

2006-12-07 Thread James Bottomley
On Thu, 2006-12-07 at 11:14 -0800, Luben Tuikov wrote: > It is. If good_bytes=0 then nothing is up to date and uptodate should > be set to 0. That's not a correct assumption. Zero transfer commands, like TEST UNIT READY are perfectly happy to complete successfully with good_bytes == 0. > Look a

Re: Infinite retries reading the partition table

2006-12-07 Thread Luben Tuikov
--- James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2006-12-06 at 12:24 -0800, Luben Tuikov wrote: > > NEEDS_RETRY _does_ terminate, after it exhausts the retries. But since > > by the ASC value we know that no amount of retries is going to work, > > this chunk of the patch resolves it quicke

Re: Infinite retries reading the partition table

2006-12-07 Thread James Bottomley
On Wed, 2006-12-06 at 12:24 -0800, Luben Tuikov wrote: > NEEDS_RETRY _does_ terminate, after it exhausts the retries. But since > by the ASC value we know that no amount of retries is going to work, > this chunk of the patch resolves it quicker, i.e. eliminates the > "NEEDS_RETRY" pointless retrie

Re: Infinite retries reading the partition table

2006-12-06 Thread Luben Tuikov
--- James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2006-12-05 at 21:08 -0800, Andrew Morton wrote: > > case MEDIUM_ERROR: > > + if (sshdr.asc == 0x11 || /* UNRECOVERED READ ERR */ > > + sshdr.asc == 0x13 || /* AMNF DATA FIELD */ > > + sshdr.asc == 0x1

Re: Infinite retries reading the partition table

2006-12-06 Thread James Bottomley
On Tue, 2006-12-05 at 21:08 -0800, Andrew Morton wrote: > case MEDIUM_ERROR: > + if (sshdr.asc == 0x11 || /* UNRECOVERED READ ERR */ > + sshdr.asc == 0x13 || /* AMNF DATA FIELD */ > + sshdr.asc == 0x14) { /* RECORD NOT FOUND */ > +

Re: Infinite retries reading the partition table

2006-12-06 Thread Etienne . Vogt
On Thu, 30 Nov 2006, Andrew Morton wrote: That looks like it prevents the IO error. But why was an IO error causing an infinite loop? What piece of code was initiating the retries? Maybe it's related to the infinite domain validation retry loop problem I reported on linux-scsi a few weeks

Re: Infinite retries reading the partition table

2006-12-05 Thread Luben Tuikov
--- Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Tue, 5 Dec 2006 21:00:20 -0800 (PST) Luben Tuikov <[EMAIL PROTECTED]> > > wrote: > > --- Michael Reed <[EMAIL PROTECTED]> wrote: > > > Luben Tuikov wrote: > > > ...snip... > > > > This statement in scsi_io_completion() causes the infinite retry l

Re: Infinite retries reading the partition table

2006-12-05 Thread Andrew Morton
> On Tue, 5 Dec 2006 21:00:20 -0800 (PST) Luben Tuikov <[EMAIL PROTECTED]> > wrote: > --- Michael Reed <[EMAIL PROTECTED]> wrote: > > Luben Tuikov wrote: > > ...snip... > > > This statement in scsi_io_completion() causes the infinite retry loop: > > >if (scsi_end_request(cmd, 1, good_bytes, !!

Re: Infinite retries reading the partition table

2006-12-05 Thread Luben Tuikov
--- Michael Reed <[EMAIL PROTECTED]> wrote: > Luben Tuikov wrote: > ...snip... > > This statement in scsi_io_completion() causes the infinite retry loop: > >if (scsi_end_request(cmd, 1, good_bytes, !!result) == NULL) > > return; > > The code in 2.6.19 is "result==0", not "!!result", w

Re: Infinite retries reading the partition table

2006-12-05 Thread Michael Reed
Luben Tuikov wrote: ...snip... > This statement in scsi_io_completion() causes the infinite retry loop: >if (scsi_end_request(cmd, 1, good_bytes, !!result) == NULL) > return; The code in 2.6.19 is "result==0", not "!!result", which is logically the same as "result!=0". Did you mean

Re: Infinite retries reading the partition table

2006-12-01 Thread Luben Tuikov
--- Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 30 Nov 2006 22:34:57 -0800 (PST) > Luben Tuikov <[EMAIL PROTECTED]> wrote: > > > --- Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Wed, 29 Nov 2006 17:22:48 -0800 (PST) > > > Luben Tuikov <[EMAIL PROTECTED]> wrote: > > > > > > > Suppose r

Re: Infinite retries reading the partition table

2006-11-30 Thread Andrew Morton
On Thu, 30 Nov 2006 22:34:57 -0800 (PST) Luben Tuikov <[EMAIL PROTECTED]> wrote: > --- Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Wed, 29 Nov 2006 17:22:48 -0800 (PST) > > Luben Tuikov <[EMAIL PROTECTED]> wrote: > > > > > Suppose reading sector 0 always reports an error, > > > sense key HARD

Re: Infinite retries reading the partition table

2006-11-30 Thread Luben Tuikov
--- Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 29 Nov 2006 17:22:48 -0800 (PST) > Luben Tuikov <[EMAIL PROTECTED]> wrote: > > > Suppose reading sector 0 always reports an error, > > sense key HARDWARE ERROR. > > > > What I'm observing is that the request to read sector 0, > > reading part

Re: Infinite retries reading the partition table

2006-11-30 Thread Andrew Morton
On Wed, 29 Nov 2006 17:22:48 -0800 (PST) Luben Tuikov <[EMAIL PROTECTED]> wrote: > Suppose reading sector 0 always reports an error, > sense key HARDWARE ERROR. > > What I'm observing is that the request to read sector 0, > reading partition information, is retried forever, ad infinitum. > > Doe

Re: Infinite retries reading the partition table

2006-11-29 Thread Luben Tuikov
--- Luben Tuikov <[EMAIL PROTECTED]> wrote: > Suppose reading sector 0 always reports an error, > sense key HARDWARE ERROR. > > What I'm observing is that the request to read sector 0, > reading partition information, is retried forever, ad infinitum. > > Does anyone have a patch to resolve this

Infinite retries reading the partition table

2006-11-29 Thread Luben Tuikov
Suppose reading sector 0 always reports an error, sense key HARDWARE ERROR. What I'm observing is that the request to read sector 0, reading partition information, is retried forever, ad infinitum. Does anyone have a patch to resolve this? (2.6.19-rc6) Thanks, Luben - To unsubscribe from th