Re: Inlined functions in perf report

2016-12-21 Thread Steinar H. Gunderson
On Thu, Dec 22, 2016 at 06:56:28AM +0800, Jin, Yao wrote: > Could you see the inline if you use the addr2line command? For example, > addr2line -e -i I'm sorry, I don't have this profile anymore. I'll try again once we sort out the problems of the DWARF error messages everywhere. /* Steinar */

Re: Inlined functions in perf report

2016-12-21 Thread Jin, Yao
Could you see the inline if you use the addr2line command? For example, addr2line -e -i For example, in my case, root@skl:/home/jinyao/skl-ws/perf-dev/lck-2867/test# addr2line -e ./test2 -i 40052d /usr/include/x86_64-linux-gnu/bits/stdio2.h:104 /home/jinyao/skl-ws/perf-dev/lck-2867/test/tes

Re: Inlined functions in perf report

2016-12-21 Thread Steinar H. Gunderson
On Wed, Dec 21, 2016 at 11:09:42AM +0100, Milian Wolff wrote: > Just to check - did you really compile your code with frame pointers? By > default, that is not the case, and the above will try to do frame pointer > unwinding which will then fail. Put differently - do you any stack frames at > al

Re: Inlined functions in perf report

2016-12-21 Thread Milian Wolff
On Wednesday, December 21, 2016 10:58:23 AM CET Steinar H. Gunderson wrote: > On Wed, Dec 21, 2016 at 08:53:33AM +0800, Jin, Yao wrote: > > I just pull my repo with the latest perf/core branch, and apply the patch > > one by one (git am 0001/0002/.../0005), they can be applied. Maybe you > > have >

Re: Inlined functions in perf report

2016-12-21 Thread Steinar H. Gunderson
On Wed, Dec 21, 2016 at 08:53:33AM +0800, Jin, Yao wrote: > I just pull my repo with the latest perf/core branch, and apply the patch > one by one (git am 0001/0002/.../0005), they can be applied. Maybe you have > to do like that because the mails are probably coming out of order. OK. I applied ev

Re: Inlined functions in perf report

2016-12-20 Thread Jin, Yao
I just pull my repo with the latest perf/core branch, and apply the patch one by one (git am 0001/0002/.../0005), they can be applied. Maybe you have to do like that because the mails are probably coming out of order. (https://marc.info/?l=linux-kernel&m=148109315020127&w=2) 0001(https://

Re: Inlined functions in perf report

2016-12-20 Thread Steinar H. Gunderson
On Tue, Dec 20, 2016 at 11:37:46AM -0300, Arnaldo Carvalho de Melo wrote: >> Woot. Is this available in git somewhere? (Or if not, what do I apply it on >> top of?) > Normally you get it from tip, i.e. from: > > git//git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core I suppose perf/cor

Re: Inlined functions in perf report

2016-12-20 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 20, 2016 at 03:08:22PM +0100, Steinar H. Gunderson escreveu: > On Tue, Dec 20, 2016 at 10:54:50AM -0300, Arnaldo Carvalho de Melo wrote: > > Have you guys looked at this: > > > > http://lkml.kernel.org/r/1481121822-2537-1-git-send-email-yao@linux.intel.com > > > > I have to review

Re: Inlined functions in perf report

2016-12-20 Thread Milian Wolff
On Tuesday, December 20, 2016 2:43:41 PM CET Steinar H. Gunderson wrote: > On Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff wrote: > > It is not even possible with that, perf report is lacking the steps > > required to add inline frames - it will only add "real" frames it gets > > from either

Re: Inlined functions in perf report

2016-12-20 Thread Steinar H. Gunderson
On Tue, Dec 20, 2016 at 10:54:50AM -0300, Arnaldo Carvalho de Melo wrote: > Have you guys looked at this: > > http://lkml.kernel.org/r/1481121822-2537-1-git-send-email-yao@linux.intel.com > > I have to review it and maybe you will help me with that ;-) Woot. Is this available in git somewher

Re: Inlined functions in perf report

2016-12-20 Thread Milian Wolff
On Tuesday, December 20, 2016 10:54:50 AM CET Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff escreveu: > > On Tuesday, December 20, 2016 1:17:55 PM CET Peter Zijlstra wrote: > > > On Tue, Dec 20, 2016 at 12:59:54PM +0100, Steinar H. Gunderson wrote: > > > >

Re: Inlined functions in perf report

2016-12-20 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff escreveu: > On Tuesday, December 20, 2016 1:17:55 PM CET Peter Zijlstra wrote: > > On Tue, Dec 20, 2016 at 12:59:54PM +0100, Steinar H. Gunderson wrote: > > > FWIW, this is with perf from 4.10 (git as of a few days ago) and GCC > > > 6.2.1. > >

Re: Inlined functions in perf report

2016-12-20 Thread Steinar H. Gunderson
On Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff wrote: > It is not even possible with that, perf report is lacking the steps required > to add inline frames - it will only add "real" frames it gets from either of > the unwind libraries. > > I have a WIP patch available for this functional

Re: Inlined functions in perf report

2016-12-20 Thread Milian Wolff
On Tuesday, December 20, 2016 1:17:55 PM CET Peter Zijlstra wrote: > On Tue, Dec 20, 2016 at 12:59:54PM +0100, Steinar H. Gunderson wrote: > > Hi Peter, > > > > I can't find a good point of contact for perf, so I'm contacting you based > > on the MAINTAINERS file; feel free to redirect somewhere i

Inlined functions in perf report

2016-12-20 Thread Steinar H. Gunderson
Hi Peter, I can't find a good point of contact for perf, so I'm contacting you based on the MAINTAINERS file; feel free to redirect somewhere if you're not the right person. I'm trying to figure out how to deal with perf report when there are inlined functions; they don't generally seem to show u

Re: Inlined functions in perf report

2016-12-20 Thread Peter Zijlstra
On Tue, Dec 20, 2016 at 12:59:54PM +0100, Steinar H. Gunderson wrote: > Hi Peter, > > I can't find a good point of contact for perf, so I'm contacting you based on > the MAINTAINERS file; feel free to redirect somewhere if you're not the right > person. > Cc'ed linux-perf-us...@vger.kernel.org