Re: Inotify fails to send IN_ATTRIB events

2007-11-26 Thread Jan Kara
> This looks bad, though: > > include/linux/fsnotify.h:121: warning: passing argument 2 of > 'audit_inode_child' from incompatible pointer type > > Missing "->d_inode"? That's the difference between 2.6.22 and 2.6.24-git against which I wrote the patch :).

Re: Inotify fails to send IN_ATTRIB events

2007-11-26 Thread Jan Kara
This looks bad, though: include/linux/fsnotify.h:121: warning: passing argument 2 of 'audit_inode_child' from incompatible pointer type Missing -d_inode? That's the difference between 2.6.22 and 2.6.24-git against which I wrote the patch :).

Re: Inotify fails to send IN_ATTRIB events

2007-11-23 Thread Morten Welinder
This looks bad, though: include/linux/fsnotify.h:121: warning: passing argument 2 of 'audit_inode_child' from incompatible pointer type Missing "->d_inode"? M. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: Inotify fails to send IN_ATTRIB events

2007-11-23 Thread Morten Welinder
> With this patch I am seeing a endless stream of IN_IGNORED events > for a removed watch. Sorry, that problem was on the chair. side of the keyboard -- too much turkey, I fear. It just happened to be easier to trigger with the patch's double event on deletion. I'd still love to see ENOSYS when

Re: Inotify fails to send IN_ATTRIB events

2007-11-23 Thread Morten Welinder
This looks bad, though: include/linux/fsnotify.h:121: warning: passing argument 2 of 'audit_inode_child' from incompatible pointer type Missing -d_inode? M. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: Inotify fails to send IN_ATTRIB events

2007-11-23 Thread Morten Welinder
With this patch I am seeing a endless stream of IN_IGNORED events for a removed watch. Sorry, that problem was on the chair. side of the keyboard -- too much turkey, I fear. It just happened to be easier to trigger with the patch's double event on deletion. I'd still love to see ENOSYS when

Re: Inotify fails to send IN_ATTRIB events

2007-11-22 Thread Morten Welinder
> Wanna try the patch below? With this patch I am seeing a endless stream of IN_IGNORED events for a removed watch. I don't see a reason that user space should ever see any IN_IGNORED, but an endless steam is not good. Utterly unrelated, inotify does not work in /proc/. The list archives

Re: Inotify fails to send IN_ATTRIB events

2007-11-22 Thread Jan Kara
Hi, > I am seeing missing inotify IN_ATTRIB events in the following situation: > > 1. "touch foo" > > 2. Make inotify watch "foo" > > 3. "ln foo bar" >--> Link count changed so I should have gotten an IN_ATTRIB. > > 4. "rm foo" >--> Link count changed so I should have gotten an

Re: Inotify fails to send IN_ATTRIB events

2007-11-22 Thread Jan Kara
Hi, I am seeing missing inotify IN_ATTRIB events in the following situation: 1. touch foo 2. Make inotify watch foo 3. ln foo bar -- Link count changed so I should have gotten an IN_ATTRIB. 4. rm foo -- Link count changed so I should have gotten an IN_ATTRIB. (Or

Re: Inotify fails to send IN_ATTRIB events

2007-11-22 Thread Morten Welinder
Wanna try the patch below? With this patch I am seeing a endless stream of IN_IGNORED events for a removed watch. I don't see a reason that user space should ever see any IN_IGNORED, but an endless steam is not good. Utterly unrelated, inotify does not work in /proc/. The list archives

Inotify fails to send IN_ATTRIB events

2007-11-20 Thread Morten Welinder
I am seeing missing inotify IN_ATTRIB events in the following situation: 1. "touch foo" 2. Make inotify watch "foo" 3. "ln foo bar" --> Link count changed so I should have gotten an IN_ATTRIB. 4. "rm foo" --> Link count changed so I should have gotten an IN_ATTRIB. (Or IN_DELETE_SELF;

Inotify fails to send IN_ATTRIB events

2007-11-20 Thread Morten Welinder
I am seeing missing inotify IN_ATTRIB events in the following situation: 1. touch foo 2. Make inotify watch foo 3. ln foo bar -- Link count changed so I should have gotten an IN_ATTRIB. 4. rm foo -- Link count changed so I should have gotten an IN_ATTRIB. (Or IN_DELETE_SELF; I don't