On Tue, Apr 21, 2015 at 10:50:15PM -0700, Christoph Hellwig wrote:
> On Mon, Apr 20, 2015 at 05:55:07PM +0200, Jan Kara wrote:
> > > Is that a good idea to export these symbols, given that lustre may be
> > > the only user?
> > Yes, it is a good idea.
>
> It was if lustre was in core code and
On Tue, Apr 21, 2015 at 10:50:15PM -0700, Christoph Hellwig wrote:
On Mon, Apr 20, 2015 at 05:55:07PM +0200, Jan Kara wrote:
Is that a good idea to export these symbols, given that lustre may be
the only user?
Yes, it is a good idea.
It was if lustre was in core code and these
On Mon, Apr 20, 2015 at 05:55:07PM +0200, Jan Kara wrote:
> > Is that a good idea to export these symbols, given that lustre may be
> > the only user?
> Yes, it is a good idea.
It was if lustre was in core code and these idiotic ioctls were something
we had to live with.
But lustre is in
Hi,
On Mon, Apr 20, 2015 at 05:55:07PM +0200, Jan Kara wrote:
> On Fri 17-04-15 20:35:30, Boqun Feng wrote:
> > Hi Al,
> >
> >
> > I'm trying to clean that part of code you mentioned, and I found I have
> > to export the symbols 'getname' and 'putname' as follow to replace that
> > __getname()
Hi,
On Mon, Apr 20, 2015 at 05:55:07PM +0200, Jan Kara wrote:
On Fri 17-04-15 20:35:30, Boqun Feng wrote:
Hi Al,
I'm trying to clean that part of code you mentioned, and I found I have
to export the symbols 'getname' and 'putname' as follow to replace that
__getname() caller:
On Mon, Apr 20, 2015 at 05:55:07PM +0200, Jan Kara wrote:
Is that a good idea to export these symbols, given that lustre may be
the only user?
Yes, it is a good idea.
It was if lustre was in core code and these idiotic ioctls were something
we had to live with.
But lustre is in staging
On Fri 17-04-15 20:35:30, Boqun Feng wrote:
> Hi Al,
>
> On Sun, Apr 12, 2015 at 02:13:18AM +0100, Al Viro wrote:
> >
> > BTW, looking at the __getname() callers... Lustre one sure as hell looks
> > bogus:
> > char *tmp = __getname();
> >
> > if (!tmp)
> >
On Fri 17-04-15 20:35:30, Boqun Feng wrote:
Hi Al,
On Sun, Apr 12, 2015 at 02:13:18AM +0100, Al Viro wrote:
BTW, looking at the __getname() callers... Lustre one sure as hell looks
bogus:
char *tmp = __getname();
if (!tmp)
return
On Fri, Apr 17, 2015 at 08:35:30PM +0800, Boqun Feng wrote:
> Hi Al,
>
> On Sun, Apr 12, 2015 at 02:13:18AM +0100, Al Viro wrote:
> >
> > BTW, looking at the __getname() callers... Lustre one sure as hell looks
> > bogus:
> > char *tmp = __getname();
> >
> > if (!tmp)
> >
Hi Al,
On Sun, Apr 12, 2015 at 02:13:18AM +0100, Al Viro wrote:
>
> BTW, looking at the __getname() callers... Lustre one sure as hell looks
> bogus:
> char *tmp = __getname();
>
> if (!tmp)
> return ERR_PTR(-ENOMEM);
>
> len = strncpy_from_user(tmp,
Hi Al,
On Sun, Apr 12, 2015 at 02:13:18AM +0100, Al Viro wrote:
BTW, looking at the __getname() callers... Lustre one sure as hell looks
bogus:
char *tmp = __getname();
if (!tmp)
return ERR_PTR(-ENOMEM);
len = strncpy_from_user(tmp, filename,
On Fri, Apr 17, 2015 at 08:35:30PM +0800, Boqun Feng wrote:
Hi Al,
On Sun, Apr 12, 2015 at 02:13:18AM +0100, Al Viro wrote:
BTW, looking at the __getname() callers... Lustre one sure as hell looks
bogus:
char *tmp = __getname();
if (!tmp)
return
12 matches
Mail list logo
