Re: Is try_module_get buggy?

2008-01-23 Thread rmingming
> Hi rminming, > > try_module_get is designed to ensure that you don't call a function inside a > module without a reference. Like any reference function, it cannot handle > the case where the argument is invalid (or invalidated partway through the > call). > > In this case, the module pointer is

Re: Is try_module_get buggy?

2008-01-16 Thread Rusty Russell
On Saturday 12 January 2008 15:35:27 rmingming wrote: > Hi, > I have a problem about the try_module_get function, I don't know if > someone removed the module just AFTER line 372, then what happens? Because > in this situation, the variable module will be incorrect, and > module_is_live function

Re: Is try_module_get buggy?

2008-01-16 Thread Rusty Russell
On Saturday 12 January 2008 15:35:27 rmingming wrote: Hi, I have a problem about the try_module_get function, I don't know if someone removed the module just AFTER line 372, then what happens? Because in this situation, the variable module will be incorrect, and module_is_live function will

Is try_module_get buggy?

2008-01-11 Thread rmingming
Hi, I have a problem about the try_module_get function, I don't know if someone removed the module just AFTER line 372, then what happens? Because in this situation, the variable module will be incorrect, and module_is_live function will lead to unpredicatable behaviour. 368 static inline int

Is try_module_get buggy?

2008-01-11 Thread rmingming
Hi, I have a problem about the try_module_get function, I don't know if someone removed the module just AFTER line 372, then what happens? Because in this situation, the variable module will be incorrect, and module_is_live function will lead to unpredicatable behaviour. 368 static inline int