Re: Is usb_hcd_giveback_urb() allowed in task context?

2020-10-06 Thread Andrey Konovalov
On Tue, Oct 6, 2020 at 3:23 AM Alan Stern wrote: > > On Mon, Oct 05, 2020 at 05:38:22PM -0600, Shuah Khan wrote: > > On 10/5/20 9:25 AM, Alan Stern wrote: > > > On Mon, Oct 05, 2020 at 05:21:30PM +0200, Andrey Konovalov wrote: > > > No, no -- it won't work right if it's called in process context.

Re: Is usb_hcd_giveback_urb() allowed in task context?

2020-10-05 Thread Alan Stern
On Mon, Oct 05, 2020 at 05:38:22PM -0600, Shuah Khan wrote: > On 10/5/20 9:25 AM, Alan Stern wrote: > > On Mon, Oct 05, 2020 at 05:21:30PM +0200, Andrey Konovalov wrote: > > No, no -- it won't work right if it's called in process context. Not > > only do the spinlock calls leave the interrupt

Re: Is usb_hcd_giveback_urb() allowed in task context?

2020-10-05 Thread Shuah Khan
On 10/5/20 9:25 AM, Alan Stern wrote: On Mon, Oct 05, 2020 at 05:21:30PM +0200, Andrey Konovalov wrote: On Mon, Oct 5, 2020 at 5:18 PM Greg Kroah-Hartman wrote: On Mon, Oct 05, 2020 at 05:08:11PM +0200, Andrey Konovalov wrote: Dear USB and USB/IP maintainers, While fuzzing the USB/IP stack

Re: Is usb_hcd_giveback_urb() allowed in task context?

2020-10-05 Thread Greg Kroah-Hartman
On Mon, Oct 05, 2020 at 11:22:18AM -0400, Alan Stern wrote: > On Mon, Oct 05, 2020 at 05:08:11PM +0200, Andrey Konovalov wrote: > > Dear USB and USB/IP maintainers, > > > > While fuzzing the USB/IP stack with syzkaller we've stumbled upon an issue. > > > > Currently kcov (the subsystem that is

Re: Is usb_hcd_giveback_urb() allowed in task context?

2020-10-05 Thread Alan Stern
On Mon, Oct 05, 2020 at 05:21:30PM +0200, Andrey Konovalov wrote: > On Mon, Oct 5, 2020 at 5:18 PM Greg Kroah-Hartman > wrote: > > > > On Mon, Oct 05, 2020 at 05:08:11PM +0200, Andrey Konovalov wrote: > > > Dear USB and USB/IP maintainers, > > > > > > While fuzzing the USB/IP stack with syzkaller

Re: Is usb_hcd_giveback_urb() allowed in task context?

2020-10-05 Thread Alan Stern
On Mon, Oct 05, 2020 at 05:08:11PM +0200, Andrey Konovalov wrote: > Dear USB and USB/IP maintainers, > > While fuzzing the USB/IP stack with syzkaller we've stumbled upon an issue. > > Currently kcov (the subsystem that is used for coverage collection) > USB-related callbacks assume that

Re: Is usb_hcd_giveback_urb() allowed in task context?

2020-10-05 Thread Andrey Konovalov
On Mon, Oct 5, 2020 at 5:18 PM Greg Kroah-Hartman wrote: > > On Mon, Oct 05, 2020 at 05:08:11PM +0200, Andrey Konovalov wrote: > > Dear USB and USB/IP maintainers, > > > > While fuzzing the USB/IP stack with syzkaller we've stumbled upon an issue. > > > > Currently kcov (the subsystem that is

Re: Is usb_hcd_giveback_urb() allowed in task context?

2020-10-05 Thread Greg Kroah-Hartman
On Mon, Oct 05, 2020 at 05:08:11PM +0200, Andrey Konovalov wrote: > Dear USB and USB/IP maintainers, > > While fuzzing the USB/IP stack with syzkaller we've stumbled upon an issue. > > Currently kcov (the subsystem that is used for coverage collection) > USB-related callbacks assume that

Is usb_hcd_giveback_urb() allowed in task context?

2020-10-05 Thread Andrey Konovalov
Dear USB and USB/IP maintainers, While fuzzing the USB/IP stack with syzkaller we've stumbled upon an issue. Currently kcov (the subsystem that is used for coverage collection) USB-related callbacks assume that usb_hcd_giveback_urb() can only be called from interrupt context, as indicated by the