Re: KMSAN: uninit-value in alauda_check_media

2019-10-14 Thread Andrey Konovalov
On Fri, Oct 11, 2019 at 5:06 PM Greg Kroah-Hartman wrote: > > On Fri, Oct 11, 2019 at 10:53:47AM -0400, Alan Stern wrote: > > On Fri, 11 Oct 2019, Andrey Konovalov wrote: > > > > > On Fri, Oct 11, 2019 at 4:08 PM Alan Stern > > > wrote: > > > > > > Now yes, it's true that defining status as an

Re: KMSAN: uninit-value in alauda_check_media

2019-10-11 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KMSAN: uninit-value in alauda_check_media = BUG: KMSAN: uninit-value in alauda_transport+0x462/0x57f0 drivers/usb/storage/alauda.c:1138 CPU: 1 PID

Re: KMSAN: uninit-value in alauda_check_media

2019-10-11 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KMSAN: uninit-value in sd_revalidate_disk = BUG: KMSAN: uninit-value in check_disk_change+0x423/0x4b0 fs/block_dev.c:1499 CPU: 1 PID: 23508 Comm:

Re: KMSAN: uninit-value in alauda_check_media

2019-10-11 Thread Greg Kroah-Hartman
On Fri, Oct 11, 2019 at 10:53:47AM -0400, Alan Stern wrote: > On Fri, 11 Oct 2019, Andrey Konovalov wrote: > > > On Fri, Oct 11, 2019 at 4:08 PM Alan Stern > > wrote: > > > > Now yes, it's true that defining status as an array on the stack is > > > also a bug, since USB transfer buffers are

Re: KMSAN: uninit-value in alauda_check_media

2019-10-11 Thread Alan Stern
On Fri, 11 Oct 2019, Andrey Konovalov wrote: > On Fri, Oct 11, 2019 at 4:08 PM Alan Stern wrote: > > Now yes, it's true that defining status as an array on the stack is > > also a bug, since USB transfer buffers are not allowed to be stack > > variables. > > Hi Alan, > > I'm curious, what is

Re: KMSAN: uninit-value in alauda_check_media

2019-10-11 Thread Andrey Konovalov
On Fri, Oct 11, 2019 at 4:08 PM Alan Stern wrote: > > On Fri, 11 Oct 2019, Jaskaran Singh wrote: > > > On Mon, 2019-10-07 at 12:39 -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:1e76a3e5 kmsan: replace __GFP_NO_KMSAN_SHADOW with > >

Re: KMSAN: uninit-value in alauda_check_media

2019-10-11 Thread Alan Stern
On Fri, 11 Oct 2019, Jaskaran Singh wrote: > On Mon, 2019-10-07 at 12:39 -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:1e76a3e5 kmsan: replace __GFP_NO_KMSAN_SHADOW with > > kmsan_i.. > > git tree: https://github.com/google/kmsan.git

Re: KMSAN: uninit-value in alauda_check_media

2019-10-11 Thread Alexander Potapenko
On Fri, Oct 11, 2019 at 1:23 PM Jaskaran Singh wrote: > > On Mon, 2019-10-07 at 12:39 -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:1e76a3e5 kmsan: replace __GFP_NO_KMSAN_SHADOW with > > kmsan_i.. > > git tree:

Re: KMSAN: uninit-value in alauda_check_media

2019-10-11 Thread Jaskaran Singh
On Mon, 2019-10-07 at 12:39 -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:1e76a3e5 kmsan: replace __GFP_NO_KMSAN_SHADOW with > kmsan_i.. > git tree: https://github.com/google/kmsan.git master > console output: >

Re: KMSAN: uninit-value in alauda_check_media

2019-10-11 Thread Jas K
Hi, just taking a crack at this. Hope you guys don't mind. #syz test: https://github.com/google/kasan.git 1e76a3e5 diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c index ddab2cd3d2e7..bb309b9ad65b 100644 --- a/drivers/usb/storage/alauda.c +++

Re: Re: KMSAN: uninit-value in alauda_check_media

2019-10-11 Thread syzbot
Hi, just taking a crack at this. Hope you guys don't mind. #syz test: https://github.com/google/kasan.git 1e76a3e5 KMSAN bugs can only be tested on https://github.com/google/kmsan.git tree because KMSAN tool is not upstreamed yet. See https://goo.gl/tpsmEJ#kmsan-bugs for details. diff

KMSAN: uninit-value in alauda_check_media

2019-10-07 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1e76a3e5 kmsan: replace __GFP_NO_KMSAN_SHADOW with kmsan_i.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=1204cc6360 kernel config: