Re: Kconfig warnings on latest GIT

2007-05-23 Thread Johannes Berg
On Wed, 2007-05-23 at 09:14 -0500, Kumar Gala wrote: > On Wed, 23 May 2007, Johannes Berg wrote: > > > On Wed, 2007-05-23 at 07:37 -0500, Kumar Gala wrote: > > > > > Was my patch ok, if so I'll push it up through my git tree to paul? > > > > Yeah, looks fine to me, or will the ARCH=ppc folks then

Re: Kconfig warnings on latest GIT

2007-05-23 Thread Kumar Gala
On Wed, 23 May 2007, Johannes Berg wrote: > On Wed, 2007-05-23 at 07:37 -0500, Kumar Gala wrote: > > > Was my patch ok, if so I'll push it up through my git tree to paul? > > Yeah, looks fine to me, or will the ARCH=ppc folks then scream and want > that added to the Kconfig there as well? I

Re: Kconfig warnings on latest GIT

2007-05-23 Thread Johannes Berg
On Wed, 2007-05-23 at 07:37 -0500, Kumar Gala wrote: > Was my patch ok, if so I'll push it up through my git tree to paul? Yeah, looks fine to me, or will the ARCH=ppc folks then scream and want that added to the Kconfig there as well? johannes signature.asc Description: This is a digitally

Re: Kconfig warnings on latest GIT

2007-05-23 Thread Kumar Gala
On May 14, 2007, at 11:25 AM, Johannes Berg wrote: On Mon, 2007-05-14 at 09:24 -0500, Kumar Gala wrote: this was my fix which looks pretty much the same. [...] Great, thanks. johannes Was my patch ok, if so I'll push it up through my git tree to paul? - k - To unsubscribe from this

Re: Kconfig warnings on latest GIT

2007-05-23 Thread Kumar Gala
On May 14, 2007, at 11:25 AM, Johannes Berg wrote: On Mon, 2007-05-14 at 09:24 -0500, Kumar Gala wrote: this was my fix which looks pretty much the same. [...] Great, thanks. johannes Was my patch ok, if so I'll push it up through my git tree to paul? - k - To unsubscribe from this

Re: Kconfig warnings on latest GIT

2007-05-23 Thread Johannes Berg
On Wed, 2007-05-23 at 07:37 -0500, Kumar Gala wrote: Was my patch ok, if so I'll push it up through my git tree to paul? Yeah, looks fine to me, or will the ARCH=ppc folks then scream and want that added to the Kconfig there as well? johannes signature.asc Description: This is a digitally

Re: Kconfig warnings on latest GIT

2007-05-23 Thread Kumar Gala
On Wed, 23 May 2007, Johannes Berg wrote: On Wed, 2007-05-23 at 07:37 -0500, Kumar Gala wrote: Was my patch ok, if so I'll push it up through my git tree to paul? Yeah, looks fine to me, or will the ARCH=ppc folks then scream and want that added to the Kconfig there as well? I can't

Re: Kconfig warnings on latest GIT

2007-05-23 Thread Johannes Berg
On Wed, 2007-05-23 at 09:14 -0500, Kumar Gala wrote: On Wed, 23 May 2007, Johannes Berg wrote: On Wed, 2007-05-23 at 07:37 -0500, Kumar Gala wrote: Was my patch ok, if so I'll push it up through my git tree to paul? Yeah, looks fine to me, or will the ARCH=ppc folks then scream and

Re: Kconfig warnings on latest GIT

2007-05-14 Thread Johannes Berg
On Mon, 2007-05-14 at 09:24 -0500, Kumar Gala wrote: > this was my fix which looks pretty much the same. [...] Great, thanks. johannes signature.asc Description: This is a digitally signed message part

Re: Kconfig warnings on latest GIT

2007-05-14 Thread Kumar Gala
On Mon, 14 May 2007, Johannes Berg wrote: > Simon, > > > I don't think that this is quite right, or at least it isn't quite the > > same as before. > > Yeah, I think you're right. > > > I think that was is below will toggle > > SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected, > > which

Re: Kconfig warnings on latest GIT

2007-05-14 Thread Johannes Berg
Simon, > I don't think that this is quite right, or at least it isn't quite the > same as before. Yeah, I think you're right. > I think that was is below will toggle > SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected, > which I think is what you want. Is it also neccessary to > add a

Re: Kconfig warnings on latest GIT

2007-05-14 Thread Johannes Berg
Simon, I don't think that this is quite right, or at least it isn't quite the same as before. Yeah, I think you're right. I think that was is below will toggle SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected, which I think is what you want. Is it also neccessary to add a

Re: Kconfig warnings on latest GIT

2007-05-14 Thread Kumar Gala
On Mon, 14 May 2007, Johannes Berg wrote: Simon, I don't think that this is quite right, or at least it isn't quite the same as before. Yeah, I think you're right. I think that was is below will toggle SYS_SUPPORTS_APM_EMULATION when PMAC_APM_EMU is selected, which I think is what

Re: Kconfig warnings on latest GIT

2007-05-14 Thread Johannes Berg
On Mon, 2007-05-14 at 09:24 -0500, Kumar Gala wrote: this was my fix which looks pretty much the same. [...] Great, thanks. johannes signature.asc Description: This is a digitally signed message part

Re: Kconfig warnings on latest GIT

2007-05-13 Thread Simon Horman
On Fri, May 11, 2007 at 01:45:37PM +0200, Johannes Berg wrote: > On Fri, 2007-05-11 at 10:22 +0900, Simon Horman wrote: > > > Actually, it was with ARCH=ia64. I have a feeling that you can get > > it to show up quite easily with anything other than ARCH=powerpc. > > Ick, I didn't know that

Re: Kconfig warnings on latest GIT

2007-05-13 Thread Simon Horman
On Fri, May 11, 2007 at 01:45:37PM +0200, Johannes Berg wrote: On Fri, 2007-05-11 at 10:22 +0900, Simon Horman wrote: Actually, it was with ARCH=ia64. I have a feeling that you can get it to show up quite easily with anything other than ARCH=powerpc. Ick, I didn't know that

Re: Kconfig warnings on latest GIT

2007-05-11 Thread Timur Tabi
Russell King wrote: You might also want to fix the other stupidity with this. See my message on this very subject ("select is evil: another reason" from May 9th on lkml.) I submitted a patch yesterday which includes both fixes. Apparently, it's already in the -mm tree. - To unsubscribe

Re: Kconfig warnings on latest GIT

2007-05-11 Thread Johannes Berg
On Fri, 2007-05-11 at 10:22 +0900, Simon Horman wrote: > Actually, it was with ARCH=ia64. I have a feeling that you can get > it to show up quite easily with anything other than ARCH=powerpc. Ick, I didn't know that drivers/macintosh was now included for all arches! Hmm. That's a bit of a

Re: Kconfig warnings on latest GIT

2007-05-11 Thread Russell King
On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: > On Fri, 11 May 2007, Simon Horman wrote: > > > On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: > > > Simon Horman wrote: > > > > > > >>So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and > > >

Re: Kconfig warnings on latest GIT

2007-05-11 Thread Russell King
On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: On Fri, 11 May 2007, Simon Horman wrote: On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: Simon Horman wrote: So my question is: in which Kconfig do I define UCC_FAST_TEMP and UCC_SLOW_TEMP? At first I

Re: Kconfig warnings on latest GIT

2007-05-11 Thread Johannes Berg
On Fri, 2007-05-11 at 10:22 +0900, Simon Horman wrote: Actually, it was with ARCH=ia64. I have a feeling that you can get it to show up quite easily with anything other than ARCH=powerpc. Ick, I didn't know that drivers/macintosh was now included for all arches! Hmm. That's a bit of a problem.

Re: Kconfig warnings on latest GIT

2007-05-11 Thread Timur Tabi
Russell King wrote: You might also want to fix the other stupidity with this. See my message on this very subject (select is evil: another reason from May 9th on lkml.) I submitted a patch yesterday which includes both fixes. Apparently, it's already in the -mm tree. - To unsubscribe from

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Fri, May 11, 2007 at 11:27:22AM +0900, Simon Horman wrote: > On Thu, May 10, 2007 at 09:13:34PM -0500, Kumar Gala wrote: > > On Fri, 11 May 2007, Simon Horman wrote: > > > > > On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: > > > > Try this patch: > > > > > > That certainly

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Timur Tabi
Simon Horman wrote: I agree. I had thought a little about a kconfig fix. Though I'm wondering if removing the warning will lead to oodles of dangling symbols and invalid checks over time. I'm pretty sure it will. Perhaps we need to have a lint for Kconfig? - To unsubscribe from this list:

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 09:13:34PM -0500, Kumar Gala wrote: > On Fri, 11 May 2007, Simon Horman wrote: > > > On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: > > > Try this patch: > > > > That certainly resolves the problem for me. > > I'll see about doing something like that for the

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Kumar Gala
On Fri, 11 May 2007, Simon Horman wrote: > On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: > > Try this patch: > > That certainly resolves the problem for me. > I'll see about doing something like that for the similar > Kconfig problems that I see. > > -- > Horms > H:

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: > Try this patch: That certainly resolves the problem for me. I'll see about doing something like that for the similar Kconfig problems that I see. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Kumar Gala
On May 10, 2007, at 8:25 PM, Simon Horman wrote: On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: Simon Horman wrote: So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and "UCC_SLOW_TEMP"? At first I thought, just put it in drivers/ Kconfig, but that Kconfig does

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Kumar Gala
On Fri, 11 May 2007, Simon Horman wrote: > On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: > > Simon Horman wrote: > > > > >>So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and > > >>"UCC_SLOW_TEMP"? At first I thought, just put it in drivers/Kconfig, but > > >>that

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: > Simon Horman wrote: > > >>So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and > >>"UCC_SLOW_TEMP"? At first I thought, just put it in drivers/Kconfig, but > >>that Kconfig does nothing but including other Kconfigs.

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 05:39:29PM +0200, Johannes Berg wrote: > On Thu, 2007-05-10 at 14:10 +0900, Simon Horman wrote: > > > drivers/macintosh/Kconfig:112:warning: 'select' used by config symbol > > 'PMAC_APM_EMU' refer to undefined symbol 'SYS_SUPPORTS_APM_EMULATION' > > Argh. Is that with

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Timur Tabi
Simon Horman wrote: So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and "UCC_SLOW_TEMP"? At first I thought, just put it in drivers/Kconfig, but that Kconfig does nothing but including other Kconfigs. I believe that if I submit a patch that adds "UCC_FAST_TEMP" and

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Johannes Berg
On Thu, 2007-05-10 at 14:10 +0900, Simon Horman wrote: > drivers/macintosh/Kconfig:112:warning: 'select' used by config symbol > 'PMAC_APM_EMU' refer to undefined symbol 'SYS_SUPPORTS_APM_EMULATION' Argh. Is that with ARCH=ppc? I keep forgetting that it still exists, sorry. johannes

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Johannes Berg
On Thu, 2007-05-10 at 14:10 +0900, Simon Horman wrote: drivers/macintosh/Kconfig:112:warning: 'select' used by config symbol 'PMAC_APM_EMU' refer to undefined symbol 'SYS_SUPPORTS_APM_EMULATION' Argh. Is that with ARCH=ppc? I keep forgetting that it still exists, sorry. johannes

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Timur Tabi
Simon Horman wrote: So my question is: in which Kconfig do I define UCC_FAST_TEMP and UCC_SLOW_TEMP? At first I thought, just put it in drivers/Kconfig, but that Kconfig does nothing but including other Kconfigs. I believe that if I submit a patch that adds UCC_FAST_TEMP and UCC_SLOW_TEMP

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 05:39:29PM +0200, Johannes Berg wrote: On Thu, 2007-05-10 at 14:10 +0900, Simon Horman wrote: drivers/macintosh/Kconfig:112:warning: 'select' used by config symbol 'PMAC_APM_EMU' refer to undefined symbol 'SYS_SUPPORTS_APM_EMULATION' Argh. Is that with ARCH=ppc?

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: Simon Horman wrote: So my question is: in which Kconfig do I define UCC_FAST_TEMP and UCC_SLOW_TEMP? At first I thought, just put it in drivers/Kconfig, but that Kconfig does nothing but including other Kconfigs. I believe that

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Kumar Gala
On Fri, 11 May 2007, Simon Horman wrote: On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: Simon Horman wrote: So my question is: in which Kconfig do I define UCC_FAST_TEMP and UCC_SLOW_TEMP? At first I thought, just put it in drivers/Kconfig, but that Kconfig does nothing

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Kumar Gala
On May 10, 2007, at 8:25 PM, Simon Horman wrote: On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote: Simon Horman wrote: So my question is: in which Kconfig do I define UCC_FAST_TEMP and UCC_SLOW_TEMP? At first I thought, just put it in drivers/ Kconfig, but that Kconfig does

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: Try this patch: That certainly resolves the problem for me. I'll see about doing something like that for the similar Kconfig problems that I see. -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/ - To

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Kumar Gala
On Fri, 11 May 2007, Simon Horman wrote: On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: Try this patch: That certainly resolves the problem for me. I'll see about doing something like that for the similar Kconfig problems that I see. -- Horms H:

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Thu, May 10, 2007 at 09:13:34PM -0500, Kumar Gala wrote: On Fri, 11 May 2007, Simon Horman wrote: On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: Try this patch: That certainly resolves the problem for me. I'll see about doing something like that for the similar

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Timur Tabi
Simon Horman wrote: I agree. I had thought a little about a kconfig fix. Though I'm wondering if removing the warning will lead to oodles of dangling symbols and invalid checks over time. I'm pretty sure it will. Perhaps we need to have a lint for Kconfig? - To unsubscribe from this list:

Re: Kconfig warnings on latest GIT

2007-05-10 Thread Simon Horman
On Fri, May 11, 2007 at 11:27:22AM +0900, Simon Horman wrote: On Thu, May 10, 2007 at 09:13:34PM -0500, Kumar Gala wrote: On Fri, 11 May 2007, Simon Horman wrote: On Thu, May 10, 2007 at 08:47:05PM -0500, Kumar Gala wrote: Try this patch: That certainly resolves the problem for

Re: Kconfig warnings on latest GIT

2007-05-09 Thread Simon Horman
On Tue, May 08, 2007 at 03:11:52PM -0500, Timur Tabi wrote: > Kim Phillips wrote: > >On Tue, 8 May 2007 00:04:14 +0300 > >Ismail Dönmez <[EMAIL PROTECTED]> wrote: > >>drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' > >>refers to undefined symbol 'UCC_FAST' > >looks

Re: Kconfig warnings on latest GIT

2007-05-09 Thread Simon Horman
On Tue, May 08, 2007 at 03:11:52PM -0500, Timur Tabi wrote: Kim Phillips wrote: On Tue, 8 May 2007 00:04:14 +0300 Ismail Dönmez [EMAIL PROTECTED] wrote: drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST' looks like this

Re: Kconfig warnings on latest GIT

2007-05-08 Thread Timur Tabi
Kim Phillips wrote: On Tue, 8 May 2007 00:04:14 +0300 Ismail Dönmez <[EMAIL PROTECTED]> wrote: drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST' looks like this introduces the error: commit

Re: Kconfig warnings on latest GIT

2007-05-08 Thread Kim Phillips
On Tue, 8 May 2007 00:04:14 +0300 Ismail Dönmez <[EMAIL PROTECTED]> wrote: > > drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' > refers to undefined symbol 'UCC_FAST' looks like this introduces the error: commit 7d776cb596994219584257eb5956b87628e5deaf Author:

Re: Kconfig warnings on latest GIT

2007-05-08 Thread Kim Phillips
On Tue, 8 May 2007 00:04:14 +0300 Ismail Dönmez [EMAIL PROTECTED] wrote: drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST' looks like this introduces the error: commit 7d776cb596994219584257eb5956b87628e5deaf Author: Timur

Re: Kconfig warnings on latest GIT

2007-05-08 Thread Timur Tabi
Kim Phillips wrote: On Tue, 8 May 2007 00:04:14 +0300 Ismail Dönmez [EMAIL PROTECTED] wrote: drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST' looks like this introduces the error: commit

Kconfig warnings on latest GIT

2007-05-07 Thread Ismail Dönmez
Hi, Following Kconfig warnings shows up with latest GIT : drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST' drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol

Kconfig warnings on latest GIT

2007-05-07 Thread Ismail Dönmez
Hi, Following Kconfig warnings shows up with latest GIT : drivers/net/Kconfig:2279:warning: 'select' used by config symbol 'UCC_GETH' refers to undefined symbol 'UCC_FAST' drivers/input/keyboard/Kconfig:170:warning: 'select' used by config symbol 'KEYBOARD_ATARI' refers to undefined symbol