Re: Latency histogram broken after "hrtimer: Set expiry time before switch_hrtimer_base()"

2014-06-22 Thread Carsten Emde
On 06/22/2014 06:24 AM, Mike Galbraith wrote: [..] On Sun, 2014-06-22 at 06:10 +0200, Mike Galbraith wrote: On Sun, 2014-06-22 at 02:04 +0100, Ben Hutchings wrote: In an rt-kernel with CONFIG_MISSED_TIMER_OFFSETS_HIST enabled, __hrtimer_start_range_ns() now crashes, as new_base is not assigned

Re: Latency histogram broken after hrtimer: Set expiry time before switch_hrtimer_base()

2014-06-22 Thread Carsten Emde
On 06/22/2014 06:24 AM, Mike Galbraith wrote: [..] On Sun, 2014-06-22 at 06:10 +0200, Mike Galbraith wrote: On Sun, 2014-06-22 at 02:04 +0100, Ben Hutchings wrote: In an rt-kernel with CONFIG_MISSED_TIMER_OFFSETS_HIST enabled, __hrtimer_start_range_ns() now crashes, as new_base is not assigned

Re: Latency histogram broken after "hrtimer: Set expiry time before switch_hrtimer_base()"

2014-06-21 Thread Mike Galbraith
(CCs stable -rt maintainer) On Sun, 2014-06-22 at 06:10 +0200, Mike Galbraith wrote: > On Sun, 2014-06-22 at 02:04 +0100, Ben Hutchings wrote: > > In an rt-kernel with CONFIG_MISSED_TIMER_OFFSETS_HIST enabled, > > __hrtimer_start_range_ns() now crashes, as new_base is not assigned > > before it

Re: Latency histogram broken after "hrtimer: Set expiry time before switch_hrtimer_base()"

2014-06-21 Thread Mike Galbraith
On Sun, 2014-06-22 at 02:04 +0100, Ben Hutchings wrote: > In an rt-kernel with CONFIG_MISSED_TIMER_OFFSETS_HIST enabled, > __hrtimer_start_range_ns() now crashes, as new_base is not assigned > before it is used. Oh yeah, forgot about this. > I'm not sure how this should be fixed; is it: My

Latency histogram broken after "hrtimer: Set expiry time before switch_hrtimer_base()"

2014-06-21 Thread Ben Hutchings
In an rt-kernel with CONFIG_MISSED_TIMER_OFFSETS_HIST enabled, __hrtimer_start_range_ns() now crashes, as new_base is not assigned before it is used. I'm not sure how this should be fixed; is it: --- a/kernel/hrtimer.c +++ b/kernel/hrtimer.c @@ -1108,7 +1108,7 @@ int

Latency histogram broken after hrtimer: Set expiry time before switch_hrtimer_base()

2014-06-21 Thread Ben Hutchings
In an rt-kernel with CONFIG_MISSED_TIMER_OFFSETS_HIST enabled, __hrtimer_start_range_ns() now crashes, as new_base is not assigned before it is used. I'm not sure how this should be fixed; is it: --- a/kernel/hrtimer.c +++ b/kernel/hrtimer.c @@ -1108,7 +1108,7 @@ int

Re: Latency histogram broken after hrtimer: Set expiry time before switch_hrtimer_base()

2014-06-21 Thread Mike Galbraith
On Sun, 2014-06-22 at 02:04 +0100, Ben Hutchings wrote: In an rt-kernel with CONFIG_MISSED_TIMER_OFFSETS_HIST enabled, __hrtimer_start_range_ns() now crashes, as new_base is not assigned before it is used. Oh yeah, forgot about this. I'm not sure how this should be fixed; is it: My

Re: Latency histogram broken after hrtimer: Set expiry time before switch_hrtimer_base()

2014-06-21 Thread Mike Galbraith
(CCs stable -rt maintainer) On Sun, 2014-06-22 at 06:10 +0200, Mike Galbraith wrote: On Sun, 2014-06-22 at 02:04 +0100, Ben Hutchings wrote: In an rt-kernel with CONFIG_MISSED_TIMER_OFFSETS_HIST enabled, __hrtimer_start_range_ns() now crashes, as new_base is not assigned before it is