Re: CPUMAP latency metrics (was: [PATCH bpf-next] bpf: ringbuf: Support consuming BPF_MAP_TYPE_RINGBUF from prog)

2024-09-12 Thread Daniel Xu
he xdp frame onto the destination CPU ptr_ring. >>>>> This can occur on any cpu, thus multi-producer. On processing side, >>>>> there is only the kthread created by the cpumap entry and bound to the >>>>> specific cpu that is consuming entries. So

CPUMAP latency metrics (was: [PATCH bpf-next] bpf: ringbuf: Support consuming BPF_MAP_TYPE_RINGBUF from prog)

2024-09-12 Thread Jesper Dangaard Brouer
this adding latency, I choose to also flush every 8 frames (CPU_MAP_BULK_SIZE). Looking at code I see this is also explained in a comment: /* General idea: XDP packets getting XDP redirected to another CPU, * will maximum be stored/queued for one driver ->poll() call. It is * guaranteed that

Re: [PATCH] tools/latency-collector: fix -Wformat-security compile warns

2024-05-21 Thread Steven Rostedt
On Tue, 21 May 2024 09:11:08 -0600 Shuah Khan wrote: > Any thoughts on this patch? Sorry, this one fell through the cracks. Daniel Bristot has been maintaining his tools and I thought this was one of his changes. I'll take a look at it. -- Steve

Re: [PATCH] tools/latency-collector: fix -Wformat-security compile warns

2024-05-21 Thread Shuah Khan
On 4/3/24 19:10, Shuah Khan wrote: Fix the following -Wformat-security compile warnings adding missing format arguments: latency-collector.c: In function ‘show_available’: latency-collector.c:938:17: warning: format not a string literal and no format arguments [-Wformat-security] 938

[PATCH] tools/latency-collector: fix -Wformat-security compile warns

2024-04-03 Thread Shuah Khan
Fix the following -Wformat-security compile warnings adding missing format arguments: latency-collector.c: In function ‘show_available’: latency-collector.c:938:17: warning: format not a string literal and no format arguments [-Wformat-security] 938 | warnx(no_tracer_msg

[PATCH V3 1/3] tools/tracing: Use tools/build makefiles on latency-collector

2024-03-15 Thread Daniel Bristot de Oliveira
Use tools/build/ makefiles to build latency-collector, inheriting the benefits of it. For example: Before this patch, a missing tracefs/traceevents headers will result in fail like this: ~/linux/tools/tracing/latency $ make cc -Wall -Wextra -g -O2 -o latency-collector latency-collector.c

Re: [PATCH V2 1/3] tools/tracing: Use tools/build makefiles on latency-collector

2024-03-15 Thread Daniel Bristot de Oliveira
On 3/15/24 15:53, Arnaldo Carvalho de Melo wrote: > On Fri, Mar 15, 2024 at 03:48:58PM +0100, Daniel Bristot de Oliveira wrote: >> On 3/15/24 15:24, Daniel Bristot de Oliveira wrote: >>> Use tools/build/ makefiles to build latency-collector, inheriting >>> the benefits

Re: [PATCH V2 1/3] tools/tracing: Use tools/build makefiles on latency-collector

2024-03-15 Thread Arnaldo Carvalho de Melo
On Fri, Mar 15, 2024 at 03:48:58PM +0100, Daniel Bristot de Oliveira wrote: > On 3/15/24 15:24, Daniel Bristot de Oliveira wrote: > > Use tools/build/ makefiles to build latency-collector, inheriting > > the benefits of it. For example: Before this patch, a missing > > tracef

Re: [PATCH V2 1/3] tools/tracing: Use tools/build makefiles on latency-collector

2024-03-15 Thread Daniel Bristot de Oliveira
On 3/15/24 15:24, Daniel Bristot de Oliveira wrote: > Use tools/build/ makefiles to build latency-collector, inheriting > the benefits of it. For example: Before this patch, a missing > tracefs/traceevents headers will result in fail

[PATCH V2 1/3] tools/tracing: Use tools/build makefiles on latency-collector

2024-03-15 Thread Daniel Bristot de Oliveira
Use tools/build/ makefiles to build latency-collector, inheriting the benefits of it. For example: Before this patch, a missing tracefs/traceevents headers will result in fail like this: %< --- ~/linux/tools/tracing/latency $ make

[PATCH 1/3] tools/tracing: Use tools/build makefiles on latency-collector

2024-03-08 Thread Daniel Bristot de Oliveira
Use tools/build/ makefiles to build latency-collector, inheriting the benefits of it. For example, having a proper way to handle dependencies. Inspired on perf and objtool. Suggested-by: Linus Torvalds Signed-off-by: Daniel Bristot de Oliveira --- tools/tracing/latency/.gitignore | 1

[RFC v3 2/2] powerpc/selftest: Add support for cpuidle latency measurement

2023-09-10 Thread Aboorva Devarajan
From: Pratik R. Sampat The cpuidle latency selftest provides support to systematically extract, analyse and present IPI and timer based wakeup latencies for each CPU and each idle state available on the system. The selftest leverages test_cpuidle_latency module's debugfs interface to int

[RFC v3 1/2] powerpc/cpuidle: cpuidle wakeup latency based on IPI and timer events

2023-09-10 Thread Aboorva Devarajan
default 0xa8001c00 if PPC_BOOK3E_64 + +config CPUIDLE_LATENCY_SELFTEST + tristate "Cpuidle latency selftests" + depends on CPU_IDLE + help + Provides a kernel module that run tests using the IPI and + timers to measure cpuidle latency. + + Sa

[RFC v3 0/2] CPU-Idle latency selftest framework

2023-09-10 Thread Aboorva Devarajan
all/20210430082804.38018-1-psam...@linux.ibm.com/ Userspace selftest: https://lkml.org/lkml/2020/9/2/356 A kernel module + userspace driver to estimate the wakeup latency caused by going into stop states. The motivation behind this program is to find significant deviations behind advertised late

Re: [PATCH v4 6/7] cpufreq: qcom-hw: Allow getting the maximum transition latency for OPPs

2021-04-19 Thread Bjorn Andersson
On Tue 19 Jan 11:45 CST 2021, AngeloGioacchino Del Regno wrote: > In order to fine-tune the frequency scaling from various governors, > allow to set a maximum transition latency from OPPs, which may be > different depending on the SoC. > Acked-by: Bjorn Andersson Regards, Bjorn

[RFC] mm/vmscan.c: avoid possible long latency caused by too_many_isolated()

2021-04-15 Thread zhengjun . xing
From: Zhengjun Xing In the system with very few file pages, it is easy to reproduce "nr_isolated_file > nr_inactive_file", then too_many_isolated return true, shrink_inactive_list enter "msleep(100)", the long latency will happen. The test case to reproduce it is very si

RE: [PATCH] serial: sh-sci: remove obsolete latency workaround

2021-04-15 Thread Yoshihiro Shimoda
Hi Ulrich-san, > From: Ulrich Hecht, Sent: Thursday, April 15, 2021 6:36 PM > > Since the transition to hrtimers there is no more need to set a minimum > RX timeout to work around latency issues. > > Signed-off-by: Ulrich Hecht Thank you for the patch! Reviewed-by: Yoshih

[PATCH] serial: sh-sci: remove obsolete latency workaround

2021-04-15 Thread Ulrich Hecht
Since the transition to hrtimers there is no more need to set a minimum RX timeout to work around latency issues. Signed-off-by: Ulrich Hecht --- drivers/tty/serial/sh-sci.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers

Re: [RFC v4 0/2] CPU-Idle latency selftest framework

2021-04-13 Thread Doug Smythies
t should run on in >default(quick) mode. > 2. The source CPU to source CPU interaction in the IPI test will always > result in a lower latency and cause a bias in the average, hence >avoid adding the latency to be averaged for same cpu IPIs. The >latency will still

[RFC v4 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-04-12 Thread Pratik Rajesh Sampat
The cpuidle latency selftest provides support to systematically extract, analyse and present IPI and timer based wakeup latencies for each CPU and each idle state available on the system. The selftest leverages test-cpuidle_latency module's debugfs interface to interact and extract la

[RFC v4 0/2] CPU-Idle latency selftest framework

2021-04-12 Thread Pratik Rajesh Sampat
n a lower latency and cause a bias in the average, hence avoid adding the latency to be averaged for same cpu IPIs. The latency will still be displayed in the detailed logs. RFC v3: https://lkml.org/lkml/2021/4/4/31 --- A kernel module + userspace driver to estimate the wakeup latency caused

[RFC v4 1/2] cpuidle: Extract IPI based and timer based wakeup latency from idle states

2021-04-12 Thread Pratik Rajesh Sampat
--- /dev/null +++ b/drivers/cpuidle/test-cpuidle_latency.c @@ -0,0 +1,157 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Module-based API test facility for cpuidle latency using IPIs and timers + */ + +#include +#include +#include + +/* + * IPI based wakeup latencies + * Measure time taken

Re: [RFC v3 0/2] CPU-Idle latency selftest framework

2021-04-09 Thread Doug Smythies
On Fri, Apr 9, 2021 at 12:43 AM Pratik Sampat wrote: > On 09/04/21 10:53 am, Doug Smythies wrote: > > I tried V3 on a Intel i5-10600K processor with 6 cores and 12 CPUs. > > The core to cpu mappings are: > > core 0 has cpus 0 and 6 > > core 1 has cpus 1 and 7 > > core 2 has cpus 2 and 8 > > core 3

Re: [RFC v3 0/2] CPU-Idle latency selftest framework

2021-04-09 Thread Pratik Sampat
ng the average. In the verbose mode I'll omit all the threads of CPU0 and in the default (quick) mode just CPU0's latency can be omitted while computing average. Thank you, Pratik Example, where I used the -v option for all CPUs: --IPI Latency Test--- --Baseline IPI Latency measureme

Re: [RFC v3 0/2] CPU-Idle latency selftest framework

2021-04-08 Thread Doug Smythies
low states. Myself, I wouldn't include them in the results. Example, where I used the -v option for all CPUs: --IPI Latency Test--- --Baseline IPI Latency measurement: CPU Busy-- SRC_CPU DEST_CPU IPI_Latency(ns) 00 101 01 790 02 609

[RFC v3 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-04-04 Thread Pratik Rajesh Sampat
The cpuidle latency selftest provides support to systematically extract, analyse and present IPI and timer based wakeup latencies for each CPU and each idle state available on the system. The selftest leverages test-cpuidle_latency module's debugfs interface to interact and extract la

[RFC v3 1/2] cpuidle: Extract IPI based and timer based wakeup latency from idle states

2021-04-04 Thread Pratik Rajesh Sampat
--- /dev/null +++ b/drivers/cpuidle/test-cpuidle_latency.c @@ -0,0 +1,157 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Module-based API test facility for cpuidle latency using IPIs and timers + */ + +#include +#include +#include + +/* + * IPI based wakeup latencies + * Measure time taken

[RFC v3 0/2] CPU-Idle latency selftest framework

2021-04-04 Thread Pratik Rajesh Sampat
the system is in a coherent state after the tests have run 4. Correct the return status of a CPU that cannot be off-lined. RFC v2: https://lkml.org/lkml/2021/4/1/615 --- A kernel module + userspace driver to estimate the wakeup latency caused by going into stop states. The motivation behind this program

Re: [RFC v2 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-04-04 Thread Pratik Sampat
Hello Doug, Thanks for your review. On 02/04/21 4:57 am, Doug Smythies wrote: Hi Pratik, On Thu, Apr 1, 2021 at 4:45 AM Pratik Rajesh Sampat wrote: ... To run this test specifically: $ make -C tools/testing/selftests TARGETS="cpuidle" run_tests I have not become any smarter than I was with

Re: [RFC v2 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-04-01 Thread Doug Smythies
Hi Pratik, On Thu, Apr 1, 2021 at 4:45 AM Pratik Rajesh Sampat wrote: > ... > To run this test specifically: > $ make -C tools/testing/selftests TARGETS="cpuidle" run_tests I have not become any smarter than I was with version 1, and still assumed that the "$" meant regular user. Please put it

[RFC v2 0/2] CPU-Idle latency selftest framework

2021-04-01 Thread Pratik Rajesh Sampat
reated differently of if they are more CPUs that cannot have its idle state properties changed. RFC v1: https://lkml.org/lkml/2021/3/15/492 --- A kernel module + userspace driver to estimate the wakeup latency caused by going into stop states. The motivation behind this program is to find sign

[RFC v2 1/2] cpuidle: Extract IPI based and timer based wakeup latency from idle states

2021-04-01 Thread Pratik Rajesh Sampat
--- /dev/null +++ b/drivers/cpuidle/test-cpuidle_latency.c @@ -0,0 +1,157 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Module-based API test facility for cpuidle latency using IPIs and timers + */ + +#include +#include +#include + +/* + * IPI based wakeup latencies + * Measure time taken

[RFC v2 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-04-01 Thread Pratik Rajesh Sampat
The cpuidle latency selftest provides support to systematically extract, analyse and present IPI and timer based wakeup latencies for each CPU and each idle state available on the system. The selftest leverages test-cpuidle_latency module's debugfs interface to interact and extract la

Re: [RFC 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-03-22 Thread Pratik Sampat
nux/tools/testing/selftests/cpuidle$ cat cpuidle.log.v3-1 --IPI Latency Test--- --Baseline IPI Latency measurement: CPU Busy-- SRC_CPU DEST_CPU IPI_Latency(ns) 00 140 01 632 02 675 03 671 04

Re: [RFC 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-03-20 Thread Doug Smythies
r tasks scheduled from time to time on an otherwise idle core. > In the full per-CPU logs at tools/testing/selftests/cpuidle/cpuidle.log can > you > spot any obvious outliers per-CPU state? Yes. I'll just paste in an example cpuidle.log file having used the -v option below, along

[for-next][PATCH 09/13] tools/latency-collector: Remove unneeded semicolon

2021-03-19 Thread Steven Rostedt
From: Xu Wang Fix semicolon.cocci warning: tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon Link: https://lkml.kernel.org/r/20210308022459.59881-1-vu...@iscas.ac.cn Reviewed-by: Viktor Rosendahl Signed-off-by: Xu Wang Signed-off-by: Steven Rostedt (VMware) --- tools

Re: [RFC 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-03-17 Thread Pratik Sampat
e which runs for all the threads of each CPU with the following: "sudo ./cpuidle.sh -v". While latency mostly matters for per-core basis but it still maybe a good idea to see if that changes anything with the observations. -- Thanks and regards, Pratik My system is very idle: Example (f

Re: [RFC 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-03-17 Thread Doug Smythies
Hi Pratik, It just so happens that I have been trying Artem's version this last week, so I tried yours. On Mon, Mar 15, 2021 at 4:49 AM Pratik Rajesh Sampat wrote: > ... > To run this test specifically: > $ make -C tools/testing/selftests TARGETS="cpuidle" run_tests While I suppose it should ha

[RFC 0/2] CPU-Idle latency selftest framework

2021-03-15 Thread Pratik Rajesh Sampat
A kernel module + userspace driver to estimate the wakeup latency caused by going into stop states. The motivation behind this program is to find significant deviations behind advertised latency and residency values. The patchset measures latencies for two kinds of events. IPIs and Timers As this

[RFC 1/2] cpuidle: Extract IPI based and timer based wakeup latency from idle states

2021-03-15 Thread Pratik Rajesh Sampat
--- /dev/null +++ b/drivers/cpuidle/test-cpuidle_latency.c @@ -0,0 +1,157 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Module-based API test facility for cpuidle latency using IPIs and timers + */ + +#include +#include +#include + +/* + * IPI based wakeup latencies + * Measure time taken

[RFC 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-03-15 Thread Pratik Rajesh Sampat
The cpuidle latency selftest provides support to systematically extract, analyse and present IPI and timer based wakeup latencies for each CPU and each idle state available on the system. The selftest leverages test-cpuidle_latency module's debugfs interface to interact and extract la

[RFC -V6 4/6] memory tiering: hot page selection with hint page fault latency

2021-03-11 Thread Huang Ying
me is recorded in struct page as scan time. - When the page is accessed, hint page fault will occur. The scan time is gotten from the struct page. And The hint page fault latency is defined as hint page fault time - scan time The shorter the hint page fault latency of a page is, the highe

Re: [PATCH] ASoC: fsl_sai: Add pm qos cpu latency support

2021-03-01 Thread Mark Brown
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_sai: Add pm qos cpu latency support commit: 6d85d770c171972c0f33f74b84bf0fedc111e89f All being well this means that it will be integrated into the linux-next tree (usually som

[PATCH 5.11 611/775] Revert "drm/amd/display: Update NV1x SR latency values"

2021-03-01 Thread Greg Kroah-Hartman
From: Alex Deucher commit 910f1601addae3e430fc7d3cd589d7622c5df693 upstream. This reverts commit 4a3dea8932d3b1199680d2056dd91d31d94d70b7. This causes blank screens for some users. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1388 Cc: Alvin Lee Cc: Jun Lei Cc: Rodrigo Siqueira Revie

[PATCH 5.10 512/663] Revert "drm/amd/display: Update NV1x SR latency values"

2021-03-01 Thread Greg Kroah-Hartman
From: Alex Deucher commit 910f1601addae3e430fc7d3cd589d7622c5df693 upstream. This reverts commit 4a3dea8932d3b1199680d2056dd91d31d94d70b7. This causes blank screens for some users. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1388 Cc: Alvin Lee Cc: Jun Lei Cc: Rodrigo Siqueira Revie

[PATCH 0/1] Fix for the latency-collector

2021-02-25 Thread Viktor Rosendahl
Hi Steve, I am not sure what is the correct approach to handle this latency-collector fix. Can you take it into your queue? best regards, Viktor Colin Ian King (1): tracing/tools: fix a couple of spelling mistakes tools/tracing/latency/latency-collector.c | 6 +++--- 1 file changed, 3

Re: [PATCH 0/1] Fix for the latency-collector

2021-02-25 Thread Steven Rostedt
On Thu, 25 Feb 2021 17:52:47 +0100 Viktor Rosendahl wrote: > Hi Steve, > > I am not sure what is the correct approach to handle this latency-collector > fix. Can you take it into your queue? Yes I can take it. I was going to just pull this in for the next merge window as it'

[PATCH] ASoC: fsl_sai: Add pm qos cpu latency support

2021-02-22 Thread Shengjiu Wang
On SoCs such as i.MX7ULP, cpuidle has some levels which may disable system/bus clocks, so need to add pm_qos to prevent cpuidle from entering low level idles and make sure system/bus clocks are enabled when sai is active. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_sai.c | 12

[for-next][PATCH 5/5] tracing/tools: Add the latency-collector to tools directory

2021-02-15 Thread Steven Rostedt
test campaign every time a latency problem has been fixed. It uses inotify to detect changes to /sys/kernel/tracing/trace. When a latency is detected, it will either sleep or print immediately, depending on a function that act as an unfair coin toss. If immediate print is chosen, it means that we

[PATCH 5.10 011/104] Revert "drm/amd/display: Update NV1x SR latency values"

2021-02-15 Thread Greg Kroah-Hartman
From: Alex Deucher commit cf050f96e0970a557601953ed7269d07a7885078 upstream. This reverts commit 4a3dea8932d3b1199680d2056dd91d31d94d70b7. This causes blank screens for some users. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1482 Cc: Alvin Lee Cc: Jun Lei Cc: Rodrigo Siqueira Revie

Re: [PATCH] Add the latency-collector to tools

2021-02-15 Thread Steven Rostedt
On Mon, 15 Feb 2021 11:54:08 + wrote: > Just a quick update: I was able to reproduce this weird behavior that I wrote > about but it turned out to be a problem with my testing. > > The test was faulty because of a mistake that I had made. > > Sorry for the extra noise. No problem. Thanks f

Re: [PATCH] Add the latency-collector to tools

2021-02-15 Thread Viktor.Rosendahl
On Fri, 2021-02-12 at 13:16 +0100, Viktor Rosendahl wrote: > > > However, for some reason I cannot reproduce the behavior now, allthough I use > exactly the same kernel. > > Because humans are more often at fault than computers, I cannot deny the > possibility that I would have misconfigured som

[PATCH v12 0/1] Add the latency-collector to tools

2021-02-12 Thread Viktor Rosendahl
Changes since v11 * I added a .gitignore in the tools/tracing/latency directory. Changes since v10 * Using libtracefs to control ftrace and find /sys/kernel/tracing * New options to list available tracers, select the tracer and other ftrace parameters * A signal handler to restore the

[PATCH v12 1/1] Add the latency-collector to tools

2021-02-12 Thread Viktor Rosendahl
ime a latency problem has been fixed. It uses inotify to detect changes to /sys/kernel/tracing/trace. When a latency is detected, it will either sleep or print immediately, depending on a function that act as an unfair coin toss. If immediate print is chosen, it means that we open /sys/kernel/tr

Re: [PATCH] Add the latency-collector to tools

2021-02-12 Thread Viktor.Rosendahl
guess > > this > > is likely to be another regression in the preemptirqsoff tracer. > > Not sure what you mean by the above. I'd be interested in fixing it if is > really a problem. Sorry, my bad; I should have been more specific. Yesterday, when I tested the latency-collec

[PATCH v11] Add the latency-collector to tools

2021-02-12 Thread Viktor Rosendahl
ime a latency problem has been fixed. It uses inotify to detect changes to /sys/kernel/tracing/trace. When a latency is detected, it will either sleep or print immediately, depending on a function that act as an unfair coin toss. If immediate print is chosen, it means that we open /sys/kernel/tr

Re: [PATCH] Add the latency-collector to tools

2021-02-11 Thread Steven Rostedt
gt; +# SPDX-License-Identifier: GPL-2.0 > +# Makefile for vm tools > +# > +VAR_CFLAGS := $(shell pkg-config --cflags libtracefs 2>/dev/null) > +VAR_LDLIBS := $(shell pkg-config --libs libtracefs 2>/dev/null) > + > +TARGETS = latency-collector > +CFLAGS = -Wall -W

[PATCH] Add the latency-collector to tools

2021-02-11 Thread Viktor Rosendahl
e the finding of > tracefs files. It can also make it easier for you to enable a tracer. > I also changed the latency-collector to enable the tracer. I added a few options for chosing the tracer and for setting up the relevant ftrace parameters. I also added a signal handler, so that the

[PATCH 5.10 062/120] tracing: Use pause-on-trace with the latency tracers

2021-02-08 Thread Greg Kroah-Hartman
o work with the latency tracers. The above mentioned commit dit not only change the behavior but also added an option to emulate the old behavior. The idea with this patch is to enable this pause-on-trace option when the latency tracers are used. Link: https://lkml.kernel.org/r/2021011

Re: [PATCH 6/9] perf report: Support instruction latency

2021-02-08 Thread Liang, Kan
On 2/6/2021 3:09 AM, Namhyung Kim wrote: On Fri, Feb 5, 2021 at 11:38 PM Liang, Kan wrote: On 2/5/2021 6:08 AM, Namhyung Kim wrote: On Wed, Feb 3, 2021 at 5:14 AM wrote: From: Kan Liang The instruction latency information can be recorded on some platforms, e.g., the Intel Sapphire

Re: [PATCH 6/9] perf report: Support instruction latency

2021-02-07 Thread Athira Rajeev
> On 05-Feb-2021, at 8:21 PM, Liang, Kan wrote: > > > > On 2/5/2021 7:55 AM, Athira Rajeev wrote: >>>> Because in other archs, the var2_w of ‘perf_sample_weight’ could be used >>>> to capture something else than the Local INSTR Latency. >>>

Re: [PATCH 6/9] perf report: Support instruction latency

2021-02-06 Thread Namhyung Kim
On Fri, Feb 5, 2021 at 11:38 PM Liang, Kan wrote: > > On 2/5/2021 6:08 AM, Namhyung Kim wrote: > > On Wed, Feb 3, 2021 at 5:14 AM wrote: > >> > >> From: Kan Liang > >> > >> The instruction latency information can be recorded on some platforms, &

Re: [PATCH 6/9] perf report: Support instruction latency

2021-02-05 Thread Athira Rajeev
> On 04-Feb-2021, at 8:49 PM, Liang, Kan wrote: > > > > On 2/4/2021 8:11 AM, Athira Rajeev wrote: >>> On 03-Feb-2021, at 1:39 AM, kan.li...@linux.intel.com wrote: >>> >>> From: Kan Liang >>> >>> The instruction latency inform

Re: [PATCH 6/9] perf report: Support instruction latency

2021-02-05 Thread Liang, Kan
On 2/5/2021 7:55 AM, Athira Rajeev wrote: Because in other archs, the var2_w of ‘perf_sample_weight’ could be used to capture something else than the Local INSTR Latency. Can we have some weak function to populate the header string ? I agree that the var2_w has different meanings among

Re: [PATCH 6/9] perf report: Support instruction latency

2021-02-05 Thread Liang, Kan
On 2/5/2021 6:08 AM, Namhyung Kim wrote: On Wed, Feb 3, 2021 at 5:14 AM wrote: From: Kan Liang The instruction latency information can be recorded on some platforms, e.g., the Intel Sapphire Rapids server. With both memory latency (weight) and the new instruction latency information

Re: [PATCH 6/9] perf report: Support instruction latency

2021-02-05 Thread Namhyung Kim
On Wed, Feb 3, 2021 at 5:14 AM wrote: > > From: Kan Liang > > The instruction latency information can be recorded on some platforms, > e.g., the Intel Sapphire Rapids server. With both memory latency > (weight) and the new instruction latency information, users can easily >

Re: [PATCH 6/9] perf report: Support instruction latency

2021-02-04 Thread Liang, Kan
On 2/4/2021 8:11 AM, Athira Rajeev wrote: On 03-Feb-2021, at 1:39 AM, kan.li...@linux.intel.com wrote: From: Kan Liang The instruction latency information can be recorded on some platforms, e.g., the Intel Sapphire Rapids server. With both memory latency (weight) and the new instruction

Re: [PATCH 6/9] perf report: Support instruction latency

2021-02-04 Thread Athira Rajeev
> On 03-Feb-2021, at 1:39 AM, kan.li...@linux.intel.com wrote: > > From: Kan Liang > > The instruction latency information can be recorded on some platforms, > e.g., the Intel Sapphire Rapids server. With both memory latency > (weight) and the new instruction latency i

[RFC -V5 3/6] memory tiering: hot page selection with hint page fault latency

2021-02-04 Thread Huang Ying
me is recorded in struct page as scan time. - When the page is accessed, hint page fault will occur. The scan time is gotten from the struct page. And The hint page fault latency is defined as hint page fault time - scan time The shorter the hint page fault latency of a page is, the highe

Re: [PATCH 6/9] perf report: Support instruction latency

2021-02-03 Thread Arnaldo Carvalho de Melo
Em Tue, Feb 02, 2021 at 12:09:10PM -0800, kan.li...@linux.intel.com escreveu: > From: Kan Liang > > The instruction latency information can be recorded on some platforms, > e.g., the Intel Sapphire Rapids server. With both memory latency > (weight) and the new instruction late

[for-linus][PATCH 2/5] tracing: Use pause-on-trace with the latency tracers

2021-02-02 Thread Steven Rostedt
From: Viktor Rosendahl Eaerlier, tracing was disabled when reading the trace file. This behavior was changed with: commit 06e0a548bad0 ("tracing: Do not disable tracing when reading the trace file"). This doesn't seem to work with the latency tracers. The above mentioned comm

[PATCH 6/9] perf report: Support instruction latency

2021-02-02 Thread kan . liang
From: Kan Liang The instruction latency information can be recorded on some platforms, e.g., the Intel Sapphire Rapids server. With both memory latency (weight) and the new instruction latency information, users can easily locate the expensive load instructions, and also understand the time

Re: [RFC PATCH 2/2] Add the latency-collector to tools

2021-01-26 Thread Steven Rostedt
-License-Identifier: GPL-2.0 > +# Makefile for vm tools > +# > +TARGETS = latency-collector > +CFLAGS = -Wall -Wextra -g -O2 > +LDFLAGS = -lpthread > + > +all: $(TARGETS) > + > +%: %.c > + $(CC) $(CFLAGS) -o $@ $< $(LDFLAGS) > + > +clean: > + $(RM)

Re: [RFC PATCH 1/2] Use pause-on-trace with the latency tracers

2021-01-26 Thread Steven Rostedt
quot;). > > This doesn't seem to work with the latency tracers. > > The above mentioned commit dit not only change the behavior but also added > an option to emulate the old behavior. The idea with this patch is to > enable this pause-on-trace option when the latency tracers

[PATCH v5 6/7] cpufreq: qcom-hw: Allow getting the maximum transition latency for OPPs

2021-01-21 Thread AngeloGioacchino Del Regno
In order to fine-tune the frequency scaling from various governors, allow to set a maximum transition latency from OPPs, which may be different depending on the SoC. Signed-off-by: AngeloGioacchino Del Regno --- drivers/cpufreq/qcom-cpufreq-hw.c | 7 +++ 1 file changed, 7 insertions

[PATCH 09/12] perf report: Support instruction latency

2021-01-19 Thread kan . liang
From: Kan Liang The instruction latency information can be recorded on some platforms, e.g., the Intel Sapphire Rapids server. With both memory latency (weight) and the new instruction latency information, users can easily locate the expensive load instructions, and also understand the time

[PATCH v4 6/7] cpufreq: qcom-hw: Allow getting the maximum transition latency for OPPs

2021-01-19 Thread AngeloGioacchino Del Regno
In order to fine-tune the frequency scaling from various governors, allow to set a maximum transition latency from OPPs, which may be different depending on the SoC. Signed-off-by: AngeloGioacchino Del Regno --- drivers/cpufreq/qcom-cpufreq-hw.c | 7 +++ 1 file changed, 7 insertions

[RFC PATCH 1/2] Use pause-on-trace with the latency tracers

2021-01-19 Thread Viktor Rosendahl
Eaerlier, tracing was disabled when reading the trace file. This behavior was changed with: commit 06e0a548bad0 ("tracing: Do not disable tracing when reading the trace file"). This doesn't seem to work with the latency tracers. The above mentioned commit dit not only change t

[RFC PATCH 2/2] Add the latency-collector to tools

2021-01-19 Thread Viktor Rosendahl
ime a latency problem has been fixed. It uses inotify to detect changes to /sys/kernel/debug/tracing/trace. When a latency is detected, it will either sleep or print immediately, depending on a function that act as an unfair coin toss. If immediate print is chosen, it means that we open /sys/kernel/

[PATCH] mm/vmstat.c: erase latency in vmstat_shepherd

2021-01-10 Thread Jiang Biao
From: Jiang Biao Many 100us+ latencies have been deteceted in vmstat_shepherd() on CPX platform which has 208 logic cpus. And vmstat_shepherd is queued every second, which could make the case worse. Add schedule point in vmstat_shepherd() to erase the latency. Signed-off-by: Jiang Biao

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-17 Thread Ian Kumlien
gt; > > > > > [ 5] 7.00-8.00 sec 110 MBytes 923 Mbits/sec 32628 > > > > > > KBytes > > > > > > [ 5] 8.00-9.00 sec 110 MBytes 923 Mbits/sec 81537 > > > > > > KBytes > > > > > > [ 5]

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-16 Thread Bjorn Helgaas
t; > > > [ 5] 9.00-10.00 sec 110 MBytes 923 Mbits/sec 10577 > > > > > KBytes > > > > > - - - - - - - - - - - - - - - - - - - - - - - - - > > > > > [ ID] Interval Transfer Bitrate Retr > > > &

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-16 Thread Ian Kumlien
c 1056 > > > > sender > > > > [ 5] 0.00-10.00 sec 1.07 GBytes 923 Mbits/sec > > > > receiver > > > > > > > > But this only confirms that the fix i experience is a side effect. > > > > >

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-15 Thread Bjorn Helgaas
uld > > add this and a dmesg log to the buzilla? It seems like other people > > should be seeing the same problem, so I'm hoping to grub around on the > > web to see if there are similar reports involving these devices. > > ASUS Pro WS X570-ACE with AMD Ryzen 9

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-15 Thread Ian Kumlien
x i experience is a side effect. > > > > The original code is still wrong :) > > What exactly is this machine? Brand, model, config? Maybe you could > add this and a dmesg log to the buzilla? It seems like other people > should be seeing the same problem, so I'm hoping to

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Bjorn Helgaas
ou could add this and a dmesg log to the buzilla? It seems like other people should be seeing the same problem, so I'm hoping to grub around on the web to see if there are similar reports involving these devices. https://bugzilla.kernel.org/show_bug.cgi?id=209725 Here's one that is s

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Ian Kumlien
e: > > > > > > On Sun, Dec 13, 2020 at 12:47 AM Bjorn Helgaas > > > > > > wrote: > > > > > > > On Sat, Oct 24, 2020 at 10:55:46PM +0200, Ian Kumlien wrote: > > > > > > > > Make pcie_aspm_check_latency comply with the PCIe

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Bjorn Helgaas
, Ian Kumlien wrote: > > > > > > > Make pcie_aspm_check_latency comply with the PCIe spec, > > > > > > > specifically: > > > > > > > "5.4.1.2.2. Exit from the L1 State" > > > > > > > > > > > >

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Ian Kumlien
0 at 12:47 AM Bjorn Helgaas > > > > wrote: > > > > > On Sat, Oct 24, 2020 at 10:55:46PM +0200, Ian Kumlien wrote: > > > > > > Make pcie_aspm_check_latency comply with the PCIe spec, > > > > > > specifically: > > >

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Bjorn Helgaas
_latency comply with the PCIe spec, specifically: > > > > > "5.4.1.2.2. Exit from the L1 State" > > > > > > > > > > Which makes it clear that each switch is required to > > > > > initiate a transition within 1μs from re

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-14 Thread Ian Kumlien
Bjorn Helgaas wrote: > > > On Sat, Oct 24, 2020 at 10:55:46PM +0200, Ian Kumlien wrote: > > > > Make pcie_aspm_check_latency comply with the PCIe spec, specifically: > > > > "5.4.1.2.2. Exit from the L1 State" > > > > > > > > Which mak

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-13 Thread Bjorn Helgaas
mply with the PCIe spec, specifically: > > > "5.4.1.2.2. Exit from the L1 State" > > > > > > Which makes it clear that each switch is required to initiate a > > > transition within 1μs from receiving it, accumulating this latency and > > > then we h

Re: [PATCH v13 3/3] binder: add transaction latency tracer

2020-11-13 Thread Greg Kroah-Hartman
On Wed, Nov 11, 2020 at 11:59:05PM +0800, Frankie Chang wrote: > On Wed, 2020-11-11 at 16:12 +0100, Greg Kroah-Hartman wrote: > > On Wed, Nov 11, 2020 at 11:03:06PM +0800, Frankie Chang wrote: > > > On Wed, 2020-11-11 at 08:34 +0100, Greg Kroah-Hartman wrote: > > > > > - The reason why printing the

Re: [PATCH v13 3/3] binder: add transaction latency tracer

2020-11-11 Thread Frankie Chang
On Wed, 2020-11-11 at 16:12 +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 11, 2020 at 11:03:06PM +0800, Frankie Chang wrote: > > On Wed, 2020-11-11 at 08:34 +0100, Greg Kroah-Hartman wrote: > > > > - The reason why printing the related information to > > > > kernel information log but not trace

Re: [PATCH v13 3/3] binder: add transaction latency tracer

2020-11-11 Thread Greg Kroah-Hartman
On Wed, Nov 11, 2020 at 11:03:06PM +0800, Frankie Chang wrote: > On Wed, 2020-11-11 at 08:34 +0100, Greg Kroah-Hartman wrote: > > > - The reason why printing the related information to > > > kernel information log but not trace buffer is that > > > some abnormal transactions may be pending for

[PATCH v14] binder: add transaction latency tracer

2020-11-11 Thread Frankie Chang
of custom registration functions. Change from v2: - create transaction latency module to monitor slow transaction. Change from v1: - first patchset. Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transaction late

Re: [PATCH v13 3/3] binder: add transaction latency tracer

2020-11-10 Thread Greg Kroah-Hartman
On Wed, Nov 11, 2020 at 11:02:44AM +0800, Frankie Chang wrote: > From: "Frankie.Chang" > > Record start/end timestamp for binder transaction. > When transaction is completed or transaction is free, > it would be checked if transaction latency over threshold > (defa

Re: [PATCH v13] binder: add transaction latency tracer

2020-11-10 Thread Greg Kroah-Hartman
On Wed, Nov 11, 2020 at 11:02:41AM +0800, Frankie Chang wrote: > > Frankie.Chang (3): > binder: move structs from core file to header file > binder: add trace at free transaction. > binder: add transaction latency tracer > > drivers/android/Kconfig

[PATCH v13] binder: add transaction latency tracer

2020-11-10 Thread Frankie Chang
Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transaction latency tracer drivers/android/Kconfig | 8 + drivers/android/Makefile| 1 + drivers/android/binder.c

[PATCH v12] binder: add transaction latency tracer

2020-11-10 Thread Frankie Chang
ead of custom registration functions. Change from v2: - create transaction latency module to monitor slow transaction. Change from v1: - first patchset. Frankie.Chang (3): binder: move structs from core file to header file binder: add trace at free transaction. binder: add transact

  1   2   3   4   5   6   7   8   9   10   >