Re: Looping more in detach_tasks() when RT and CFS tasks are present

2020-06-24 Thread Pavan Kondeti
Hi Vincent, On Wed, Jun 24, 2020 at 02:39:25PM +0200, Vincent Guittot wrote: > Hi Pavan, > > On Wed, 24 Jun 2020 at 13:42, Pavan Kondeti wrote: > > > > Hi Vincent/Peter, > > > > in load_balance(), we derive env->loop_max based on rq->nr_running. > > When the busiest rq has both RT and CFS tasks,

Re: Looping more in detach_tasks() when RT and CFS tasks are present

2020-06-24 Thread Vincent Guittot
Hi Pavan, On Wed, 24 Jun 2020 at 13:42, Pavan Kondeti wrote: > > Hi Vincent/Peter, > > in load_balance(), we derive env->loop_max based on rq->nr_running. > When the busiest rq has both RT and CFS tasks, we do more loops in > detach_tasks(). Is there any reason for not using > rq->cfs.h_nr_runnin

Looping more in detach_tasks() when RT and CFS tasks are present

2020-06-24 Thread Pavan Kondeti
Hi Vincent/Peter, in load_balance(), we derive env->loop_max based on rq->nr_running. When the busiest rq has both RT and CFS tasks, we do more loops in detach_tasks(). Is there any reason for not using rq->cfs.h_nr_running? Lei Wen attempted to fix this before. https://lore.kernel.org/lkml/13768