Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-06-01 Thread Bjorn Helgaas
On Sat, May 30, 2020 at 04:33:44AM -0700, Christoph Hellwig wrote: > On Sat, May 30, 2020 at 08:14:34AM +0100, Matthew Garrett wrote: > > On Sat, May 30, 2020 at 08:33:50AM +0200, Heiner Kallweit wrote: > > > > > It *was* default y. This changed with a914ff2d78ce ("PCI/ASPM: Don't > > > select

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-06-01 Thread Rafael J. Wysocki
On Sat, May 30, 2020 at 1:34 PM Christoph Hellwig wrote: > > On Sat, May 30, 2020 at 08:14:34AM +0100, Matthew Garrett wrote: > > On Sat, May 30, 2020 at 08:33:50AM +0200, Heiner Kallweit wrote: > > > > > It *was* default y. This changed with a914ff2d78ce ("PCI/ASPM: Don't > > > select

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-30 Thread Christoph Hellwig
On Sat, May 30, 2020 at 08:14:34AM +0100, Matthew Garrett wrote: > On Sat, May 30, 2020 at 08:33:50AM +0200, Heiner Kallweit wrote: > > > It *was* default y. This changed with a914ff2d78ce ("PCI/ASPM: Don't > > select CONFIG_PCIEASPM by default") and that's what triggered the > > problem. If

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-30 Thread Matthew Garrett
On Sat, May 30, 2020 at 08:33:50AM +0200, Heiner Kallweit wrote: > It *was* default y. This changed with a914ff2d78ce ("PCI/ASPM: Don't > select CONFIG_PCIEASPM by default") and that's what triggered the > problem. If there's no easy solution, then maybe it's best to revert > the change for now.

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-30 Thread Heiner Kallweit
On 30.05.2020 00:58, Matthew Garrett wrote: > On Sat, May 30, 2020 at 12:26:17AM +0200, Heiner Kallweit wrote: > >> Current situation means that PME is unusable on all systems where >> pcie_aspm_support_enabled() returns false, what is basically every >> system except EXPERT mode is enabled and

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Matthew Garrett
On Sat, May 30, 2020 at 12:26:17AM +0200, Heiner Kallweit wrote: > Current situation means that PME is unusable on all systems where > pcie_aspm_support_enabled() returns false, what is basically every > system except EXPERT mode is enabled and CONFIG_PCIEASPM is set. > So we definitely need to

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Heiner Kallweit
On 29.05.2020 22:59, Matthew Garrett wrote: > On Fri, May 29, 2020 at 03:21:35PM -0500, Bjorn Helgaas wrote: > >> Yeah, that makes sense. I can't remember the details, but I'm pretty >> sure there's a reason why we ask for the whole set of things. Seems >> like it solved some problem. I think

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Matthew Garrett
On Fri, May 29, 2020 at 03:21:35PM -0500, Bjorn Helgaas wrote: > Yeah, that makes sense. I can't remember the details, but I'm pretty > sure there's a reason why we ask for the whole set of things. Seems > like it solved some problem. I think Matthew Garrett might have been > involved in that.

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Heiner Kallweit
On 29.05.2020 22:21, Bjorn Helgaas wrote: > [+cc Matthew] > > On Fri, May 29, 2020 at 10:09:08PM +0200, Heiner Kallweit wrote: >> On 29.05.2020 21:40, Heiner Kallweit wrote: >>> On 29.05.2020 21:21, Bjorn Helgaas wrote: On Fri, May 29, 2020 at 08:50:46PM +0200, Heiner Kallweit wrote: >

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Bjorn Helgaas
[+cc Matthew] On Fri, May 29, 2020 at 10:09:08PM +0200, Heiner Kallweit wrote: > On 29.05.2020 21:40, Heiner Kallweit wrote: > > On 29.05.2020 21:21, Bjorn Helgaas wrote: > >> On Fri, May 29, 2020 at 08:50:46PM +0200, Heiner Kallweit wrote: > >>> On 28.05.2020 23:44, Heiner Kallweit wrote: >

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Heiner Kallweit
On 29.05.2020 21:40, Heiner Kallweit wrote: > On 29.05.2020 21:21, Bjorn Helgaas wrote: >> [+cc Rafael, linux-kernel] >> >> On Fri, May 29, 2020 at 08:50:46PM +0200, Heiner Kallweit wrote: >>> On 28.05.2020 23:44, Heiner Kallweit wrote: For whatever reason with this change (and losing ASPM

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Heiner Kallweit
On 29.05.2020 21:21, Bjorn Helgaas wrote: > [+cc Rafael, linux-kernel] > > On Fri, May 29, 2020 at 08:50:46PM +0200, Heiner Kallweit wrote: >> On 28.05.2020 23:44, Heiner Kallweit wrote: >>> For whatever reason with this change (and losing ASPM control) I also >>> loose the PCIe PME interrupts.

Re: Lost PCIe PME after a914ff2d78ce ("PCI/ASPM: Don't select CONFIG_PCIEASPM by default")

2020-05-29 Thread Bjorn Helgaas
[+cc Rafael, linux-kernel] On Fri, May 29, 2020 at 08:50:46PM +0200, Heiner Kallweit wrote: > On 28.05.2020 23:44, Heiner Kallweit wrote: > > For whatever reason with this change (and losing ASPM control) I also > > loose the PCIe PME interrupts. This prevents my network card from > > resuming