Re: May close() return any error code?

2015-08-04 Thread Takashi Iwai
On Sun, 02 Aug 2015 16:07:06 +0200, Al Viro wrote: > > On Wed, Jul 29, 2015 at 07:45:11AM -0700, Dmitry Torokhov wrote: > > > This seems coming from evdev_flush(). As there is no fd leak, it's no > > > big problem per se. But, now the question is whether returning such > > > an error code is

Re: May close() return any error code?

2015-08-04 Thread Takashi Iwai
On Sun, 02 Aug 2015 16:07:06 +0200, Al Viro wrote: On Wed, Jul 29, 2015 at 07:45:11AM -0700, Dmitry Torokhov wrote: This seems coming from evdev_flush(). As there is no fd leak, it's no big problem per se. But, now the question is whether returning such an error code is correct

Re: May close() return any error code?

2015-08-02 Thread Al Viro
On Wed, Jul 29, 2015 at 07:45:11AM -0700, Dmitry Torokhov wrote: > > This seems coming from evdev_flush(). As there is no fd leak, it's no > > big problem per se. But, now the question is whether returning such > > an error code is correct behavior at all. At least, it doesn't seem > > defined

Re: May close() return any error code?

2015-08-02 Thread Al Viro
On Sun, Aug 02, 2015 at 09:42:20AM +0200, Pavel Machek wrote: > > This seems coming from evdev_flush(). As there is no fd leak, it's no > > big problem per se. But, now the question is whether returning such > > an error code is correct behavior at all. At least, it doesn't seem > > defined in

Re: May close() return any error code?

2015-08-02 Thread Pavel Machek
On Wed 2015-07-29 12:46:59, Takashi Iwai wrote: > Hi, > > while debugging a problem of X and gdm with the old systemd-210, we > encountered a sudden death of systemd-logind, and this turned out to > be an unexpected errno from close(). The close() call for input > devices returns ENODEV error.

Re: May close() return any error code?

2015-08-02 Thread Pavel Machek
On Wed 2015-07-29 12:46:59, Takashi Iwai wrote: Hi, while debugging a problem of X and gdm with the old systemd-210, we encountered a sudden death of systemd-logind, and this turned out to be an unexpected errno from close(). The close() call for input devices returns ENODEV error. The

Re: May close() return any error code?

2015-08-02 Thread Al Viro
On Wed, Jul 29, 2015 at 07:45:11AM -0700, Dmitry Torokhov wrote: This seems coming from evdev_flush(). As there is no fd leak, it's no big problem per se. But, now the question is whether returning such an error code is correct behavior at all. At least, it doesn't seem defined in

Re: May close() return any error code?

2015-08-02 Thread Al Viro
On Sun, Aug 02, 2015 at 09:42:20AM +0200, Pavel Machek wrote: This seems coming from evdev_flush(). As there is no fd leak, it's no big problem per se. But, now the question is whether returning such an error code is correct behavior at all. At least, it doesn't seem defined in POSIX:

Re: May close() return any error code?

2015-07-30 Thread Takashi Iwai
On Wed, 29 Jul 2015 16:45:11 +0200, Dmitry Torokhov wrote: > > HI Takashi, > > On Wed, Jul 29, 2015 at 12:46:59PM +0200, Takashi Iwai wrote: > > Hi, > > > > while debugging a problem of X and gdm with the old systemd-210, we > > encountered a sudden death of systemd-logind, and this turned out

Re: May close() return any error code?

2015-07-30 Thread Takashi Iwai
On Wed, 29 Jul 2015 16:45:11 +0200, Dmitry Torokhov wrote: HI Takashi, On Wed, Jul 29, 2015 at 12:46:59PM +0200, Takashi Iwai wrote: Hi, while debugging a problem of X and gdm with the old systemd-210, we encountered a sudden death of systemd-logind, and this turned out to be an

Re: May close() return any error code?

2015-07-29 Thread Dmitry Torokhov
HI Takashi, On Wed, Jul 29, 2015 at 12:46:59PM +0200, Takashi Iwai wrote: > Hi, > > while debugging a problem of X and gdm with the old systemd-210, we > encountered a sudden death of systemd-logind, and this turned out to > be an unexpected errno from close(). The close() call for input >

May close() return any error code?

2015-07-29 Thread Takashi Iwai
Hi, while debugging a problem of X and gdm with the old systemd-210, we encountered a sudden death of systemd-logind, and this turned out to be an unexpected errno from close(). The close() call for input devices returns ENODEV error. The logind in systemd-210 treats this error code as fatal,

May close() return any error code?

2015-07-29 Thread Takashi Iwai
Hi, while debugging a problem of X and gdm with the old systemd-210, we encountered a sudden death of systemd-logind, and this turned out to be an unexpected errno from close(). The close() call for input devices returns ENODEV error. The logind in systemd-210 treats this error code as fatal,

Re: May close() return any error code?

2015-07-29 Thread Dmitry Torokhov
HI Takashi, On Wed, Jul 29, 2015 at 12:46:59PM +0200, Takashi Iwai wrote: Hi, while debugging a problem of X and gdm with the old systemd-210, we encountered a sudden death of systemd-logind, and this turned out to be an unexpected errno from close(). The close() call for input devices