On Thu, Mar 01 2001, Jens Axboe wrote:
> I've suggested that before, turn ndb into ndb_make_request style
> driver and all of this will disappear. I'll give it a shot.
Here's a first shot, compile tested but that's it. Steve, does this
work for you? Against 2.4.2-ac7
--
Jens Axboe
diff -ur -
On Wed, Feb 28 2001, Linus Torvalds wrote:
> >I think most of the "we want to disable plugging" behaviour stems
> >from the way task queues behave. Once somebody starts a tq_disk
> >run, the list is fried and walked one by one. Both old loop
> >and nbd drop the io_request_lock and block, possibly
In article <[EMAIL PROTECTED]>, Jens Axboe <[EMAIL PROTECTED]> wrote:
>
>I think most of the "we want to disable plugging" behaviour stems
>from the way task queues behave. Once somebody starts a tq_disk
>run, the list is fried and walked one by one. Both old loop
>and nbd drop the io_request_loc
On Wed, Feb 28 2001, Linus Torvalds wrote:
> As far as I can tell, the patch will trigger only for a not-empty request
> list, where the elevator decides to put the new request at the head of the
> queue.
>
> Which is probably unlikely (and with the current elevator it might even be
> impossible)
On Wed, 28 Feb 2001, Steve Whitehouse wrote:
>
> I tested the patch with a printk() which printed whenever the new call to the
> request function was triggered. It didn't happen once in normal fs use
> with ext2 on a scsi disk.
As far as I can tell, the patch will trigger only for a not-empty
On Wed, Feb 28 2001, Steve Whitehouse wrote:
> > > The bug fix in ll_rw_blk.c prevents hangs when using block devices which
> > > don't have plugging functions,
> >
> > I'm convinced that the right fix is to just make everybody have plugging
> > functions.
> >
> I'm working on that. Once I've di
Hi,
>
>
>
> On Sun, 25 Feb 2001, Steve Whitehouse wrote:
> >
> > Here is a new version of the patch I recently sent to the list with some
> > NBD cleanups and a bug fix in ll_rw_blk.c. The changes to NBD have Pavel
> > Machek's approval as I've left out the two changes as he suggested.
> >
On Sun, 25 Feb 2001, Steve Whitehouse wrote:
>
> Here is a new version of the patch I recently sent to the list with some
> NBD cleanups and a bug fix in ll_rw_blk.c. The changes to NBD have Pavel
> Machek's approval as I've left out the two changes as he suggested.
>
> The bug fix in ll_rw_
Hi,
Oops, sorry. Updated patch below. Jens & Russell: Thanks for pointing
this out,
Steve.
>
> On Sun, Feb 25 2001, Russell King wrote:
> > On Sun, Feb 25, 2001 at 07:57:29PM +, Steve Whitehouse wrote:
> > > -int nbd_init(void)
> > > +int __init nbd_init(void)
> >
> > > -void cleanup_modu
On Sun, Feb 25 2001, Russell King wrote:
> On Sun, Feb 25, 2001 at 07:57:29PM +, Steve Whitehouse wrote:
> > -int nbd_init(void)
> > +int __init nbd_init(void)
>
> > -void cleanup_module(void)
> > +void __exit nbd_cleanup(void)
>
> > +
> > +module_init(nbd_init);
> > +module_exit(nbd_cleanup
On Sun, Feb 25, 2001 at 07:57:29PM +, Steve Whitehouse wrote:
> -int nbd_init(void)
> +int __init nbd_init(void)
> -void cleanup_module(void)
> +void __exit nbd_cleanup(void)
> +
> +module_init(nbd_init);
> +module_exit(nbd_cleanup);
If you're using module_init/module_exit, shouldn't nbd_in
On Sun, Feb 25 2001, Andrea Arcangeli wrote:
> On Sun, Feb 25, 2001 at 07:57:29PM +, Steve Whitehouse wrote:
> > The bug fix in ll_rw_blk.c prevents hangs when using block devices which
> > don't have plugging functions,
>
> It looks the right fix (better than 2.4.0 that didn't had such bug b
On Sun, Feb 25, 2001 at 07:57:29PM +, Steve Whitehouse wrote:
> The bug fix in ll_rw_blk.c prevents hangs when using block devices which
> don't have plugging functions,
It looks the right fix (better than 2.4.0 that didn't had such bug but that was
recalling the request_fn at every inserctio
Hi,
Here is a new version of the patch I recently sent to the list with some
NBD cleanups and a bug fix in ll_rw_blk.c. The changes to NBD have Pavel
Machek's approval as I've left out the two changes as he suggested.
The bug fix in ll_rw_blk.c prevents hangs when using block devices which
don
14 matches
Mail list logo
