[PATCH v26 07/10] fs/ntfs3: Add NTFS journal

2021-04-02 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5181 ++ 1 file changed, 5181 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index 0

[PATCH v26 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-04-02 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

fs/ntfs/aops.c:378:12: warning: stack frame size of 2288 bytes in function 'ntfs_readpage'

2021-03-27 Thread kernel test robot
fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> fs/ntfs/aops.c:378:12: warning: stack frame size of 2288 bytes in function >> 'ntfs_readpage' [-Wframe-larger-than=] static int ntfs_readpage

[PATCH v25 07/10] fs/ntfs3: Add NTFS journal

2021-03-27 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5208 ++ 1 file changed, 5208 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index 0

[PATCH v25 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-03-27 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

Re: [PATCH v2] ntfs: fix incorrect kernel-doc comment syntax in files

2021-03-22 Thread Randy Dunlap
On 3/22/21 10:11 AM, Aditya Srivastava wrote: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > There are certain files in fs/ntfs which follow this syntax, but the > content inside does not comply with kernel-doc. > Such line

[PATCH v2] ntfs: fix incorrect kernel-doc comment syntax in files

2021-03-22 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. There are certain files in fs/ntfs which follow this syntax, but the content inside does not comply with kernel-doc. Such lines were probably not meant for kernel-doc parsing, but are parsed due

Re: [PATCH] ntfs: fix incorrect kernel-doc comment syntax in files

2021-03-21 Thread Lukas Bulwahn
On Sat, Mar 20, 2021 at 5:29 PM Aditya Srivastava wrote: > > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > There are certain files in fs/ntfs which follow this syntax, but the > content inside does not comply with kernel-doc. &g

Re: [PATCH] ntfs: fix incorrect kernel-doc comment syntax in files

2021-03-20 Thread Randy Dunlap
LGTM. Thanks. Reviewed-by: Randy Dunlap

[PATCH] ntfs: fix incorrect kernel-doc comment syntax in files

2021-03-20 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. There are certain files in fs/ntfs which follow this syntax, but the content inside does not comply with kernel-doc. Such lines were probably not meant for kernel-doc parsing, but are parsed due

[PATCH v24 07/10] fs/ntfs3: Add NTFS journal

2021-03-19 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5206 ++ 1 file changed, 5206 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v24 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-03-19 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

[PATCH v23 07/10] fs/ntfs3: Add NTFS journal

2021-03-15 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5202 ++ 1 file changed, 5202 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v23 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-03-15 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

Re: [PATCH v22 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-03-04 Thread Miguel Ojeda
On Thu, Mar 4, 2021 at 1:09 AM Konstantin Komarov wrote: > > - use clang-format 11.0 instead of 10.0 to format code Out of curiosity: was this due to some specific reason? i.e. have you found it provides better output? (it is useful to know this to justify later an increase of the minimum

[PATCH 4.19 004/247] ntfs: check for valid standard information attribute

2021-03-01 Thread Greg Kroah-Hartman
From: Rustam Kovhaev commit 4dfe6bd94959222e18d512bdf15f6bf9edb9c27c upstream. Mounting a corrupted filesystem with NTFS resulted in a kernel crash. We should check for valid STANDARD_INFORMATION attribute offset and length before trying to access it Link: https://lkml.kernel.org/r

[PATCH 4.14 003/176] ntfs: check for valid standard information attribute

2021-03-01 Thread Greg Kroah-Hartman
From: Rustam Kovhaev commit 4dfe6bd94959222e18d512bdf15f6bf9edb9c27c upstream. Mounting a corrupted filesystem with NTFS resulted in a kernel crash. We should check for valid STANDARD_INFORMATION attribute offset and length before trying to access it Link: https://lkml.kernel.org/r

[PATCH 4.9 003/134] ntfs: check for valid standard information attribute

2021-03-01 Thread Greg Kroah-Hartman
From: Rustam Kovhaev commit 4dfe6bd94959222e18d512bdf15f6bf9edb9c27c upstream. Mounting a corrupted filesystem with NTFS resulted in a kernel crash. We should check for valid STANDARD_INFORMATION attribute offset and length before trying to access it Link: https://lkml.kernel.org/r

[PATCH 4.4 04/93] ntfs: check for valid standard information attribute

2021-03-01 Thread Greg Kroah-Hartman
From: Rustam Kovhaev commit 4dfe6bd94959222e18d512bdf15f6bf9edb9c27c upstream. Mounting a corrupted filesystem with NTFS resulted in a kernel crash. We should check for valid STANDARD_INFORMATION attribute offset and length before trying to access it Link: https://lkml.kernel.org/r

[PATCH v22 07/10] fs/ntfs3: Add NTFS journal

2021-03-01 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5202 ++ 1 file changed, 5202 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v22 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-03-01 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

[PATCH 5.4 05/17] ntfs: check for valid standard information attribute

2021-02-25 Thread Greg Kroah-Hartman
From: Rustam Kovhaev commit 4dfe6bd94959222e18d512bdf15f6bf9edb9c27c upstream. Mounting a corrupted filesystem with NTFS resulted in a kernel crash. We should check for valid STANDARD_INFORMATION attribute offset and length before trying to access it Link: https://lkml.kernel.org/r

[PATCH 5.10 08/23] ntfs: check for valid standard information attribute

2021-02-25 Thread Greg Kroah-Hartman
From: Rustam Kovhaev commit 4dfe6bd94959222e18d512bdf15f6bf9edb9c27c upstream. Mounting a corrupted filesystem with NTFS resulted in a kernel crash. We should check for valid STANDARD_INFORMATION attribute offset and length before trying to access it Link: https://lkml.kernel.org/r

[PATCH 5.11 05/12] ntfs: check for valid standard information attribute

2021-02-25 Thread Greg Kroah-Hartman
From: Rustam Kovhaev commit 4dfe6bd94959222e18d512bdf15f6bf9edb9c27c upstream. Mounting a corrupted filesystem with NTFS resulted in a kernel crash. We should check for valid STANDARD_INFORMATION attribute offset and length before trying to access it Link: https://lkml.kernel.org/r

Re: [PATCH] ntfs: check for valid standard information attribute

2021-02-22 Thread Rustam Kovhaev
On Mon, Feb 22, 2021 at 02:18:50PM +, Anton Altaparmakov wrote: > Rustam would you like to resubmit with an improved/extended description? sure thing, no problem! > when resubmitting with better description, please also add the > "Cc: sta...@vger.kernel.org" line together with the

Re: [PATCH] ntfs: check for valid standard information attribute

2021-02-22 Thread Anton Altaparmakov
t; we should check for valid STANDARD_INFORMATION attribute offset and >>> length before trying to access it > > It's a kernel a crash and I assume it results from mounting a corrupted > filesystem? > > I think it's worth a cc:stable, yes? The problem is an invalid memory access du

Re: [PATCH] ntfs: check for valid standard information attribute

2021-02-19 Thread Andrew Morton
On Fri, 19 Feb 2021 01:54:30 + Anton Altaparmakov wrote: > Hi Andrew, > > Can you please push this one upstream? Thanks a lot in advance! The changelog is a bit brief... > > > On 17 Feb 2021, at 15:59, Rustam Kovhaev wrote: > > > > we should check for valid STANDARD_INFORMATION

Re: [PATCH] ntfs: check for valid standard information attribute

2021-02-18 Thread Anton Altaparmakov
eported-and-tested-by: syzbot+c584225dabdea2f71...@syzkaller.appspotmail.com > Signed-off-by: Rustam Kovhaev > Acked-by: Anton Altaparmakov > Link: https://syzkaller.appspot.com/bug?extid=c584225dabdea2f71969 > --- > fs/ntfs/inode.c | 6 ++ > 1 file changed, 6 insertions(+) > &

[PATCH] ntfs: check for valid standard information attribute

2021-02-17 Thread Rustam Kovhaev
=c584225dabdea2f71969 --- fs/ntfs/inode.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c index f7e4cbc26eaf..be4ff9386ec0 100644 --- a/fs/ntfs/inode.c +++ b/fs/ntfs/inode.c @@ -629,6 +629,12 @@ static int ntfs_read_locked_inode(struct inode *vi

Re: [PATCH] ntfs: move check for valid resident attribute offset and length

2021-02-16 Thread Rustam Kovhaev
On Tue, Feb 16, 2021 at 02:40:37AM +, Anton Altaparmakov wrote: > Hi Rustam, > > Thank you for the patch but it is not quite correct: > > 1) The first delta: yes that is a good idea to add this check but the error > message is incorrect. It should say "Corrupt standard information

Re: [PATCH] ntfs: move check for valid resident attribute offset and length

2021-02-15 Thread Anton Altaparmakov
ug > > Reported-and-tested-by: syzbot+c584225dabdea2f71...@syzkaller.appspotmail.com > Signed-off-by: Rustam Kovhaev > Link: https://syzkaller.appspot.com/bug?extid=c584225dabdea2f71969 > --- > fs/ntfs/inode.c | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-)

Re: [PATCH v21 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-02-14 Thread kasep pisan
-rwxrwxrwx 1 root root 8230 Oct 19 17:02 Layer.js < this file is ok > -? ? ???? NlsStrings.js < this file is > inaccessible > ... > > To reproduce the issue try to mount a NTFS partition with deep > structure and large files amout. Then run on it some recursive f

[PATCH] ntfs: move check for valid resident attribute offset and length

2021-02-14 Thread Rustam Kovhaev
...@syzkaller.appspotmail.com Signed-off-by: Rustam Kovhaev Link: https://syzkaller.appspot.com/bug?extid=c584225dabdea2f71969 --- fs/ntfs/inode.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c index f7e4cbc26eaf..70745aea5106 100644 --- a/fs/ntfs/inode.c

Re: [PATCH v21 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-02-13 Thread Hanabishi Recca
drwxrwxrwx 1 root root 12288 Oct 20 10:42 .. -rwxrwxrwx 1 root root 8230 Oct 19 17:02 Layer.js < this file is ok -? ? ???? NlsStrings.js < this file is inaccessible ... To reproduce the issue try to mount a NTFS partition with deep structure and large fil

Re: [PATCH v21 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-02-12 Thread Oleksandr Natalenko
Hi. On Fri, Feb 12, 2021 at 07:24:06PM +0300, Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > … > v21: > - fixes for clang CFI checks > - fixed sb->s_maxbytes for 32bit clusters > - user.DOSATTRIB is no more intercepted by ntfs3 >

[PATCH v21 07/10] fs/ntfs3: Add NTFS journal

2021-02-12 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5204 ++ 1 file changed, 5204 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v21 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-02-12 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

Re: [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-02-06 Thread Oleksandr Natalenko
On Sat, Feb 06, 2021 at 05:57:45PM +0100, Oleksandr Natalenko wrote: > On Sat, Feb 06, 2021 at 01:43:10AM +0500, Hanabishi Recca wrote: > > Can't even build v20 due to compilation errors. > > Try this please: http://ix.io/2OwR Slightly reworked version: http://ix.io/2Oxa -- Oleksandr

Re: [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-02-06 Thread Oleksandr Natalenko
On Sat, Feb 06, 2021 at 01:43:10AM +0500, Hanabishi Recca wrote: > Can't even build v20 due to compilation errors. Try this please: http://ix.io/2OwR -- Oleksandr Natalenko (post-factum)

Re: [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-02-06 Thread Oleksandr Natalenko
On Sat, Feb 06, 2021 at 01:43:10AM +0500, Hanabishi Recca wrote: > Can't even build v20 due to compilation errors. I think this submission is based against linux-next branch where idmapped mounts are introduced, hence it is not applicable to v5.10 and v5.11 any more. -- Oleksandr Natalenko

Re: [PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-02-05 Thread Hanabishi Recca
Can't even build v20 due to compilation errors. DKMS make.log for ntfs3-20.0.0 for kernel 5.10.13-arch1-1 (x86_64) Sat Feb 6 01:20:00 +05 2021 make -C /lib/modules/5.10.13-arch1-1/build M=/var/lib/dkms/ntfs3/20.0.0/build modules make[1]: Entering directory

[PATCH v20 07/10] fs/ntfs3: Add NTFS journal

2021-02-05 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5204 ++ 1 file changed, 5204 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v20 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-02-05 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

[PATCH] ntfs: remove unneeded semicolon

2021-02-02 Thread Yang Li
Eliminate the following coccicheck warning: ./fs/ntfs/super.c:1615:2-3: Unneeded semicolon ./fs/ntfs/super.c:1684:2-3: Unneeded semicolon Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/ntfs/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ntfs/super.c

fs/ntfs/aops.c:899:12: warning: stack frame size of 2528 bytes in function 'ntfs_write_mst_block'

2021-02-02 Thread kernel test robot
, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> fs/ntfs/aops.c:899:12: warning: stack frame size of 2528 bytes in function >> 'ntfs_write_mst_block' [-Wframe-larger-than=] static int ntfs_write_mst_block

[PATCH v19 07/10] fs/ntfs3: Add NTFS journal

2021-01-28 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5204 ++ 1 file changed, 5204 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v19 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-01-28 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

[PATCH RESEND2] ntfs: layout.h: delete duplicated words

2021-01-25 Thread Randy Dunlap
Drop the repeated words "the" and "in" in comments. Signed-off-by: Randy Dunlap Cc: Anton Altaparmakov Cc: linux-ntfs-...@lists.sourceforge.net Acked-by: Anton Altaparmakov Cc: Andrew Morton --- Andrew, Anton asked you to merge this patch: https://lore.kernel.org/lkm

[PATCH v18 00/10] NTFS read-write driver GPL implementation by Paragon Software

2021-01-22 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

[PATCH v18 07/10] fs/ntfs3: Add NTFS journal

2021-01-22 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5204 ++ 1 file changed, 5204 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

Re: [PATCH v17 07/10] fs/ntfs3: Add NTFS journal

2021-01-03 Thread Kari Argillander
On Thu, Dec 31, 2020 at 06:23:58PM +0300, Konstantin Komarov wrote: > This adds NTFS journal > > Signed-off-by: Konstantin Komarov > --- > fs/ntfs3/fslog.c | 5220 ++ > 1 file changed, 5220 insertions(+) > create mode 10

[PATCH v17 07/10] fs/ntfs3: Add NTFS journal

2020-12-31 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5220 ++ 1 file changed, 5220 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v17 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-12-31 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

[PATCH v16 07/10] fs/ntfs3: Add NTFS journal

2020-12-25 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5220 ++ 1 file changed, 5220 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v16 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-12-25 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

ntfs: extern vs inline?

2020-12-17 Thread Joe Perches
Hello Anton. I was looking around for bare inline uses and found this in fs/ntfs/inode.[ch]: $ git grep -w ntfs_new_extent_inode fs/ntfs/inode.c:inline ntfs_inode *ntfs_new_extent_inode(struct super_block *sb, fs/ntfs/inode.h:extern ntfs_inode *ntfs_new_extent_inode(struct super_block *sb, fs

[PATCH v15 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-12-11 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

[PATCH v15 07/10] fs/ntfs3: Add NTFS journal

2020-12-11 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5220 ++ 1 file changed, 5220 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

2020-12-09 Thread Zheng Zengkai
On 10 Dec 2020, at 02:36, Andrew Morton wrote: On Tue, 8 Dec 2020 08:24:02 + Anton Altaparmakov wrote: Can you please apply this? ... --- a/fs/ntfs/logfile.c +++ b/fs/ntfs/logfile.c @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

2020-12-09 Thread Anton Altaparmakov
:36, Andrew Morton wrote: > > On Tue, 8 Dec 2020 08:24:02 + Anton Altaparmakov wrote: > >> Can you please apply this? >> >> ... >> >>> --- a/fs/ntfs/logfile.c >>> +++ b/fs/ntfs/logfile.c >>> @@ -507,7 +507,7 @@ bool ntfs_ch

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

2020-12-09 Thread Andrew Morton
On Tue, 8 Dec 2020 08:24:02 + Anton Altaparmakov wrote: > Can you please apply this? > > ... > > > --- a/fs/ntfs/logfile.c > > +++ b/fs/ntfs/logfile.c > > @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, > > RESTART_PAGE_HEADER **r

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

2020-12-08 Thread Anton Altaparmakov
Hi Andrew, Can you please apply this? Thanks a lot in advance! Hi Zheng, Thank you for the patch! Best regards, Anton > On 12 Mar 2020, at 04:13, Zheng Zengkai wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > fs/ntfs/logfile.c: In function ntfs_chec

[PATCH v14 07/10] fs/ntfs3: Add NTFS journal

2020-12-04 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5220 ++ 1 file changed, 5220 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v14 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-12-04 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

RE: [PATCH v12 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-11-30 Thread Konstantin Komarov
@perches.com; m...@harmstone.com; > nbori...@suse.com; linux-ntfs-...@lists.sourceforge.net; > an...@tuxera.com; dan.carpen...@oracle.com; h...@lst.de; ebigg...@kernel.org; > Konstantin Komarov > > Subject: Re: [PATCH v12 00/10] NTFS read-write driver GPL implementation by > Paragon Softw

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

2020-11-27 Thread Zheng Zengkai
Ping... Fixes gcc '-Wunused-but-set-variable' warning: fs/ntfs/logfile.c: In function ntfs_check_logfile: fs/ntfs/logfile.c:481:21: warning: variable log_page_mask set but not used [-Wunused-but-set-variable] Actually log_page_mask can be used to replace 'log_page_size - 1' as it is set

[PATCH v13 07/10] fs/ntfs3: Add NTFS journal

2020-11-20 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5220 ++ 1 file changed, 5220 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v13 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-11-20 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

Re: [PATCH v12 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-11-10 Thread Aurélien Aptel
Hi Konstantin, Have you looked at Eric Biggers last comments regarding KASAN and lockdep? You can enable KASAN in menuconfig in Kernel hacking > Memory debugging > KASAN. With v12 I'm still seeing the out-of-bound read and potential deadlock. The bad read: [ 69.496132] BUG: KASAN:

Re: [PATCH] fs/ntfs: remove unused varibles

2020-11-09 Thread Anton Altaparmakov
Hi, Andrew, please can you merge this? Thanks a lot in advance! Alex, thank you for the patch! Best regards, Anton > On 8 Nov 2020, at 07:38, Alex Shi wrote: > > We actually don't use these varibles, so remove them to avoid gcc warning: > fs/ntfs/file.c:326:14: warni

Re: [PATCH] fs/ntfs: remove unused varible attr_len

2020-11-09 Thread Anton Altaparmakov
Hi Andrew, Can you also please merge this one? Thanks a lot in advance! Alex, again, thank you for the patch! Best regards, Anton > On 8 Nov 2020, at 08:06, Alex Shi wrote: > From: Alex Shi > Date: Sun, 8 Nov 2020 15:52:32 +0800 > Subject: [PATCH] fs/ntfs: remove un

Re: [PATCH] fs/ntfs: remove unused varible attr_len

2020-11-08 Thread Alex Shi
Nov 2020 15:52:32 +0800 Subject: [PATCH] fs/ntfs: remove unused varible attr_len MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This varible isn't used anymore, remove it to skip W=1 warning: fs/ntfs/inode.c:2350:6: warning: variable ‘attr_len’ set but

[PATCH] fs/ntfs: remove unused varible attr_len

2020-11-07 Thread Alex Shi
This varible isn't used anymore, remove it to skip W=1 warning: fs/ntfs/inode.c:2350:6: warning: variable ‘attr_len’ set but not used [-Wunused-but-set-variable] Signed-off-by: Alex Shi Cc: Anton Altaparmakov Cc: linux-ntfs-...@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org --- fs

[PATCH] fs/ntfs: remove unused varibles

2020-11-07 Thread Alex Shi
We actually don't use these varibles, so remove them to avoid gcc warning: fs/ntfs/file.c:326:14: warning: variable ‘base_ni’ set but not used [-Wunused-but-set-variable] fs/ntfs/logfile.c:481:21: warning: variable ‘log_page_mask’ set but not used [-Wunused-but-set-variable] Signed-off-by: Alex

[PATCH v12 07/10] fs/ntfs3: Add NTFS journal

2020-11-06 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5221 ++ 1 file changed, 5221 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v12 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-11-06 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

[PATCH] NTFS: Add name sanity check to ntfs_attr_find

2020-11-02 Thread Fox Chen
-by: syzbot+ecbcf37464c627253...@syzkaller.appspotmail.com Signed-off-by: Fox Chen --- fs/ntfs/attrib.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c index d563abc3e136..e7366f74ff62 100644 --- a/fs/ntfs/attrib.c +++ b/fs/ntfs/attrib.c

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-31 Thread Christoph Hellwig
On Fri, Oct 30, 2020 at 05:41:22PM +0100, Pali Rohár wrote: > I would like to open discussion about two ntfs kernel drivers. Do we > really need two drivers (one read only - current version and one > read/write - this new version)? > > What other people think? > > I re

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Eric Biggers
On Fri, Oct 30, 2020 at 07:42:09PM -0700, Eric Biggers wrote: > Hi Konstantin, > > On Fri, Oct 30, 2020 at 06:02:29PM +0300, Konstantin Komarov wrote: > > This patch adds NTFS Read-Write driver to fs/ntfs3. > > > > Having decades of expertise in commercial file s

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Eric Biggers
Hi Konstantin, On Fri, Oct 30, 2020 at 06:02:29PM +0300, Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Having decades of expertise in commercial file systems development and huge > test coverage, we at Paragon Software GmbH want to make our

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Pali Rohár
h > create mode 100644 fs/ntfs3/ntfs_fs.h > create mode 100644 fs/ntfs3/record.c > create mode 100644 fs/ntfs3/run.c > create mode 100644 fs/ntfs3/super.c > create mode 100644 fs/ntfs3/upcase.c > create mode 100644 fs/ntfs3/xattr.c I would like to open discussion about two

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Pali Rohár
aap...@suse.com; > > wi...@infradead.org; rdun...@infradead.org; j...@perches.com; > > m...@harmstone.com; nbori...@suse.com; linux-ntfs- > > d...@lists.sourceforge.net; an...@tuxera.com > > Subject: Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by

RE: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Konstantin Komarov
.@harmstone.com; nbori...@suse.com; linux-ntfs- > d...@lists.sourceforge.net; an...@tuxera.com > Subject: Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by > Paragon Software > > Hello and thanks for update! > > I have just two comments for the last v11 versio

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Pali Rohár
Hello and thanks for update! I have just two comments for the last v11 version. I really do not like nls_alt mount option and I do not think we should merge this mount option into ntfs kernel driver. Details I described in: https://lore.kernel.org/linux-fsdevel/20201009154734.andv4es3azkkskm5

[PATCH v11 07/10] fs/ntfs3: Add NTFS journal

2020-10-30 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5221 ++ 1 file changed, 5221 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

[PATCH 4.4 087/112] ntfs: add check for mft record size in superblock

2020-10-27 Thread Greg Kroah-Hartman
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH 4.14 154/191] ntfs: add check for mft record size in superblock

2020-10-27 Thread Greg Kroah-Hartman
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH 5.9 673/757] ntfs: add check for mft record size in superblock

2020-10-27 Thread Greg Kroah-Hartman
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH 5.8 557/633] ntfs: add check for mft record size in superblock

2020-10-27 Thread Greg Kroah-Hartman
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH 5.4 348/408] ntfs: add check for mft record size in superblock

2020-10-27 Thread Greg Kroah-Hartman
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH 4.19 225/264] ntfs: add check for mft record size in superblock

2020-10-27 Thread Greg Kroah-Hartman
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH 4.9 109/139] ntfs: add check for mft record size in superblock

2020-10-27 Thread Greg Kroah-Hartman
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH v10 07/10] fs/ntfs3: Add NTFS journal

2020-10-23 Thread Konstantin Komarov
This adds NTFS journal Signed-off-by: Konstantin Komarov --- fs/ntfs3/fslog.c | 5227 ++ 1 file changed, 5227 insertions(+) create mode 100644 fs/ntfs3/fslog.c diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c new file mode 100644 index

[PATCH v10 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-23 Thread Konstantin Komarov
This patch adds NTFS Read-Write driver to fs/ntfs3. Having decades of expertise in commercial file systems development and huge test coverage, we at Paragon Software GmbH want to make our contribution to the Open Source Community by providing implementation of NTFS Read-Write driver for the Linux

[PATCH AUTOSEL 5.8 034/101] ntfs: add check for mft record size in superblock

2020-10-18 Thread Sasha Levin
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH AUTOSEL 4.14 21/52] ntfs: add check for mft record size in superblock

2020-10-18 Thread Sasha Levin
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH AUTOSEL 4.9 16/41] ntfs: add check for mft record size in superblock

2020-10-18 Thread Sasha Levin
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH AUTOSEL 4.4 11/33] ntfs: add check for mft record size in superblock

2020-10-18 Thread Sasha Levin
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

[PATCH AUTOSEL 4.19 22/56] ntfs: add check for mft record size in superblock

2020-10-18 Thread Sasha Levin
From: Rustam Kovhaev [ Upstream commit 4f8c94022f0bc3babd0a124c0a7dcdd7547bd94e ] Number of bytes allocated for mft record should be equal to the mft record size stored in ntfs superblock as reported by syzbot, userspace might trigger out-of-bounds read by dereferencing ctx->a

  1   2   3   4   5   6   7   8   9   10   >