/20190123173707.ga16...@gmail.com/
Link: https://lore.kernel.org/lkml/20190206175627.ga20...@gmail.com/
Suggested-by: Martin Sebor
Acked-by: Jessica Yu
Signed-off-by: Miguel Ojeda
Signed-off-by: Sasha Levin
---
include/linux/module.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
-Hartman
---
include/linux/module.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -129,13 +129,13 @@ extern void cleanup_module(void);
#define module_init(initfn)\
static inline
://lore.kernel.org/lkml/20190123173707.ga16...@gmail.com/
Link: https://lore.kernel.org/lkml/20190206175627.ga20...@gmail.com/
Suggested-by: Martin Sebor
Acked-by: Jessica Yu
Signed-off-by: Miguel Ojeda
Signed-off-by: Stefan Agner
Signed-off-by: Greg Kroah-Hartman
---
include/linux/module.h |4
://lore.kernel.org/lkml/20190123173707.ga16...@gmail.com/
Link: https://lore.kernel.org/lkml/20190206175627.ga20...@gmail.com/
Suggested-by: Martin Sebor
Acked-by: Jessica Yu
Signed-off-by: Miguel Ojeda
Signed-off-by: Stefan Agner
Signed-off-by: Greg Kroah-Hartman
---
include/linux/module.h |4
On 3/29/19 11:09 AM, Nick Desaulniers wrote:
> On Fri, Mar 29, 2019 at 11:01 AM Randy Dunlap wrote:
>>
>> On 3/29/19 10:45 AM, Nick Desaulniers wrote:
>>> Fixes commit 8c3d220cb6b5 ("gcov: clang support")
>>>
>>> Cc: Greg Hackmann
>>> Cc: Tri Vo
>>> Cc: Peter Oberparleiter
>>> Cc:
On Fri, Mar 29, 2019 at 11:01 AM Randy Dunlap wrote:
>
> On 3/29/19 10:45 AM, Nick Desaulniers wrote:
> > Fixes commit 8c3d220cb6b5 ("gcov: clang support")
> >
> > Cc: Greg Hackmann
> > Cc: Tri Vo
> > Cc: Peter Oberparleiter
> > Cc: linux...@kvack.org
> > Cc: kbuild-...@01.org
> > Reported-by:
On 3/29/19 11:01 AM, Randy Dunlap wrote:
> On 3/29/19 10:45 AM, Nick Desaulniers wrote:
>> Fixes commit 8c3d220cb6b5 ("gcov: clang support")
>>
>> Cc: Greg Hackmann
>> Cc: Tri Vo
>> Cc: Peter Oberparleiter
>> Cc: linux...@kvack.org
>> Cc: kbuild-...@01.org
>> Reported-by: kbuild test robot
>>
On 3/29/19 10:45 AM, Nick Desaulniers wrote:
> Fixes commit 8c3d220cb6b5 ("gcov: clang support")
>
> Cc: Greg Hackmann
> Cc: Tri Vo
> Cc: Peter Oberparleiter
> Cc: linux...@kvack.org
> Cc: kbuild-...@01.org
> Reported-by: kbuild test robot
> Link:
Fixes commit 8c3d220cb6b5 ("gcov: clang support")
Cc: Greg Hackmann
Cc: Tri Vo
Cc: Peter Oberparleiter
Cc: linux...@kvack.org
Cc: kbuild-...@01.org
Reported-by: kbuild test robot
Link: https://marc.info/?l=linux-mm=155384681109231=2
Signed-off-by: Nick Desaulniers
---
kernel/gcov/gcc_3_4.c
...@gmail.com/
Link: https://lore.kernel.org/lkml/20190206175627.ga20...@gmail.com/
Suggested-by: Martin Sebor
Signed-off-by: Miguel Ojeda
Acked-by: Jessica Yu
Thanks!
---
include/linux/module.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/module.h b
/lkml/20190206175627.ga20...@gmail.com/
Suggested-by: Martin Sebor
Signed-off-by: Miguel Ojeda
---
include/linux/module.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/module.h b/include/linux/module.h
index 8fa38d3e7538..f5bc4c046461 100644
--- a/include
On Thu, Feb 7, 2019 at 11:54 AM Jessica Yu wrote:
>
> My order of preference would be 2, 1, striving for 3 eventually.
For reference, for 3), we would need to tweak the following ~130
modules [1]. Quite a lot of them are the simple kind. Also, if we end
up with 3), we could potentially remove a
+++ Miguel Ojeda [06/02/19 22:19 +0100]:
On Wed, Feb 6, 2019 at 6:56 PM Miguel Ojeda
wrote:
diff --git a/include/linux/module.h b/include/linux/module.h
index 8fa38d3e7538..1b5e370f1bc0 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -129,13 +129,13 @@ extern void
On Wed, Feb 6, 2019 at 6:56 PM Miguel Ojeda
wrote:
>
> diff --git a/include/linux/module.h b/include/linux/module.h
> index 8fa38d3e7538..1b5e370f1bc0 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -129,13 +129,13 @@ extern void cleanup_module
be assumed to be unlikely).
Link: https://lore.kernel.org/lkml/20190123173707.ga16...@gmail.com/
Suggested-by: Martin Sebor
Tested-by: Laura Abbott
Signed-off-by: Miguel Ojeda
---
The new version I pushed for -next.
include/linux/module.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
On Wed, Feb 6, 2019 at 5:31 PM Miguel Ojeda
wrote:
>
> On Mon, Feb 4, 2019 at 4:08 PM Jessica Yu wrote:
> >
> > IMHO I think annotating with __init is more straightforward, instead
> > of cherry-picking attributes (we wouldn't know at first glance why the
> > aliases are specifically annotated
On Mon, Feb 4, 2019 at 4:08 PM Jessica Yu wrote:
>
> IMHO I think annotating with __init is more straightforward, instead
> of cherry-picking attributes (we wouldn't know at first glance why the
> aliases are specifically annotated with __cold without looking at git
> history). Plus the actual
+++ Miguel Ojeda [31/01/19 17:48 +0100]:
Hi Jessica,
On Thu, Jan 31, 2019 at 3:22 PM Jessica Yu wrote:
Hi Miguel, sorry for the delay!
No worries! :)
The module init functions are only called once from do_init_module().
Does the __cold attribute just assume it is unlikely to be executed,
Hi Jessica,
On Thu, Jan 31, 2019 at 3:22 PM Jessica Yu wrote:
>
> Hi Miguel, sorry for the delay!
No worries! :)
> The module init functions are only called once from do_init_module().
> Does the __cold attribute just assume it is unlikely to be executed,
> or just that it is infrequently
this in the compiler-attributes tree and get
some time in linux-next, unless you want to pick it up!
include/linux/module.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/module.h b/include/linux/module.h
index 8fa38d3e7538..c4e805e87628 100644
--- a/include/linux
paths that end up
calling the __init/__exit functions are not meant to be taken
(but when we are asked to load modules, that is the expected
path, no?).
I will put this in the compiler-attributes tree and get
some time in linux-next, unless you want to pick it up!
include/linux/module.h | 4
functions are not meant to be taken
(but when we are asked to load modules, that is the expected
path, no?).
I will put this in the compiler-attributes tree and get
some time in linux-next, unless you want to pick it up!
include/linux/module.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
The patch
ASoC: intel: include linux/module.h as needed
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent
The patch
ASoC: intel: include linux/module.h as needed
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent
The MODULE_DESCRIPTION() macro is only available when including
the linux/module.h header. Apparently this is included indirectly
from sst-firmware.c in some configurations, but not in others:
sound/soc/intel/common/sst-firmware.c:1278:20: error: expected declaration
specifiers or '...' before
The MODULE_DESCRIPTION() macro is only available when including
the linux/module.h header. Apparently this is included indirectly
from sst-firmware.c in some configurations, but not in others:
sound/soc/intel/common/sst-firmware.c:1278:20: error: expected declaration
specifiers or '...' before
On Fri, 2017-02-17 at 15:38 +0100, Arnd Bergmann wrote:
> I ran into a build error on arm64 randconfig testing:
>
> infiniband/hw/hns/hns_roce_main.c:539:1: error: data definition has
> no type or storage class [-Werror]
> infiniband/hw/hns/hns_roce_main.c:539:1: error: type defaults to
> 'int'
On Fri, 2017-02-17 at 15:38 +0100, Arnd Bergmann wrote:
> I ran into a build error on arm64 randconfig testing:
>
> infiniband/hw/hns/hns_roce_main.c:539:1: error: data definition has
> no type or storage class [-Werror]
> infiniband/hw/hns/hns_roce_main.c:539:1: error: type defaults to
> 'int'
I ran into a build error on arm64 randconfig testing:
infiniband/hw/hns/hns_roce_main.c:539:1: error: data definition has no type or
storage class [-Werror]
infiniband/hw/hns/hns_roce_main.c:539:1: error: type defaults to 'int' in
declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
I ran into a build error on arm64 randconfig testing:
infiniband/hw/hns/hns_roce_main.c:539:1: error: data definition has no type or
storage class [-Werror]
infiniband/hw/hns/hns_roce_main.c:539:1: error: type defaults to 'int' in
declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
On Wednesday, July 6, 2016 9:21:39 AM CEST Paul Gortmaker wrote:
> > --- a/drivers/pinctrl/freescale/pinctrl-imx21.c
> > +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
> > @@ -325,7 +325,6 @@ static const struct of_device_id
> > imx21_pinctrl_of_match[] =
> > { .compatible =
On Wednesday, July 6, 2016 9:21:39 AM CEST Paul Gortmaker wrote:
> > --- a/drivers/pinctrl/freescale/pinctrl-imx21.c
> > +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
> > @@ -325,7 +325,6 @@ static const struct of_device_id
> > imx21_pinctrl_of_match[] =
> > { .compatible =
[Re: [PATCH] pinctrl: imx21: include linux/module.h] On 06/07/2016 (Wed 10:15)
Fabio Estevam wrote:
> Hi Arnd,
>
> On Wed, Jul 6, 2016 at 9:52 AM, Arnd Bergmann <a...@arndb.de> wrote:
> > The pinctrl driver includes a device table, but the macro used for
> > declaring
[Re: [PATCH] pinctrl: imx21: include linux/module.h] On 06/07/2016 (Wed 10:15)
Fabio Estevam wrote:
> Hi Arnd,
>
> On Wed, Jul 6, 2016 at 9:52 AM, Arnd Bergmann wrote:
> > The pinctrl driver includes a device table, but the macro used for
> > declaring it is
On Wednesday, July 6, 2016 10:15:41 AM CEST Fabio Estevam wrote:
> I think the correct fix here would be:
>
> --- a/drivers/pinctrl/freescale/pinctrl-imx21.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
> @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[]
> =
>
On Wednesday, July 6, 2016 10:15:41 AM CEST Fabio Estevam wrote:
> I think the correct fix here would be:
>
> --- a/drivers/pinctrl/freescale/pinctrl-imx21.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c
> @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[]
> =
>
Hi Arnd,
On Wed, Jul 6, 2016 at 9:52 AM, Arnd Bergmann wrote:
> The pinctrl driver includes a device table, but the macro used for
> declaring it is declared in a header that is not visible here:
>
> drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has
> no
Hi Arnd,
On Wed, Jul 6, 2016 at 9:52 AM, Arnd Bergmann wrote:
> The pinctrl driver includes a device table, but the macro used for
> declaring it is declared in a header that is not visible here:
>
> drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has
> no type or
The pinctrl driver includes a device table, but the macro used for
declaring it is declared in a header that is not visible here:
drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no
type or storage class [-Werror]
MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
This
The pinctrl driver includes a device table, but the macro used for
declaring it is declared in a header that is not visible here:
drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no
type or storage class [-Werror]
MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
This
Otherwise an apptempt to build sync_debug.o as modules results in
compiler errors:
CC [M] drivers/staging/android/sync_debug.o
drivers/staging/android/sync_debug.c:226:1: warning: data definition has no
type or storage class [enabled by default] late_initcall(sync_debugfs_init);
/drivers/staging/android/sync_debug.c
index 91ed2c4..a452975 100644
--- a/drivers/staging/android/sync_debug.c
+++ b/drivers/staging/android/sync_debug.c
@@ -26,6 +26,7 @@
#include linux/uaccess.h
#include linux/anon_inodes.h
#include linux/time64.h
+#include linux/module.h
#include sync.h
#ifdef
Add prototype definition of function to header file
include/linux/module.h because it is used by more than one file.
This eliminates the following warning in kernel/module.c:
kernel/module.c:3823:6: warning: no previous prototype for ‘module_layout’
[-Wmissing-prototypes]
Signed-off-by: Rashika
Add prototype definition of function to header file
include/linux/module.h because it is used by more than one file.
This eliminates the following warning in kernel/module.c:
kernel/module.c:3823:6: warning: no previous prototype for ‘module_layout’
[-Wmissing-prototypes]
Signed-off-by: Rashika
On Tue, Aug 20, 2013 at 04:01:26PM +0900, Jingoo Han wrote:
Include in order to fix the following errors.
drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or
'...' before string constant
drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or
'...'
On Tue, 20 Aug 2013, Jingoo Han wrote:
> Include in order to fix the following errors.
>
> drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or
> '...' before string constant
> drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or
> '...' before
Include in order to fix the following errors.
drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or
'...' before string constant
drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or
'...' before string constant
drivers/mfd/pm8921-core.c:211:16:
Include linux/module.h in order to fix the following errors.
drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or
'...' before string constant
drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or
'...' before string constant
drivers/mfd/pm8921
On Tue, 20 Aug 2013, Jingoo Han wrote:
Include linux/module.h in order to fix the following errors.
drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or
'...' before string constant
drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers
On Tue, Aug 20, 2013 at 04:01:26PM +0900, Jingoo Han wrote:
Include linux/module.h in order to fix the following errors.
drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or
'...' before string constant
drivers/mfd/pm8921-core.c:210:20: error: expected declaration
Hi,
On Tue, Nov 13, 2012 at 9:48 PM, Syam Sidhardhan wrote:
> Since it uses only THIS_MODULE macro, include
> is the right to go here.
>
> Signed-off-by: Syam Sidhardhan
> ---
> fs/proc/proc_devtree.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git
(+), 1 deletions(-)
diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c
index df7dd08..0e9df31 100644
--- a/fs/proc/proc_devtree.c
+++ b/fs/proc/proc_devtree.c
@@ -11,7 +11,7 @@
#include linux/stat.h
#include linux/string.h
#include linux/of.h
-#include linux/module.h
+#include
Since it uses only THIS_MODULE macro, include
is the right to go here.
Signed-off-by: Syam Sidhardhan
---
fs/proc/proc_devtree.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c
index df7dd08..0e9df31 100644
---
df7dd08..0e9df31 100644
--- a/fs/proc/proc_devtree.c
+++ b/fs/proc/proc_devtree.c
@@ -11,7 +11,7 @@
#include linux/stat.h
#include linux/string.h
#include linux/of.h
-#include linux/module.h
+#include linux/export.h
#include linux/slab.h
#include asm/prom.h
#include asm/uaccess.h
--
1.7.4.1
includes linux/netdevice.h which includes linux/netprio_cgroup.h which
used to include linux/module.h. The real issue was actually present since
the initial commit that added this driver since it uses macros from
linux/module.h without including this file.
Signed-off-by: Florian Fainelli
Signed-off
includes linux/netdevice.h which includes linux/netprio_cgroup.h which
used to include linux/module.h. The real issue was actually present since
the initial commit that added this driver since it uses macros from
linux/module.h without including this file.
Signed-off-by: Florian Fainelli
Signed-off
includes linux/netdevice.h which includes linux/netprio_cgroup.h which
used to include linux/module.h. The real issue was actually present since
the initial commit that added this driver since it uses macros from
linux/module.h without including this file.
Signed-off-by: Florian Fainelli
Signed-off
linux/hdlc.h which
includes linux/netdevice.h which includes linux/netprio_cgroup.h which
used to include linux/module.h. The real issue was actually present since
the initial commit that added this driver since it uses macros from
linux/module.h without including this file.
Signed-off-by: Florian
linux/hdlc.h which
includes linux/netdevice.h which includes linux/netprio_cgroup.h which
used to include linux/module.h. The real issue was actually present since
the initial commit that added this driver since it uses macros from
linux/module.h without including this file.
Signed-off-by: Florian
linux/hdlc.h which
includes linux/netdevice.h which includes linux/netprio_cgroup.h which
used to include linux/module.h. The real issue was actually present since
the initial commit that added this driver since it uses macros from
linux/module.h without including this file.
Signed-off-by: Florian
includes linux/netdevice.h which includes linux/netprio_cgroup.h which
used to include linux/module.h. The real issue was actually present since
the initial commit that added this driver since it uses macros from
linux/module.h without including this file.
Signed-off-by: Florian Fainelli
Signed-off
linux/hdlc.h which
includes linux/netdevice.h which includes linux/netprio_cgroup.h which
used to include linux/module.h. The real issue was actually present since
the initial commit that added this driver since it uses macros from
linux/module.h without including this file.
Signed-off-by: Florian
From: David Howells <[EMAIL PROTECTED]>
mm/nommu.c needs to #include linux/module.h for it to understand EXPORT_*()
macros.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
mm/nommu.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/mm/nommu.c b/mm/n
From: David Howells [EMAIL PROTECTED]
mm/nommu.c needs to #include linux/module.h for it to understand EXPORT_*()
macros.
Signed-off-by: David Howells [EMAIL PROTECTED]
---
mm/nommu.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/mm/nommu.c b/mm/nommu.c
index 8f09333
On 09/26/2007 10:25 PM, Kristof Provost wrote:
> On 2007-09-26 11:29:33 (+0100), mahamuni ashish <[EMAIL PROTECTED]> wrote:
>> I am writing simple kernel module.
>> I have included linux/module.h
>> compiler gives me error that no such file, I also
>> search
On 2007-09-26 11:29:33 (+0100), mahamuni ashish <[EMAIL PROTECTED]> wrote:
> I am writing simple kernel module.
> I have included linux/module.h
> compiler gives me error that no such file, I also
> searched it on my machine.
> It really doesn't exist. I am using fedora
I am writing simple kernel module.
I have included linux/module.h
compiler gives me error that no such file, I also
searched it on my machine.
It really doesn't exist. I am using fedora 6.
How do I install required libraries.
Did you know? You can CHAT without downloading messenger. Go
I am writing simple kernel module.
I have included linux/module.h
compiler gives me error that no such file, I also
searched it on my machine.
It really doesn't exist. I am using fedora 6.
How do I install required libraries.
Did you know? You can CHAT without downloading messenger. Go
On 2007-09-26 11:29:33 (+0100), mahamuni ashish [EMAIL PROTECTED] wrote:
I am writing simple kernel module.
I have included linux/module.h
compiler gives me error that no such file, I also
searched it on my machine.
It really doesn't exist. I am using fedora 6.
How do I install required
On 09/26/2007 10:25 PM, Kristof Provost wrote:
On 2007-09-26 11:29:33 (+0100), mahamuni ashish [EMAIL PROTECTED] wrote:
I am writing simple kernel module.
I have included linux/module.h
compiler gives me error that no such file, I also
searched it on my machine.
It really doesn't exist. I am
On Sun, 29 Jul 2007, Jesper Juhl wrote:
> Hi,
>
> This patch removes the duplicate inclusion of
> linux/module.h from arm26.
is it really worth doing any cleanup of arm26 given the recent
discussion of tossing it ent
Hi,
This patch removes the duplicate inclusion of
linux/module.h from arm26.
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
arch/arm26/kernel/armksyms.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm26/kernel/armksyms.c b/arch/arm26/kernel/armk
Hi,
This patch removes the duplicate inclusion of
linux/module.h from arm26.
Signed-off-by: Jesper Juhl [EMAIL PROTECTED]
---
arch/arm26/kernel/armksyms.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm26/kernel/armksyms.c b/arch/arm26/kernel/armksyms.c
On Sun, 29 Jul 2007, Jesper Juhl wrote:
Hi,
This patch removes the duplicate inclusion of
linux/module.h from arm26.
is it really worth doing any cleanup of arm26 given the recent
discussion of tossing it entirely?
rday
/a.out.h
#include linux/reboot.h
+#include linux/module.h
#include asm/uaccess.h
#include asm/system.h
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
On Sat, 24 Feb 2007 12:22:11 + Ralf Baechle [EMAIL PROTECTED] wrote:
sysdev.h uses THIS_MODULE so should include linux/module.h.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
diff --git a/include/linux/sysdev.h b/include/linux/sysdev.h
index 389ccf8..e699ab2 100644
--- a/include
On Sat, 24 Feb 2007 12:22:11 +
Ralf Baechle [EMAIL PROTECTED] wrote:
sysdev.h uses THIS_MODULE so should include linux/module.h.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
diff --git a/include/linux/sysdev.h b/include/linux/sysdev.h
index 389ccf8..e699ab2 100644
--- a/include
sysdev.h uses THIS_MODULE so should include linux/module.h.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
diff --git a/include/linux/sysdev.h b/include/linux/sysdev.h
index 389ccf8..e699ab2 100644
--- a/include/linux/sysdev.h
+++ b/include/linux/sysdev.h
@@ -22,6 +22,7 @@
#define _SYSDEV_H_
TECTED]>
> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
> ---
>
>
> kj-domen/include/linux/module.h |5 -
> 1 files changed, 4 insertions(+), 1 deletion(-)
>
> diff -puN include/linux/module.h~extinguish_warnings-include_linux_module.h
> include/linux/mod
[EMAIL PROTECTED]
---
kj-domen/include/linux/module.h |5 -
1 files changed, 4 insertions(+), 1 deletion(-)
diff -puN include/linux/module.h~extinguish_warnings-include_linux_module.h
include/linux/module.h
--- kj/include/linux/module.h~extinguish_warnings
PROTECTED]>
---
kj-domen/include/linux/module.h |5 -
1 files changed, 4 insertions(+), 1 deletion(-)
diff -puN include/linux/module.h~extinguish_warnings-include_linux_module.h
include/linux/module.h
--- kj/include/linux/module.h~extinguish_warnings-include_linux_module.h
2005
-domen/include/linux/module.h |5 -
1 files changed, 4 insertions(+), 1 deletion(-)
diff -puN include/linux/module.h~extinguish_warnings-include_linux_module.h
include/linux/module.h
--- kj/include/linux/module.h~extinguish_warnings-include_linux_module.h
2005-03-05 16:12:03.0
On Mon, Dec 11, 2000 at 07:53:05PM -0600, Peter Samuelson wrote:
>
> [Mohammad A. Haque]
> > Wasn't there discussion that user space apps shouldn't include kernel
> > headers?
>
> Oh, it's been discussed, many times. Here is my executive summary of
> why nobody needs to use kernel headers in
On Mon, Dec 11, 2000 at 07:53:05PM -0600, Peter Samuelson wrote:
[Mohammad A. Haque]
Wasn't there discussion that user space apps shouldn't include kernel
headers?
Oh, it's been discussed, many times. Here is my executive summary of
why nobody needs to use kernel headers in userspace
[Mohammad A. Haque]
> Wasn't there discussion that user space apps shouldn't include kernel
> headers?
Oh, it's been discussed, many times. Here is my executive summary of
why nobody needs to use kernel headers in userspace programs, *EVER*:
Q: I want to #include but I get compile errors,
} User space applications _must_ not include kernel headers. Even
} modutils does not include linux/module.h, it has its own portable
} (kernels 2.0 - 2.4) version.
There are cases where a user-program _must_ include kernel headers. Some
glibc versions have incorrect values for MCL_* and asm
Wasn't there discussion that user space apps shouldn't include kernel
headers?
"Adam J. Richter" wrote:
>
> linux-2.4.0test12pre8/include/linux/module.h contains some
> kernel-specific declarations that now reference struct list_head, which
> which is only defined
On Mon, 11 Dec 2000 14:59:01 -0800,
"Adam J. Richter" <[EMAIL PROTECTED]> wrote:
> linux-2.4.0test12pre8/include/linux/module.h contains some
>kernel-specific declarations that now reference struct list_head, which
>which is only defined when __KERNEL__ is s
linux-2.4.0test12pre8/include/linux/module.h contains some
kernel-specific declarations that now reference struct list_head, which
which is only defined when __KERNEL__ is set. This causes sysklogd
and probably any other user level program that needs to include
to fail to compile
linux-2.4.0test12pre8/include/linux/module.h contains some
kernel-specific declarations that now reference struct list_head, which
which is only defined when __KERNEL__ is set. This causes sysklogd
and probably any other user level program that needs to include
linux/module.h to fail
On Mon, 11 Dec 2000 14:59:01 -0800,
"Adam J. Richter" [EMAIL PROTECTED] wrote:
linux-2.4.0test12pre8/include/linux/module.h contains some
kernel-specific declarations that now reference struct list_head, which
which is only defined when __KERNEL__ is set. This cause
Wasn't there discussion that user space apps shouldn't include kernel
headers?
"Adam J. Richter" wrote:
linux-2.4.0test12pre8/include/linux/module.h contains some
kernel-specific declarations that now reference struct list_head, which
which is only defined when __KERNE
} User space applications _must_ not include kernel headers. Even
} modutils does not include linux/module.h, it has its own portable
} (kernels 2.0 - 2.4) version.
There are cases where a user-program _must_ include kernel headers. Some
glibc versions have incorrect values for MCL_* and asm
[Mohammad A. Haque]
Wasn't there discussion that user space apps shouldn't include kernel
headers?
Oh, it's been discussed, many times. Here is my executive summary of
why nobody needs to use kernel headers in userspace programs, *EVER*:
Q: I want to #include linux/foo.h but I get compile
94 matches
Mail list logo