Re: On Lindent shortcomings and massive style fixing

2015-12-29 Thread Julia Lawall
On Tue, 29 Dec 2015, Andrey Utkin wrote: > On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab > wrote: > > IMHO, there are two problems by letting indent breaking long > > lines: > > > > 1) indent would break strings on printks. This is something that we don't > > want to break strings on

Re: On Lindent shortcomings and massive style fixing

2015-12-29 Thread Andrey Utkin
On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab wrote: > IMHO, there are two problems by letting indent breaking long > lines: > > 1) indent would break strings on printks. This is something that we don't > want to break strings on multiple lines in the Kernel; Yeah, GNU indent does its

Re: On Lindent shortcomings and massive style fixing

2015-12-29 Thread Andrey Utkin
On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab wrote: > IMHO, there are two problems by letting indent breaking long > lines: > > 1) indent would break strings on printks. This is something that we don't > want to break strings on multiple lines in the Kernel;

Re: On Lindent shortcomings and massive style fixing

2015-12-29 Thread Julia Lawall
On Tue, 29 Dec 2015, Andrey Utkin wrote: > On Tue, Dec 29, 2015 at 9:32 AM, Mauro Carvalho Chehab > wrote: > > IMHO, there are two problems by letting indent breaking long > > lines: > > > > 1) indent would break strings on printks. This is something that we don't > >

Re: On Lindent shortcomings and massive style fixing

2015-12-28 Thread Mauro Carvalho Chehab
Em Mon, 28 Dec 2015 07:33:32 -0800 Greg KH escreveu: > On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote: > > After some iterations of checkpatch.pl, on a new developed driver > > (tw5864), now I have the following: > > > > $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort |

Re: On Lindent shortcomings and massive style fixing

2015-12-28 Thread Greg KH
On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote: > After some iterations of checkpatch.pl, on a new developed driver > (tw5864), now I have the following: > > $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c > 31 ERROR: do not use C99 // comments > 147

On Lindent shortcomings and massive style fixing

2015-12-28 Thread Andrey Utkin
After some iterations of checkpatch.pl, on a new developed driver (tw5864), now I have the following: $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c 31 ERROR: do not use C99 // comments 147 WARNING: Block comments use a trailing */ on a separate line 144 WARNING:

Re: On Lindent shortcomings and massive style fixing

2015-12-28 Thread Greg KH
On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote: > After some iterations of checkpatch.pl, on a new developed driver > (tw5864), now I have the following: > > $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c > 31 ERROR: do not use C99 // comments > 147

On Lindent shortcomings and massive style fixing

2015-12-28 Thread Andrey Utkin
After some iterations of checkpatch.pl, on a new developed driver (tw5864), now I have the following: $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c 31 ERROR: do not use C99 // comments 147 WARNING: Block comments use a trailing */ on a separate line 144 WARNING:

Re: On Lindent shortcomings and massive style fixing

2015-12-28 Thread Mauro Carvalho Chehab
Em Mon, 28 Dec 2015 07:33:32 -0800 Greg KH escreveu: > On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote: > > After some iterations of checkpatch.pl, on a new developed driver > > (tw5864), now I have the following: > > > > $ grep 'WARNING\|ERROR'