Greg Kroah-Hartman wrote:
> And, if you want my larger fix that I will be sending to netdev one of
> these days, here's that one. It includes the above patch as part of it.
That works.
Tested-by: David Howells
On Tue, Feb 12, 2019 at 04:04:59PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 12, 2019 at 02:57:34PM +, David Howells wrote:
> > Greg Kroah-Hartman wrote:
> >
> > > - if (!xprt->debugfs) {
> > > + if (IS_ERR_OR_NULL(xprt->debugfs)) {
> >
> > That works, though I don't much like the idea
On Tue, Feb 12, 2019 at 02:57:34PM +, David Howells wrote:
> Greg Kroah-Hartman wrote:
>
> > - if (!xprt->debugfs) {
> > + if (IS_ERR_OR_NULL(xprt->debugfs)) {
>
> That works, though I don't much like the idea of there being an error there.
>
> Looking in rpc_xprt_debugfs_register()
On Tue, Feb 12, 2019 at 03:42:14PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 12, 2019 at 03:37:20PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Feb 12, 2019 at 02:31:14PM +, David Howells wrote:
> > > I've bisected an oops that occurs in rpc_clnt_debugfs_register() trying to
> > >
Greg Kroah-Hartman wrote:
> - if (!xprt->debugfs) {
> + if (IS_ERR_OR_NULL(xprt->debugfs)) {
That works, though I don't much like the idea of there being an error there.
Looking in rpc_xprt_debugfs_register() there are two now-dodgy looking checks
on the result of debugfs calls.
David
On Tue, Feb 12, 2019 at 03:37:20PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 12, 2019 at 02:31:14PM +, David Howells wrote:
> > I've bisected an oops that occurs in rpc_clnt_debugfs_register() trying to
> > dereference a pointer with -EACCES in it. This is the causing commit,
> > though
On Tue, Feb 12, 2019 at 02:31:14PM +, David Howells wrote:
> I've bisected an oops that occurs in rpc_clnt_debugfs_register() trying to
> dereference a pointer with -EACCES in it. This is the causing commit, though
> I suspect the bug is in sunrpc expecting to see NULL rather than an error.
>
I've bisected an oops that occurs in rpc_clnt_debugfs_register() trying to
dereference a pointer with -EACCES in it. This is the causing commit, though
I suspect the bug is in sunrpc expecting to see NULL rather than an error.
ff9fb72bc07705c00795ca48631f7fffe24d2c6b is the first bad commit
8 matches
Mail list logo
