Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-19 Thread Benjamin Romer
On Fri, 2007-01-19 at 07:43 -0800, Randy Dunlap wrote: > On Fri, 19 Jan 2007 10:11:10 -0500 Benjamin Romer wrote: > > > On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote: > > > On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: > > > [..] > > > > > > > > > > > > OK, here's the

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-19 Thread Eric W. Biederman
Benjamin Romer <[EMAIL PROTECTED]> writes: > On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote: >> On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: >> [..] >> > > > >> > > > OK, here's the updated patch that uses the new definition and fixes up >> > > > the other places that use

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-19 Thread Randy Dunlap
On Fri, 19 Jan 2007 10:11:10 -0500 Benjamin Romer wrote: > On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote: > > On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: > > [..] > > > > > > > > > > OK, here's the updated patch that uses the new definition and fixes up > > > > > the

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-19 Thread Benjamin Romer
On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote: > On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: > [..] > > > > > > > > OK, here's the updated patch that uses the new definition and fixes up > > > > the other places that use it. I built and tested this on the ES7000/ONE > >

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-19 Thread Benjamin Romer
On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote: On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: [..] OK, here's the updated patch that uses the new definition and fixes up the other places that use it. I built and tested this on the ES7000/ONE and it works

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-19 Thread Randy Dunlap
On Fri, 19 Jan 2007 10:11:10 -0500 Benjamin Romer wrote: On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote: On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: [..] OK, here's the updated patch that uses the new definition and fixes up the other places that use

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-19 Thread Eric W. Biederman
Benjamin Romer [EMAIL PROTECTED] writes: On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote: On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: [..] OK, here's the updated patch that uses the new definition and fixes up the other places that use it. I built and

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-19 Thread Benjamin Romer
On Fri, 2007-01-19 at 07:43 -0800, Randy Dunlap wrote: On Fri, 19 Jan 2007 10:11:10 -0500 Benjamin Romer wrote: On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote: On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: [..] OK, here's the updated patch that uses

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Vivek Goyal
On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: [..] > > > > > > OK, here's the updated patch that uses the new definition and fixes up > > > the other places that use it. I built and tested this on the ES7000/ONE > > > and it works well. :) > > > > Cool. > > > > I hate to pick

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Benjamin Romer
On Thu, 2007-01-18 at 11:14 -0700, Eric W. Biederman wrote: > Benjamin Romer <[EMAIL PROTECTED]> writes: > > > On Thu, 2007-01-18 at 13:30 +0530, Vivek Goyal wrote: > >> On Thu, Jan 18, 2007 at 12:10:55AM -0700, Eric W. Biederman wrote: > >> > Vivek Goyal <[EMAIL PROTECTED]> writes: > >> > > > >>

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Eric W. Biederman
Benjamin Romer <[EMAIL PROTECTED]> writes: > On Thu, 2007-01-18 at 13:30 +0530, Vivek Goyal wrote: >> On Thu, Jan 18, 2007 at 12:10:55AM -0700, Eric W. Biederman wrote: >> > Vivek Goyal <[EMAIL PROTECTED]> writes: >> > > >> > > Or how about making physical_dest field also 8bit like logical_dest

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Benjamin Romer
On Thu, 2007-01-18 at 13:30 +0530, Vivek Goyal wrote: > On Thu, Jan 18, 2007 at 12:10:55AM -0700, Eric W. Biederman wrote: > > Vivek Goyal <[EMAIL PROTECTED]> writes: > > > > > > Or how about making physical_dest field also 8bit like logical_dest field. > > > This will work both for 4bit and 8bit

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Benjamin Romer
On Thu, 2007-01-18 at 13:30 +0530, Vivek Goyal wrote: > On Thu, Jan 18, 2007 at 12:10:55AM -0700, Eric W. Biederman wrote: > > Vivek Goyal <[EMAIL PROTECTED]> writes: > > > > > > Or how about making physical_dest field also 8bit like logical_dest field. > > > This will work both for 4bit and 8bit

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Vivek Goyal
On Thu, Jan 18, 2007 at 12:10:55AM -0700, Eric W. Biederman wrote: > Vivek Goyal <[EMAIL PROTECTED]> writes: > > > > Or how about making physical_dest field also 8bit like logical_dest field. > > This will work both for 4bit and 8bit physical apic ids at the same time > > code becomes more

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Vivek Goyal
On Thu, Jan 18, 2007 at 12:10:55AM -0700, Eric W. Biederman wrote: Vivek Goyal [EMAIL PROTECTED] writes: Or how about making physical_dest field also 8bit like logical_dest field. This will work both for 4bit and 8bit physical apic ids at the same time code becomes more intutive and it is

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Benjamin Romer
On Thu, 2007-01-18 at 13:30 +0530, Vivek Goyal wrote: On Thu, Jan 18, 2007 at 12:10:55AM -0700, Eric W. Biederman wrote: Vivek Goyal [EMAIL PROTECTED] writes: Or how about making physical_dest field also 8bit like logical_dest field. This will work both for 4bit and 8bit physical apic

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Benjamin Romer
On Thu, 2007-01-18 at 13:30 +0530, Vivek Goyal wrote: On Thu, Jan 18, 2007 at 12:10:55AM -0700, Eric W. Biederman wrote: Vivek Goyal [EMAIL PROTECTED] writes: Or how about making physical_dest field also 8bit like logical_dest field. This will work both for 4bit and 8bit physical apic

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Eric W. Biederman
Benjamin Romer [EMAIL PROTECTED] writes: On Thu, 2007-01-18 at 13:30 +0530, Vivek Goyal wrote: On Thu, Jan 18, 2007 at 12:10:55AM -0700, Eric W. Biederman wrote: Vivek Goyal [EMAIL PROTECTED] writes: Or how about making physical_dest field also 8bit like logical_dest field. This

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Benjamin Romer
On Thu, 2007-01-18 at 11:14 -0700, Eric W. Biederman wrote: Benjamin Romer [EMAIL PROTECTED] writes: On Thu, 2007-01-18 at 13:30 +0530, Vivek Goyal wrote: On Thu, Jan 18, 2007 at 12:10:55AM -0700, Eric W. Biederman wrote: Vivek Goyal [EMAIL PROTECTED] writes: Or how about making

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-18 Thread Vivek Goyal
On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: [..] OK, here's the updated patch that uses the new definition and fixes up the other places that use it. I built and tested this on the ES7000/ONE and it works well. :) Cool. I hate to pick nits by why the double

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-17 Thread Eric W. Biederman
Vivek Goyal <[EMAIL PROTECTED]> writes: >> Hi Eric, >> >> In physical destination mode, the destination APIC is determined by >> APIC ID and in logical destination mode, destination apics are determined >> by the configurations based on LDR and DFR registers in APIC (Depending >> on Flat mode

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-17 Thread Vivek Goyal
On Thu, Jan 18, 2007 at 09:11:53AM +0530, Vivek Goyal wrote: > On Wed, Jan 17, 2007 at 12:08:48PM -0700, Eric W. Biederman wrote: > > Benjamin Romer <[EMAIL PROTECTED]> writes: > > > > > On the Unisys ES7000/ONE system, we encountered a problem where > > > performing a kexec reboot or dump on any

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-17 Thread Vivek Goyal
On Wed, Jan 17, 2007 at 12:08:48PM -0700, Eric W. Biederman wrote: > Benjamin Romer <[EMAIL PROTECTED]> writes: > > > On the Unisys ES7000/ONE system, we encountered a problem where > > performing a kexec reboot or dump on any cell other than cell 0 causes > > the system timer to stop working,

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-17 Thread Eric W. Biederman
Benjamin Romer <[EMAIL PROTECTED]> writes: > On the Unisys ES7000/ONE system, we encountered a problem where > performing a kexec reboot or dump on any cell other than cell 0 causes > the system timer to stop working, resulting in a hang during timer > calibration in the new kernel. > > We

PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-17 Thread Benjamin Romer
On the Unisys ES7000/ONE system, we encountered a problem where performing a kexec reboot or dump on any cell other than cell 0 causes the system timer to stop working, resulting in a hang during timer calibration in the new kernel. We traced the problem to one line of code in disable_IO_APIC(),

PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-17 Thread Benjamin Romer
On the Unisys ES7000/ONE system, we encountered a problem where performing a kexec reboot or dump on any cell other than cell 0 causes the system timer to stop working, resulting in a hang during timer calibration in the new kernel. We traced the problem to one line of code in disable_IO_APIC(),

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-17 Thread Eric W. Biederman
Benjamin Romer [EMAIL PROTECTED] writes: On the Unisys ES7000/ONE system, we encountered a problem where performing a kexec reboot or dump on any cell other than cell 0 causes the system timer to stop working, resulting in a hang during timer calibration in the new kernel. We traced the

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-17 Thread Vivek Goyal
On Wed, Jan 17, 2007 at 12:08:48PM -0700, Eric W. Biederman wrote: Benjamin Romer [EMAIL PROTECTED] writes: On the Unisys ES7000/ONE system, we encountered a problem where performing a kexec reboot or dump on any cell other than cell 0 causes the system timer to stop working, resulting in

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-17 Thread Vivek Goyal
On Thu, Jan 18, 2007 at 09:11:53AM +0530, Vivek Goyal wrote: On Wed, Jan 17, 2007 at 12:08:48PM -0700, Eric W. Biederman wrote: Benjamin Romer [EMAIL PROTECTED] writes: On the Unisys ES7000/ONE system, we encountered a problem where performing a kexec reboot or dump on any cell other

Re: PATCH: Update disable_IO_APIC to use 8-bit destination field (X86_64)

2007-01-17 Thread Eric W. Biederman
Vivek Goyal [EMAIL PROTECTED] writes: Hi Eric, In physical destination mode, the destination APIC is determined by APIC ID and in logical destination mode, destination apics are determined by the configurations based on LDR and DFR registers in APIC (Depending on Flat mode or cluster