Hi Ricky.
On 05/08/2020 13:48, Chris Clayton wrote:
> Hi Ricky
>>
>> Ah, OK. I'll prepare the patch and send it to you once I've tested it.
>>
>
> Please see the patch included below. As you suggested, it removes the code
> that does the OC power down on card readers
> that are not members
PM
>>> To: 吳昊澄 Ricky; gre...@linuxfoundation.org
>>> Cc: LKML; rdun...@infradead.org; philqua...@gmail.com; Arnd Bergmann
>>> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader
>>> on
>>> Intel NUC boxes
>>>
>&g
dead.org; philqua...@gmail.com; Arnd Bergmann
>> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader
>> on
>> Intel NUC boxes
>>
>>
>>
>> On 04/08/2020 11:46, 吳昊澄 Ricky wrote:
>>>> -Original Message-
>>>
gt;> To: 吳昊澄 Ricky; gre...@linuxfoundation.org
> >> Cc: LKML; rdun...@infradead.org; philqua...@gmail.com; Arnd Bergmann
> >> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card
> >> reader on
> >> Intel NUC boxes
> >>
> >>
.com; Arnd Bergmann
>> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader
>> on
>> Intel NUC boxes
>>
>>
>>
>> On 04/08/2020 09:08, 吳昊澄 Ricky wrote:
>>>> -Original Message-
>>>> From: gre...@lin
:49 PM
> >> To: 吳昊澄 Ricky
> >> Cc: Chris Clayton; LKML; rdun...@infradead.org; philqua...@gmail.com;
> Arnd
> >> Bergmann
> >> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card
> >> reader on
> >> Intel NUC boxes
> >>
..@gmail.com; Arnd
>> Bergmann
>> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader
>> on
>> Intel NUC boxes
>>
>> On Tue, Aug 04, 2020 at 02:44:41AM +, 吳昊澄 Ricky wrote:
>>> Hi Chris,
>>>
>>> rtsx_pci_write_regi
dead.org; philqua...@gmail.com; Arnd
> > Bergmann
> > Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader
> > on
> > Intel NUC boxes
> >
> > On Tue, Aug 04, 2020 at 02:44:41AM +, 吳昊澄 Ricky wrote:
> > > Hi Chris,
&
river - don't disable the rts5229 card reader on
> Intel NUC boxes
>
> On Tue, Aug 04, 2020 at 02:44:41AM +, 吳昊澄 Ricky wrote:
> > Hi Chris,
> >
> > rtsx_pci_write_register(pcr, FPDTL, OC_POWER_DOWN, OC_POWER_DOWN);
> > This register operation saved power un
On Tue, Aug 04, 2020 at 02:44:41AM +, 吳昊澄 Ricky wrote:
> Hi Chris,
>
> rtsx_pci_write_register(pcr, FPDTL, OC_POWER_DOWN, OC_POWER_DOWN);
> This register operation saved power under 1mA, so if do not care the 1mA
> power we can have a patch to remove it, make compatible with NUC6
> We tested
; Arnd Bergmann
> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on
> Intel NUC boxes
>
> Sorry, I should have said that the patch is against 5.7.12. It applies to
> upstream,
> but with offsets.
>
> On 02/08/2020 20:48, Chris Clayton wrote:
> &g
dead.org;
>> philqua...@gmail.com; Arnd Bergmann
>> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader
>> on
>> Intel NUC boxes
>>
>> Sorry, I should have said that the patch is against 5.7.12. It applies to
>> upstream,
>> b
To: LKML; 吳昊澄 Ricky; gre...@linuxfoundation.org; rdun...@infradead.org;
> philqua...@gmail.com; Arnd Bergmann
> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on
> Intel NUC boxes
>
> Sorry, I should have said that the patch is against 5.7.12
Sorry, I should have said that the patch is against 5.7.12. It applies to
upstream, but with offsets.
On 02/08/2020 20:48, Chris Clayton wrote:
> bede03a579b3 introduced a bug which leaves the rts5229 PCI Express card
> reader on my Intel NUC6CAYH box.
>
> The bug is in
bede03a579b3 introduced a bug which leaves the rts5229 PCI Express card reader
on my Intel NUC6CAYH box.
The bug is in drivers/misc/cardreader/rtsx_pcr.c. A call to rtsx_pci_init_ocp()
was added to rtsx_pci_init_hw().
At the call point, pcr->ops->init_ocp is NULL and pcr->option.ocp_en is 0, so
15 matches
Mail list logo
