Re: PATCH: trident , pci_enable_device moved

2001-04-27 Thread Eric W. Biederman
Jeff Garzik <[EMAIL PROTECTED]> writes: > Andres Salomon wrote: > > This is what I was told (it was only needed for secondary video > > devices). From that, I would expect that all video devices would > > need it, just in case they happened to be the second card. Am I > > missing some subtlety

Re: PATCH: trident , pci_enable_device moved

2001-04-27 Thread Eric W. Biederman
Jeff Garzik [EMAIL PROTECTED] writes: Andres Salomon wrote: This is what I was told (it was only needed for secondary video devices). From that, I would expect that all video devices would need it, just in case they happened to be the second card. Am I missing some subtlety in some of

Re: PATCH: trident , pci_enable_device moved

2001-04-25 Thread Jeff Garzik
Andres Salomon wrote: > This is what I was told (it was only needed for secondary video > devices). From that, I would expect that all video devices would > need it, just in case they happened to be the second card. Am I > missing some subtlety in some of the video driers/chipsets that >

Re: PATCH: trident , pci_enable_device moved

2001-04-25 Thread Andres Salomon
Oops, I saw "trident" and thought video. Sorry, marcus. :) This is what I was told (it was only needed for secondary video devices). From that, I would expect that all video devices would need it, just in case they happened to be the second card. Am I missing some subtlety in some of the

Re: PATCH: trident , pci_enable_device moved

2001-04-25 Thread Jeff Garzik
Andres Salomon wrote: > Just a warning; I was informed by Alan that doing this for video > drivers was unnecessary, since video devices were already enabled > during bootup. To clarify: the primary display device is enabled and initialized, and its video BIOS executed, when during BIOS startup

Re: PATCH: trident , pci_enable_device moved

2001-04-25 Thread Andres Salomon
Just a warning; I was informed by Alan that doing this for video drivers was unnecessary, since video devices were already enabled during bootup. On Wed, Apr 25, 2001 at 01:06:24PM +0200, Marcus Meissner wrote: > > On Wed, Apr 25, 2001 at 09:04:38AM +0200, Marcus Meissner wrote: > > Hi Alan,

Re: PATCH: trident , pci_enable_device moved

2001-04-25 Thread Marcus Meissner
On Wed, Apr 25, 2001 at 09:04:38AM +0200, Marcus Meissner wrote: > Hi Alan, linux-kernel, > > This moves pci_enable_device() in trident.c before any PCI resource access. > Everything else appears to be ok in regards to 2.4 PCI API and return values. > > Ciao, Marcus Argh, actually the return

PATCH: trident , pci_enable_device moved

2001-04-25 Thread Marcus Meissner
Hi Alan, linux-kernel, This moves pci_enable_device() in trident.c before any PCI resource access. Everything else appears to be ok in regards to 2.4 PCI API and return values. Ciao, Marcus Index: trident.c === RCS file:

PATCH: trident , pci_enable_device moved

2001-04-25 Thread Marcus Meissner
Hi Alan, linux-kernel, This moves pci_enable_device() in trident.c before any PCI resource access. Everything else appears to be ok in regards to 2.4 PCI API and return values. Ciao, Marcus Index: trident.c === RCS file:

Re: PATCH: trident , pci_enable_device moved

2001-04-25 Thread Andres Salomon
Just a warning; I was informed by Alan that doing this for video drivers was unnecessary, since video devices were already enabled during bootup. On Wed, Apr 25, 2001 at 01:06:24PM +0200, Marcus Meissner wrote: On Wed, Apr 25, 2001 at 09:04:38AM +0200, Marcus Meissner wrote: Hi Alan,

Re: PATCH: trident , pci_enable_device moved

2001-04-25 Thread Jeff Garzik
Andres Salomon wrote: Just a warning; I was informed by Alan that doing this for video drivers was unnecessary, since video devices were already enabled during bootup. To clarify: the primary display device is enabled and initialized, and its video BIOS executed, when during BIOS startup and

Re: PATCH: trident , pci_enable_device moved

2001-04-25 Thread Andres Salomon
Oops, I saw trident and thought video. Sorry, marcus. :) This is what I was told (it was only needed for secondary video devices). From that, I would expect that all video devices would need it, just in case they happened to be the second card. Am I missing some subtlety in some of the video

Re: PATCH: trident , pci_enable_device moved

2001-04-25 Thread Jeff Garzik
Andres Salomon wrote: This is what I was told (it was only needed for secondary video devices). From that, I would expect that all video devices would need it, just in case they happened to be the second card. Am I missing some subtlety in some of the video driers/chipsets that wouldn't