Re: PATCH] backlight: add lms501kf03 LCD driver

2012-12-17 Thread Jingoo Han
On Tuesday, December 18, 2012 12:51 AM, Joe Perches wrote > On Mon, 2012-12-17 at 17:22 +0900, Jingoo Han wrote: > > Add the lms501kf03 LCD panel driver. The lms501kf03 LCD panel (800 > > x 480) driver uses 3-wired SPI inteface. > > A trivial note: > > > diff --git a/drivers/video/backlight/lms50

Re: PATCH] backlight: add lms501kf03 LCD driver

2012-12-17 Thread Sachin Kamat
On 18 December 2012 06:59, Jingoo Han wrote: > On Monday, Monday, December 17, 2012 7:01 PM, Sachin Kamat wrote >> >> Hi Jingoo, >> >> I had already submitted a patch for adding support for this driver [1] >> and you had also provided your review comments on them ([2] and [3]). >> There were certa

Re: PATCH] backlight: add lms501kf03 LCD driver

2012-12-17 Thread Jingoo Han
On Tuesday, December 18, 2012 2:00 PM, Sachin Kamat wrote > On 18 December 2012 06:59, Jingoo Han wrote: > > On Monday, Monday, December 17, 2012 7:01 PM, Sachin Kamat wrote > >> > >> Hi Jingoo, > >> > >> I had already submitted a patch for adding support for this driver [1] > >> and you had also

Re: PATCH] backlight: add lms501kf03 LCD driver

2012-12-17 Thread Jingoo Han
On Tuesday, December 18, 2012 1:51 AM, devendra.aaru wrote > Hello, > > > +static int lms501kf03_spi_write(struct lms501kf03 *lcd, unsigned char > > address, > > + unsigned char command) > > +{ > > + int ret; > > + > > + ret = lms501kf03_spi_write_byte(lc

Re: PATCH] backlight: add lms501kf03 LCD driver

2012-12-17 Thread Jingoo Han
On Monday, Monday, December 17, 2012 7:01 PM, Sachin Kamat wrote > > Hi Jingoo, > > I had already submitted a patch for adding support for this driver [1] > and you had also provided your review comments on them ([2] and [3]). > There were certain comments from Andrew Morton that needed to be add

Re: PATCH] backlight: add lms501kf03 LCD driver

2012-12-17 Thread devendra.aaru
Hello, > +static int lms501kf03_spi_write(struct lms501kf03 *lcd, unsigned char > address, > + unsigned char command) > +{ > + int ret; > + > + ret = lms501kf03_spi_write_byte(lcd, address, command); > + > + return ret; there is redundancy here, yo

Re: PATCH] backlight: add lms501kf03 LCD driver

2012-12-17 Thread Joe Perches
On Mon, 2012-12-17 at 17:22 +0900, Jingoo Han wrote: > Add the lms501kf03 LCD panel driver. The lms501kf03 LCD panel (800 > x 480) driver uses 3-wired SPI inteface. A trivial note: > diff --git a/drivers/video/backlight/lms501kf03.c > b/drivers/video/backlight/lms501kf03.c [] > +static const u

Re: PATCH] backlight: add lms501kf03 LCD driver

2012-12-17 Thread Sachin Kamat
Hi Jingoo, I had already submitted a patch for adding support for this driver [1] and you had also provided your review comments on them ([2] and [3]). There were certain comments from Andrew Morton that needed to be addressed which I could not due to some other priorities. IMO, it would be bette

PATCH] backlight: add lms501kf03 LCD driver

2012-12-17 Thread Jingoo Han
Add the lms501kf03 LCD panel driver. The lms501kf03 LCD panel (800 x 480) driver uses 3-wired SPI inteface. Signed-off-by: Ilho Lee Signed-off-by: Jingoo Han --- drivers/video/backlight/Kconfig |8 + drivers/video/backlight/Makefile |1 + drivers/video/backlight/lms501kf03.c |