Re: PCI: Remove users of pci_enable_device_bars()

2008-02-02 Thread Benjamin Herrenschmidt
> > Since Alan has commented on it: > > > > http://lkml.org/lkml/2007/12/17/422 > > > > "5520 in fact is always enabled as it is the host bridge. > > pci_enable_device_io will do just fine. The 5520 fun is if you disable it > > the system hangs." > > > > I moved on assuming that either submitte

Re: PCI: Remove users of pci_enable_device_bars()

2008-02-02 Thread Greg KH
On Sat, Feb 02, 2008 at 09:01:10PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Saturday 02 February 2008, Jeff Garzik wrote: > > Linux Kernel Mailing List wrote: > > > Commit: 0948391641918b95d8d96c15089eb5ac156850b3 > > > > > PCI: Remov

Re: PCI: Remove users of pci_enable_device_bars()

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Saturday 02 February 2008, Jeff Garzik wrote: > Linux Kernel Mailing List wrote: > > Commit: 0948391641918b95d8d96c15089eb5ac156850b3 > > > PCI: Remove users of pci_enable_device_bars() > > > > This patch converts users of pci_e

Re: PCI: Remove users of pci_enable_device_bars()

2008-02-01 Thread Jeff Garzik
Linux Kernel Mailing List wrote: Commit: 0948391641918b95d8d96c15089eb5ac156850b3 PCI: Remove users of pci_enable_device_bars() This patch converts users of pci_enable_device_bars() to the new pci_enable_device_{io,mem} interface. The new API fits nicely, except

Re: [PATCH 2/3] pci: Remove users of pci_enable_device_bars()

2008-01-31 Thread Greg KH
On Thu, Jan 31, 2008 at 04:14:45PM -0800, Andrew Vasquez wrote: > On Tue, 08 Jan 2008, Benjamin Herrenschmidt wrote: > > > On Mon, 2008-01-07 at 11:42 -0800, Andrew Vasquez wrote: > > > That's fine. I take it these patches will be funneled via > > > gregkh/pci-2.6.git. There's some qla2xxx updat

Re: [PATCH 2/3] pci: Remove users of pci_enable_device_bars()

2008-01-31 Thread Andrew Vasquez
On Tue, 08 Jan 2008, Benjamin Herrenschmidt wrote: > On Mon, 2008-01-07 at 11:42 -0800, Andrew Vasquez wrote: > > That's fine. I take it these patches will be funneled via > > gregkh/pci-2.6.git. There's some qla2xxx updates which are queued for > > post-2.6.24 consumption in jejb/scsi-misc-2.6.

Re: [PATCH 2/3] pci: Remove users of pci_enable_device_bars()

2008-01-07 Thread Benjamin Herrenschmidt
On Mon, 2008-01-07 at 11:42 -0800, Andrew Vasquez wrote: > That's fine. I take it these patches will be funneled via > gregkh/pci-2.6.git. There's some qla2xxx updates which are queued for > post-2.6.24 consumption in jejb/scsi-misc-2.6.git which don't appear > to have any conflicts. > > I do t

Re: [PATCH 2/3] pci: Remove users of pci_enable_device_bars()

2008-01-07 Thread Andrew Vasquez
On Thu, 20 Dec 2007, Benjamin Herrenschmidt wrote: > This patch converts users of pci_enable_device_bars() to the new > pci_enable_device_{io,mem} interface. > > The new API fits nicely, except maybe for the QLA case where a bit of > code re-organization might be a good idea but I prefer sticking

Re: [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars()

2007-12-23 Thread Grant Grundler
Just a style nit... On Tue, Dec 18, 2007 at 10:01:14AM +1100, Benjamin Herrenschmidt wrote: > This patch converts users of pci_enable_device_bars() to the new > pci_enable_device_{io,mem} interface. > > The new API fits nicely, except maybe for the QLA case where a bit of > code re-organization m

[PATCH 2/3] pci: Remove users of pci_enable_device_bars()

2007-12-19 Thread Benjamin Herrenschmidt
This patch converts users of pci_enable_device_bars() to the new pci_enable_device_{io,mem} interface. The new API fits nicely, except maybe for the QLA case where a bit of code re-organization might be a good idea but I prefer sticking to the simple patch as I don't have hardware to test on. I'l

Re: [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars()

2007-12-17 Thread Benjamin Herrenschmidt
On Tue, 2007-12-18 at 00:07 +, Alan Cox wrote: > On Tue, 18 Dec 2007 10:01:14 +1100 > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > This patch converts users of pci_enable_device_bars() to the new > > pci_enable_device_{io,mem} interface. > > > > The new API fits nicely, except may

Re: [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars()

2007-12-17 Thread Alan Cox
On Tue, 18 Dec 2007 10:01:14 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > This patch converts users of pci_enable_device_bars() to the new > pci_enable_device_{io,mem} interface. > > The new API fits nicely, except maybe for the QLA case where a bit of > code re-organization might be

[RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars()

2007-12-17 Thread Benjamin Herrenschmidt
This patch converts users of pci_enable_device_bars() to the new pci_enable_device_{io,mem} interface. The new API fits nicely, except maybe for the QLA case where a bit of code re-organization might be a good idea but I prefer sticking to the simple patch as I don't have hardware to test on. I'l