Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-06-02 Thread Vidya Sagar
On 23-May-20 11:00 PM, Vidya Sagar wrote: On 22-May-20 7:36 PM, Thierry Reding wrote: On Fri, May 22, 2020 at 02:32:49PM +0100, Lorenzo Pieralisi wrote: On Fri, May 22, 2020 at 02:06:55PM +0200, Thierry Reding wrote: On Wed, May 20, 2020 at 04:48:16PM -0600, Rob Herring wrote: On Wed, Ma

Re: Re: Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-23 Thread Vidya Sagar
On 22-May-20 7:36 PM, Thierry Reding wrote: On Fri, May 22, 2020 at 02:32:49PM +0100, Lorenzo Pieralisi wrote: On Fri, May 22, 2020 at 02:06:55PM +0200, Thierry Reding wrote: On Wed, May 20, 2020 at 04:48:16PM -0600, Rob Herring wrote: On Wed, May 20, 2020 at 11:16:32PM +0530, Vidya Sagar w

Re: Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-22 Thread Thierry Reding
On Fri, May 22, 2020 at 02:32:49PM +0100, Lorenzo Pieralisi wrote: > On Fri, May 22, 2020 at 02:06:55PM +0200, Thierry Reding wrote: > > On Wed, May 20, 2020 at 04:48:16PM -0600, Rob Herring wrote: > > > On Wed, May 20, 2020 at 11:16:32PM +0530, Vidya Sagar wrote: > > > > > > > > > > > > On 20-Ma

Re: PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-22 Thread Lorenzo Pieralisi
On Tue, May 19, 2020 at 07:33:04PM -0700, Alan Mikhak wrote: > Hi Lorenzo, > > I came across this issue when implementing a Linux NVMe endpoint function > driver under the Linux PCI Endpoint Framework: > https://lwn.net/Articles/804369/ > > I needed to map up to 128GB of host memory using a singl

Re: Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-22 Thread Lorenzo Pieralisi
On Fri, May 22, 2020 at 02:06:55PM +0200, Thierry Reding wrote: > On Wed, May 20, 2020 at 04:48:16PM -0600, Rob Herring wrote: > > On Wed, May 20, 2020 at 11:16:32PM +0530, Vidya Sagar wrote: > > > > > > > > > On 20-May-20 4:47 PM, Thierry Reding wrote: > > > > On Tue, May 19, 2020 at 10:08:54PM

Re: Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-22 Thread Thierry Reding
On Wed, May 20, 2020 at 04:48:16PM -0600, Rob Herring wrote: > On Wed, May 20, 2020 at 11:16:32PM +0530, Vidya Sagar wrote: > > > > > > On 20-May-20 4:47 PM, Thierry Reding wrote: > > > On Tue, May 19, 2020 at 10:08:54PM +, Gustavo Pimentel wrote: > > > > On Tue, May 19, 2020 at 15:58:16, Lor

Re: Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-20 Thread Rob Herring
On Wed, May 20, 2020 at 11:16:32PM +0530, Vidya Sagar wrote: > > > On 20-May-20 4:47 PM, Thierry Reding wrote: > > On Tue, May 19, 2020 at 10:08:54PM +, Gustavo Pimentel wrote: > > > On Tue, May 19, 2020 at 15:58:16, Lorenzo Pieralisi > > > wrote: > > > > > > > On Tue, May 19, 2020 at 07:25

Re: Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-20 Thread Vidya Sagar
On 20-May-20 6:46 PM, Thierry Reding wrote: On Wed, May 20, 2020 at 12:06:40PM +0100, Lorenzo Pieralisi wrote: On Tue, May 19, 2020 at 10:08:54PM +, Gustavo Pimentel wrote: [...] diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designwar

Re: Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-20 Thread Vidya Sagar
On 20-May-20 4:47 PM, Thierry Reding wrote: On Tue, May 19, 2020 at 10:08:54PM +, Gustavo Pimentel wrote: On Tue, May 19, 2020 at 15:58:16, Lorenzo Pieralisi wrote: On Tue, May 19, 2020 at 07:25:02PM +0530, Vidya Sagar wrote: On 18-May-20 9:24 PM, Lorenzo Pieralisi wrote: External

Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-20 Thread Thierry Reding
On Wed, May 20, 2020 at 12:06:40PM +0100, Lorenzo Pieralisi wrote: > On Tue, May 19, 2020 at 10:08:54PM +, Gustavo Pimentel wrote: > > [...] > > > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c > > > > > > > b/drivers/pci/controller/dwc/pcie-designware-host.c > > >

Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-20 Thread Thierry Reding
On Tue, May 19, 2020 at 10:08:54PM +, Gustavo Pimentel wrote: > On Tue, May 19, 2020 at 15:58:16, Lorenzo Pieralisi > wrote: > > > On Tue, May 19, 2020 at 07:25:02PM +0530, Vidya Sagar wrote: > > > > > > > > > On 18-May-20 9:24 PM, Lorenzo Pieralisi wrote: > > > > External email: Use cauti

Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-20 Thread Lorenzo Pieralisi
On Tue, May 19, 2020 at 10:08:54PM +, Gustavo Pimentel wrote: [...] > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c > > > > > > b/drivers/pci/controller/dwc/pcie-designware-host.c > > > > > > index 42fbfe2a1b8f..a29396529ea4 100644 > > > > > > --- a/drivers/pci/con

Re: PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-19 Thread Alan Mikhak
Hi Lorenzo, I came across this issue when implementing a Linux NVMe endpoint function driver under the Linux PCI Endpoint Framework: https://lwn.net/Articles/804369/ I needed to map up to 128GB of host memory using a single ATU window from the endpoint side because NVMe PRPs can be scattered all

RE: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-19 Thread Gustavo Pimentel
On Tue, May 19, 2020 at 15:58:16, Lorenzo Pieralisi wrote: > On Tue, May 19, 2020 at 07:25:02PM +0530, Vidya Sagar wrote: > > > > > > On 18-May-20 9:24 PM, Lorenzo Pieralisi wrote: > > > External email: Use caution opening links or attachments > > > > > > > > > On Wed, May 13, 2020 at 05:35:

Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-19 Thread Lorenzo Pieralisi
On Tue, May 19, 2020 at 10:38:39PM +0530, Vidya Sagar wrote: [...] > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c > > > > > > b/drivers/pci/controller/dwc/pcie-designware-host.c > > > > > > index 42fbfe2a1b8f..a29396529ea4 100644 > > > > > > --- a/drivers/pci/controll

Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-19 Thread Vidya Sagar
On 19-May-20 8:28 PM, Lorenzo Pieralisi wrote: External email: Use caution opening links or attachments On Tue, May 19, 2020 at 07:25:02PM +0530, Vidya Sagar wrote: On 18-May-20 9:24 PM, Lorenzo Pieralisi wrote: External email: Use caution opening links or attachments On Wed, May 13, 2

Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-19 Thread Lorenzo Pieralisi
On Tue, May 19, 2020 at 07:25:02PM +0530, Vidya Sagar wrote: > > > On 18-May-20 9:24 PM, Lorenzo Pieralisi wrote: > > External email: Use caution opening links or attachments > > > > > > On Wed, May 13, 2020 at 05:35:08PM -0500, Bjorn Helgaas wrote: > > > [+cc Alan; please cc authors of relevan

Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-19 Thread Vidya Sagar
On 18-May-20 9:24 PM, Lorenzo Pieralisi wrote: External email: Use caution opening links or attachments On Wed, May 13, 2020 at 05:35:08PM -0500, Bjorn Helgaas wrote: [+cc Alan; please cc authors of relevant commits, updated Andrew's email address] On Thu, May 14, 2020 at 12:38:55AM +0530,

Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-18 Thread Lorenzo Pieralisi
On Wed, May 13, 2020 at 05:35:08PM -0500, Bjorn Helgaas wrote: > [+cc Alan; please cc authors of relevant commits, > updated Andrew's email address] > > On Thu, May 14, 2020 at 12:38:55AM +0530, Vidya Sagar wrote: > > commit 9e73fa02aa009 ("PCI: dwc: Warn if MEM resource size exceeds max for > > 3

Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-13 Thread Bjorn Helgaas
[+cc Alan; please cc authors of relevant commits, updated Andrew's email address] On Thu, May 14, 2020 at 12:38:55AM +0530, Vidya Sagar wrote: > commit 9e73fa02aa009 ("PCI: dwc: Warn if MEM resource size exceeds max for > 32-bits") enables warning for MEM resources of size >4GB but prefetchable >

[PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-13 Thread Vidya Sagar
commit 9e73fa02aa009 ("PCI: dwc: Warn if MEM resource size exceeds max for 32-bits") enables warning for MEM resources of size >4GB but prefetchable memory resources also come under this category where sizes can go beyond 4GB. Avoid logging a warning for prefetchable memory resources. Signed-off-