Re: PCI device driver broken between 4.2 and 4.3

2016-02-05 Thread Bjorn Helgaas
[+cc Jiang, Yinghai, Sunjin, linux-kernel] On Sat, Jan 23, 2016 at 10:08:50AM +0300, Олег Мороз wrote: > Hello. I've got a device driver for MIL-1553b card called TA1-PCI, > which could be found at > https://github.com/qmor/elcus-1553-driver-linux > Card is using PLX_PCI9030 PCI controller. > Toda

Re: PCI device driver broken between 4.2 and 4.3

2016-02-05 Thread Bjorn Helgaas
On Tue, Feb 02, 2016 at 07:17:02PM +0300, Олег Мороз wrote: > Ohhh. It's not my driver from scratch. I'm just trying to maintain > it in working state. > Could you please advice me some correct and small and simple (I know > I ask a lot) PCI driver as example. Maybe it will be not so hard to > fix

Re: PCI device driver broken between 4.2 and 4.3

2016-02-02 Thread Олег Мороз
Ohhh. It's not my driver from scratch. I'm just trying to maintain it in working state. Could you please advice me some correct and small and simple (I know I ask a lot) PCI driver as example. Maybe it will be not so hard to fix this 1553b driver. 02.02.2016 19:13, Bjorn Helgaas пишет: On Tue

Re: PCI device driver broken between 4.2 and 4.3

2016-02-02 Thread Bjorn Helgaas
On Tue, Feb 02, 2016 at 08:04:39AM +0300, Олег Мороз wrote: > it looks much better with pci=routeirq > > [ 100.896723] *Before pci_enable_device IRQ 20* > [ 100.896735] *After pci_enable_device IRQ 20* > [ 100.896745] *Before pci_enable_device IRQ 21* > [ 100.896752] *After pci_enable_devic

Re: PCI device driver broken between 4.2 and 4.3

2016-02-01 Thread Олег Мороз
it looks much better with pci=routeirq [ 100.896723] *Before pci_enable_device IRQ 20* [ 100.896735] *After pci_enable_device IRQ 20* [ 100.896745] *Before pci_enable_device IRQ 21* [ 100.896752] *After pci_enable_device IRQ 21* On Monday 01 of February 2016 15:08:23 Bjorn Helgaas wrote:

Re: PCI device driver broken between 4.2 and 4.3

2016-02-01 Thread Bjorn Helgaas
[+cc Yinghai] On Mon, Feb 01, 2016 at 08:18:35AM +0300, Олег Мороз wrote: > Okay. I've started from driver level printk > results are: > > On 4.2 > > [414006.575989] Before pci_enable_device IRQ 20 > > [414006.575991] After pci_enable_device IRQ 20 > > [414006.575997] Before pci_enable_device

Re: PCI device driver broken between 4.2 and 4.3

2016-01-31 Thread Олег Мороз
Okay. I've started from driver level printk results are: On 4.2 [414006.575989] Before pci_enable_device IRQ 20 [414006.575991] After pci_enable_device IRQ 20 [414006.575997] Before pci_enable_device IRQ 21 [414006.575999] After pci_enable_device IRQ 21 on 4.3 [ 114.862289] Before pci_enabl

Re: PCI device driver broken between 4.2 and 4.3

2016-01-29 Thread Yinghai Lu
On Fri, Jan 29, 2016 at 8:31 AM, Bjorn Helgaas wrote: > > 991de2e59090 is related to IRQs, so I'd start by printing dev->irq in your > driver before and after you call pci_enable_device(). Add some printks in > pcibios_alloc_irq() and pcibios_enable_device() just to confirm that we got > there an

Re: PCI device driver broken between 4.2 and 4.3

2016-01-29 Thread Bjorn Helgaas
On Thu, Jan 28, 2016 at 10:28:14PM +0300, Мороз Олег wrote: > What i need to print out at first order? Jiang, can you chime in here? 991de2e59090 is related to IRQs, so I'd start by printing dev->irq in your driver before and after you call pci_enable_device(). Add some printks in pcibios_alloc

Re: PCI device driver broken between 4.2 and 4.3

2016-01-28 Thread Мороз Олег
What i need to print out at first order? 27 янв. 2016 г. 16:22 пользователь Bjorn Helgaas написал: > > On Wed, Jan 27, 2016 at 12:38:06PM +0300, Мороз Олег wrote: > > Also, my drive has no > > > > pcibios_enable_device() > > pcibios_alloc_irq() > > > > calls. > > Those are internal interfa

Re: PCI device driver broken between 4.2 and 4.3

2016-01-27 Thread Bjorn Helgaas
On Wed, Jan 27, 2016 at 12:38:06PM +0300, Мороз Олег wrote: > Also, my drive has no > > pcibios_enable_device() > pcibios_alloc_irq() > > calls. Those are internal interfaces used by the PCI core. Drivers shouldn't call them directly. Drivers normally call pci_enable_device(), and those intern

Re: PCI device driver broken between 4.2 and 4.3

2016-01-27 Thread Мороз Олег
Also, my drive has no pcibios_enable_device() pcibios_alloc_irq() calls. 26.01.2016 22:05, Олег Мороз пишет: I confirmed it works in 890e4847587f and do not works in 991de2e59090 26.01.2016 18:32, Bjorn Helgaas пишет: [+cc Jiang] On Mon, Jan 25, 2016 at 03:52:51PM -0600, Bjorn Helgaas

Re: PCI device driver broken between 4.2 and 4.3

2016-01-26 Thread Олег Мороз
I confirmed it works in 890e4847587f and do not works in 991de2e59090 26.01.2016 18:32, Bjorn Helgaas пишет: [+cc Jiang] On Mon, Jan 25, 2016 at 03:52:51PM -0600, Bjorn Helgaas wrote: Hi Олег, On Sun, Jan 24, 2016 at 04:50:08PM +0300, Олег Мороз wrote: Okay. I've sent logs (dmesg and lspc

Re: PCI device driver broken between 4.2 and 4.3

2016-01-26 Thread Bjorn Helgaas
[+cc Jiang] On Mon, Jan 25, 2016 at 03:52:51PM -0600, Bjorn Helgaas wrote: > Hi Олег, > > On Sun, Jan 24, 2016 at 04:50:08PM +0300, Олег Мороз wrote: > > Okay. I've sent logs (dmesg and lspci) from both 4.2 and 4.3 to bugzilla > > I don't see anything wrong in either log. Both v4.2 and v4.3 > e

Re: PCI device driver broken between 4.2 and 4.3

2016-01-25 Thread Bjorn Helgaas
Hi Олег, On Sun, Jan 24, 2016 at 04:50:08PM +0300, Олег Мороз wrote: > Okay. I've sent logs (dmesg and lspci) from both 4.2 and 4.3 to bugzilla I don't see anything wrong in either log. Both v4.2 and v4.3 enumerate the device the same way, and the driver seems to claim it the same way: pci 00

Re: PCI device driver broken between 4.2 and 4.3

2016-01-24 Thread Олег Мороз
Okay. I've sent logs (dmesg and lspci) from both 4.2 and 4.3 to bugzilla 23.01.2016 17:54, Bjorn Helgaas пишет: [+cc linux-kernel] Hi Олег, On Sat, Jan 23, 2016 at 1:08 AM, Олег Мороз wrote: Hello. I've got a device driver for MIL-1553b card called TA1-PCI, which could be found at https://gi

Re: PCI device driver broken between 4.2 and 4.3

2016-01-23 Thread Bjorn Helgaas
[+cc linux-kernel] Hi Олег, On Sat, Jan 23, 2016 at 1:08 AM, Олег Мороз wrote: > Hello. I've got a device driver for MIL-1553b card called TA1-PCI, which > could be found at > https://github.com/qmor/elcus-1553-driver-linux > Card is using PLX_PCI9030 PCI controller. > Today i've found that this

PCI device driver broken between 4.2 and 4.3

2016-01-22 Thread Олег Мороз
Hello. I've got a device driver for MIL-1553b card called TA1-PCI, which could be found at https://github.com/qmor/elcus-1553-driver-linux Card is using PLX_PCI9030 PCI controller. Today i've found that this driver compiles, installes, but is not working as it should. Looks like it not receives