Re: PNPACPI probes serial twice, messes up serial console

2007-04-06 Thread Bjorn Helgaas
On Wednesday 21 March 2007 22:23, Keith Owens wrote: > The aim of the patch looks sensible, but it will not compile for > 2.6.21-rc4. 8250_x86.c tests pnp_platform_devices, which does not > exist. Also the combination of CONFIG_SERIAL_8250_X86=y and > CONFIG_SERIAL_8250_PNP=m would result in 8250

Re: PNPACPI probes serial twice, messes up serial console

2007-03-24 Thread Russell King
On Wed, Mar 21, 2007 at 10:40:54AM -0600, Bjorn Helgaas wrote: > On Wednesday 21 March 2007 10:37, Russell King wrote: > > On Wed, Mar 21, 2007 at 10:35:38AM -0600, Bjorn Helgaas wrote: > > > On Tuesday 20 March 2007 08:32, Bjorn Helgaas wrote: > > > > On Tuesday 20 March 2007 00:46, Keith Owens wr

Re: PNPACPI probes serial twice, messes up serial console

2007-03-21 Thread Bjorn Helgaas
On Wednesday 21 March 2007 22:23, Keith Owens wrote: > The aim of the patch looks sensible, but it will not compile for > 2.6.21-rc4. 8250_x86.c tests pnp_platform_devices, which does not > exist. Also the combination of CONFIG_SERIAL_8250_X86=y and > CONFIG_SERIAL_8250_PNP=m would result in 8250

Re: PNPACPI probes serial twice, messes up serial console

2007-03-21 Thread Keith Owens
Bjorn Helgaas (on Wed, 21 Mar 2007 10:35:38 -0600) wrote: >On Tuesday 20 March 2007 08:32, Bjorn Helgaas wrote: >> On Tuesday 20 March 2007 00:46, Keith Owens wrote: >> > Booting with 'console=tty console=ttyS0,9600'. The serial console on >> > ttyS0 (0x3f8, irq 4) is probed twice, once from seria

Re: PNPACPI probes serial twice, messes up serial console

2007-03-21 Thread Bjorn Helgaas
On Tuesday 20 March 2007 08:32, Bjorn Helgaas wrote: > On Tuesday 20 March 2007 00:46, Keith Owens wrote: > > Booting with 'console=tty console=ttyS0,9600'. The serial console on > > ttyS0 (0x3f8, irq 4) is probed twice, once from serial8250_init() and > > again from serial_pnp_probe(). > > I pla

Re: PNPACPI probes serial twice, messes up serial console

2007-03-21 Thread Bjorn Helgaas
On Wednesday 21 March 2007 10:37, Russell King wrote: > On Wed, Mar 21, 2007 at 10:35:38AM -0600, Bjorn Helgaas wrote: > > On Tuesday 20 March 2007 08:32, Bjorn Helgaas wrote: > > > On Tuesday 20 March 2007 00:46, Keith Owens wrote: > > > > Booting with 'console=tty console=ttyS0,9600'. The serial

Re: PNPACPI probes serial twice, messes up serial console

2007-03-21 Thread Russell King
On Wed, Mar 21, 2007 at 10:35:38AM -0600, Bjorn Helgaas wrote: > On Tuesday 20 March 2007 08:32, Bjorn Helgaas wrote: > > On Tuesday 20 March 2007 00:46, Keith Owens wrote: > > > Booting with 'console=tty console=ttyS0,9600'. The serial console on > > > ttyS0 (0x3f8, irq 4) is probed twice, once f

Re: PNPACPI probes serial twice, messes up serial console

2007-03-20 Thread Russell King
On Tue, Mar 20, 2007 at 08:32:24AM -0600, Bjorn Helgaas wrote: > Index: work-mm2/include/linux/serial_8250.h > === > --- work-mm2.orig/include/linux/serial_8250.h 2006-08-22 12:26:25.0 > -0600 > +++ work-mm2/include/linux/seri

Re: PNPACPI probes serial twice, messes up serial console

2007-03-20 Thread Bjorn Helgaas
On Tuesday 20 March 2007 00:46, Keith Owens wrote: > Booting with 'console=tty console=ttyS0,9600'. The serial console on > ttyS0 (0x3f8, irq 4) is probed twice, once from serial8250_init() and > again from serial_pnp_probe(). I played with this last summer, but was too timid to finish it and pos

Re: PNPACPI probes serial twice, messes up serial console

2007-03-20 Thread Russell King
On Tue, Mar 20, 2007 at 05:46:46PM +1100, Keith Owens wrote: > Should pnpacpi probe and setup the serial devices even when thay have > already been setup? Or this is something strange about the UART in > this particular box? Yes, so it can be associated with the correct device. No idea why it's

PNPACPI probes serial twice, messes up serial console

2007-03-19 Thread Keith Owens
Dell SC1425 x86_64 running in i386 mode (the problem also occurs in x86_64 mode). Kernel 2.6.21-rc4, gcc 4.1.0. Config extract at end. Booting with 'console=tty console=ttyS0,9600'. The serial console on ttyS0 (0x3f8, irq 4) is probed twice, once from serial8250_init() and again from serial_pnp