Re: PROBLEM: NULL pointer dereference in dell_set_arguments() in 4.15

2018-02-04 Thread Alexander Sergeyev
To make dell_micmute_led_set() work properly we need to ensure that either WMI or SMM driver is already loaded and initialized. From the looks of the call trace dell_micmute_led_set() is called from device phase of initialization. Which means that there is a use of dell-laptop interface while

Re: PROBLEM: NULL pointer dereference in dell_set_arguments() in 4.15

2018-02-04 Thread Andy Shevchenko
On Sun, Feb 4, 2018 at 2:15 PM, Pali Rohár wrote: > On Sunday 04 February 2018 12:23:33 Alexander Sergeyev wrote: >> Is there any estimates on when the patch will be merged into mainline? I >> want to put something into my distribution bug tracker, but it's unlikely >> they will use this patch be

Re: PROBLEM: NULL pointer dereference in dell_set_arguments() in 4.15

2018-02-04 Thread Pali Rohár
On Sunday 04 February 2018 12:23:33 Alexander Sergeyev wrote: > Mario, > > > Would you please try https://patchwork.kernel.org/patch/10194287/ > > And see if it cleans up this null pointer dereference? > > Yes, it does. So problem which I spotted is not only theoretical, but already affects user

Re: PROBLEM: NULL pointer dereference in dell_set_arguments() in 4.15

2018-02-04 Thread Alexander Sergeyev
Mario, Would you please try https://patchwork.kernel.org/patch/10194287/ And see if it cleans up this null pointer dereference? Yes, it does. Is there any estimates on when the patch will be merged into mainline? I want to put something into my distribution bug tracker, but it's unlikely the

Re: PROBLEM: NULL pointer dereference in dell_set_arguments() in 4.15

2018-02-03 Thread Alexander Sergeyev
On Sat, Feb 03, 2018 at 07:20:21PM +0300, Alexander Sergeyev wrote: # first bad commit: [549b4930f057658dc50d8010e66219233119a4d8] platform/x86: dell-smbios: Introduce dispatcher for SMM calls From source code (at 549b4930f057) it looks like dell_set_arguments() which writes to `buffer` is cal